Blame view
Documentation/coccinelle.txt
9.03 KB
e228b1e65 Add Documentation... |
1 2 3 4 5 6 7 |
Copyright 2010 Nicolas Palix <npalix@diku.dk> Copyright 2010 Julia Lawall <julia@diku.dk> Copyright 2010 Gilles Muller <Gilles.Muller@lip6.fr> Getting Coccinelle ~~~~~~~~~~~~~~~~~~~~ |
ec97946ed Coccinelle: Updat... |
8 9 10 11 |
The semantic patches included in the kernel use features and options which are provided by Coccinelle version 1.0.0-rc11 and above. Using earlier versions will fail as the option names used by the Coccinelle files and coccicheck have been updated. |
e228b1e65 Add Documentation... |
12 |
|
ec97946ed Coccinelle: Updat... |
13 |
Coccinelle is available through the package manager |
e228b1e65 Add Documentation... |
14 |
of many distributions, e.g. : |
ec97946ed Coccinelle: Updat... |
15 16 17 |
- Debian - Fedora - Ubuntu |
e228b1e65 Add Documentation... |
18 19 20 21 22 23 24 25 |
- OpenSUSE - Arch Linux - NetBSD - FreeBSD You can get the latest version released from the Coccinelle homepage at http://coccinelle.lip6.fr/ |
32af08987 Coccinelle: Updat... |
26 27 |
Information and tips about Coccinelle are also provided on the wiki pages at http://cocci.ekstranet.diku.dk/wiki/doku.php |
e228b1e65 Add Documentation... |
28 29 30 31 32 33 34 35 |
Once you have it, run the following command: ./configure make as a regular user, and install it with sudo make install |
e228b1e65 Add Documentation... |
36 37 38 39 40 41 |
Using Coccinelle on the Linux kernel ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ A Coccinelle-specific target is defined in the top level Makefile. This target is named 'coccicheck' and calls the 'coccicheck' front-end in the 'scripts' directory. |
78a95b9b4 Coccinelle: Updat... |
42 |
Four basic modes are defined: patch, report, context, and org. The mode to |
e228b1e65 Add Documentation... |
43 |
use is specified by setting the MODE variable with 'MODE=<mode>'. |
32af08987 Coccinelle: Updat... |
44 |
'patch' proposes a fix, when possible. |
e228b1e65 Add Documentation... |
45 46 |
'report' generates a list in the following format: file:line:column-column: message |
e228b1e65 Add Documentation... |
47 48 49 50 |
'context' highlights lines of interest and their context in a diff-like style.Lines of interest are indicated with '-'. 'org' generates a report in the Org mode format of Emacs. |
32af08987 Coccinelle: Updat... |
51 |
Note that not all semantic patches implement all modes. For easy use |
78a95b9b4 Coccinelle: Updat... |
52 |
of Coccinelle, the default mode is "report". |
e228b1e65 Add Documentation... |
53 |
|
78a95b9b4 Coccinelle: Updat... |
54 |
Two other modes provide some common combinations of these modes. |
e228b1e65 Add Documentation... |
55 |
|
78a95b9b4 Coccinelle: Updat... |
56 |
'chain' tries the previous modes in the order above until one succeeds. |
e228b1e65 Add Documentation... |
57 |
|
78a95b9b4 Coccinelle: Updat... |
58 59 60 |
'rep+ctxt' runs successively the report mode and the context mode. It should be used with the C option (described later) which checks the code on a file basis. |
e228b1e65 Add Documentation... |
61 |
|
78a95b9b4 Coccinelle: Updat... |
62 63 |
Examples: To make a report for every semantic patch, run the following command: |
e228b1e65 Add Documentation... |
64 |
|
78a95b9b4 Coccinelle: Updat... |
65 66 67 68 69 |
make coccicheck MODE=report To produce patches, run: make coccicheck MODE=patch |
e228b1e65 Add Documentation... |
70 71 72 |
The coccicheck target applies every semantic patch available in the |
32af08987 Coccinelle: Updat... |
73 |
sub-directories of 'scripts/coccinelle' to the entire Linux kernel. |
e228b1e65 Add Documentation... |
74 |
|
32af08987 Coccinelle: Updat... |
75 |
For each semantic patch, a commit message is proposed. It gives a |
e228b1e65 Add Documentation... |
76 77 78 79 80 81 |
description of the problem being checked by the semantic patch, and includes a reference to Coccinelle. As any static code analyzer, Coccinelle produces false positives. Thus, reports must be carefully checked, and patches reviewed. |
26e567209 coccicheck: Allow... |
82 83 84 |
To enable verbose messages set the V= variable, for example: make coccicheck MODE=report V=1 |
90d06a468 coccicheck: span ... |
85 86 87 88 |
By default, coccicheck tries to run as parallel as possible. To change the parallelism, set the J= variable. For example, to run across 4 CPUs: make coccicheck MODE=report J=4 |
e228b1e65 Add Documentation... |
89 90 91 92 93 94 95 96 97 98 99 100 101 |
Using Coccinelle with a single semantic patch ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The optional make variable COCCI can be used to check a single semantic patch. In that case, the variable must be initialized with the name of the semantic patch to apply. For instance: make coccicheck COCCI=<my_SP.cocci> MODE=patch or make coccicheck COCCI=<my_SP.cocci> MODE=report |
f95ab2097 coccinelle.txt: u... |
102 103 104 105 106 107 |
Controlling Which Files are Processed by Coccinelle ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ By default the entire kernel source tree is checked. To apply Coccinelle to a specific directory, M= can be used. For example, to check drivers/net/wireless/ one may write: |
32af08987 Coccinelle: Updat... |
108 |
|
f95ab2097 coccinelle.txt: u... |
109 |
make coccicheck M=drivers/net/wireless/ |
ed621cc4a Coccinelle: Add s... |
110 |
|
32af08987 Coccinelle: Updat... |
111 112 113 114 115 116 117 118 |
To apply Coccinelle on a file basis, instead of a directory basis, the following command may be used: make C=1 CHECK="scripts/coccicheck" To check only newly edited code, use the value 2 for the C flag, i.e. make C=2 CHECK="scripts/coccicheck" |
78a95b9b4 Coccinelle: Updat... |
119 120 |
In these modes, which works on a file basis, there is no information about semantic patches displayed, and no commit message proposed. |
32af08987 Coccinelle: Updat... |
121 122 123 |
This runs every semantic patch in scripts/coccinelle by default. The COCCI variable may additionally be used to only apply a single semantic patch as shown in the previous section. |
78a95b9b4 Coccinelle: Updat... |
124 |
The "report" mode is the default. You can select another one with the |
32af08987 Coccinelle: Updat... |
125 |
MODE variable explained above. |
ed621cc4a Coccinelle: Add s... |
126 127 128 129 130 |
Additional flags ~~~~~~~~~~~~~~~~~~ Additional flags can be passed to spatch through the SPFLAGS variable. |
78a95b9b4 Coccinelle: Updat... |
131 132 |
make SPFLAGS=--use-glimpse coccicheck make SPFLAGS=--use-idutils coccicheck |
ed621cc4a Coccinelle: Add s... |
133 134 |
See spatch --help to learn more about spatch options. |
32af08987 Coccinelle: Updat... |
135 |
|
78a95b9b4 Coccinelle: Updat... |
136 137 138 139 140 |
Note that the '--use-glimpse' and '--use-idutils' options require external tools for indexing the code. None of them is thus active by default. However, by indexing the code with one of these tools, and according to the cocci file used, spatch could proceed the entire code base more quickly. |
e228b1e65 Add Documentation... |
141 142 143 144 145 |
Proposing new semantic patches ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ New semantic patches can be proposed and submitted by kernel developers. For sake of clarity, they should be organized in the |
32af08987 Coccinelle: Updat... |
146 |
sub-directories of 'scripts/coccinelle/'. |
e228b1e65 Add Documentation... |
147 148 149 150 151 152 153 154 155 156 157 |
Detailed description of the 'report' mode ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 'report' generates a list in the following format: file:line:column-column: message Example: Running |
9dcf7990c Coccinelle: Fix d... |
158 |
make coccicheck MODE=report COCCI=scripts/coccinelle/api/err_cast.cocci |
e228b1e65 Add Documentation... |
159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 |
will execute the following part of the SmPL script. <smpl> @r depends on !context && !patch && (org || report)@ expression x; position p; @@ ERR_PTR@p(PTR_ERR(x)) @script:python depends on report@ p << r.p; x << r.x; @@ msg="ERR_CAST can be used with %s" % (x) coccilib.report.print_report(p[0], msg) </smpl> This SmPL excerpt generates entries on the standard output, as illustrated below: /home/user/linux/crypto/ctr.c:188:9-16: ERR_CAST can be used with alg /home/user/linux/crypto/authenc.c:619:9-16: ERR_CAST can be used with auth /home/user/linux/crypto/xts.c:227:9-16: ERR_CAST can be used with alg Detailed description of the 'patch' mode ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ When the 'patch' mode is available, it proposes a fix for each problem identified. Example: Running |
9dcf7990c Coccinelle: Fix d... |
196 |
make coccicheck MODE=patch COCCI=scripts/coccinelle/api/err_cast.cocci |
e228b1e65 Add Documentation... |
197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 |
will execute the following part of the SmPL script. <smpl> @ depends on !context && patch && !org && !report @ expression x; @@ - ERR_PTR(PTR_ERR(x)) + ERR_CAST(x) </smpl> This SmPL excerpt generates patch hunks on the standard output, as illustrated below: diff -u -p a/crypto/ctr.c b/crypto/ctr.c --- a/crypto/ctr.c 2010-05-26 10:49:38.000000000 +0200 +++ b/crypto/ctr.c 2010-06-03 23:44:49.000000000 +0200 @@ -185,7 +185,7 @@ static struct crypto_instance *crypto_ct alg = crypto_attr_alg(tb[1], CRYPTO_ALG_TYPE_CIPHER, CRYPTO_ALG_TYPE_MASK); if (IS_ERR(alg)) - return ERR_PTR(PTR_ERR(alg)); + return ERR_CAST(alg); /* Block size must be >= 4 bytes. */ err = -EINVAL; Detailed description of the 'context' mode ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 'context' highlights lines of interest and their context in a diff-like style. NOTE: The diff-like output generated is NOT an applicable patch. The intent of the 'context' mode is to highlight the important lines (annotated with minus, '-') and gives some surrounding context lines around. This output can be used with the diff mode of Emacs to review the code. Example: Running |
9dcf7990c Coccinelle: Fix d... |
240 |
make coccicheck MODE=context COCCI=scripts/coccinelle/api/err_cast.cocci |
e228b1e65 Add Documentation... |
241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 |
will execute the following part of the SmPL script. <smpl> @ depends on context && !patch && !org && !report@ expression x; @@ * ERR_PTR(PTR_ERR(x)) </smpl> This SmPL excerpt generates diff hunks on the standard output, as illustrated below: diff -u -p /home/user/linux/crypto/ctr.c /tmp/nothing --- /home/user/linux/crypto/ctr.c 2010-05-26 10:49:38.000000000 +0200 +++ /tmp/nothing @@ -185,7 +185,6 @@ static struct crypto_instance *crypto_ct alg = crypto_attr_alg(tb[1], CRYPTO_ALG_TYPE_CIPHER, CRYPTO_ALG_TYPE_MASK); if (IS_ERR(alg)) - return ERR_PTR(PTR_ERR(alg)); /* Block size must be >= 4 bytes. */ err = -EINVAL; Detailed description of the 'org' mode ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 'org' generates a report in the Org mode format of Emacs. Example: Running |
9dcf7990c Coccinelle: Fix d... |
275 |
make coccicheck MODE=org COCCI=scripts/coccinelle/api/err_cast.cocci |
e228b1e65 Add Documentation... |
276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 |
will execute the following part of the SmPL script. <smpl> @r depends on !context && !patch && (org || report)@ expression x; position p; @@ ERR_PTR@p(PTR_ERR(x)) @script:python depends on org@ p << r.p; x << r.x; @@ msg="ERR_CAST can be used with %s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) </smpl> This SmPL excerpt generates Org entries on the standard output, as illustrated below: * TODO [[view:/home/user/linux/crypto/ctr.c::face=ovl-face1::linb=188::colb=9::cole=16][ERR_CAST can be used with alg]] * TODO [[view:/home/user/linux/crypto/authenc.c::face=ovl-face1::linb=619::colb=9::cole=16][ERR_CAST can be used with auth]] * TODO [[view:/home/user/linux/crypto/xts.c::face=ovl-face1::linb=227::colb=9::cole=16][ERR_CAST can be used with alg]] |