Blame view
scripts/checkpatch.pl
88.2 KB
0a920b5b6 add a trivial pat... |
1 |
#!/usr/bin/perl -w |
dbf004d78 remove my email a... |
2 |
# (c) 2001, Dave Jones. (the file handling bit) |
00df344fd update checkpatch... |
3 |
# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) |
2a5a2c252 checkpatch: updat... |
4 |
# (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite) |
015830be9 checkpatch: updat... |
5 |
# (c) 2008-2010 Andy Whitcroft <apw@canonical.com> |
0a920b5b6 add a trivial pat... |
6 7 8 9 10 |
# Licensed under the terms of the GNU GPL License version 2 use strict; my $P = $0; |
00df344fd update checkpatch... |
11 |
$P =~ s@.*/@@g; |
0a920b5b6 add a trivial pat... |
12 |
|
000d1cc18 checkpatch.pl: ad... |
13 |
my $V = '0.32'; |
0a920b5b6 add a trivial pat... |
14 15 16 17 18 19 20 |
use Getopt::Long qw(:config no_auto_abbrev); my $quiet = 0; my $tree = 1; my $chk_signoff = 1; my $chk_patch = 1; |
773647a09 update checkpatch... |
21 |
my $tst_only; |
6c72ffaab update checkpatch... |
22 |
my $emacs = 0; |
8905a67c6 update checkpatch... |
23 |
my $terse = 0; |
6c72ffaab update checkpatch... |
24 25 |
my $file = 0; my $check = 0; |
8905a67c6 update checkpatch... |
26 27 |
my $summary = 1; my $mailback = 0; |
13214adf7 update checkpatch... |
28 |
my $summary_file = 0; |
000d1cc18 checkpatch.pl: ad... |
29 |
my $show_types = 0; |
6c72ffaab update checkpatch... |
30 |
my $root; |
c2fdda0df update checkpatch... |
31 |
my %debug; |
000d1cc18 checkpatch.pl: ad... |
32 33 |
my %ignore_type = (); my @ignore = (); |
77f5b10a8 checkpatch: make ... |
34 |
my $help = 0; |
000d1cc18 checkpatch.pl: ad... |
35 |
my $configuration_file = ".checkpatch.conf"; |
77f5b10a8 checkpatch: make ... |
36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 |
sub help { my ($exitcode) = @_; print << "EOM"; Usage: $P [OPTION]... [FILE]... Version: $V Options: -q, --quiet quiet --no-tree run without a kernel tree --no-signoff do not check for 'Signed-off-by' line --patch treat FILE as patchfile (default) --emacs emacs compile window format --terse one line per report -f, --file treat FILE as regular source file --subjective, --strict enable more subjective tests |
000d1cc18 checkpatch.pl: ad... |
53 54 |
--ignore TYPE(,TYPE2...) ignore various comma separated message types --show-types show the message "types" in the output |
77f5b10a8 checkpatch: make ... |
55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 |
--root=PATH PATH to the kernel tree root --no-summary suppress the per-file summary --mailback only produce a report in case of warnings/errors --summary-file include the filename in summary --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of 'values', 'possible', 'type', and 'attr' (default is all off) --test-only=WORD report only warnings/errors containing WORD literally -h, --help, --version display this help and exit When FILE is - read standard input. EOM exit($exitcode); } |
000d1cc18 checkpatch.pl: ad... |
71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 |
my $conf = which_conf($configuration_file); if (-f $conf) { my @conf_args; open(my $conffile, '<', "$conf") or warn "$P: Can't find a readable $configuration_file file $! "; while (<$conffile>) { my $line = $_; $line =~ s/\s* ?$//g; $line =~ s/^\s*//g; $line =~ s/\s+/ /g; next if ($line =~ m/^\s*#/); next if ($line =~ m/^\s*$/); my @words = split(" ", $line); foreach my $word (@words) { last if ($word =~ m/^#/); push (@conf_args, $word); } } close($conffile); unshift(@ARGV, @conf_args) if @conf_args; } |
0a920b5b6 add a trivial pat... |
98 |
GetOptions( |
6c72ffaab update checkpatch... |
99 |
'q|quiet+' => \$quiet, |
0a920b5b6 add a trivial pat... |
100 101 102 |
'tree!' => \$tree, 'signoff!' => \$chk_signoff, 'patch!' => \$chk_patch, |
6c72ffaab update checkpatch... |
103 |
'emacs!' => \$emacs, |
8905a67c6 update checkpatch... |
104 |
'terse!' => \$terse, |
77f5b10a8 checkpatch: make ... |
105 |
'f|file!' => \$file, |
6c72ffaab update checkpatch... |
106 107 |
'subjective!' => \$check, 'strict!' => \$check, |
000d1cc18 checkpatch.pl: ad... |
108 109 |
'ignore=s' => \@ignore, 'show-types!' => \$show_types, |
6c72ffaab update checkpatch... |
110 |
'root=s' => \$root, |
8905a67c6 update checkpatch... |
111 112 |
'summary!' => \$summary, 'mailback!' => \$mailback, |
13214adf7 update checkpatch... |
113 |
'summary-file!' => \$summary_file, |
c2fdda0df update checkpatch... |
114 |
'debug=s' => \%debug, |
773647a09 update checkpatch... |
115 |
'test-only=s' => \$tst_only, |
77f5b10a8 checkpatch: make ... |
116 117 118 119 120 |
'h|help' => \$help, 'version' => \$help ) or help(1); help(0) if ($help); |
0a920b5b6 add a trivial pat... |
121 122 123 124 |
my $exit = 0; if ($#ARGV < 0) { |
77f5b10a8 checkpatch: make ... |
125 126 |
print "$P: no input files "; |
0a920b5b6 add a trivial pat... |
127 128 |
exit(1); } |
000d1cc18 checkpatch.pl: ad... |
129 130 131 132 133 134 135 136 137 138 139 140 141 |
@ignore = split(/,/, join(',',@ignore)); foreach my $word (@ignore) { $word =~ s/\s* ?$//g; $word =~ s/^\s*//g; $word =~ s/\s+/ /g; $word =~ tr/[a-z]/[A-Z]/; next if ($word =~ m/^\s*#/); next if ($word =~ m/^\s*$/); $ignore_type{$word}++; } |
c2fdda0df update checkpatch... |
142 143 |
my $dbg_values = 0; my $dbg_possible = 0; |
7429c6903 checkpatch: impro... |
144 |
my $dbg_type = 0; |
a1ef277e2 checkpatch: add t... |
145 |
my $dbg_attr = 0; |
c2fdda0df update checkpatch... |
146 |
for my $key (keys %debug) { |
21caa13c0 checkpatch: fix t... |
147 148 149 |
## no critic eval "\${dbg_$key} = '$debug{$key}';"; die "$@" if ($@); |
c2fdda0df update checkpatch... |
150 |
} |
d2c0a2351 checkpatch: sugge... |
151 |
my $rpt_cleaners = 0; |
8905a67c6 update checkpatch... |
152 153 154 155 |
if ($terse) { $emacs = 1; $quiet++; } |
6c72ffaab update checkpatch... |
156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 |
if ($tree) { if (defined $root) { if (!top_of_kernel_tree($root)) { die "$P: $root: --root does not point at a valid tree "; } } else { if (top_of_kernel_tree('.')) { $root = '.'; } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ && top_of_kernel_tree($1)) { $root = $1; } } if (!defined $root) { print "Must be run from the top-level dir. of a kernel tree "; exit(2); } |
0a920b5b6 add a trivial pat... |
176 |
} |
6c72ffaab update checkpatch... |
177 |
my $emitted_corrupt = 0; |
2ceb532b0 checkpatch: fix f... |
178 179 180 181 |
our $Ident = qr{ [A-Za-z_][A-Za-z\d_]* (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)* }x; |
6c72ffaab update checkpatch... |
182 183 184 185 186 187 188 189 |
our $Storage = qr{extern|static|asmlinkage}; our $Sparse = qr{ __user| __kernel| __force| __iomem| __must_check| __init_refok| |
417495eda checkpatch: add _... |
190 |
__kprobes| |
165e72a6c checkpatch: add _... |
191 192 |
__ref| __rcu |
6c72ffaab update checkpatch... |
193 |
}x; |
52131292c checkpatch: fix f... |
194 195 196 |
# Notes to $Attribute: # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check |
6c72ffaab update checkpatch... |
197 198 |
our $Attribute = qr{ const| |
03f1df7da checkpatch: Add a... |
199 200 201 202 203 204 205 206 207 208 209 210 211 212 |
__percpu| __nocast| __safe| __bitwise__| __packed__| __packed2__| __naked| __maybe_unused| __always_unused| __noreturn| __used| __cold| __noclone| __deprecated| |
6c72ffaab update checkpatch... |
213 214 |
__read_mostly| __kprobes| |
52131292c checkpatch: fix f... |
215 |
__(?:mem|cpu|dev|)(?:initdata|initconst|init\b)| |
24e1d81ac checkpatch: ____c... |
216 217 |
____cacheline_aligned| ____cacheline_aligned_in_smp| |
5fe3af119 checkpatch: __wea... |
218 219 |
____cacheline_internodealigned_in_smp| __weak |
6c72ffaab update checkpatch... |
220 |
}x; |
c45dcabd2 update checkpatch... |
221 |
our $Modifier; |
6c72ffaab update checkpatch... |
222 |
our $Inline = qr{inline|__always_inline|noinline}; |
6c72ffaab update checkpatch... |
223 224 225 226 227 |
our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]}; our $Lval = qr{$Ident(?:$Member)*}; our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*}; our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)}; |
86f9d059c checkpatch: allow... |
228 |
our $Compare = qr{<=|>=|==|!=|<|>}; |
6c72ffaab update checkpatch... |
229 230 231 |
our $Operators = qr{ <=|>=|==|!=| =>|->|<<|>>|<|>|!|~| |
c2fdda0df update checkpatch... |
232 |
&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% |
6c72ffaab update checkpatch... |
233 |
}x; |
8905a67c6 update checkpatch... |
234 235 236 |
our $NonptrType; our $Type; our $Declare; |
171ae1a49 update checkpatch... |
237 238 239 240 241 242 243 244 245 246 |
our $UTF8 = qr { [\x09\x0A\x0D\x20-\x7E] # ASCII | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 }x; |
8ed22cad9 checkpatch: pull ... |
247 |
our $typeTypedefs = qr{(?x: |
fb9e9096b checkpatch: limit... |
248 |
(?:__)?(?:u|s|be|le)(?:8|16|32|64)| |
8ed22cad9 checkpatch: pull ... |
249 250 |
atomic_t )}; |
691e669ba checkpatch.pl: al... |
251 |
our $logFunctions = qr{(?x: |
6e60c02e9 checkpatch.pl: up... |
252 253 254 |
printk(?:_ratelimited|_once|)| [a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)| WARN(?:_RATELIMIT|_ONCE|)| |
b05317221 checkpatch: add <... |
255 256 |
panic| MODULE_[A-Z_]+ |
691e669ba checkpatch.pl: al... |
257 |
)}; |
201124755 checkpatch: valid... |
258 259 260 261 262 263 264 265 266 |
our $signature_tags = qr{(?xi: Signed-off-by:| Acked-by:| Tested-by:| Reviewed-by:| Reported-by:| To:| Cc: )}; |
8905a67c6 update checkpatch... |
267 268 |
our @typeList = ( qr{void}, |
c45dcabd2 update checkpatch... |
269 270 271 272 273 274 275 |
qr{(?:unsigned\s+)?char}, qr{(?:unsigned\s+)?short}, qr{(?:unsigned\s+)?int}, qr{(?:unsigned\s+)?long}, qr{(?:unsigned\s+)?long\s+int}, qr{(?:unsigned\s+)?long\s+long}, qr{(?:unsigned\s+)?long\s+long\s+int}, |
8905a67c6 update checkpatch... |
276 277 278 279 |
qr{unsigned}, qr{float}, qr{double}, qr{bool}, |
8905a67c6 update checkpatch... |
280 281 282 283 284 285 286 |
qr{struct\s+$Ident}, qr{union\s+$Ident}, qr{enum\s+$Ident}, qr{${Ident}_t}, qr{${Ident}_handler}, qr{${Ident}_handler_fn}, ); |
c45dcabd2 update checkpatch... |
287 288 289 |
our @modifierList = ( qr{fastcall}, ); |
8905a67c6 update checkpatch... |
290 |
|
7840a94cd checkpatch: refac... |
291 292 293 294 295 |
our $allowed_asm_includes = qr{(?x: irq| memory )}; # memory.h: ARM has a custom one |
8905a67c6 update checkpatch... |
296 |
sub build_types { |
d2172eb5b checkpatch: possi... |
297 298 299 300 301 302 303 304 |
my $mods = "(?x: " . join("| ", @modifierList) . " )"; my $all = "(?x: " . join("| ", @typeList) . " )"; |
c8cb2ca37 checkpatch: types... |
305 |
$Modifier = qr{(?:$Attribute|$Sparse|$mods)}; |
8905a67c6 update checkpatch... |
306 |
$NonptrType = qr{ |
d2172eb5b checkpatch: possi... |
307 |
(?:$Modifier\s+|const\s+)* |
cf655043d update checkpatch... |
308 |
(?: |
c45dcabd2 update checkpatch... |
309 |
(?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| |
8ed22cad9 checkpatch: pull ... |
310 |
(?:$typeTypedefs\b)| |
c45dcabd2 update checkpatch... |
311 |
(?:${all}\b) |
cf655043d update checkpatch... |
312 |
) |
c8cb2ca37 checkpatch: types... |
313 |
(?:\s+$Modifier|\s+const)* |
8905a67c6 update checkpatch... |
314 315 |
}x; $Type = qr{ |
c45dcabd2 update checkpatch... |
316 |
$NonptrType |
65863862b checkpatch: dissa... |
317 |
(?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)? |
c8cb2ca37 checkpatch: types... |
318 |
(?:\s+$Inline|\s+$Modifier)* |
8905a67c6 update checkpatch... |
319 320 321 322 |
}x; $Declare = qr{(?:$Storage\s+)?$Type}; } build_types(); |
6c72ffaab update checkpatch... |
323 |
|
7d2367af0 checkpatch: sugge... |
324 325 326 327 328 329 330 331 332 333 334 335 336 |
our $match_balanced_parentheses = qr/(\((?:[^\(\)]+|(-1))*\))/; our $Typecast = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*}; our $LvalOrFunc = qr{($Lval)\s*($match_balanced_parentheses{0,1})\s*}; sub deparenthesize { my ($string) = @_; return "" if (!defined($string)); $string =~ s@^\s*\(\s*@@g; $string =~ s@\s*\)\s*$@@g; $string =~ s@\s+@ @g; return $string; } |
6c72ffaab update checkpatch... |
337 |
$chk_signoff = 0 if ($file); |
4a0df2ef4 update checkpatch... |
338 339 |
my @dep_includes = (); my @dep_functions = (); |
6c72ffaab update checkpatch... |
340 341 |
my $removal = "Documentation/feature-removal-schedule.txt"; if ($tree && -f "$root/$removal") { |
21caa13c0 checkpatch: fix t... |
342 |
open(my $REMOVE, '<', "$root/$removal") || |
6c72ffaab update checkpatch... |
343 344 |
die "$P: $removal: open failed - $! "; |
21caa13c0 checkpatch: fix t... |
345 |
while (<$REMOVE>) { |
f0a594c1c update checkpatch... |
346 347 348 |
if (/^Check:\s+(.*\S)/) { for my $entry (split(/[, ]+/, $1)) { if ($entry =~ m@include/(.*)@) { |
4a0df2ef4 update checkpatch... |
349 |
push(@dep_includes, $1); |
4a0df2ef4 update checkpatch... |
350 |
|
f0a594c1c update checkpatch... |
351 352 353 |
} elsif ($entry !~ m@/@) { push(@dep_functions, $entry); } |
4a0df2ef4 update checkpatch... |
354 |
} |
0a920b5b6 add a trivial pat... |
355 356 |
} } |
21caa13c0 checkpatch: fix t... |
357 |
close($REMOVE); |
0a920b5b6 add a trivial pat... |
358 |
} |
00df344fd update checkpatch... |
359 |
my @rawlines = (); |
c2fdda0df update checkpatch... |
360 361 |
my @lines = (); my $vname; |
6c72ffaab update checkpatch... |
362 |
for my $filename (@ARGV) { |
21caa13c0 checkpatch: fix t... |
363 |
my $FILE; |
6c72ffaab update checkpatch... |
364 |
if ($file) { |
21caa13c0 checkpatch: fix t... |
365 |
open($FILE, '-|', "diff -u /dev/null $filename") || |
6c72ffaab update checkpatch... |
366 367 |
die "$P: $filename: diff failed - $! "; |
21caa13c0 checkpatch: fix t... |
368 369 |
} elsif ($filename eq '-') { open($FILE, '<&STDIN'); |
6c72ffaab update checkpatch... |
370 |
} else { |
21caa13c0 checkpatch: fix t... |
371 |
open($FILE, '<', "$filename") || |
6c72ffaab update checkpatch... |
372 373 |
die "$P: $filename: open failed - $! "; |
0a920b5b6 add a trivial pat... |
374 |
} |
c2fdda0df update checkpatch... |
375 376 377 378 379 |
if ($filename eq '-') { $vname = 'Your patch'; } else { $vname = $filename; } |
21caa13c0 checkpatch: fix t... |
380 |
while (<$FILE>) { |
6c72ffaab update checkpatch... |
381 382 383 |
chomp; push(@rawlines, $_); } |
21caa13c0 checkpatch: fix t... |
384 |
close($FILE); |
c2fdda0df update checkpatch... |
385 |
if (!process($filename)) { |
6c72ffaab update checkpatch... |
386 387 388 |
$exit = 1; } @rawlines = (); |
13214adf7 update checkpatch... |
389 |
@lines = (); |
0a920b5b6 add a trivial pat... |
390 391 392 393 394 |
} exit($exit); sub top_of_kernel_tree { |
6c72ffaab update checkpatch... |
395 396 397 398 399 400 401 402 403 404 405 406 |
my ($root) = @_; my @tree_check = ( "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile", "README", "Documentation", "arch", "include", "drivers", "fs", "init", "ipc", "kernel", "lib", "scripts", ); foreach my $check (@tree_check) { if (! -e $root . '/' . $check) { return 0; } |
0a920b5b6 add a trivial pat... |
407 |
} |
6c72ffaab update checkpatch... |
408 |
return 1; |
000d1cc18 checkpatch.pl: ad... |
409 |
} |
0a920b5b6 add a trivial pat... |
410 |
|
201124755 checkpatch: valid... |
411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 |
sub parse_email { my ($formatted_email) = @_; my $name = ""; my $address = ""; my $comment = ""; if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) { $name = $1; $address = $2; $comment = $3 if defined $3; } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) { $address = $1; $comment = $2 if defined $2; } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) { $address = $1; $comment = $2 if defined $2; $formatted_email =~ s/$address.*$//; $name = $formatted_email; $name =~ s/^\s+|\s+$//g; $name =~ s/^\"|\"$//g; # If there's a name left after stripping spaces and # leading quotes, and the address doesn't have both # leading and trailing angle brackets, the address # is invalid. ie: # "joe smith joe@smith.com" bad # "joe smith <joe@smith.com" bad if ($name ne "" && $address !~ /^<[^>]+>$/) { $name = ""; $address = ""; $comment = ""; } } $name =~ s/^\s+|\s+$//g; $name =~ s/^\"|\"$//g; $address =~ s/^\s+|\s+$//g; $address =~ s/^\<|\>$//g; if ($name =~ /[^\w \-]/i) { ##has "must quote" chars $name =~ s/(?<!\\)"/\\"/g; ##escape quotes $name = "\"$name\""; } return ($name, $address, $comment); } sub format_email { my ($name, $address) = @_; my $formatted_email; $name =~ s/^\s+|\s+$//g; $name =~ s/^\"|\"$//g; $address =~ s/^\s+|\s+$//g; if ($name =~ /[^\w \-]/i) { ##has "must quote" chars $name =~ s/(?<!\\)"/\\"/g; ##escape quotes $name = "\"$name\""; } if ("$name" eq "") { $formatted_email = "$address"; } else { $formatted_email = "$name <$address>"; } return $formatted_email; } |
000d1cc18 checkpatch.pl: ad... |
480 481 482 483 484 485 486 487 488 489 490 |
sub which_conf { my ($conf) = @_; foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) { if (-e "$path/$conf") { return "$path/$conf"; } } return ""; } |
0a920b5b6 add a trivial pat... |
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 |
sub expand_tabs { my ($str) = @_; my $res = ''; my $n = 0; for my $c (split(//, $str)) { if ($c eq "\t") { $res .= ' '; $n++; for (; ($n % 8) != 0; $n++) { $res .= ' '; } next; } $res .= $c; $n++; } return $res; } |
6c72ffaab update checkpatch... |
511 |
sub copy_spacing { |
773647a09 update checkpatch... |
512 |
(my $res = shift) =~ tr/\t/ /c; |
6c72ffaab update checkpatch... |
513 514 |
return $res; } |
0a920b5b6 add a trivial pat... |
515 |
|
4a0df2ef4 update checkpatch... |
516 517 518 519 520 521 522 523 524 525 526 527 |
sub line_stats { my ($line) = @_; # Drop the diff line leader and expand tabs $line =~ s/^.//; $line = expand_tabs($line); # Pick the indent from the front of the line. my ($white) = ($line =~ /^(\s*)/); return (length($line), length($white)); } |
773647a09 update checkpatch... |
528 529 530 531 532 533 534 535 536 537 538 |
my $sanitise_quote = ''; sub sanitise_line_reset { my ($in_comment) = @_; if ($in_comment) { $sanitise_quote = '*/'; } else { $sanitise_quote = ''; } } |
00df344fd update checkpatch... |
539 540 541 542 543 |
sub sanitise_line { my ($line) = @_; my $res = ''; my $l = ''; |
c2fdda0df update checkpatch... |
544 |
my $qlen = 0; |
773647a09 update checkpatch... |
545 546 |
my $off = 0; my $c; |
00df344fd update checkpatch... |
547 |
|
773647a09 update checkpatch... |
548 549 550 551 552 553 554 555 556 557 558 559 560 561 |
# Always copy over the diff marker. $res = substr($line, 0, 1); for ($off = 1; $off < length($line); $off++) { $c = substr($line, $off, 1); # Comments we are wacking completly including the begin # and end, all to $;. if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') { $sanitise_quote = '*/'; substr($res, $off, 2, "$;$;"); $off++; next; |
00df344fd update checkpatch... |
562 |
} |
81bc0e020 checkpatch: handl... |
563 |
if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') { |
773647a09 update checkpatch... |
564 565 566 567 |
$sanitise_quote = ''; substr($res, $off, 2, "$;$;"); $off++; next; |
c2fdda0df update checkpatch... |
568 |
} |
113f04a83 checkpatch: handl... |
569 570 571 572 573 574 575 |
if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') { $sanitise_quote = '//'; substr($res, $off, 2, $sanitise_quote); $off++; next; } |
773647a09 update checkpatch... |
576 577 578 579 580 581 582 |
# A \ in a string means ignore the next character. if (($sanitise_quote eq "'" || $sanitise_quote eq '"') && $c eq "\\") { substr($res, $off, 2, 'XX'); $off++; next; |
00df344fd update checkpatch... |
583 |
} |
773647a09 update checkpatch... |
584 585 586 587 |
# Regular quotes. if ($c eq "'" || $c eq '"') { if ($sanitise_quote eq '') { $sanitise_quote = $c; |
00df344fd update checkpatch... |
588 |
|
773647a09 update checkpatch... |
589 590 591 592 593 594 |
substr($res, $off, 1, $c); next; } elsif ($sanitise_quote eq $c) { $sanitise_quote = ''; } } |
00df344fd update checkpatch... |
595 |
|
fae17daed checkpatch: comme... |
596 597 |
#print "c<$c> SQ<$sanitise_quote> "; |
773647a09 update checkpatch... |
598 599 |
if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") { substr($res, $off, 1, $;); |
113f04a83 checkpatch: handl... |
600 601 |
} elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") { substr($res, $off, 1, $;); |
773647a09 update checkpatch... |
602 603 604 605 606 |
} elsif ($off != 0 && $sanitise_quote && $c ne "\t") { substr($res, $off, 1, 'X'); } else { substr($res, $off, 1, $c); } |
c2fdda0df update checkpatch... |
607 |
} |
113f04a83 checkpatch: handl... |
608 609 610 |
if ($sanitise_quote eq '//') { $sanitise_quote = ''; } |
c2fdda0df update checkpatch... |
611 |
# The pathname on a #include may be surrounded by '<' and '>'. |
c45dcabd2 update checkpatch... |
612 |
if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) { |
c2fdda0df update checkpatch... |
613 614 615 616 |
my $clean = 'X' x length($1); $res =~ s@\<.*\>@<$clean>@; # The whole of a #error is a string. |
c45dcabd2 update checkpatch... |
617 |
} elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) { |
c2fdda0df update checkpatch... |
618 |
my $clean = 'X' x length($1); |
c45dcabd2 update checkpatch... |
619 |
$res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@; |
c2fdda0df update checkpatch... |
620 |
} |
00df344fd update checkpatch... |
621 622 |
return $res; } |
8905a67c6 update checkpatch... |
623 624 625 626 627 628 |
sub ctx_statement_block { my ($linenr, $remain, $off) = @_; my $line = $linenr - 1; my $blk = ''; my $soff = $off; my $coff = $off - 1; |
773647a09 update checkpatch... |
629 |
my $coff_set = 0; |
8905a67c6 update checkpatch... |
630 |
|
13214adf7 update checkpatch... |
631 |
my $loff = 0; |
8905a67c6 update checkpatch... |
632 633 |
my $type = ''; my $level = 0; |
a27506459 checkpatch: handl... |
634 |
my @stack = (); |
cf655043d update checkpatch... |
635 |
my $p; |
8905a67c6 update checkpatch... |
636 637 |
my $c; my $len = 0; |
13214adf7 update checkpatch... |
638 639 |
my $remainder; |
8905a67c6 update checkpatch... |
640 |
while (1) { |
a27506459 checkpatch: handl... |
641 |
@stack = (['', 0]) if ($#stack == -1); |
773647a09 update checkpatch... |
642 643 |
#warn "CSB: blk<$blk> remain<$remain> "; |
8905a67c6 update checkpatch... |
644 645 646 647 |
# If we are about to drop off the end, pull in more # context. if ($off >= $len) { for (; $remain > 0; $line++) { |
dea33496d checkpatch: suppr... |
648 |
last if (!defined $lines[$line]); |
c2fdda0df update checkpatch... |
649 |
next if ($lines[$line] =~ /^-/); |
8905a67c6 update checkpatch... |
650 |
$remain--; |
13214adf7 update checkpatch... |
651 |
$loff = $len; |
c2fdda0df update checkpatch... |
652 653 |
$blk .= $lines[$line] . " "; |
8905a67c6 update checkpatch... |
654 655 656 657 658 659 660 |
$len = length($blk); $line++; last; } # Bail if there is no further context. #warn "CSB: blk<$blk> off<$off> len<$len> "; |
13214adf7 update checkpatch... |
661 |
if ($off >= $len) { |
8905a67c6 update checkpatch... |
662 663 664 |
last; } } |
cf655043d update checkpatch... |
665 |
$p = $c; |
8905a67c6 update checkpatch... |
666 |
$c = substr($blk, $off, 1); |
13214adf7 update checkpatch... |
667 |
$remainder = substr($blk, $off); |
8905a67c6 update checkpatch... |
668 |
|
773647a09 update checkpatch... |
669 670 |
#warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set> "; |
4635f4fba checkpatch: track... |
671 672 673 674 675 676 677 678 679 |
# Handle nested #if/#else. if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) { push(@stack, [ $type, $level ]); } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) { ($type, $level) = @{$stack[$#stack - 1]}; } elsif ($remainder =~ /^#\s*endif\b/) { ($type, $level) = @{pop(@stack)}; } |
8905a67c6 update checkpatch... |
680 681 682 683 684 |
# Statement ends at the ';' or a close '}' at the # outermost level. if ($level == 0 && $c eq ';') { last; } |
13214adf7 update checkpatch... |
685 |
# An else is really a conditional as long as its not else if |
773647a09 update checkpatch... |
686 687 688 689 690 691 692 693 694 695 |
if ($level == 0 && $coff_set == 0 && (!defined($p) || $p =~ /(?:\s|\}|\+)/) && $remainder =~ /^(else)(?:\s|{)/ && $remainder !~ /^else\s+if\b/) { $coff = $off + length($1) - 1; $coff_set = 1; #warn "CSB: mark coff<$coff> soff<$soff> 1<$1> "; #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "] "; |
13214adf7 update checkpatch... |
696 |
} |
8905a67c6 update checkpatch... |
697 698 699 700 701 702 703 704 705 706 |
if (($type eq '' || $type eq '(') && $c eq '(') { $level++; $type = '('; } if ($type eq '(' && $c eq ')') { $level--; $type = ($level != 0)? '(' : ''; if ($level == 0 && $coff < $soff) { $coff = $off; |
773647a09 update checkpatch... |
707 708 709 |
$coff_set = 1; #warn "CSB: mark coff<$coff> "; |
8905a67c6 update checkpatch... |
710 711 712 713 714 715 716 717 718 719 720 |
} } if (($type eq '' || $type eq '{') && $c eq '{') { $level++; $type = '{'; } if ($type eq '{' && $c eq '}') { $level--; $type = ($level != 0)? '{' : ''; if ($level == 0) { |
b998e001e checkpatch: fix e... |
721 722 723 |
if (substr($blk, $off + 1, 1) eq ';') { $off++; } |
8905a67c6 update checkpatch... |
724 725 726 727 728 |
last; } } $off++; } |
a3bb97a7a checkpatch: macro... |
729 |
# We are truly at the end, so shuffle to the next line. |
13214adf7 update checkpatch... |
730 |
if ($off == $len) { |
a3bb97a7a checkpatch: macro... |
731 |
$loff = $len + 1; |
13214adf7 update checkpatch... |
732 733 734 |
$line++; $remain--; } |
8905a67c6 update checkpatch... |
735 736 737 738 739 740 741 742 |
my $statement = substr($blk, $soff, $off - $soff + 1); my $condition = substr($blk, $soff, $coff - $soff + 1); #warn "STATEMENT<$statement> "; #warn "CONDITION<$condition> "; |
773647a09 update checkpatch... |
743 744 |
#print "coff<$coff> soff<$off> loff<$loff> "; |
13214adf7 update checkpatch... |
745 746 747 748 |
return ($statement, $condition, $line, $remain + 1, $off - $loff + 1, $level); } |
cf655043d update checkpatch... |
749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 |
sub statement_lines { my ($stmt) = @_; # Strip the diff line prefixes and rip blank lines at start and end. $stmt =~ s/(^| )./$1/g; $stmt =~ s/^\s*//; $stmt =~ s/\s*$//; my @stmt_lines = ($stmt =~ / /g); return $#stmt_lines + 2; } sub statement_rawlines { my ($stmt) = @_; my @stmt_lines = ($stmt =~ / /g); return $#stmt_lines + 2; } sub statement_block_size { my ($stmt) = @_; $stmt =~ s/(^| )./$1/g; $stmt =~ s/^\s*{//; $stmt =~ s/}\s*$//; $stmt =~ s/^\s*//; $stmt =~ s/\s*$//; my @stmt_lines = ($stmt =~ / /g); my @stmt_statements = ($stmt =~ /;/g); my $stmt_lines = $#stmt_lines + 2; my $stmt_statements = $#stmt_statements + 1; if ($stmt_lines > $stmt_statements) { return $stmt_lines; } else { return $stmt_statements; } } |
13214adf7 update checkpatch... |
796 797 798 799 800 |
sub ctx_statement_full { my ($linenr, $remain, $off) = @_; my ($statement, $condition, $level); my (@chunks); |
cf655043d update checkpatch... |
801 |
# Grab the first conditional/block pair. |
13214adf7 update checkpatch... |
802 803 |
($statement, $condition, $linenr, $remain, $off, $level) = ctx_statement_block($linenr, $remain, $off); |
773647a09 update checkpatch... |
804 805 |
#print "F: c<$condition> s<$statement> remain<$remain> "; |
cf655043d update checkpatch... |
806 807 808 809 810 811 812 813 |
push(@chunks, [ $condition, $statement ]); if (!($remain > 0 && $condition =~ /^\s*(?: [+-])?\s*(?:if|else|do)\b/s)) { return ($level, $linenr, @chunks); } # Pull in the following conditional/block pairs and see if they # could continue the statement. |
13214adf7 update checkpatch... |
814 |
for (;;) { |
13214adf7 update checkpatch... |
815 816 |
($statement, $condition, $linenr, $remain, $off, $level) = ctx_statement_block($linenr, $remain, $off); |
cf655043d update checkpatch... |
817 818 |
#print "C: c<$condition> s<$statement> remain<$remain> "; |
773647a09 update checkpatch... |
819 820 |
last if (!($remain > 0 && $condition =~ /^(?:\s* [+-])*\s*(?:else|do)\b/s)); |
cf655043d update checkpatch... |
821 822 823 |
#print "C: push "; push(@chunks, [ $condition, $statement ]); |
13214adf7 update checkpatch... |
824 825 826 |
} return ($level, $linenr, @chunks); |
8905a67c6 update checkpatch... |
827 |
} |
4a0df2ef4 update checkpatch... |
828 |
sub ctx_block_get { |
f0a594c1c update checkpatch... |
829 |
my ($linenr, $remain, $outer, $open, $close, $off) = @_; |
4a0df2ef4 update checkpatch... |
830 831 |
my $line; my $start = $linenr - 1; |
4a0df2ef4 update checkpatch... |
832 833 834 835 |
my $blk = ''; my @o; my @c; my @res = (); |
f0a594c1c update checkpatch... |
836 |
my $level = 0; |
4635f4fba checkpatch: track... |
837 |
my @stack = ($level); |
00df344fd update checkpatch... |
838 839 840 841 842 |
for ($line = $start; $remain > 0; $line++) { next if ($rawlines[$line] =~ /^-/); $remain--; $blk .= $rawlines[$line]; |
4635f4fba checkpatch: track... |
843 844 |
# Handle nested #if/#else. |
01464f30a checkpatch: state... |
845 |
if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) { |
4635f4fba checkpatch: track... |
846 |
push(@stack, $level); |
01464f30a checkpatch: state... |
847 |
} elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) { |
4635f4fba checkpatch: track... |
848 |
$level = $stack[$#stack - 1]; |
01464f30a checkpatch: state... |
849 |
} elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) { |
4635f4fba checkpatch: track... |
850 851 |
$level = pop(@stack); } |
01464f30a checkpatch: state... |
852 |
foreach my $c (split(//, $lines[$line])) { |
f0a594c1c update checkpatch... |
853 854 855 856 857 858 |
##print "C<$c>L<$level><$open$close>O<$off> "; if ($off > 0) { $off--; next; } |
4a0df2ef4 update checkpatch... |
859 |
|
f0a594c1c update checkpatch... |
860 861 862 863 864 865 866 |
if ($c eq $close && $level > 0) { $level--; last if ($level == 0); } elsif ($c eq $open) { $level++; } } |
4a0df2ef4 update checkpatch... |
867 |
|
f0a594c1c update checkpatch... |
868 |
if (!$outer || $level <= 1) { |
00df344fd update checkpatch... |
869 |
push(@res, $rawlines[$line]); |
4a0df2ef4 update checkpatch... |
870 |
} |
f0a594c1c update checkpatch... |
871 |
last if ($level == 0); |
4a0df2ef4 update checkpatch... |
872 |
} |
f0a594c1c update checkpatch... |
873 |
return ($level, @res); |
4a0df2ef4 update checkpatch... |
874 875 876 |
} sub ctx_block_outer { my ($linenr, $remain) = @_; |
f0a594c1c update checkpatch... |
877 878 |
my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0); return @r; |
4a0df2ef4 update checkpatch... |
879 880 881 |
} sub ctx_block { my ($linenr, $remain) = @_; |
f0a594c1c update checkpatch... |
882 883 |
my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0); return @r; |
653d4876b update checkpatch... |
884 885 |
} sub ctx_statement { |
f0a594c1c update checkpatch... |
886 887 888 889 890 891 |
my ($linenr, $remain, $off) = @_; my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off); return @r; } sub ctx_block_level { |
653d4876b update checkpatch... |
892 |
my ($linenr, $remain) = @_; |
f0a594c1c update checkpatch... |
893 |
return ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
4a0df2ef4 update checkpatch... |
894 |
} |
9c0ca6f9a update checkpatch... |
895 896 897 898 899 |
sub ctx_statement_level { my ($linenr, $remain, $off) = @_; return ctx_block_get($linenr, $remain, 0, '(', ')', $off); } |
4a0df2ef4 update checkpatch... |
900 901 902 903 904 |
sub ctx_locate_comment { my ($first_line, $end_line) = @_; # Catch a comment on the end of the line itself. |
beae63324 checkpatch: comme... |
905 |
my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@); |
4a0df2ef4 update checkpatch... |
906 907 908 909 910 911 912 |
return $current_comment if (defined $current_comment); # Look through the context and try and figure out if there is a # comment. my $in_comment = 0; $current_comment = ''; for (my $linenr = $first_line; $linenr < $end_line; $linenr++) { |
00df344fd update checkpatch... |
913 914 915 |
my $line = $rawlines[$linenr - 1]; #warn " $line "; |
4a0df2ef4 update checkpatch... |
916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 |
if ($linenr == $first_line and $line =~ m@^.\s*\*@) { $in_comment = 1; } if ($line =~ m@/\*@) { $in_comment = 1; } if (!$in_comment && $current_comment ne '') { $current_comment = ''; } $current_comment .= $line . " " if ($in_comment); if ($line =~ m@\*/@) { $in_comment = 0; } } chomp($current_comment); return($current_comment); } sub ctx_has_comment { my ($first_line, $end_line) = @_; my $cmt = ctx_locate_comment($first_line, $end_line); |
00df344fd update checkpatch... |
938 939 |
##print "LINE: $rawlines[$end_line - 1 ] "; |
4a0df2ef4 update checkpatch... |
940 941 942 943 944 |
##print "CMMT: $cmt "; return ($cmt ne ''); } |
4d001e4d8 checkpatch: repor... |
945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 |
sub raw_line { my ($linenr, $cnt) = @_; my $offset = $linenr - 1; $cnt++; my $line; while ($cnt) { $line = $rawlines[$offset++]; next if (defined($line) && $line =~ /^-/); $cnt--; } return $line; } |
6c72ffaab update checkpatch... |
960 961 962 |
sub cat_vet { my ($vet) = @_; my ($res, $coded); |
9c0ca6f9a update checkpatch... |
963 |
|
6c72ffaab update checkpatch... |
964 965 966 967 968 969 |
$res = ''; while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) { $res .= $1; if ($2 ne '') { $coded = sprintf("^%c", unpack('C', $2) + 64); $res .= $coded; |
9c0ca6f9a update checkpatch... |
970 971 |
} } |
6c72ffaab update checkpatch... |
972 |
$res =~ s/$/\$/; |
9c0ca6f9a update checkpatch... |
973 |
|
6c72ffaab update checkpatch... |
974 |
return $res; |
9c0ca6f9a update checkpatch... |
975 |
} |
c2fdda0df update checkpatch... |
976 |
my $av_preprocessor = 0; |
cf655043d update checkpatch... |
977 |
my $av_pending; |
c2fdda0df update checkpatch... |
978 |
my @av_paren_type; |
1f65f947a checkpatch: add c... |
979 |
my $av_pend_colon; |
c2fdda0df update checkpatch... |
980 981 982 |
sub annotate_reset { $av_preprocessor = 0; |
cf655043d update checkpatch... |
983 984 |
$av_pending = '_'; @av_paren_type = ('E'); |
1f65f947a checkpatch: add c... |
985 |
$av_pend_colon = 'O'; |
c2fdda0df update checkpatch... |
986 |
} |
6c72ffaab update checkpatch... |
987 988 |
sub annotate_values { my ($stream, $type) = @_; |
0a920b5b6 add a trivial pat... |
989 |
|
6c72ffaab update checkpatch... |
990 |
my $res; |
1f65f947a checkpatch: add c... |
991 |
my $var = '_' x length($stream); |
6c72ffaab update checkpatch... |
992 |
my $cur = $stream; |
c2fdda0df update checkpatch... |
993 994 |
print "$stream " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
995 |
|
6c72ffaab update checkpatch... |
996 |
while (length($cur)) { |
773647a09 update checkpatch... |
997 |
@av_paren_type = ('E') if ($#av_paren_type < 0); |
cf655043d update checkpatch... |
998 |
print " <" . join('', @av_paren_type) . |
171ae1a49 update checkpatch... |
999 |
"> <$type> <$av_pending>" if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1000 |
if ($cur =~ /^(\s+)/o) { |
c2fdda0df update checkpatch... |
1001 1002 1003 1004 |
print "WS($1) " if ($dbg_values > 1); if ($1 =~ / / && $av_preprocessor) { |
cf655043d update checkpatch... |
1005 |
$type = pop(@av_paren_type); |
c2fdda0df update checkpatch... |
1006 |
$av_preprocessor = 0; |
6c72ffaab update checkpatch... |
1007 |
} |
c023e4734 checkpatch.pl: fi... |
1008 |
} elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') { |
9446ef569 checkpatch: handl... |
1009 1010 1011 1012 |
print "CAST($1) " if ($dbg_values > 1); push(@av_paren_type, $type); $type = 'C'; |
e91b6e263 checkpatch: types... |
1013 |
} elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) { |
c2fdda0df update checkpatch... |
1014 1015 |
print "DECLARE($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1016 |
$type = 'T'; |
389a2fe57 checkpatch: allow... |
1017 1018 1019 1020 |
} elsif ($cur =~ /^($Modifier)\s*/) { print "MODIFIER($1) " if ($dbg_values > 1); $type = 'T'; |
c45dcabd2 update checkpatch... |
1021 |
} elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) { |
171ae1a49 update checkpatch... |
1022 1023 |
print "DEFINE($1,$2) " if ($dbg_values > 1); |
c2fdda0df update checkpatch... |
1024 |
$av_preprocessor = 1; |
171ae1a49 update checkpatch... |
1025 1026 1027 1028 1029 |
push(@av_paren_type, $type); if ($2 ne '') { $av_pending = 'N'; } $type = 'E'; |
c45dcabd2 update checkpatch... |
1030 |
} elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) { |
171ae1a49 update checkpatch... |
1031 1032 1033 1034 |
print "UNDEF($1) " if ($dbg_values > 1); $av_preprocessor = 1; push(@av_paren_type, $type); |
6c72ffaab update checkpatch... |
1035 |
|
c45dcabd2 update checkpatch... |
1036 |
} elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) { |
cf655043d update checkpatch... |
1037 1038 |
print "PRE_START($1) " if ($dbg_values > 1); |
c2fdda0df update checkpatch... |
1039 |
$av_preprocessor = 1; |
cf655043d update checkpatch... |
1040 1041 1042 |
push(@av_paren_type, $type); push(@av_paren_type, $type); |
171ae1a49 update checkpatch... |
1043 |
$type = 'E'; |
cf655043d update checkpatch... |
1044 |
|
c45dcabd2 update checkpatch... |
1045 |
} elsif ($cur =~ /^(\#\s*(?:else|elif))/o) { |
cf655043d update checkpatch... |
1046 1047 1048 1049 1050 |
print "PRE_RESTART($1) " if ($dbg_values > 1); $av_preprocessor = 1; push(@av_paren_type, $av_paren_type[$#av_paren_type]); |
171ae1a49 update checkpatch... |
1051 |
$type = 'E'; |
cf655043d update checkpatch... |
1052 |
|
c45dcabd2 update checkpatch... |
1053 |
} elsif ($cur =~ /^(\#\s*(?:endif))/o) { |
cf655043d update checkpatch... |
1054 1055 1056 1057 1058 1059 1060 1061 1062 |
print "PRE_END($1) " if ($dbg_values > 1); $av_preprocessor = 1; # Assume all arms of the conditional end as this # one does, and continue as if the #endif was not here. pop(@av_paren_type); push(@av_paren_type, $type); |
171ae1a49 update checkpatch... |
1063 |
$type = 'E'; |
6c72ffaab update checkpatch... |
1064 1065 1066 |
} elsif ($cur =~ /^(\\ )/o) { |
c2fdda0df update checkpatch... |
1067 1068 |
print "PRECONT($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1069 |
|
171ae1a49 update checkpatch... |
1070 1071 1072 1073 1074 |
} elsif ($cur =~ /^(__attribute__)\s*\(?/o) { print "ATTR($1) " if ($dbg_values > 1); $av_pending = $type; $type = 'N'; |
6c72ffaab update checkpatch... |
1075 |
} elsif ($cur =~ /^(sizeof)\s*(\()?/o) { |
c2fdda0df update checkpatch... |
1076 1077 |
print "SIZEOF($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1078 |
if (defined $2) { |
cf655043d update checkpatch... |
1079 |
$av_pending = 'V'; |
6c72ffaab update checkpatch... |
1080 1081 |
} $type = 'N'; |
14b111c15 checkpatch: condi... |
1082 |
} elsif ($cur =~ /^(if|while|for)\b/o) { |
c2fdda0df update checkpatch... |
1083 1084 |
print "COND($1) " if ($dbg_values > 1); |
14b111c15 checkpatch: condi... |
1085 |
$av_pending = 'E'; |
6c72ffaab update checkpatch... |
1086 |
$type = 'N'; |
1f65f947a checkpatch: add c... |
1087 1088 1089 1090 1091 |
} elsif ($cur =~/^(case)/o) { print "CASE($1) " if ($dbg_values > 1); $av_pend_colon = 'C'; $type = 'N'; |
14b111c15 checkpatch: condi... |
1092 |
} elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) { |
c2fdda0df update checkpatch... |
1093 1094 |
print "KEYWORD($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1095 1096 1097 |
$type = 'N'; } elsif ($cur =~ /^(\()/o) { |
c2fdda0df update checkpatch... |
1098 1099 |
print "PAREN('$1') " if ($dbg_values > 1); |
cf655043d update checkpatch... |
1100 1101 |
push(@av_paren_type, $av_pending); $av_pending = '_'; |
6c72ffaab update checkpatch... |
1102 1103 1104 |
$type = 'N'; } elsif ($cur =~ /^(\))/o) { |
cf655043d update checkpatch... |
1105 1106 1107 |
my $new_type = pop(@av_paren_type); if ($new_type ne '_') { $type = $new_type; |
c2fdda0df update checkpatch... |
1108 1109 1110 |
print "PAREN('$1') -> $type " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1111 |
} else { |
c2fdda0df update checkpatch... |
1112 1113 |
print "PAREN('$1') " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1114 |
} |
c8cb2ca37 checkpatch: types... |
1115 |
} elsif ($cur =~ /^($Ident)\s*\(/o) { |
c2fdda0df update checkpatch... |
1116 1117 |
print "FUNC($1) " if ($dbg_values > 1); |
c8cb2ca37 checkpatch: types... |
1118 |
$type = 'V'; |
cf655043d update checkpatch... |
1119 |
$av_pending = 'V'; |
6c72ffaab update checkpatch... |
1120 |
|
8e761b04a checkpatch: detec... |
1121 1122 |
} elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) { if (defined $2 && $type eq 'C' || $type eq 'T') { |
1f65f947a checkpatch: add c... |
1123 |
$av_pend_colon = 'B'; |
8e761b04a checkpatch: detec... |
1124 1125 |
} elsif ($type eq 'E') { $av_pend_colon = 'L'; |
1f65f947a checkpatch: add c... |
1126 1127 1128 1129 |
} print "IDENT_COLON($1,$type>$av_pend_colon) " if ($dbg_values > 1); $type = 'V'; |
6c72ffaab update checkpatch... |
1130 |
} elsif ($cur =~ /^($Ident|$Constant)/o) { |
c2fdda0df update checkpatch... |
1131 1132 |
print "IDENT($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1133 1134 1135 |
$type = 'V'; } elsif ($cur =~ /^($Assignment)/o) { |
c2fdda0df update checkpatch... |
1136 1137 |
print "ASSIGN($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1138 |
$type = 'N'; |
cf655043d update checkpatch... |
1139 |
} elsif ($cur =~/^(;|{|})/) { |
c2fdda0df update checkpatch... |
1140 1141 |
print "END($1) " if ($dbg_values > 1); |
13214adf7 update checkpatch... |
1142 |
$type = 'E'; |
1f65f947a checkpatch: add c... |
1143 |
$av_pend_colon = 'O'; |
8e761b04a checkpatch: detec... |
1144 1145 1146 1147 |
} elsif ($cur =~/^(,)/) { print "COMMA($1) " if ($dbg_values > 1); $type = 'C'; |
1f65f947a checkpatch: add c... |
1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 |
} elsif ($cur =~ /^(\?)/o) { print "QUESTION($1) " if ($dbg_values > 1); $type = 'N'; } elsif ($cur =~ /^(:)/o) { print "COLON($1,$av_pend_colon) " if ($dbg_values > 1); substr($var, length($res), 1, $av_pend_colon); if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') { $type = 'E'; } else { $type = 'N'; } $av_pend_colon = 'O'; |
13214adf7 update checkpatch... |
1164 |
|
8e761b04a checkpatch: detec... |
1165 |
} elsif ($cur =~ /^(\[)/o) { |
13214adf7 update checkpatch... |
1166 1167 |
print "CLOSE($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1168 |
$type = 'N'; |
0d413866c checkpatch: value... |
1169 |
} elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) { |
74048ed81 checkpatch: varia... |
1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 |
my $variant; print "OPV($1) " if ($dbg_values > 1); if ($type eq 'V') { $variant = 'B'; } else { $variant = 'U'; } substr($var, length($res), 1, $variant); $type = 'N'; |
6c72ffaab update checkpatch... |
1182 |
} elsif ($cur =~ /^($Operators)/o) { |
c2fdda0df update checkpatch... |
1183 1184 |
print "OP($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1185 1186 1187 1188 1189 |
if ($1 ne '++' && $1 ne '--') { $type = 'N'; } } elsif ($cur =~ /(^.)/o) { |
c2fdda0df update checkpatch... |
1190 1191 |
print "C($1) " if ($dbg_values > 1); |
6c72ffaab update checkpatch... |
1192 1193 1194 1195 1196 |
} if (defined $1) { $cur = substr($cur, length($1)); $res .= $type x length($1); } |
9c0ca6f9a update checkpatch... |
1197 |
} |
0a920b5b6 add a trivial pat... |
1198 |
|
1f65f947a checkpatch: add c... |
1199 |
return ($res, $var); |
0a920b5b6 add a trivial pat... |
1200 |
} |
8905a67c6 update checkpatch... |
1201 |
sub possible { |
13214adf7 update checkpatch... |
1202 |
my ($possible, $line) = @_; |
9a974fdbe checkpatch: possi... |
1203 |
my $notPermitted = qr{(?: |
0776e5946 checkpatch: do is... |
1204 1205 1206 1207 |
^(?: $Modifier| $Storage| $Type| |
9a974fdbe checkpatch: possi... |
1208 1209 1210 |
DEFINE_\S+ )$| ^(?: |
0776e5946 checkpatch: do is... |
1211 1212 1213 1214 1215 1216 |
goto| return| case| else| asm|__asm__| do |
9a974fdbe checkpatch: possi... |
1217 |
)(?:\s|$)| |
0776e5946 checkpatch: do is... |
1218 |
^(?:typedef|struct|enum)\b |
9a974fdbe checkpatch: possi... |
1219 1220 1221 1222 |
)}x; warn "CHECK<$possible> ($line) " if ($dbg_possible > 2); if ($possible !~ $notPermitted) { |
c45dcabd2 update checkpatch... |
1223 1224 1225 1226 1227 1228 1229 |
# Check for modifiers. $possible =~ s/\s*$Storage\s*//g; $possible =~ s/\s*$Sparse\s*//g; if ($possible =~ /^\s*$/) { } elsif ($possible =~ /\s/) { $possible =~ s/\s*$Type\s*//g; |
d25065865 checkpatch: possi... |
1230 |
for my $modifier (split(' ', $possible)) { |
9a974fdbe checkpatch: possi... |
1231 1232 1233 1234 1235 |
if ($modifier !~ $notPermitted) { warn "MODIFIER: $modifier ($possible) ($line) " if ($dbg_possible); push(@modifierList, $modifier); } |
d25065865 checkpatch: possi... |
1236 |
} |
c45dcabd2 update checkpatch... |
1237 1238 1239 1240 1241 1242 |
} else { warn "POSSIBLE: $possible ($line) " if ($dbg_possible); push(@typeList, $possible); } |
8905a67c6 update checkpatch... |
1243 |
build_types(); |
0776e5946 checkpatch: do is... |
1244 1245 1246 |
} else { warn "NOTPOSS: $possible ($line) " if ($dbg_possible > 1); |
8905a67c6 update checkpatch... |
1247 1248 |
} } |
6c72ffaab update checkpatch... |
1249 |
my $prefix = ''; |
000d1cc18 checkpatch.pl: ad... |
1250 1251 1252 |
sub show_type { return !defined $ignore_type{$_[0]}; } |
f0a594c1c update checkpatch... |
1253 |
sub report { |
000d1cc18 checkpatch.pl: ad... |
1254 1255 |
if (!show_type($_[1]) || (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) { |
773647a09 update checkpatch... |
1256 1257 |
return 0; } |
000d1cc18 checkpatch.pl: ad... |
1258 1259 1260 1261 1262 1263 1264 1265 |
my $line; if ($show_types) { $line = "$prefix$_[0]:$_[1]: $_[2] "; } else { $line = "$prefix$_[0]: $_[2] "; } |
8905a67c6 update checkpatch... |
1266 1267 1268 |
$line = (split(' ', $line))[0] . " " if ($terse); |
13214adf7 update checkpatch... |
1269 |
push(our @report, $line); |
773647a09 update checkpatch... |
1270 1271 |
return 1; |
f0a594c1c update checkpatch... |
1272 1273 |
} sub report_dump { |
13214adf7 update checkpatch... |
1274 |
our @report; |
f0a594c1c update checkpatch... |
1275 |
} |
000d1cc18 checkpatch.pl: ad... |
1276 |
|
de7d4f0e1 update checkpatch... |
1277 |
sub ERROR { |
000d1cc18 checkpatch.pl: ad... |
1278 |
if (report("ERROR", $_[0], $_[1])) { |
773647a09 update checkpatch... |
1279 1280 1281 |
our $clean = 0; our $cnt_error++; } |
de7d4f0e1 update checkpatch... |
1282 1283 |
} sub WARN { |
000d1cc18 checkpatch.pl: ad... |
1284 |
if (report("WARNING", $_[0], $_[1])) { |
773647a09 update checkpatch... |
1285 1286 1287 |
our $clean = 0; our $cnt_warn++; } |
de7d4f0e1 update checkpatch... |
1288 1289 |
} sub CHK { |
000d1cc18 checkpatch.pl: ad... |
1290 |
if ($check && report("CHECK", $_[0], $_[1])) { |
6c72ffaab update checkpatch... |
1291 1292 1293 |
our $clean = 0; our $cnt_chk++; } |
de7d4f0e1 update checkpatch... |
1294 |
} |
6ecd96744 checkpatch: repor... |
1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 |
sub check_absolute_file { my ($absolute, $herecurr) = @_; my $file = $absolute; ##print "absolute<$absolute> "; # See if any suffix of this path is a path within the tree. while ($file =~ s@^[^/]*/@@) { if (-f "$root/$file") { ##print "file<$file> "; last; } } if (! -f _) { return 0; } # It is, so see if the prefix is acceptable. my $prefix = $absolute; substr($prefix, -length($file)) = ''; ##print "prefix<$prefix> "; if ($prefix ne ".../") { |
000d1cc18 checkpatch.pl: ad... |
1321 1322 1323 |
WARN("USE_RELATIVE_PATH", "use relative pathname instead of absolute in changelog text " . $herecurr); |
6ecd96744 checkpatch: repor... |
1324 1325 |
} } |
0a920b5b6 add a trivial pat... |
1326 1327 |
sub process { my $filename = shift; |
0a920b5b6 add a trivial pat... |
1328 1329 1330 |
my $linenr=0; my $prevline=""; |
c2fdda0df update checkpatch... |
1331 |
my $prevrawline=""; |
0a920b5b6 add a trivial pat... |
1332 |
my $stashline=""; |
c2fdda0df update checkpatch... |
1333 |
my $stashrawline=""; |
0a920b5b6 add a trivial pat... |
1334 |
|
4a0df2ef4 update checkpatch... |
1335 |
my $length; |
0a920b5b6 add a trivial pat... |
1336 1337 1338 |
my $indent; my $previndent=0; my $stashindent=0; |
de7d4f0e1 update checkpatch... |
1339 |
our $clean = 1; |
0a920b5b6 add a trivial pat... |
1340 1341 |
my $signoff = 0; my $is_patch = 0; |
13214adf7 update checkpatch... |
1342 |
our @report = (); |
6c72ffaab update checkpatch... |
1343 1344 1345 1346 |
our $cnt_lines = 0; our $cnt_error = 0; our $cnt_warn = 0; our $cnt_chk = 0; |
0a920b5b6 add a trivial pat... |
1347 1348 1349 1350 1351 1352 |
# Trace the real file/line as we go. my $realfile = ''; my $realline = 0; my $realcnt = 0; my $here = ''; my $in_comment = 0; |
c2fdda0df update checkpatch... |
1353 |
my $comment_edge = 0; |
0a920b5b6 add a trivial pat... |
1354 |
my $first_line = 0; |
1e8557269 checkpatch: Add w... |
1355 |
my $p1_prefix = ''; |
0a920b5b6 add a trivial pat... |
1356 |
|
13214adf7 update checkpatch... |
1357 1358 1359 |
my $prev_values = 'E'; # suppression flags |
773647a09 update checkpatch... |
1360 |
my %suppress_ifbraces; |
170d3a226 checkpatch: handl... |
1361 |
my %suppress_whiletrailers; |
2b474a1a5 checkpatch: fix f... |
1362 |
my %suppress_export; |
653d4876b update checkpatch... |
1363 |
|
c2fdda0df update checkpatch... |
1364 |
# Pre-scan the patch sanitizing the lines. |
de7d4f0e1 update checkpatch... |
1365 |
# Pre-scan the patch looking for any __setup documentation. |
c2fdda0df update checkpatch... |
1366 |
# |
de7d4f0e1 update checkpatch... |
1367 1368 |
my @setup_docs = (); my $setup_docs = 0; |
773647a09 update checkpatch... |
1369 1370 |
sanitise_line_reset(); |
c2fdda0df update checkpatch... |
1371 1372 |
my $line; foreach my $rawline (@rawlines) { |
773647a09 update checkpatch... |
1373 1374 |
$linenr++; $line = $rawline; |
c2fdda0df update checkpatch... |
1375 |
|
773647a09 update checkpatch... |
1376 |
if ($rawline=~/^\+\+\+\s+(\S+)/) { |
de7d4f0e1 update checkpatch... |
1377 1378 1379 1380 |
$setup_docs = 0; if ($1 =~ m@Documentation/kernel-parameters.txt$@) { $setup_docs = 1; } |
773647a09 update checkpatch... |
1381 1382 1383 1384 1385 1386 1387 1388 1389 |
#next; } if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { $realline=$1-1; if (defined $2) { $realcnt=$3+1; } else { $realcnt=1+1; } |
c45dcabd2 update checkpatch... |
1390 |
$in_comment = 0; |
773647a09 update checkpatch... |
1391 1392 1393 1394 1395 1396 |
# Guestimate if this is a continuing comment. Run # the context looking for a comment "edge". If this # edge is a close comment then we must be in a comment # at context start. my $edge; |
01fa91471 checkpatch: fix u... |
1397 1398 1399 1400 1401 1402 1403 |
my $cnt = $realcnt; for (my $ln = $linenr + 1; $cnt > 0; $ln++) { next if (defined $rawlines[$ln - 1] && $rawlines[$ln - 1] =~ /^-/); $cnt--; #print "RAW<$rawlines[$ln - 1]> "; |
721c1cb60 checkpatch: comme... |
1404 |
last if (!defined $rawlines[$ln - 1]); |
fae17daed checkpatch: comme... |
1405 1406 1407 1408 1409 |
if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ && $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) { ($edge) = $1; last; } |
773647a09 update checkpatch... |
1410 1411 1412 1413 1414 1415 1416 1417 1418 |
} if (defined $edge && $edge eq '*/') { $in_comment = 1; } # Guestimate if this is a continuing comment. If this # is the start of a diff block and this line starts # ' *' then it is very likely a comment. if (!defined $edge && |
83242e0c2 checkpatch: widen... |
1419 |
$rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@) |
773647a09 update checkpatch... |
1420 1421 1422 1423 1424 1425 1426 |
{ $in_comment = 1; } ##print "COMMENT:$in_comment edge<$edge> $rawline "; sanitise_line_reset($in_comment); |
171ae1a49 update checkpatch... |
1427 |
} elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) { |
773647a09 update checkpatch... |
1428 |
# Standardise the strings and chars within the input to |
171ae1a49 update checkpatch... |
1429 |
# simplify matching -- only bother with positive lines. |
773647a09 update checkpatch... |
1430 |
$line = sanitise_line($rawline); |
de7d4f0e1 update checkpatch... |
1431 |
} |
773647a09 update checkpatch... |
1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 |
push(@lines, $line); if ($realcnt > 1) { $realcnt-- if ($line =~ /^(?:\+| |$)/); } else { $realcnt = 0; } #print "==>$rawline "; #print "-->$line "; |
de7d4f0e1 update checkpatch... |
1444 1445 1446 1447 1448 |
if ($setup_docs && $line =~ /^\+/) { push(@setup_docs, $line); } } |
6c72ffaab update checkpatch... |
1449 |
$prefix = ''; |
773647a09 update checkpatch... |
1450 1451 |
$realcnt = 0; $linenr = 0; |
0a920b5b6 add a trivial pat... |
1452 1453 |
foreach my $line (@lines) { $linenr++; |
c2fdda0df update checkpatch... |
1454 |
my $rawline = $rawlines[$linenr - 1]; |
6c72ffaab update checkpatch... |
1455 |
|
0a920b5b6 add a trivial pat... |
1456 |
#extract the line range in the file after the patch is applied |
6c72ffaab update checkpatch... |
1457 |
if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
0a920b5b6 add a trivial pat... |
1458 |
$is_patch = 1; |
4a0df2ef4 update checkpatch... |
1459 |
$first_line = $linenr + 1; |
0a920b5b6 add a trivial pat... |
1460 1461 1462 1463 1464 1465 |
$realline=$1-1; if (defined $2) { $realcnt=$3+1; } else { $realcnt=1+1; } |
c2fdda0df update checkpatch... |
1466 |
annotate_reset(); |
13214adf7 update checkpatch... |
1467 |
$prev_values = 'E'; |
773647a09 update checkpatch... |
1468 |
%suppress_ifbraces = (); |
170d3a226 checkpatch: handl... |
1469 |
%suppress_whiletrailers = (); |
2b474a1a5 checkpatch: fix f... |
1470 |
%suppress_export = (); |
0a920b5b6 add a trivial pat... |
1471 |
next; |
0a920b5b6 add a trivial pat... |
1472 |
|
4a0df2ef4 update checkpatch... |
1473 1474 1475 |
# track the line number as we move through the hunk, note that # new versions of GNU diff omit the leading space on completely # blank context lines so we need to count that too. |
773647a09 update checkpatch... |
1476 |
} elsif ($line =~ /^( |\+|$)/) { |
0a920b5b6 add a trivial pat... |
1477 |
$realline++; |
d8aaf1214 update checkpatch... |
1478 |
$realcnt-- if ($realcnt != 0); |
0a920b5b6 add a trivial pat... |
1479 |
|
4a0df2ef4 update checkpatch... |
1480 |
# Measure the line length and indent. |
c2fdda0df update checkpatch... |
1481 |
($length, $indent) = line_stats($rawline); |
0a920b5b6 add a trivial pat... |
1482 1483 1484 1485 |
# Track the previous line. ($prevline, $stashline) = ($stashline, $line); ($previndent, $stashindent) = ($stashindent, $indent); |
c2fdda0df update checkpatch... |
1486 |
($prevrawline, $stashrawline) = ($stashrawline, $rawline); |
773647a09 update checkpatch... |
1487 1488 |
#warn "line<$line> "; |
6c72ffaab update checkpatch... |
1489 |
|
d8aaf1214 update checkpatch... |
1490 1491 |
} elsif ($realcnt == 1) { $realcnt--; |
0a920b5b6 add a trivial pat... |
1492 |
} |
cc77cdca5 checkpatch: corre... |
1493 |
my $hunk_line = ($realcnt != 0); |
0a920b5b6 add a trivial pat... |
1494 |
#make up the handle for any error we report on this line |
773647a09 update checkpatch... |
1495 1496 |
$prefix = "$filename:$realline: " if ($emacs && $file); $prefix = "$filename:$linenr: " if ($emacs && !$file); |
6c72ffaab update checkpatch... |
1497 1498 |
$here = "#$linenr: " if (!$file); $here = "#$realline: " if ($file); |
773647a09 update checkpatch... |
1499 1500 |
# extract the filename as it passes |
3bf9a009f checkpatch: check... |
1501 1502 1503 1504 1505 |
if ($line =~ /^diff --git.*?(\S+)$/) { $realfile = $1; $realfile =~ s@^([^/]*)/@@; } elsif ($line =~ /^\+\+\+\s+(\S+)/) { |
773647a09 update checkpatch... |
1506 |
$realfile = $1; |
1e8557269 checkpatch: Add w... |
1507 1508 1509 |
$realfile =~ s@^([^/]*)/@@; $p1_prefix = $1; |
e2f7aa4b8 checkpatch: do no... |
1510 1511 |
if (!$file && $tree && $p1_prefix ne '' && -e "$root/$p1_prefix") { |
000d1cc18 checkpatch.pl: ad... |
1512 1513 1514 |
WARN("PATCH_PREFIX", "patch prefix '$p1_prefix' exists, appears to be a -p0 patch "); |
1e8557269 checkpatch: Add w... |
1515 |
} |
773647a09 update checkpatch... |
1516 |
|
c1ab33269 checkpatch: inclu... |
1517 |
if ($realfile =~ m@^include/asm/@) { |
000d1cc18 checkpatch.pl: ad... |
1518 1519 1520 1521 |
ERROR("MODIFIED_INCLUDE_ASM", "do not modify files in include/asm, change architecture specific files in include/asm-<architecture> " . "$here$rawline "); |
773647a09 update checkpatch... |
1522 1523 1524 |
} next; } |
389834b68 checkpatch: produ... |
1525 |
$here .= "FILE: $realfile:$realline:" if ($realcnt != 0); |
0a920b5b6 add a trivial pat... |
1526 |
|
c2fdda0df update checkpatch... |
1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 |
my $hereline = "$here $rawline "; my $herecurr = "$here $rawline "; my $hereprev = "$here $prevrawline $rawline "; |
0a920b5b6 add a trivial pat... |
1537 |
|
6c72ffaab update checkpatch... |
1538 |
$cnt_lines++ if ($realcnt != 0); |
3bf9a009f checkpatch: check... |
1539 1540 1541 1542 1543 |
# Check for incorrect file permissions if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { my $permhere = $here . "FILE: $realfile "; if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) { |
000d1cc18 checkpatch.pl: ad... |
1544 1545 1546 |
ERROR("EXECUTE_PERMISSIONS", "do not set execute permissions for source files " . $permhere); |
3bf9a009f checkpatch: check... |
1547 1548 |
} } |
201124755 checkpatch: valid... |
1549 |
# Check the patch for a signoff: |
d8aaf1214 update checkpatch... |
1550 |
if ($line =~ /^\s*signed-off-by:/i) { |
4a0df2ef4 update checkpatch... |
1551 |
$signoff++; |
201124755 checkpatch: valid... |
1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 |
} # Check signature styles if ($line =~ /^(\s*)($signature_tags)(\s*)(.*)/) { my $space_before = $1; my $sign_off = $2; my $space_after = $3; my $email = $4; my $ucfirst_sign_off = ucfirst(lc($sign_off)); if (defined $space_before && $space_before ne "") { |
000d1cc18 checkpatch.pl: ad... |
1563 1564 1565 |
WARN("BAD_SIGN_OFF", "Do not use whitespace before $ucfirst_sign_off " . $herecurr); |
201124755 checkpatch: valid... |
1566 1567 |
} if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) { |
000d1cc18 checkpatch.pl: ad... |
1568 1569 1570 |
WARN("BAD_SIGN_OFF", "'$ucfirst_sign_off' is the preferred signature form " . $herecurr); |
201124755 checkpatch: valid... |
1571 1572 |
} if (!defined $space_after || $space_after ne " ") { |
000d1cc18 checkpatch.pl: ad... |
1573 1574 1575 |
WARN("BAD_SIGN_OFF", "Use a single space after $ucfirst_sign_off " . $herecurr); |
0a920b5b6 add a trivial pat... |
1576 |
} |
201124755 checkpatch: valid... |
1577 1578 1579 1580 |
my ($email_name, $email_address, $comment) = parse_email($email); my $suggested_email = format_email(($email_name, $email_address)); if ($suggested_email eq "") { |
000d1cc18 checkpatch.pl: ad... |
1581 1582 1583 |
ERROR("BAD_SIGN_OFF", "Unrecognized email address: '$email' " . $herecurr); |
201124755 checkpatch: valid... |
1584 1585 1586 1587 1588 1589 1590 1591 1592 |
} else { my $dequoted = $suggested_email; $dequoted =~ s/^"//; $dequoted =~ s/" </ </; # Don't force email to have quotes # Allow just an angle bracketed address if ("$dequoted$comment" ne $email && "<$email_address>$comment" ne $email && "$suggested_email$comment" ne $email) { |
000d1cc18 checkpatch.pl: ad... |
1593 1594 1595 |
WARN("BAD_SIGN_OFF", "email address '$email' might be better as '$suggested_email$comment' " . $herecurr); |
201124755 checkpatch: valid... |
1596 |
} |
0a920b5b6 add a trivial pat... |
1597 1598 |
} } |
00df344fd update checkpatch... |
1599 |
# Check for wrappage within a valid hunk of the file |
8905a67c6 update checkpatch... |
1600 |
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { |
000d1cc18 checkpatch.pl: ad... |
1601 1602 1603 |
ERROR("CORRUPTED_PATCH", "patch seems to be corrupt (line wrapped?) " . |
6c72ffaab update checkpatch... |
1604 |
$herecurr) if (!$emitted_corrupt++); |
de7d4f0e1 update checkpatch... |
1605 |
} |
6ecd96744 checkpatch: repor... |
1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 |
# Check for absolute kernel paths. if ($tree) { while ($line =~ m{(?:^|\s)(/\S*)}g) { my $file = $1; if ($file =~ m{^(.*?)(?::\d+)+:?$} && check_absolute_file($1, $herecurr)) { # } else { check_absolute_file($file, $herecurr); } } } |
de7d4f0e1 update checkpatch... |
1619 1620 |
# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php if (($realfile =~ /^$/ || $line =~ /^\+/) && |
171ae1a49 update checkpatch... |
1621 1622 1623 1624 1625 1626 1627 |
$rawline !~ m/^$UTF8*$/) { my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/); my $blank = copy_spacing($rawline); my $ptr = substr($blank, 0, length($utf8_prefix)) . "^"; my $hereptr = "$hereline$ptr "; |
34d992197 checkpatch: make ... |
1628 1629 1630 |
CHK("INVALID_UTF8", "Invalid UTF-8, patch and commit message should be encoded in UTF-8 " . $hereptr); |
00df344fd update checkpatch... |
1631 |
} |
306708547 checkpatch: ensur... |
1632 1633 |
# ignore non-hunk lines and lines being removed next if (!$hunk_line || $line =~ /^-/); |
0a920b5b6 add a trivial pat... |
1634 |
|
0a920b5b6 add a trivial pat... |
1635 |
#trailing whitespace |
9c0ca6f9a update checkpatch... |
1636 |
if ($line =~ /^\+.*\015/) { |
c2fdda0df update checkpatch... |
1637 1638 1639 |
my $herevet = "$here " . cat_vet($rawline) . " "; |
000d1cc18 checkpatch.pl: ad... |
1640 1641 1642 |
ERROR("DOS_LINE_ENDINGS", "DOS line endings " . $herevet); |
9c0ca6f9a update checkpatch... |
1643 |
|
c2fdda0df update checkpatch... |
1644 1645 1646 1647 |
} elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) { my $herevet = "$here " . cat_vet($rawline) . " "; |
000d1cc18 checkpatch.pl: ad... |
1648 1649 1650 |
ERROR("TRAILING_WHITESPACE", "trailing whitespace " . $herevet); |
d2c0a2351 checkpatch: sugge... |
1651 |
$rpt_cleaners = 1; |
0a920b5b6 add a trivial pat... |
1652 |
} |
5368df20f checkpatch: check... |
1653 |
|
3354957a4 checkpatch: add c... |
1654 |
# check for Kconfig help text having a real description |
9fe287d79 checkpatch: ensur... |
1655 1656 |
# Only applies when adding the entry originally, after that we do not have # sufficient context to determine whether it is indeed long enough. |
3354957a4 checkpatch: add c... |
1657 |
if ($realfile =~ /Kconfig/ && |
9fe287d79 checkpatch: ensur... |
1658 |
$line =~ /\+\s*(?:---)?help(?:---)?$/) { |
3354957a4 checkpatch: add c... |
1659 |
my $length = 0; |
9fe287d79 checkpatch: ensur... |
1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 |
my $cnt = $realcnt; my $ln = $linenr + 1; my $f; my $is_end = 0; while ($cnt > 0 && defined $lines[$ln - 1]) { $f = $lines[$ln - 1]; $cnt-- if ($lines[$ln - 1] !~ /^-/); $is_end = $lines[$ln - 1] =~ /^\+/; $ln++; next if ($f =~ /^-/); $f =~ s/^.//; |
3354957a4 checkpatch: add c... |
1672 1673 1674 |
$f =~ s/#.*//; $f =~ s/^\s+//; next if ($f =~ /^$/); |
9fe287d79 checkpatch: ensur... |
1675 1676 1677 1678 |
if ($f =~ /^\s*config\s/) { $is_end = 1; last; } |
3354957a4 checkpatch: add c... |
1679 1680 |
$length++; } |
000d1cc18 checkpatch.pl: ad... |
1681 1682 1683 |
WARN("CONFIG_DESCRIPTION", "please write a paragraph that describes the config symbol fully " . $herecurr) if ($is_end && $length < 4); |
9fe287d79 checkpatch: ensur... |
1684 1685 |
#print "is_end<$is_end> length<$length> "; |
3354957a4 checkpatch: add c... |
1686 |
} |
5368df20f checkpatch: check... |
1687 1688 |
# check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); |
0a920b5b6 add a trivial pat... |
1689 |
#80 column limit |
c45dcabd2 update checkpatch... |
1690 |
if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
f4c014c0d checkpatch: allow... |
1691 |
$rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
0fccc6221 checkpatch: fix d... |
1692 |
!($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ || |
8bbea968f checkpatch: add m... |
1693 |
$line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && |
f4c014c0d checkpatch: allow... |
1694 |
$length > 80) |
c45dcabd2 update checkpatch... |
1695 |
{ |
000d1cc18 checkpatch.pl: ad... |
1696 1697 1698 |
WARN("LONG_LINE", "line over 80 characters " . $herecurr); |
0a920b5b6 add a trivial pat... |
1699 |
} |
5e79d96ee checkpatch: warn ... |
1700 1701 1702 |
# check for spaces before a quoted newline if ($rawline =~ /^.*\".*\s\ /) { |
000d1cc18 checkpatch.pl: ad... |
1703 1704 1705 |
WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE", "unnecessary whitespace before a quoted newline " . $herecurr); |
5e79d96ee checkpatch: warn ... |
1706 |
} |
8905a67c6 update checkpatch... |
1707 1708 |
# check for adding lines without a newline. if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) { |
000d1cc18 checkpatch.pl: ad... |
1709 1710 1711 |
WARN("MISSING_EOF_NEWLINE", "adding a line without newline at end of file " . $herecurr); |
8905a67c6 update checkpatch... |
1712 |
} |
42e41c54d checkpatch: add s... |
1713 1714 1715 1716 1717 1718 |
# Blackfin: use hi/lo macros if ($realfile =~ m@arch/blackfin/.*\.S$@) { if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) { my $herevet = "$here " . cat_vet($line) . " "; |
000d1cc18 checkpatch.pl: ad... |
1719 1720 1721 |
ERROR("LO_MACRO", "use the LO() macro, not (... & 0xFFFF) " . $herevet); |
42e41c54d checkpatch: add s... |
1722 1723 1724 1725 1726 |
} if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) { my $herevet = "$here " . cat_vet($line) . " "; |
000d1cc18 checkpatch.pl: ad... |
1727 1728 1729 |
ERROR("HI_MACRO", "use the HI() macro, not (... >> 16) " . $herevet); |
42e41c54d checkpatch: add s... |
1730 1731 |
} } |
b9ea10d69 checkpatch: perfo... |
1732 1733 |
# check we are in a valid source file C or perl if not then ignore this hunk next if ($realfile !~ /\.(h|c|pl)$/); |
0a920b5b6 add a trivial pat... |
1734 1735 1736 |
# at the beginning of a line any tabs must come first and anything # more than 8 must use tabs. |
c2fdda0df update checkpatch... |
1737 1738 1739 1740 1741 |
if ($rawline =~ /^\+\s* \t\s*\S/ || $rawline =~ /^\+\s* \s*/) { my $herevet = "$here " . cat_vet($rawline) . " "; |
000d1cc18 checkpatch.pl: ad... |
1742 1743 1744 |
ERROR("CODE_INDENT", "code indent should use tabs where possible " . $herevet); |
d2c0a2351 checkpatch: sugge... |
1745 |
$rpt_cleaners = 1; |
0a920b5b6 add a trivial pat... |
1746 |
} |
08e443656 checkpatch.pl: wa... |
1747 1748 1749 1750 1751 |
# check for space before tabs. if ($rawline =~ /^\+/ && $rawline =~ / \t/) { my $herevet = "$here " . cat_vet($rawline) . " "; |
000d1cc18 checkpatch.pl: ad... |
1752 1753 1754 |
WARN("SPACE_BEFORE_TAB", "please, no space before tabs " . $herevet); |
08e443656 checkpatch.pl: wa... |
1755 |
} |
5f7ddae61 checkpatch: fix h... |
1756 |
# check for spaces at the beginning of a line. |
6b4c5bebc checkpatch: fix r... |
1757 1758 1759 1760 1761 |
# Exceptions: # 1) within comments # 2) indented preprocessor commands # 3) hanging labels if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/) { |
5f7ddae61 checkpatch: fix h... |
1762 1763 1764 |
my $herevet = "$here " . cat_vet($rawline) . " "; |
000d1cc18 checkpatch.pl: ad... |
1765 1766 1767 |
WARN("LEADING_SPACE", "please, no spaces at the start of a line " . $herevet); |
5f7ddae61 checkpatch: fix h... |
1768 |
} |
b9ea10d69 checkpatch: perfo... |
1769 1770 |
# check we are in a valid C source file if not then ignore this hunk next if ($realfile !~ /\.(h|c)$/); |
c2fdda0df update checkpatch... |
1771 |
# check for RCS/CVS revision markers |
cf655043d update checkpatch... |
1772 |
if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { |
000d1cc18 checkpatch.pl: ad... |
1773 1774 1775 |
WARN("CVS_KEYWORD", "CVS style keyword markers, these will _not_ be updated ". $herecurr); |
c2fdda0df update checkpatch... |
1776 |
} |
22f2a2ef9 update checkpatch... |
1777 |
|
42e41c54d checkpatch: add s... |
1778 1779 1780 1781 1782 |
# Blackfin: don't use __builtin_bfin_[cs]sync if ($line =~ /__builtin_bfin_csync/) { my $herevet = "$here " . cat_vet($line) . " "; |
000d1cc18 checkpatch.pl: ad... |
1783 1784 1785 |
ERROR("CSYNC", "use the CSYNC() macro in asm/blackfin.h " . $herevet); |
42e41c54d checkpatch: add s... |
1786 1787 1788 1789 1790 |
} if ($line =~ /__builtin_bfin_ssync/) { my $herevet = "$here " . cat_vet($line) . " "; |
000d1cc18 checkpatch.pl: ad... |
1791 1792 1793 |
ERROR("SSYNC", "use the SSYNC() macro in asm/blackfin.h " . $herevet); |
42e41c54d checkpatch: add s... |
1794 |
} |
9c0ca6f9a update checkpatch... |
1795 |
# Check for potential 'bare' types |
2b474a1a5 checkpatch: fix f... |
1796 1797 |
my ($stat, $cond, $line_nr_next, $remain_next, $off_next, $realline_next); |
9c9ba34ee update checkpatch... |
1798 |
if ($realcnt && $line =~ /.\s*\S/) { |
170d3a226 checkpatch: handl... |
1799 |
($stat, $cond, $line_nr_next, $remain_next, $off_next) = |
f5fe35dd9 checkpatch: condi... |
1800 |
ctx_statement_block($linenr, $realcnt, 0); |
171ae1a49 update checkpatch... |
1801 1802 1803 1804 1805 1806 |
$stat =~ s/ ./ /g; $cond =~ s/ ./ /g; |
2b474a1a5 checkpatch: fix f... |
1807 1808 1809 1810 1811 1812 1813 |
# Find the real next line. $realline_next = $line_nr_next; if (defined $realline_next && (!defined $lines[$realline_next - 1] || substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) { $realline_next++; } |
171ae1a49 update checkpatch... |
1814 1815 |
my $s = $stat; $s =~ s/{.*$//s; |
cf655043d update checkpatch... |
1816 |
|
c2fdda0df update checkpatch... |
1817 |
# Ignore goto labels. |
171ae1a49 update checkpatch... |
1818 |
if ($s =~ /$Ident:\*$/s) { |
c2fdda0df update checkpatch... |
1819 1820 |
# Ignore functions being called |
171ae1a49 update checkpatch... |
1821 |
} elsif ($s =~ /^.\s*$Ident\s*\(/s) { |
c2fdda0df update checkpatch... |
1822 |
|
463f28648 checkpatch: possi... |
1823 |
} elsif ($s =~ /^.\s*else\b/s) { |
c45dcabd2 update checkpatch... |
1824 |
# declarations always start with types |
d25065865 checkpatch: possi... |
1825 |
} elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) { |
c45dcabd2 update checkpatch... |
1826 1827 1828 |
my $type = $1; $type =~ s/\s+/ /g; possible($type, "A:" . $s); |
8905a67c6 update checkpatch... |
1829 |
# definitions in global scope can only start with types |
a6a840628 checkpatch: label... |
1830 |
} elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) { |
c45dcabd2 update checkpatch... |
1831 |
possible($1, "B:" . $s); |
c2fdda0df update checkpatch... |
1832 |
} |
8905a67c6 update checkpatch... |
1833 1834 |
# any (foo ... *) is a pointer cast, and foo is a type |
65863862b checkpatch: dissa... |
1835 |
while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) { |
c45dcabd2 update checkpatch... |
1836 |
possible($1, "C:" . $s); |
8905a67c6 update checkpatch... |
1837 1838 1839 1840 1841 |
} # Check for any sort of function declaration. # int foo(something bar, other baz); # void (*store_gdt)(x86_descr_ptr *); |
171ae1a49 update checkpatch... |
1842 |
if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) { |
8905a67c6 update checkpatch... |
1843 |
my ($name_len) = length($1); |
8905a67c6 update checkpatch... |
1844 |
|
cf655043d update checkpatch... |
1845 |
my $ctx = $s; |
773647a09 update checkpatch... |
1846 |
substr($ctx, 0, $name_len + 1, ''); |
8905a67c6 update checkpatch... |
1847 |
$ctx =~ s/\)[^\)]*$//; |
cf655043d update checkpatch... |
1848 |
|
8905a67c6 update checkpatch... |
1849 |
for my $arg (split(/\s*,\s*/, $ctx)) { |
c45dcabd2 update checkpatch... |
1850 |
if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) { |
8905a67c6 update checkpatch... |
1851 |
|
c45dcabd2 update checkpatch... |
1852 |
possible($1, "D:" . $s); |
8905a67c6 update checkpatch... |
1853 1854 |
} } |
9c0ca6f9a update checkpatch... |
1855 |
} |
8905a67c6 update checkpatch... |
1856 |
|
9c0ca6f9a update checkpatch... |
1857 |
} |
653d4876b update checkpatch... |
1858 1859 1860 |
# # Checks which may be anchored in the context. # |
00df344fd update checkpatch... |
1861 |
|
653d4876b update checkpatch... |
1862 1863 |
# Check for switch () and associated case and default # statements should be at the same indent. |
00df344fd update checkpatch... |
1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 |
if ($line=~/\bswitch\s*\(.*\)/) { my $err = ''; my $sep = ''; my @ctx = ctx_block_outer($linenr, $realcnt); shift(@ctx); for my $ctx (@ctx) { my ($clen, $cindent) = line_stats($ctx); if ($ctx =~ /^\+\s*(case\s+|default:)/ && $indent != $cindent) { $err .= "$sep$ctx "; $sep = ''; } else { $sep = "[...] "; } } if ($err ne '') { |
000d1cc18 checkpatch.pl: ad... |
1882 1883 1884 |
ERROR("SWITCH_CASE_INDENT_LEVEL", "switch and case should be at the same indent $hereline$err"); |
de7d4f0e1 update checkpatch... |
1885 1886 1887 1888 1889 |
} } # if/while/etc brace do not go on next line, unless defining a do while loop, # or if that brace on the next line is for something else |
c45dcabd2 update checkpatch... |
1890 |
if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) { |
773647a09 update checkpatch... |
1891 |
my $pre_ctx = "$1$2"; |
9c0ca6f9a update checkpatch... |
1892 |
my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0); |
de7d4f0e1 update checkpatch... |
1893 1894 1895 |
my $ctx_cnt = $realcnt - $#ctx - 1; my $ctx = join(" ", @ctx); |
548596d52 checkpatch: trail... |
1896 1897 |
my $ctx_ln = $linenr; my $ctx_skip = $realcnt; |
773647a09 update checkpatch... |
1898 |
|
548596d52 checkpatch: trail... |
1899 1900 1901 1902 1903 1904 |
while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt && defined $lines[$ctx_ln - 1] && $lines[$ctx_ln - 1] =~ /^-/)) { ##print "SKIP<$ctx_skip> CNT<$ctx_cnt> "; $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/); |
de7d4f0e1 update checkpatch... |
1905 |
$ctx_ln++; |
de7d4f0e1 update checkpatch... |
1906 |
} |
548596d52 checkpatch: trail... |
1907 |
|
53210168f checkpatch: tough... |
1908 1909 1910 1911 1912 1913 1914 |
#print "realcnt<$realcnt> ctx_cnt<$ctx_cnt> "; #print "pre<$pre_ctx> line<$line> ctx<$ctx> next<$lines[$ctx_ln - 1]> "; |
de7d4f0e1 update checkpatch... |
1915 |
|
773647a09 update checkpatch... |
1916 |
if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) { |
000d1cc18 checkpatch.pl: ad... |
1917 1918 1919 |
ERROR("OPEN_BRACE", "that open brace { should be on the previous line " . |
01464f30a checkpatch: state... |
1920 1921 1922 1923 |
"$here $ctx $rawlines[$ctx_ln - 1] "); |
00df344fd update checkpatch... |
1924 |
} |
773647a09 update checkpatch... |
1925 1926 1927 1928 |
if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ && $ctx =~ /\)\s*\;\s*$/ && defined $lines[$ctx_ln - 1]) { |
9c0ca6f9a update checkpatch... |
1929 1930 |
my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]); if ($nindent > $indent) { |
000d1cc18 checkpatch.pl: ad... |
1931 1932 1933 |
WARN("TRAILING_SEMICOLON", "trailing semicolon indicates no statements, indent implies otherwise " . |
01464f30a checkpatch: state... |
1934 1935 1936 1937 |
"$here $ctx $rawlines[$ctx_ln - 1] "); |
9c0ca6f9a update checkpatch... |
1938 1939 |
} } |
00df344fd update checkpatch... |
1940 |
} |
4d001e4d8 checkpatch: repor... |
1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 |
# Check relative indent for conditionals and blocks. if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { my ($s, $c) = ($stat, $cond); substr($s, 0, length($c), ''); # Make sure we remove the line prefixes as we have # none on the first line, and are going to readd them # where necessary. $s =~ s/ ./ /gs; # Find out how long the conditional actually is. |
6f779c18c checkpatch: suspe... |
1955 1956 1957 |
my @newlines = ($c =~ / /gs); my $cond_lines = 1 + $#newlines; |
4d001e4d8 checkpatch: repor... |
1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 |
# We want to check the first line inside the block # starting at the end of the conditional, so remove: # 1) any blank line termination # 2) any opening brace { on end of the line # 3) any do (...) { my $continuation = 0; my $check = 0; $s =~ s/^.*\bdo\b//; $s =~ s/^\s*{//; if ($s =~ s/^\s*\\//) { $continuation = 1; } |
9bd49efe4 checkpatch: suspe... |
1971 1972 |
if ($s =~ s/^\s*? //) { |
4d001e4d8 checkpatch: repor... |
1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 |
$check = 1; $cond_lines++; } # Also ignore a loop construct at the end of a # preprocessor statement. if (($prevline =~ /^.\s*#\s*define\s/ || $prevline =~ /\\\s*$/) && $continuation == 0) { $check = 0; } |
9bd49efe4 checkpatch: suspe... |
1983 |
my $cond_ptr = -1; |
740504c61 checkpatch: suspe... |
1984 |
$continuation = 0; |
9bd49efe4 checkpatch: suspe... |
1985 1986 |
while ($cond_ptr != $cond_lines) { $cond_ptr = $cond_lines; |
f16fa28f7 checkpatch: suspe... |
1987 1988 1989 1990 1991 |
# If we see an #else/#elif then the code # is not linear. if ($s =~ /^\s*\#\s*(?:else|elif)/) { $check = 0; } |
9bd49efe4 checkpatch: suspe... |
1992 1993 1994 1995 |
# Ignore: # 1) blank lines, they should be at 0, # 2) preprocessor lines, and # 3) labels. |
740504c61 checkpatch: suspe... |
1996 1997 1998 |
if ($continuation || $s =~ /^\s*? / || |
9bd49efe4 checkpatch: suspe... |
1999 2000 |
$s =~ /^\s*#\s*?/ || $s =~ /^\s*$Ident\s*:/) { |
740504c61 checkpatch: suspe... |
2001 2002 |
$continuation = ($s =~ /^.*?\\ /) ? 1 : 0; |
30dad6ebe checkpatch: inden... |
2003 2004 2005 2006 |
if ($s =~ s/^.*? //) { $cond_lines++; } |
9bd49efe4 checkpatch: suspe... |
2007 |
} |
4d001e4d8 checkpatch: repor... |
2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 |
} my (undef, $sindent) = line_stats("+" . $s); my $stat_real = raw_line($linenr, $cond_lines); # Check if either of these lines are modified, else # this is not this patch's fault. if (!defined($stat_real) || $stat !~ /^\+/ && $stat_real !~ /^\+/) { $check = 0; } if (defined($stat_real) && $cond_lines > 1) { $stat_real = "[...] $stat_real"; } |
9bd49efe4 checkpatch: suspe... |
2023 2024 |
#print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat> "; |
4d001e4d8 checkpatch: repor... |
2025 2026 2027 |
if ($check && (($sindent % 8) != 0 || ($sindent <= $indent && $s ne ''))) { |
000d1cc18 checkpatch.pl: ad... |
2028 2029 2030 2031 |
WARN("SUSPECT_CODE_INDENT", "suspect code indent for conditional statements ($indent, $sindent) " . $herecurr . "$stat_real "); |
4d001e4d8 checkpatch: repor... |
2032 2033 |
} } |
6c72ffaab update checkpatch... |
2034 2035 |
# Track the 'values' across context and added lines. my $opline = $line; $opline =~ s/^./ /; |
1f65f947a checkpatch: add c... |
2036 2037 2038 |
my ($curr_values, $curr_vars) = annotate_values($opline . " ", $prev_values); |
6c72ffaab update checkpatch... |
2039 |
$curr_values = $prev_values . $curr_values; |
c2fdda0df update checkpatch... |
2040 2041 |
if ($dbg_values) { my $outline = $opline; $outline =~ s/\t/ /g; |
cf655043d update checkpatch... |
2042 2043 2044 2045 |
print "$linenr > .$outline "; print "$linenr > $curr_values "; |
1f65f947a checkpatch: add c... |
2046 2047 |
print "$linenr > $curr_vars "; |
c2fdda0df update checkpatch... |
2048 |
} |
6c72ffaab update checkpatch... |
2049 |
$prev_values = substr($curr_values, -1); |
00df344fd update checkpatch... |
2050 2051 |
#ignore lines not being added if ($line=~/^[^\+]/) {next;} |
653d4876b update checkpatch... |
2052 |
# TEST: allow direct testing of the type matcher. |
7429c6903 checkpatch: impro... |
2053 2054 |
if ($dbg_type) { if ($line =~ /^.\s*$Declare\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
2055 2056 2057 |
ERROR("TEST_TYPE", "TEST: is type " . $herecurr); |
7429c6903 checkpatch: impro... |
2058 |
} elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) { |
000d1cc18 checkpatch.pl: ad... |
2059 2060 2061 |
ERROR("TEST_NOT_TYPE", "TEST: is not type ($1 is) ". $herecurr); |
7429c6903 checkpatch: impro... |
2062 |
} |
653d4876b update checkpatch... |
2063 2064 |
next; } |
a1ef277e2 checkpatch: add t... |
2065 2066 |
# TEST: allow direct testing of the attribute matcher. if ($dbg_attr) { |
9360b0e50 checkpatch: exten... |
2067 |
if ($line =~ /^.\s*$Modifier\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
2068 2069 2070 |
ERROR("TEST_ATTR", "TEST: is attr " . $herecurr); |
9360b0e50 checkpatch: exten... |
2071 |
} elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) { |
000d1cc18 checkpatch.pl: ad... |
2072 2073 2074 |
ERROR("TEST_NOT_ATTR", "TEST: is not attr ($1 is) ". $herecurr); |
a1ef277e2 checkpatch: add t... |
2075 2076 2077 |
} next; } |
653d4876b update checkpatch... |
2078 |
|
f0a594c1c update checkpatch... |
2079 |
# check for initialisation to aggregates open brace on the next line |
99423c206 checkpatch: fix _... |
2080 2081 |
if ($line =~ /^.\s*{/ && $prevline =~ /(?:^|[^=])=\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
2082 2083 2084 |
ERROR("OPEN_BRACE", "that open brace { should be on the previous line " . $hereprev); |
f0a594c1c update checkpatch... |
2085 |
} |
653d4876b update checkpatch... |
2086 2087 2088 2089 2090 |
# # Checks which are anchored on the added line. # # check for malformed paths in #include statements (uses RAW line) |
c45dcabd2 update checkpatch... |
2091 |
if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) { |
653d4876b update checkpatch... |
2092 2093 |
my $path = $1; if ($path =~ m{//}) { |
000d1cc18 checkpatch.pl: ad... |
2094 2095 2096 |
ERROR("MALFORMED_INCLUDE", "malformed #include filename " . |
de7d4f0e1 update checkpatch... |
2097 |
$herecurr); |
653d4876b update checkpatch... |
2098 |
} |
653d4876b update checkpatch... |
2099 |
} |
00df344fd update checkpatch... |
2100 |
|
0a920b5b6 add a trivial pat... |
2101 |
# no C99 // comments |
00df344fd update checkpatch... |
2102 |
if ($line =~ m{//}) { |
000d1cc18 checkpatch.pl: ad... |
2103 2104 2105 |
ERROR("C99_COMMENTS", "do not use C99 // comments " . $herecurr); |
0a920b5b6 add a trivial pat... |
2106 |
} |
00df344fd update checkpatch... |
2107 |
# Remove C99 comments. |
0a920b5b6 add a trivial pat... |
2108 |
$line =~ s@//.*@@; |
6c72ffaab update checkpatch... |
2109 |
$opline =~ s@//.*@@; |
0a920b5b6 add a trivial pat... |
2110 |
|
2b474a1a5 checkpatch: fix f... |
2111 2112 2113 2114 2115 2116 2117 2118 2119 |
# EXPORT_SYMBOL should immediately follow the thing it is exporting, consider # the whole statement. #print "APW <$lines[$realline_next - 1]> "; if (defined $realline_next && exists $lines[$realline_next - 1] && !defined $suppress_export{$realline_next} && ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ || $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { |
3cbf62df3 checkpatch: handl... |
2120 2121 2122 2123 |
# Handle definitions which produce identifiers with # a prefix: # XXX(foo); # EXPORT_SYMBOL(something_foo); |
653d4876b update checkpatch... |
2124 |
my $name = $1; |
3cbf62df3 checkpatch: handl... |
2125 2126 2127 2128 2129 2130 2131 |
if ($stat =~ /^.([A-Z_]+)\s*\(\s*($Ident)/ && $name =~ /^${Ident}_$2/) { #print "FOO C name<$name> "; $suppress_export{$realline_next} = 1; } elsif ($stat !~ /(?: |
2b474a1a5 checkpatch: fix f... |
2132 2133 |
.}\s*$| |
480120586 checkpatch: DEFIN... |
2134 2135 2136 |
^.DEFINE_$Ident\(\Q$name\E\)| ^.DECLARE_$Ident\(\Q$name\E\)| ^.LIST_HEAD\(\Q$name\E\)| |
2b474a1a5 checkpatch: fix f... |
2137 2138 |
^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(| \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\() |
480120586 checkpatch: DEFIN... |
2139 |
)/x) { |
2b474a1a5 checkpatch: fix f... |
2140 2141 2142 2143 2144 |
#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name> "; $suppress_export{$realline_next} = 2; } else { $suppress_export{$realline_next} = 1; |
0a920b5b6 add a trivial pat... |
2145 2146 |
} } |
2b474a1a5 checkpatch: fix f... |
2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 |
if (!defined $suppress_export{$linenr} && $prevline =~ /^.\s*$/ && ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ || $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { #print "FOO B <$lines[$linenr - 1]> "; $suppress_export{$linenr} = 2; } if (defined $suppress_export{$linenr} && $suppress_export{$linenr} == 2) { |
000d1cc18 checkpatch.pl: ad... |
2157 2158 2159 |
WARN("EXPORT_SYMBOL", "EXPORT_SYMBOL(foo); should immediately follow its function/variable " . $herecurr); |
2b474a1a5 checkpatch: fix f... |
2160 |
} |
0a920b5b6 add a trivial pat... |
2161 |
|
5150bda43 checkpatch: chang... |
2162 |
# check for global initialisers. |
c45dcabd2 update checkpatch... |
2163 |
if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { |
000d1cc18 checkpatch.pl: ad... |
2164 2165 2166 |
ERROR("GLOBAL_INITIALISERS", "do not initialise globals to 0 or NULL " . |
f0a594c1c update checkpatch... |
2167 2168 |
$herecurr); } |
653d4876b update checkpatch... |
2169 |
# check for static initialisers. |
2d1bafd79 checkpatch: do no... |
2170 |
if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) { |
000d1cc18 checkpatch.pl: ad... |
2171 2172 2173 |
ERROR("INITIALISED_STATIC", "do not initialise statics to 0 or NULL " . |
de7d4f0e1 update checkpatch... |
2174 |
$herecurr); |
0a920b5b6 add a trivial pat... |
2175 |
} |
cb710eca6 scripts/checkpatc... |
2176 2177 |
# check for static const char * arrays. if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) { |
000d1cc18 checkpatch.pl: ad... |
2178 2179 2180 |
WARN("STATIC_CONST_CHAR_ARRAY", "static const char * array should probably be static const char * const " . |
cb710eca6 scripts/checkpatc... |
2181 2182 2183 2184 2185 |
$herecurr); } # check for static char foo[] = "bar" declarations. if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) { |
000d1cc18 checkpatch.pl: ad... |
2186 2187 2188 |
WARN("STATIC_CONST_CHAR_ARRAY", "static char array declaration should probably be static const char " . |
cb710eca6 scripts/checkpatc... |
2189 2190 |
$herecurr); } |
93ed0e2d0 scripts/checkpatc... |
2191 2192 |
# check for declarations of struct pci_device_id if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) { |
000d1cc18 checkpatch.pl: ad... |
2193 2194 2195 |
WARN("DEFINE_PCI_DEVICE_TABLE", "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id " . $herecurr); |
93ed0e2d0 scripts/checkpatc... |
2196 |
} |
653d4876b update checkpatch... |
2197 2198 2199 |
# check for new typedefs, only function parameters and sparse annotations # make sense. if ($line =~ /\btypedef\s/ && |
8054576dc checkpatch: loose... |
2200 |
$line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && |
c45dcabd2 update checkpatch... |
2201 |
$line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && |
8ed22cad9 checkpatch: pull ... |
2202 |
$line !~ /\b$typeTypedefs\b/ && |
653d4876b update checkpatch... |
2203 |
$line !~ /\b__bitwise(?:__|)\b/) { |
000d1cc18 checkpatch.pl: ad... |
2204 2205 2206 |
WARN("NEW_TYPEDEFS", "do not add new typedefs " . $herecurr); |
0a920b5b6 add a trivial pat... |
2207 2208 2209 |
} # * goes on variable not on type |
65863862b checkpatch: dissa... |
2210 |
# (char*[ const]) |
00ef4ece0 checkpatch: corre... |
2211 |
if ($line =~ m{\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\)}) { |
65863862b checkpatch: dissa... |
2212 2213 2214 2215 2216 2217 2218 |
my ($from, $to) = ($1, $1); # Should start with a space. $to =~ s/^(\S)/ $1/; # Should not end with a space. $to =~ s/\s+$//; # '*'s should not have spaces between. |
f9a0b3d17 checkpatch: type/... |
2219 |
while ($to =~ s/\*\s+\*/\*\*/) { |
65863862b checkpatch: dissa... |
2220 |
} |
d8aaf1214 update checkpatch... |
2221 |
|
65863862b checkpatch: dissa... |
2222 2223 2224 |
#print "from<$from> to<$to> "; if ($from ne $to) { |
000d1cc18 checkpatch.pl: ad... |
2225 2226 2227 |
ERROR("POINTER_LOCATION", "\"(foo$from)\" should be \"(foo$to)\" " . $herecurr); |
65863862b checkpatch: dissa... |
2228 |
} |
00ef4ece0 checkpatch: corre... |
2229 |
} elsif ($line =~ m{\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident)}) { |
65863862b checkpatch: dissa... |
2230 2231 2232 2233 2234 2235 2236 |
my ($from, $to, $ident) = ($1, $1, $2); # Should start with a space. $to =~ s/^(\S)/ $1/; # Should not end with a space. $to =~ s/\s+$//; # '*'s should not have spaces between. |
f9a0b3d17 checkpatch: type/... |
2237 |
while ($to =~ s/\*\s+\*/\*\*/) { |
65863862b checkpatch: dissa... |
2238 2239 2240 |
} # Modifiers should have spaces. $to =~ s/(\b$Modifier$)/$1 /; |
d8aaf1214 update checkpatch... |
2241 |
|
667026e7b checkpatch: a mod... |
2242 2243 2244 |
#print "from<$from> to<$to> ident<$ident> "; if ($from ne $to && $ident !~ /^$Modifier$/) { |
000d1cc18 checkpatch.pl: ad... |
2245 2246 2247 |
ERROR("POINTER_LOCATION", "\"foo${from}bar\" should be \"foo${to}bar\" " . $herecurr); |
65863862b checkpatch: dissa... |
2248 |
} |
0a920b5b6 add a trivial pat... |
2249 2250 2251 2252 2253 2254 2255 2256 2257 |
} # # no BUG() or BUG_ON() # if ($line =~ /\b(BUG|BUG_ON)\b/) { # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON() "; # print "$herecurr"; # $clean = 0; # } |
8905a67c6 update checkpatch... |
2258 |
if ($line =~ /\bLINUX_VERSION_CODE\b/) { |
000d1cc18 checkpatch.pl: ad... |
2259 2260 2261 |
WARN("LINUX_VERSION_CODE", "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged " . $herecurr); |
8905a67c6 update checkpatch... |
2262 |
} |
17441227f checkpatch: add w... |
2263 2264 |
# check for uses of printk_ratelimit if ($line =~ /\bprintk_ratelimit\s*\(/) { |
000d1cc18 checkpatch.pl: ad... |
2265 2266 2267 |
WARN("PRINTK_RATELIMITED", "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit " . $herecurr); |
17441227f checkpatch: add w... |
2268 |
} |
00df344fd update checkpatch... |
2269 2270 2271 |
# printk should use KERN_* levels. Note that follow on printk's on the # same line do not need a level, so we use the current block context # to try and find and validate the current printk. In summary the current |
25985edce Fix common misspe... |
2272 |
# printk includes all preceding printk's which have no newline on the end. |
00df344fd update checkpatch... |
2273 |
# we assume the first bad printk is the one to report. |
f0a594c1c update checkpatch... |
2274 |
if ($line =~ /\bprintk\((?!KERN_)\s*"/) { |
00df344fd update checkpatch... |
2275 2276 2277 2278 |
my $ok = 0; for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) { #print "CHECK<$lines[$ln - 1] "; |
25985edce Fix common misspe... |
2279 |
# we have a preceding printk if it ends |
00df344fd update checkpatch... |
2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 |
# with " " ignore it, else it is to blame if ($lines[$ln - 1] =~ m{\bprintk\(}) { if ($rawlines[$ln - 1] !~ m{\ "}) { $ok = 1; } last; } } if ($ok == 0) { |
000d1cc18 checkpatch.pl: ad... |
2291 2292 2293 |
WARN("PRINTK_WITHOUT_KERN_LEVEL", "printk() should include KERN_ facility level " . $herecurr); |
00df344fd update checkpatch... |
2294 |
} |
0a920b5b6 add a trivial pat... |
2295 |
} |
653d4876b update checkpatch... |
2296 2297 |
# function brace can't be on same line, except for #defines of do while, # or if closed on same line |
c45dcabd2 update checkpatch... |
2298 2299 |
if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) { |
000d1cc18 checkpatch.pl: ad... |
2300 2301 2302 |
ERROR("OPEN_BRACE", "open brace '{' following function declarations go on the next line " . $herecurr); |
0a920b5b6 add a trivial pat... |
2303 |
} |
653d4876b update checkpatch... |
2304 |
|
8905a67c6 update checkpatch... |
2305 2306 2307 |
# open braces for enum, union and struct go on the same line. if ($line =~ /^.\s*{/ && $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
2308 2309 2310 |
ERROR("OPEN_BRACE", "open brace '{' following $1 go on the same line " . $hereprev); |
8905a67c6 update checkpatch... |
2311 |
} |
0c73b4eb7 checkpatch: simpl... |
2312 2313 |
# missing space after union, struct or enum definition if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) { |
000d1cc18 checkpatch.pl: ad... |
2314 2315 2316 |
WARN("SPACING", "missing space after $1 definition " . $herecurr); |
0c73b4eb7 checkpatch: simpl... |
2317 |
} |
8d31cfcec checkpatch: check... |
2318 2319 |
# check for spacing round square brackets; allowed: # 1. with a type on the left -- int [] a; |
fe2a7dbc8 checkpatch: squar... |
2320 2321 |
# 2. at the beginning of a line for slice initialisers -- [0...10] = 5, # 3. inside a curly brace -- = { [0...10] = 5 } |
8d31cfcec checkpatch: check... |
2322 2323 2324 |
while ($line =~ /(.*?\s)\[/g) { my ($where, $prefix) = ($-[1], $1); if ($prefix !~ /$Type\s+$/ && |
fe2a7dbc8 checkpatch: squar... |
2325 2326 |
($where != 0 || $prefix !~ /^.\s+$/) && $prefix !~ /{\s+$/) { |
000d1cc18 checkpatch.pl: ad... |
2327 2328 2329 |
ERROR("BRACKET_SPACE", "space prohibited before open square bracket '[' " . $herecurr); |
8d31cfcec checkpatch: check... |
2330 2331 |
} } |
f0a594c1c update checkpatch... |
2332 |
# check for spaces between functions and their parentheses. |
6c72ffaab update checkpatch... |
2333 |
while ($line =~ /($Ident)\s+\(/g) { |
c2fdda0df update checkpatch... |
2334 |
my $name = $1; |
773647a09 update checkpatch... |
2335 2336 |
my $ctx_before = substr($line, 0, $-[1]); my $ctx = "$ctx_before$name"; |
c2fdda0df update checkpatch... |
2337 2338 |
# Ignore those directives where spaces _are_ permitted. |
773647a09 update checkpatch... |
2339 2340 2341 2342 2343 2344 |
if ($name =~ /^(?: if|for|while|switch|return|case| volatile|__volatile__| __attribute__|format|__extension__| asm|__asm__)$/x) { |
c2fdda0df update checkpatch... |
2345 2346 2347 2348 |
# cpp #define statements have non-optional spaces, ie # if there is a space between the name and the open # parenthesis it is simply not a parameter group. |
c45dcabd2 update checkpatch... |
2349 |
} elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { |
773647a09 update checkpatch... |
2350 2351 |
# cpp #elif statement condition may start with a ( |
c45dcabd2 update checkpatch... |
2352 |
} elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) { |
c2fdda0df update checkpatch... |
2353 2354 2355 |
# If this whole things ends with a type its most # likely a typedef for a function. |
773647a09 update checkpatch... |
2356 |
} elsif ($ctx =~ /$Type$/) { |
c2fdda0df update checkpatch... |
2357 2358 |
} else { |
000d1cc18 checkpatch.pl: ad... |
2359 2360 2361 |
WARN("SPACING", "space prohibited between function name and open parenthesis '(' " . $herecurr); |
6c72ffaab update checkpatch... |
2362 |
} |
f0a594c1c update checkpatch... |
2363 |
} |
653d4876b update checkpatch... |
2364 |
# Check operator spacing. |
0a920b5b6 add a trivial pat... |
2365 |
if (!($line=~/\#\s*include/)) { |
9c0ca6f9a update checkpatch... |
2366 2367 2368 2369 |
my $ops = qr{ <<=|>>=|<=|>=|==|!=| \+=|-=|\*=|\/=|%=|\^=|\|=|&=| =>|->|<<|>>|<|>|=|!|~| |
1f65f947a checkpatch: add c... |
2370 2371 |
&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%| \?|: |
9c0ca6f9a update checkpatch... |
2372 |
}x; |
cf655043d update checkpatch... |
2373 |
my @elements = split(/($ops|;)/, $opline); |
00df344fd update checkpatch... |
2374 |
my $off = 0; |
6c72ffaab update checkpatch... |
2375 2376 |
my $blank = copy_spacing($opline); |
0a920b5b6 add a trivial pat... |
2377 |
for (my $n = 0; $n < $#elements; $n += 2) { |
4a0df2ef4 update checkpatch... |
2378 |
$off += length($elements[$n]); |
25985edce Fix common misspe... |
2379 |
# Pick up the preceding and succeeding characters. |
773647a09 update checkpatch... |
2380 2381 2382 2383 2384 2385 |
my $ca = substr($opline, 0, $off); my $cc = ''; if (length($opline) >= ($off + length($elements[$n + 1]))) { $cc = substr($opline, $off + length($elements[$n + 1])); } my $cb = "$ca$;$cc"; |
4a0df2ef4 update checkpatch... |
2386 2387 2388 |
my $a = ''; $a = 'V' if ($elements[$n] ne ''); $a = 'W' if ($elements[$n] =~ /\s$/); |
cf655043d update checkpatch... |
2389 |
$a = 'C' if ($elements[$n] =~ /$;$/); |
4a0df2ef4 update checkpatch... |
2390 2391 |
$a = 'B' if ($elements[$n] =~ /(\[|\()$/); $a = 'O' if ($elements[$n] eq ''); |
773647a09 update checkpatch... |
2392 |
$a = 'E' if ($ca =~ /^\s*$/); |
4a0df2ef4 update checkpatch... |
2393 |
|
0a920b5b6 add a trivial pat... |
2394 |
my $op = $elements[$n + 1]; |
4a0df2ef4 update checkpatch... |
2395 2396 |
my $c = ''; |
0a920b5b6 add a trivial pat... |
2397 |
if (defined $elements[$n + 2]) { |
4a0df2ef4 update checkpatch... |
2398 2399 |
$c = 'V' if ($elements[$n + 2] ne ''); $c = 'W' if ($elements[$n + 2] =~ /^\s/); |
cf655043d update checkpatch... |
2400 |
$c = 'C' if ($elements[$n + 2] =~ /^$;/); |
4a0df2ef4 update checkpatch... |
2401 2402 |
$c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/); $c = 'O' if ($elements[$n + 2] eq ''); |
8b1b33786 checkpatch: fix c... |
2403 |
$c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/); |
4a0df2ef4 update checkpatch... |
2404 2405 |
} else { $c = 'E'; |
0a920b5b6 add a trivial pat... |
2406 |
} |
4a0df2ef4 update checkpatch... |
2407 2408 2409 |
my $ctx = "${a}x${c}"; my $at = "(ctx:$ctx)"; |
6c72ffaab update checkpatch... |
2410 |
my $ptr = substr($blank, 0, $off) . "^"; |
de7d4f0e1 update checkpatch... |
2411 2412 |
my $hereptr = "$hereline$ptr "; |
0a920b5b6 add a trivial pat... |
2413 |
|
74048ed81 checkpatch: varia... |
2414 |
# Pull out the value of this operator. |
6c72ffaab update checkpatch... |
2415 |
my $op_type = substr($curr_values, $off + 1, 1); |
0a920b5b6 add a trivial pat... |
2416 |
|
1f65f947a checkpatch: add c... |
2417 2418 |
# Get the full operator variant. my $opv = $op . substr($curr_vars, $off, 1); |
13214adf7 update checkpatch... |
2419 2420 2421 |
# Ignore operators passed as parameters. if ($op_type ne 'V' && $ca =~ /\s$/ && $cc =~ /^\s*,/) { |
cf655043d update checkpatch... |
2422 2423 |
# # Ignore comments # } elsif ($op =~ /^$;+$/) { |
13214adf7 update checkpatch... |
2424 |
|
d8aaf1214 update checkpatch... |
2425 |
# ; should have either the end of line or a space or \ after it |
13214adf7 update checkpatch... |
2426 |
} elsif ($op eq ';') { |
cf655043d update checkpatch... |
2427 2428 |
if ($ctx !~ /.x[WEBC]/ && $cc !~ /^\\/ && $cc !~ /^;/) { |
000d1cc18 checkpatch.pl: ad... |
2429 2430 2431 |
ERROR("SPACING", "space required after that '$op' $at " . $hereptr); |
d8aaf1214 update checkpatch... |
2432 2433 2434 2435 |
} # // is a comment } elsif ($op eq '//') { |
0a920b5b6 add a trivial pat... |
2436 |
|
1f65f947a checkpatch: add c... |
2437 2438 2439 2440 |
# No spaces for: # -> # : when part of a bitfield } elsif ($op eq '->' || $opv eq ':B') { |
4a0df2ef4 update checkpatch... |
2441 |
if ($ctx =~ /Wx.|.xW/) { |
000d1cc18 checkpatch.pl: ad... |
2442 2443 2444 |
ERROR("SPACING", "spaces prohibited around that '$op' $at " . $hereptr); |
0a920b5b6 add a trivial pat... |
2445 2446 2447 2448 |
} # , must have a space on the right. } elsif ($op eq ',') { |
cf655043d update checkpatch... |
2449 |
if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) { |
000d1cc18 checkpatch.pl: ad... |
2450 2451 2452 |
ERROR("SPACING", "space required after that '$op' $at " . $hereptr); |
0a920b5b6 add a trivial pat... |
2453 |
} |
9c0ca6f9a update checkpatch... |
2454 |
# '*' as part of a type definition -- reported already. |
74048ed81 checkpatch: varia... |
2455 |
} elsif ($opv eq '*_') { |
9c0ca6f9a update checkpatch... |
2456 2457 2458 2459 2460 2461 2462 |
#warn "'*' is part of type "; # unary operators should have a space before and # none after. May be left adjacent to another # unary operator, or a cast } elsif ($op eq '!' || $op eq '~' || |
74048ed81 checkpatch: varia... |
2463 |
$opv eq '*U' || $opv eq '-U' || |
0d413866c checkpatch: value... |
2464 |
$opv eq '&U' || $opv eq '&&U') { |
cf655043d update checkpatch... |
2465 |
if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { |
000d1cc18 checkpatch.pl: ad... |
2466 2467 2468 |
ERROR("SPACING", "space required before that '$op' $at " . $hereptr); |
0a920b5b6 add a trivial pat... |
2469 |
} |
a3340b357 checkpatch: point... |
2470 |
if ($op eq '*' && $cc =~/\s*$Modifier\b/) { |
171ae1a49 update checkpatch... |
2471 2472 2473 |
# A unary '*' may be const } elsif ($ctx =~ /.xW/) { |
000d1cc18 checkpatch.pl: ad... |
2474 2475 2476 |
ERROR("SPACING", "space prohibited after that '$op' $at " . $hereptr); |
0a920b5b6 add a trivial pat... |
2477 2478 2479 2480 |
} # unary ++ and unary -- are allowed no space on one side. } elsif ($op eq '++' or $op eq '--') { |
773647a09 update checkpatch... |
2481 |
if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) { |
000d1cc18 checkpatch.pl: ad... |
2482 2483 2484 |
ERROR("SPACING", "space required one side of that '$op' $at " . $hereptr); |
773647a09 update checkpatch... |
2485 2486 2487 |
} if ($ctx =~ /Wx[BE]/ || ($ctx =~ /Wx./ && $cc =~ /^;/)) { |
000d1cc18 checkpatch.pl: ad... |
2488 2489 2490 |
ERROR("SPACING", "space prohibited before that '$op' $at " . $hereptr); |
0a920b5b6 add a trivial pat... |
2491 |
} |
773647a09 update checkpatch... |
2492 |
if ($ctx =~ /ExW/) { |
000d1cc18 checkpatch.pl: ad... |
2493 2494 2495 |
ERROR("SPACING", "space prohibited after that '$op' $at " . $hereptr); |
653d4876b update checkpatch... |
2496 |
} |
0a920b5b6 add a trivial pat... |
2497 |
|
773647a09 update checkpatch... |
2498 |
|
0a920b5b6 add a trivial pat... |
2499 |
# << and >> may either have or not have spaces both sides |
9c0ca6f9a update checkpatch... |
2500 2501 2502 |
} elsif ($op eq '<<' or $op eq '>>' or $op eq '&' or $op eq '^' or $op eq '|' or $op eq '+' or $op eq '-' or |
c2fdda0df update checkpatch... |
2503 2504 |
$op eq '*' or $op eq '/' or $op eq '%') |
0a920b5b6 add a trivial pat... |
2505 |
{ |
773647a09 update checkpatch... |
2506 |
if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { |
000d1cc18 checkpatch.pl: ad... |
2507 2508 2509 |
ERROR("SPACING", "need consistent spacing around '$op' $at " . |
de7d4f0e1 update checkpatch... |
2510 |
$hereptr); |
0a920b5b6 add a trivial pat... |
2511 |
} |
1f65f947a checkpatch: add c... |
2512 2513 2514 2515 |
# A colon needs no spaces before when it is # terminating a case value or a label. } elsif ($opv eq ':C' || $opv eq ':L') { if ($ctx =~ /Wx./) { |
000d1cc18 checkpatch.pl: ad... |
2516 2517 2518 |
ERROR("SPACING", "space prohibited before that '$op' $at " . $hereptr); |
1f65f947a checkpatch: add c... |
2519 |
} |
0a920b5b6 add a trivial pat... |
2520 |
# All the others need spaces both sides. |
cf655043d update checkpatch... |
2521 |
} elsif ($ctx !~ /[EWC]x[CWE]/) { |
1f65f947a checkpatch: add c... |
2522 |
my $ok = 0; |
22f2a2ef9 update checkpatch... |
2523 |
# Ignore email addresses <foo@bar> |
1f65f947a checkpatch: add c... |
2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 |
if (($op eq '<' && $cc =~ /^\S+\@\S+>/) || ($op eq '>' && $ca =~ /<\S+\@\S+$/)) { $ok = 1; } # Ignore ?: if (($opv eq ':O' && $ca =~ /\?$/) || ($op eq '?' && $cc =~ /^:/)) { $ok = 1; } if ($ok == 0) { |
000d1cc18 checkpatch.pl: ad... |
2539 2540 2541 |
ERROR("SPACING", "spaces required around that '$op' $at " . $hereptr); |
22f2a2ef9 update checkpatch... |
2542 |
} |
0a920b5b6 add a trivial pat... |
2543 |
} |
4a0df2ef4 update checkpatch... |
2544 |
$off += length($elements[$n + 1]); |
0a920b5b6 add a trivial pat... |
2545 2546 |
} } |
f0a594c1c update checkpatch... |
2547 2548 |
# check for multiple assignments if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) { |
000d1cc18 checkpatch.pl: ad... |
2549 2550 2551 |
CHK("MULTIPLE_ASSIGNMENTS", "multiple assignments should be avoided " . $herecurr); |
f0a594c1c update checkpatch... |
2552 |
} |
22f2a2ef9 update checkpatch... |
2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 |
## # check for multiple declarations, allowing for a function declaration ## # continuation. ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ && ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) { ## ## # Remove any bracketed sections to ensure we do not ## # falsly report the parameters of functions. ## my $ln = $line; ## while ($ln =~ s/\([^\(\)]*\)//g) { ## } ## if ($ln =~ /,/) { |
000d1cc18 checkpatch.pl: ad... |
2564 2565 2566 |
## WARN("MULTIPLE_DECLARATION", ## "declaring multiple variables together should be avoided " . $herecurr); |
22f2a2ef9 update checkpatch... |
2567 2568 |
## } ## } |
f0a594c1c update checkpatch... |
2569 |
|
0a920b5b6 add a trivial pat... |
2570 |
#need space before brace following if, while, etc |
22f2a2ef9 update checkpatch... |
2571 2572 |
if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) || $line =~ /do{/) { |
000d1cc18 checkpatch.pl: ad... |
2573 2574 2575 |
ERROR("SPACING", "space required before the open brace '{' " . $herecurr); |
de7d4f0e1 update checkpatch... |
2576 2577 2578 2579 2580 |
} # closing brace should have a space following it when it has anything # on the line if ($line =~ /}(?!(?:,|;|\)))\S/) { |
000d1cc18 checkpatch.pl: ad... |
2581 2582 2583 |
ERROR("SPACING", "space required after that close brace '}' " . $herecurr); |
0a920b5b6 add a trivial pat... |
2584 |
} |
22f2a2ef9 update checkpatch... |
2585 2586 |
# check spacing on square brackets if ($line =~ /\[\s/ && $line !~ /\[\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
2587 2588 2589 |
ERROR("SPACING", "space prohibited after that open square bracket '[' " . $herecurr); |
22f2a2ef9 update checkpatch... |
2590 2591 |
} if ($line =~ /\s\]/) { |
000d1cc18 checkpatch.pl: ad... |
2592 2593 2594 |
ERROR("SPACING", "space prohibited before that close square bracket ']' " . $herecurr); |
22f2a2ef9 update checkpatch... |
2595 |
} |
c45dcabd2 update checkpatch... |
2596 |
# check spacing on parentheses |
9c0ca6f9a update checkpatch... |
2597 2598 |
if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ && $line !~ /for\s*\(\s+;/) { |
000d1cc18 checkpatch.pl: ad... |
2599 2600 2601 |
ERROR("SPACING", "space prohibited after that open parenthesis '(' " . $herecurr); |
22f2a2ef9 update checkpatch... |
2602 |
} |
13214adf7 update checkpatch... |
2603 |
if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ && |
c45dcabd2 update checkpatch... |
2604 2605 |
$line !~ /for\s*\(.*;\s+\)/ && $line !~ /:\s+\)/) { |
000d1cc18 checkpatch.pl: ad... |
2606 2607 2608 |
ERROR("SPACING", "space prohibited before that close parenthesis ')' " . $herecurr); |
22f2a2ef9 update checkpatch... |
2609 |
} |
0a920b5b6 add a trivial pat... |
2610 |
#goto labels aren't indented, allow a single space however |
4a0df2ef4 update checkpatch... |
2611 |
if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and |
0a920b5b6 add a trivial pat... |
2612 |
!($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) { |
000d1cc18 checkpatch.pl: ad... |
2613 2614 2615 |
WARN("INDENTED_LABEL", "labels should not be indented " . $herecurr); |
0a920b5b6 add a trivial pat... |
2616 |
} |
c45dcabd2 update checkpatch... |
2617 2618 2619 2620 |
# Return is not a function. if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { my $spacing = $1; my $value = $2; |
86f9d059c checkpatch: allow... |
2621 |
# Flatten any parentheses |
fb2d2c1b5 checkpatch: ensur... |
2622 2623 |
$value =~ s/\(/ \(/g; $value =~ s/\)/\) /g; |
63f17f897 checkpatch: allow... |
2624 2625 2626 2627 2628 |
while ($value =~ s/\[[^\{\}]*\]/1/ || $value !~ /(?:$Ident|-?$Constant)\s* $Compare\s* (?:$Ident|-?$Constant)/x && $value =~ s/\([^\(\)]*\)/1/) { |
c45dcabd2 update checkpatch... |
2629 |
} |
fb2d2c1b5 checkpatch: ensur... |
2630 2631 2632 |
#print "value<$value> "; if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
2633 2634 2635 |
ERROR("RETURN_PARENTHESES", "return is not a function, parentheses are not required " . $herecurr); |
c45dcabd2 update checkpatch... |
2636 2637 |
} elsif ($spacing !~ /\s+/) { |
000d1cc18 checkpatch.pl: ad... |
2638 2639 2640 |
ERROR("SPACING", "space required before the open parenthesis '(' " . $herecurr); |
c45dcabd2 update checkpatch... |
2641 2642 |
} } |
53a3c4487 checkpatch: retur... |
2643 2644 2645 2646 |
# Return of what appears to be an errno should normally be -'ve if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) { my $name = $1; if ($name ne 'EOF' && $name ne 'ERROR') { |
000d1cc18 checkpatch.pl: ad... |
2647 2648 2649 |
WARN("USE_NEGATIVE_ERRNO", "return of an errno should typically be -ve (return -$1) " . $herecurr); |
53a3c4487 checkpatch: retur... |
2650 2651 |
} } |
c45dcabd2 update checkpatch... |
2652 |
|
7d2367af0 checkpatch: sugge... |
2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 |
# typecasts on min/max could be min_t/max_t if ($line =~ /^\+(?:.*?)\b(min|max)\s*\($Typecast{0,1}($LvalOrFunc)\s*,\s*$Typecast{0,1}($LvalOrFunc)\s*\)/) { if (defined $2 || defined $8) { my $call = $1; my $cast1 = deparenthesize($2); my $arg1 = $3; my $cast2 = deparenthesize($8); my $arg2 = $9; my $cast; if ($cast1 ne "" && $cast2 ne "") { $cast = "$cast1 or $cast2"; } elsif ($cast1 ne "") { $cast = $cast1; } else { $cast = $cast2; } WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2) " . $herecurr); } } |
0a920b5b6 add a trivial pat... |
2674 |
# Need a space before open parenthesis after if, while etc |
4a0df2ef4 update checkpatch... |
2675 |
if ($line=~/\b(if|while|for|switch)\(/) { |
000d1cc18 checkpatch.pl: ad... |
2676 2677 |
ERROR("SPACING", "space required before the open parenthesis '(' " . $herecurr); |
0a920b5b6 add a trivial pat... |
2678 |
} |
f5fe35dd9 checkpatch: condi... |
2679 2680 |
# Check for illegal assignment in if conditional -- and check for trailing # statements after the conditional. |
170d3a226 checkpatch: handl... |
2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 |
if ($line =~ /do\s*(?!{)/) { my ($stat_next) = ctx_statement_block($line_nr_next, $remain_next, $off_next); $stat_next =~ s/ ./ /g; ##print "stat<$stat> stat_next<$stat_next> "; if ($stat_next =~ /^\s*while\b/) { # If the statement carries leading newlines, # then count those as offsets. my ($whitespace) = ($stat_next =~ /^((?:\s* [+-])*\s*)/s); my $offset = statement_rawlines($whitespace) - 1; $suppress_whiletrailers{$line_nr_next + $offset} = 1; } } if (!defined $suppress_whiletrailers{$linenr} && $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { |
171ae1a49 update checkpatch... |
2705 |
my ($s, $c) = ($stat, $cond); |
8905a67c6 update checkpatch... |
2706 |
|
b53c8e104 checkpatch: ensur... |
2707 |
if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) { |
000d1cc18 checkpatch.pl: ad... |
2708 2709 2710 |
ERROR("ASSIGN_IN_IF", "do not use assignment in if condition " . $herecurr); |
8905a67c6 update checkpatch... |
2711 2712 2713 2714 |
} # Find out what is on the end of the line after the # conditional. |
773647a09 update checkpatch... |
2715 |
substr($s, 0, length($c), ''); |
8905a67c6 update checkpatch... |
2716 2717 |
$s =~ s/ .*//g; |
13214adf7 update checkpatch... |
2718 |
$s =~ s/$;//g; # Remove any comments |
53210168f checkpatch: tough... |
2719 2720 |
if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ && $c !~ /}\s*while\s*/) |
773647a09 update checkpatch... |
2721 |
{ |
bb44ad39c checkpatch: trail... |
2722 2723 2724 2725 |
# Find out how long the conditional actually is. my @newlines = ($c =~ / /gs); my $cond_lines = 1 + $#newlines; |
42bdf74c9 checkpatch: trivi... |
2726 |
my $stat_real = ''; |
bb44ad39c checkpatch: trail... |
2727 |
|
42bdf74c9 checkpatch: trivi... |
2728 2729 2730 |
$stat_real = raw_line($linenr, $cond_lines) . " " if ($cond_lines); |
bb44ad39c checkpatch: trail... |
2731 2732 2733 2734 |
if (defined($stat_real) && $cond_lines > 1) { $stat_real = "[...] $stat_real"; } |
000d1cc18 checkpatch.pl: ad... |
2735 2736 2737 |
ERROR("TRAILING_STATEMENTS", "trailing statements should be on next line " . $herecurr . $stat_real); |
8905a67c6 update checkpatch... |
2738 2739 |
} } |
13214adf7 update checkpatch... |
2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 |
# Check for bitwise tests written as boolean if ($line =~ / (?: (?:\[|\(|\&\&|\|\|) \s*0[xX][0-9]+\s* (?:\&\&|\|\|) | (?:\&\&|\|\|) \s*0[xX][0-9]+\s* (?:\&\&|\|\||\)|\]) )/x) { |
000d1cc18 checkpatch.pl: ad... |
2752 2753 2754 |
WARN("HEXADECIMAL_BOOLEAN_TEST", "boolean test with hexadecimal, perhaps just 1 \& or \|? " . $herecurr); |
13214adf7 update checkpatch... |
2755 |
} |
8905a67c6 update checkpatch... |
2756 |
# if and else should not have general statements after it |
13214adf7 update checkpatch... |
2757 2758 2759 2760 |
if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) { my $s = $1; $s =~ s/$;//g; # Remove any comments if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) { |
000d1cc18 checkpatch.pl: ad... |
2761 2762 2763 |
ERROR("TRAILING_STATEMENTS", "trailing statements should be on next line " . $herecurr); |
13214adf7 update checkpatch... |
2764 |
} |
0a920b5b6 add a trivial pat... |
2765 |
} |
396677823 checkpatch: if sh... |
2766 2767 |
# if should not continue a brace if ($line =~ /}\s*if\b/) { |
000d1cc18 checkpatch.pl: ad... |
2768 2769 2770 |
ERROR("TRAILING_STATEMENTS", "trailing statements should be on next line " . |
396677823 checkpatch: if sh... |
2771 2772 |
$herecurr); } |
a1080bf80 checkpatch: case/... |
2773 2774 2775 |
# case and default should not have general statements after them if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && $line !~ /\G(?: |
3fef12d6c checkpatch: allow... |
2776 |
(?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| |
a1080bf80 checkpatch: case/... |
2777 2778 2779 |
\s*return\s+ )/xg) { |
000d1cc18 checkpatch.pl: ad... |
2780 2781 2782 |
ERROR("TRAILING_STATEMENTS", "trailing statements should be on next line " . $herecurr); |
a1080bf80 checkpatch: case/... |
2783 |
} |
0a920b5b6 add a trivial pat... |
2784 2785 2786 2787 2788 |
# Check for }<nl>else {, these must be at the same # indent level to be relevant to each other. if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and $previndent == $indent) { |
000d1cc18 checkpatch.pl: ad... |
2789 2790 2791 |
ERROR("ELSE_AFTER_BRACE", "else should follow close brace '}' " . $hereprev); |
0a920b5b6 add a trivial pat... |
2792 |
} |
c2fdda0df update checkpatch... |
2793 2794 2795 2796 2797 2798 |
if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and $previndent == $indent) { my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0); # Find out what is on the end of the line after the # conditional. |
773647a09 update checkpatch... |
2799 |
substr($s, 0, length($c), ''); |
c2fdda0df update checkpatch... |
2800 2801 2802 2803 |
$s =~ s/ .*//g; if ($s =~ /^\s*;/) { |
000d1cc18 checkpatch.pl: ad... |
2804 2805 2806 |
ERROR("WHILE_AFTER_BRACE", "while should follow close brace '}' " . $hereprev); |
c2fdda0df update checkpatch... |
2807 2808 |
} } |
0a920b5b6 add a trivial pat... |
2809 2810 2811 2812 2813 2814 2815 2816 2817 |
#studly caps, commented out until figure out how to distinguish between use of existing and adding new # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { # print "No studly caps, use _ "; # print "$herecurr"; # $clean = 0; # } #no spaces allowed after \ in define |
c45dcabd2 update checkpatch... |
2818 |
if ($line=~/\#\s*define.*\\\s$/) { |
000d1cc18 checkpatch.pl: ad... |
2819 2820 2821 |
WARN("WHITESPACE_AFTER_LINE_CONTINUATION", "Whitepspace after \\ makes next lines useless " . $herecurr); |
0a920b5b6 add a trivial pat... |
2822 |
} |
653d4876b update checkpatch... |
2823 |
#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line) |
c45dcabd2 update checkpatch... |
2824 |
if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) { |
e09dec483 checkpatch: reduc... |
2825 2826 2827 2828 |
my $file = "$1.h"; my $checkfile = "include/linux/$file"; if (-f "$root/$checkfile" && $realfile ne $checkfile && |
7840a94cd checkpatch: refac... |
2829 |
$1 !~ /$allowed_asm_includes/) |
c45dcabd2 update checkpatch... |
2830 |
{ |
e09dec483 checkpatch: reduc... |
2831 |
if ($realfile =~ m{^arch/}) { |
000d1cc18 checkpatch.pl: ad... |
2832 2833 2834 |
CHK("ARCH_INCLUDE_LINUX", "Consider using #include <linux/$file> instead of <asm/$file> " . $herecurr); |
e09dec483 checkpatch: reduc... |
2835 |
} else { |
000d1cc18 checkpatch.pl: ad... |
2836 2837 2838 |
WARN("INCLUDE_LINUX", "Use #include <linux/$file> instead of <asm/$file> " . $herecurr); |
e09dec483 checkpatch: reduc... |
2839 |
} |
0a920b5b6 add a trivial pat... |
2840 2841 |
} } |
653d4876b update checkpatch... |
2842 2843 |
# multi-statement macros should be enclosed in a do while loop, grab the # first statement and ensure its the whole macro if its not enclosed |
cf655043d update checkpatch... |
2844 |
# in a known good container |
b8f96a31f checkpatch: macro... |
2845 2846 |
if ($realfile !~ m@/vmlinux.lds.h$@ && $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) { |
d8aaf1214 update checkpatch... |
2847 2848 |
my $ln = $linenr; my $cnt = $realcnt; |
c45dcabd2 update checkpatch... |
2849 2850 |
my ($off, $dstat, $dcond, $rest); my $ctx = ''; |
653d4876b update checkpatch... |
2851 |
|
c45dcabd2 update checkpatch... |
2852 2853 2854 2855 2856 2857 2858 2859 2860 |
my $args = defined($1); # Find the end of the macro and limit our statement # search to that. while ($cnt > 0 && defined $lines[$ln - 1] && $lines[$ln - 1] =~ /^(?:-|..*\\$)/) { $ctx .= $rawlines[$ln - 1] . " "; |
a3bb97a7a checkpatch: macro... |
2861 |
$cnt-- if ($lines[$ln - 1] !~ /^-/); |
c45dcabd2 update checkpatch... |
2862 |
$ln++; |
c45dcabd2 update checkpatch... |
2863 2864 2865 2866 2867 2868 2869 |
} $ctx .= $rawlines[$ln - 1]; ($dstat, $dcond, $ln, $cnt, $off) = ctx_statement_block($linenr, $ln - $linenr + 1, 0); #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off> "; |
a3bb97a7a checkpatch: macro... |
2870 2871 |
#print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . " "; |
c45dcabd2 update checkpatch... |
2872 2873 2874 2875 |
# Extract the remainder of the define (if any) and # rip off surrounding spaces, and trailing \'s. $rest = ''; |
636d140a8 checkpatch: compl... |
2876 2877 2878 |
while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) { #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest> "; |
a3bb97a7a checkpatch: macro... |
2879 2880 2881 2882 2883 |
if ($off != 0 || $lines[$ln - 1] !~ /^-/) { $rest .= substr($lines[$ln - 1], $off) . " "; $cnt--; } |
c45dcabd2 update checkpatch... |
2884 |
$ln++; |
c45dcabd2 update checkpatch... |
2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 |
$off = 0; } $rest =~ s/\\ .//g; $rest =~ s/^\s*//s; $rest =~ s/\s*$//s; # Clean up the original statement. if ($args) { substr($dstat, 0, length($dcond), ''); } else { $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//; |
d8aaf1214 update checkpatch... |
2897 |
} |
292f1a9b3 checkpatch: compl... |
2898 |
$dstat =~ s/$;//g; |
c45dcabd2 update checkpatch... |
2899 2900 2901 2902 |
$dstat =~ s/\\ .//g; $dstat =~ s/^\s*//s; $dstat =~ s/\s*$//s; |
de7d4f0e1 update checkpatch... |
2903 |
|
c45dcabd2 update checkpatch... |
2904 |
# Flatten any parentheses and braces |
bf30d6ede checkpatch: compl... |
2905 2906 2907 2908 |
while ($dstat =~ s/\([^\(\)]*\)/1/ || $dstat =~ s/\{[^\{\}]*\}/1/ || $dstat =~ s/\[[^\{\}]*\]/1/) { |
de7d4f0e1 update checkpatch... |
2909 |
} |
d8aaf1214 update checkpatch... |
2910 |
|
c45dcabd2 update checkpatch... |
2911 2912 2913 2914 2915 2916 |
my $exceptions = qr{ $Declare| module_param_named| MODULE_PARAM_DESC| DECLARE_PER_CPU| DEFINE_PER_CPU| |
383099fd6 checkpatch: struc... |
2917 |
__typeof__\(| |
22fd2d3e4 checkpatch.pl: ad... |
2918 2919 |
union| struct| |
ea71a0a01 checkpatch: forma... |
2920 2921 |
\.$Ident\s*=\s*| ^\"|\"$ |
c45dcabd2 update checkpatch... |
2922 |
}x; |
5eaa20b98 checkpatch: clean... |
2923 2924 2925 |
#print "REST<$rest> dstat<$dstat> ctx<$ctx> "; if ($rest ne '' && $rest ne ',') { |
c45dcabd2 update checkpatch... |
2926 2927 2928 |
if ($rest !~ /while\s*\(/ && $dstat !~ /$exceptions/) { |
000d1cc18 checkpatch.pl: ad... |
2929 2930 2931 2932 2933 |
ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE", "Macros with multiple statements should be enclosed in a do - while loop " . "$here $ctx "); |
c45dcabd2 update checkpatch... |
2934 2935 2936 2937 2938 2939 |
} } elsif ($ctx !~ /;/) { if ($dstat ne '' && $dstat !~ /^(?:$Ident|-?$Constant)$/ && $dstat !~ /$exceptions/ && |
b132e5d58 checkpatch: macro... |
2940 |
$dstat !~ /^\.$Ident\s*=/ && |
c45dcabd2 update checkpatch... |
2941 2942 |
$dstat =~ /$Operators/) { |
000d1cc18 checkpatch.pl: ad... |
2943 2944 2945 2946 2947 |
ERROR("COMPLEX_MACRO", "Macros with complex values should be enclosed in parenthesis " . "$here $ctx "); |
d8aaf1214 update checkpatch... |
2948 |
} |
653d4876b update checkpatch... |
2949 |
} |
0a920b5b6 add a trivial pat... |
2950 |
} |
080ba9296 checkpatch: try t... |
2951 2952 2953 2954 2955 2956 |
# make sure symbols are always wrapped with VMLINUX_SYMBOL() ... # all assignments may have only one of the following with an assignment: # . # ALIGN(...) # VMLINUX_SYMBOL(...) if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) { |
000d1cc18 checkpatch.pl: ad... |
2957 2958 2959 |
WARN("MISSING_VMLINUX_SYMBOL", "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols " . $herecurr); |
080ba9296 checkpatch: try t... |
2960 |
} |
f0a594c1c update checkpatch... |
2961 |
# check for redundant bracing round if etc |
13214adf7 update checkpatch... |
2962 2963 |
if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) { my ($level, $endln, @chunks) = |
cf655043d update checkpatch... |
2964 |
ctx_statement_full($linenr, $realcnt, 1); |
13214adf7 update checkpatch... |
2965 2966 |
#print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level> "; |
cf655043d update checkpatch... |
2967 2968 2969 |
#print "APW: <<$chunks[1][0]>><<$chunks[1][1]>> "; if ($#chunks > 0 && $level == 0) { |
13214adf7 update checkpatch... |
2970 2971 |
my $allowed = 0; my $seen = 0; |
773647a09 update checkpatch... |
2972 2973 |
my $herectx = $here . " "; |
cf655043d update checkpatch... |
2974 |
my $ln = $linenr - 1; |
13214adf7 update checkpatch... |
2975 2976 |
for my $chunk (@chunks) { my ($cond, $block) = @{$chunk}; |
773647a09 update checkpatch... |
2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 |
# If the condition carries leading newlines, then count those as offsets. my ($whitespace) = ($cond =~ /^((?:\s* [+-])*\s*)/s); my $offset = statement_rawlines($whitespace) - 1; #print "COND<$cond> whitespace<$whitespace> offset<$offset> "; # We have looked at and allowed this specific line. $suppress_ifbraces{$ln + $offset} = 1; $herectx .= "$rawlines[$ln + $offset] [...] "; |
cf655043d update checkpatch... |
2991 |
$ln += statement_rawlines($block) - 1; |
773647a09 update checkpatch... |
2992 |
substr($block, 0, length($cond), ''); |
13214adf7 update checkpatch... |
2993 2994 |
$seen++ if ($block =~ /^\s*{/); |
cf655043d update checkpatch... |
2995 2996 2997 2998 2999 |
#print "cond<$cond> block<$block> allowed<$allowed> "; if (statement_lines($cond) > 1) { #print "APW: ALLOWED: cond<$cond> "; |
13214adf7 update checkpatch... |
3000 3001 3002 |
$allowed = 1; } if ($block =~/\b(?:if|for|while)\b/) { |
cf655043d update checkpatch... |
3003 3004 |
#print "APW: ALLOWED: block<$block> "; |
13214adf7 update checkpatch... |
3005 3006 |
$allowed = 1; } |
cf655043d update checkpatch... |
3007 3008 3009 |
if (statement_block_size($block) > 1) { #print "APW: ALLOWED: lines block<$block> "; |
13214adf7 update checkpatch... |
3010 3011 3012 3013 |
$allowed = 1; } } if ($seen && !$allowed) { |
000d1cc18 checkpatch.pl: ad... |
3014 3015 3016 |
WARN("BRACES", "braces {} are not necessary for any arm of this statement " . $herectx); |
13214adf7 update checkpatch... |
3017 3018 3019 |
} } } |
773647a09 update checkpatch... |
3020 |
if (!defined $suppress_ifbraces{$linenr - 1} && |
13214adf7 update checkpatch... |
3021 |
$line =~ /\b(if|while|for|else)\b/) { |
cf655043d update checkpatch... |
3022 3023 3024 3025 3026 3027 3028 3029 |
my $allowed = 0; # Check the pre-context. if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { #print "APW: ALLOWED: pre<$1> "; $allowed = 1; } |
773647a09 update checkpatch... |
3030 3031 3032 |
my ($level, $endln, @chunks) = ctx_statement_full($linenr, $realcnt, $-[0]); |
cf655043d update checkpatch... |
3033 3034 |
# Check the condition. my ($cond, $block) = @{$chunks[0]}; |
773647a09 update checkpatch... |
3035 3036 |
#print "CHECKING<$linenr> cond<$cond> block<$block> "; |
cf655043d update checkpatch... |
3037 |
if (defined $cond) { |
773647a09 update checkpatch... |
3038 |
substr($block, 0, length($cond), ''); |
cf655043d update checkpatch... |
3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 |
} if (statement_lines($cond) > 1) { #print "APW: ALLOWED: cond<$cond> "; $allowed = 1; } if ($block =~/\b(?:if|for|while)\b/) { #print "APW: ALLOWED: block<$block> "; $allowed = 1; } if (statement_block_size($block) > 1) { #print "APW: ALLOWED: lines block<$block> "; $allowed = 1; } # Check the post-context. if (defined $chunks[1]) { my ($cond, $block) = @{$chunks[1]}; if (defined $cond) { |
773647a09 update checkpatch... |
3059 |
substr($block, 0, length($cond), ''); |
cf655043d update checkpatch... |
3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 |
} if ($block =~ /^\s*\{/) { #print "APW: ALLOWED: chunk-1 block<$block> "; $allowed = 1; } } if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) { my $herectx = $here . " ";; |
f055663c5 checkpatch: repor... |
3070 |
my $cnt = statement_rawlines($block); |
cf655043d update checkpatch... |
3071 |
|
f055663c5 checkpatch: repor... |
3072 3073 3074 |
for (my $n = 0; $n < $cnt; $n++) { $herectx .= raw_line($linenr, $n) . " ";; |
f0a594c1c update checkpatch... |
3075 |
} |
cf655043d update checkpatch... |
3076 |
|
000d1cc18 checkpatch.pl: ad... |
3077 3078 3079 |
WARN("BRACES", "braces {} are not necessary for single statement blocks " . $herectx); |
f0a594c1c update checkpatch... |
3080 3081 |
} } |
653d4876b update checkpatch... |
3082 |
# don't include deprecated include files (uses RAW line) |
4a0df2ef4 update checkpatch... |
3083 |
for my $inc (@dep_includes) { |
c45dcabd2 update checkpatch... |
3084 |
if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) { |
000d1cc18 checkpatch.pl: ad... |
3085 3086 3087 |
ERROR("DEPRECATED_INCLUDE", "Don't use <$inc>: see Documentation/feature-removal-schedule.txt " . $herecurr); |
0a920b5b6 add a trivial pat... |
3088 3089 |
} } |
4a0df2ef4 update checkpatch... |
3090 3091 |
# don't use deprecated functions for my $func (@dep_functions) { |
00df344fd update checkpatch... |
3092 |
if ($line =~ /\b$func\b/) { |
000d1cc18 checkpatch.pl: ad... |
3093 3094 3095 |
ERROR("DEPRECATED_FUNCTION", "Don't use $func(): see Documentation/feature-removal-schedule.txt " . $herecurr); |
4a0df2ef4 update checkpatch... |
3096 3097 3098 3099 |
} } # no volatiles please |
6c72ffaab update checkpatch... |
3100 3101 |
my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { |
000d1cc18 checkpatch.pl: ad... |
3102 3103 3104 |
WARN("VOLATILE", "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt " . $herecurr); |
4a0df2ef4 update checkpatch... |
3105 |
} |
00df344fd update checkpatch... |
3106 |
# warn about #if 0 |
c45dcabd2 update checkpatch... |
3107 |
if ($line =~ /^.\s*\#\s*if\s+0\b/) { |
000d1cc18 checkpatch.pl: ad... |
3108 3109 3110 |
CHK("REDUNDANT_CODE", "if this code is redundant consider removing it " . |
de7d4f0e1 update checkpatch... |
3111 |
$herecurr); |
4a0df2ef4 update checkpatch... |
3112 |
} |
f0a594c1c update checkpatch... |
3113 3114 3115 3116 |
# check for needless kfree() checks if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { my $expr = $1; if ($line =~ /\bkfree\(\Q$expr\E\);/) { |
000d1cc18 checkpatch.pl: ad... |
3117 3118 3119 |
WARN("NEEDLESS_KFREE", "kfree(NULL) is safe this check is probably not required " . $hereprev); |
f0a594c1c update checkpatch... |
3120 3121 |
} } |
4c432a8f0 checkpatch: usb_f... |
3122 3123 3124 3125 |
# check for needless usb_free_urb() checks if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { my $expr = $1; if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { |
000d1cc18 checkpatch.pl: ad... |
3126 3127 3128 |
WARN("NEEDLESS_USB_FREE_URB", "usb_free_urb(NULL) is safe this check is probably not required " . $hereprev); |
4c432a8f0 checkpatch: usb_f... |
3129 3130 |
} } |
f0a594c1c update checkpatch... |
3131 |
|
1a15a2508 checkpatch: prefe... |
3132 3133 3134 3135 |
# prefer usleep_range over udelay if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) { # ignore udelay's < 10, however if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) { |
000d1cc18 checkpatch.pl: ad... |
3136 3137 3138 |
CHK("USLEEP_RANGE", "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt " . $line); |
1a15a2508 checkpatch: prefe... |
3139 3140 |
} } |
09ef87255 checkpatch: warn ... |
3141 3142 3143 |
# warn about unexpectedly long msleep's if ($line =~ /\bmsleep\s*\((\d+)\);/) { if ($1 < 20) { |
000d1cc18 checkpatch.pl: ad... |
3144 3145 3146 |
WARN("MSLEEP", "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt " . $line); |
09ef87255 checkpatch: warn ... |
3147 3148 |
} } |
00df344fd update checkpatch... |
3149 |
# warn about #ifdefs in C files |
c45dcabd2 update checkpatch... |
3150 |
# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { |
00df344fd update checkpatch... |
3151 3152 3153 3154 3155 |
# print "#ifdef in C files should be avoided "; # print "$herecurr"; # $clean = 0; # } |
22f2a2ef9 update checkpatch... |
3156 |
# warn about spacing in #ifdefs |
c45dcabd2 update checkpatch... |
3157 |
if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) { |
000d1cc18 checkpatch.pl: ad... |
3158 3159 3160 |
ERROR("SPACING", "exactly one space required after that #$1 " . $herecurr); |
22f2a2ef9 update checkpatch... |
3161 |
} |
4a0df2ef4 update checkpatch... |
3162 |
# check for spinlock_t definitions without a comment. |
171ae1a49 update checkpatch... |
3163 3164 |
if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ || $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) { |
4a0df2ef4 update checkpatch... |
3165 3166 |
my $which = $1; if (!ctx_has_comment($first_line, $linenr)) { |
000d1cc18 checkpatch.pl: ad... |
3167 3168 3169 |
CHK("UNCOMMENTED_DEFINITION", "$1 definition without comment " . $herecurr); |
4a0df2ef4 update checkpatch... |
3170 3171 3172 3173 3174 |
} } # check for memory barriers without a comment. if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { if (!ctx_has_comment($first_line, $linenr)) { |
000d1cc18 checkpatch.pl: ad... |
3175 3176 3177 |
CHK("MEMORY_BARRIER", "memory barrier without comment " . $herecurr); |
4a0df2ef4 update checkpatch... |
3178 3179 3180 |
} } # check of hardware specific defines |
c45dcabd2 update checkpatch... |
3181 |
if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) { |
000d1cc18 checkpatch.pl: ad... |
3182 3183 3184 |
CHK("ARCH_DEFINES", "architecture specific defines should be avoided " . $herecurr); |
0a920b5b6 add a trivial pat... |
3185 |
} |
653d4876b update checkpatch... |
3186 |
|
d4977c78e checkpatch: warn ... |
3187 3188 |
# Check that the storage class is at the beginning of a declaration if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) { |
000d1cc18 checkpatch.pl: ad... |
3189 3190 3191 |
WARN("STORAGE_CLASS", "storage class should be at the beginning of the declaration " . $herecurr) |
d4977c78e checkpatch: warn ... |
3192 |
} |
de7d4f0e1 update checkpatch... |
3193 3194 |
# check the location of the inline attribute, that it is between # storage class and type. |
9c0ca6f9a update checkpatch... |
3195 3196 |
if ($line =~ /\b$Type\s+$Inline\b/ || $line =~ /\b$Inline\s+$Storage\b/) { |
000d1cc18 checkpatch.pl: ad... |
3197 3198 3199 |
ERROR("INLINE_LOCATION", "inline keyword should sit between storage class and type " . $herecurr); |
de7d4f0e1 update checkpatch... |
3200 |
} |
8905a67c6 update checkpatch... |
3201 3202 |
# Check for __inline__ and __inline, prefer inline if ($line =~ /\b(__inline__|__inline)\b/) { |
000d1cc18 checkpatch.pl: ad... |
3203 3204 3205 |
WARN("INLINE", "plain inline is preferred over $1 " . $herecurr); |
8905a67c6 update checkpatch... |
3206 |
} |
3d130fd03 checkpatch.pl: ad... |
3207 3208 |
# Check for __attribute__ packed, prefer __packed if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) { |
000d1cc18 checkpatch.pl: ad... |
3209 3210 3211 |
WARN("PREFER_PACKED", "__packed is preferred over __attribute__((packed)) " . $herecurr); |
3d130fd03 checkpatch.pl: ad... |
3212 |
} |
39b7e2878 checkpatch: add a... |
3213 3214 |
# Check for __attribute__ aligned, prefer __aligned if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) { |
000d1cc18 checkpatch.pl: ad... |
3215 3216 3217 |
WARN("PREFER_ALIGNED", "__aligned(size) is preferred over __attribute__((aligned(size))) " . $herecurr); |
39b7e2878 checkpatch: add a... |
3218 |
} |
8f53a9b80 scripts/checkpatc... |
3219 3220 |
# check for sizeof(&) if ($line =~ /\bsizeof\s*\(\s*\&/) { |
000d1cc18 checkpatch.pl: ad... |
3221 3222 3223 |
WARN("SIZEOF_ADDRESS", "sizeof(& should be avoided " . $herecurr); |
8f53a9b80 scripts/checkpatc... |
3224 |
} |
428e2fdc4 checkpatch: add c... |
3225 3226 |
# check for line continuations in quoted strings with odd counts of " if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) { |
000d1cc18 checkpatch.pl: ad... |
3227 3228 3229 |
WARN("LINE_CONTINUATIONS", "Avoid line continuations in quoted strings " . $herecurr); |
428e2fdc4 checkpatch: add c... |
3230 |
} |
de7d4f0e1 update checkpatch... |
3231 |
# check for new externs in .c files. |
171ae1a49 update checkpatch... |
3232 |
if ($realfile =~ /\.c$/ && defined $stat && |
c45dcabd2 update checkpatch... |
3233 |
$stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |
171ae1a49 update checkpatch... |
3234 |
{ |
c45dcabd2 update checkpatch... |
3235 3236 |
my $function_name = $1; my $paren_space = $2; |
171ae1a49 update checkpatch... |
3237 3238 3239 3240 3241 |
my $s = $stat; if (defined $cond) { substr($s, 0, length($cond), ''); } |
c45dcabd2 update checkpatch... |
3242 3243 3244 |
if ($s =~ /^\s*;/ && $function_name ne 'uninitialized_var') { |
000d1cc18 checkpatch.pl: ad... |
3245 3246 3247 |
WARN("AVOID_EXTERNS", "externs should be avoided in .c files " . $herecurr); |
171ae1a49 update checkpatch... |
3248 3249 3250 3251 |
} if ($paren_space =~ / /) { |
000d1cc18 checkpatch.pl: ad... |
3252 3253 3254 |
WARN("FUNCTION_ARGUMENTS", "arguments for function declarations should follow identifier " . $herecurr); |
171ae1a49 update checkpatch... |
3255 |
} |
9c9ba34ee update checkpatch... |
3256 3257 3258 3259 |
} elsif ($realfile =~ /\.c$/ && defined $stat && $stat =~ /^.\s*extern\s+/) { |
000d1cc18 checkpatch.pl: ad... |
3260 3261 3262 |
WARN("AVOID_EXTERNS", "externs should be avoided in .c files " . $herecurr); |
de7d4f0e1 update checkpatch... |
3263 3264 3265 3266 3267 3268 3269 |
} # checks for new __setup's if ($rawline =~ /\b__setup\("([^"]*)"/) { my $name = $1; if (!grep(/$name/, @setup_docs)) { |
000d1cc18 checkpatch.pl: ad... |
3270 3271 3272 |
CHK("UNDOCUMENTED_SETUP", "__setup appears un-documented -- check Documentation/kernel-parameters.txt " . $herecurr); |
de7d4f0e1 update checkpatch... |
3273 |
} |
653d4876b update checkpatch... |
3274 |
} |
9c0ca6f9a update checkpatch... |
3275 3276 |
# check for pointless casting of kmalloc return |
caf2a54f1 scripts/checkpatc... |
3277 |
if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) { |
000d1cc18 checkpatch.pl: ad... |
3278 3279 3280 |
WARN("UNNECESSARY_CASTS", "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html " . $herecurr); |
9c0ca6f9a update checkpatch... |
3281 |
} |
13214adf7 update checkpatch... |
3282 |
|
caf2a54f1 scripts/checkpatc... |
3283 3284 |
# check for multiple semicolons if ($line =~ /;\s*;\s*$/) { |
000d1cc18 checkpatch.pl: ad... |
3285 3286 3287 |
WARN("ONE_SEMICOLON", "Statements terminations use 1 semicolon " . $herecurr); |
caf2a54f1 scripts/checkpatc... |
3288 |
} |
13214adf7 update checkpatch... |
3289 3290 |
# check for gcc specific __FUNCTION__ if ($line =~ /__FUNCTION__/) { |
000d1cc18 checkpatch.pl: ad... |
3291 3292 3293 |
WARN("USE_FUNC", "__func__ should be used instead of gcc specific __FUNCTION__ " . $herecurr); |
13214adf7 update checkpatch... |
3294 |
} |
773647a09 update checkpatch... |
3295 |
|
4882720b2 semaphore: Remove... |
3296 3297 |
# check for semaphores initialized locked if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) { |
000d1cc18 checkpatch.pl: ad... |
3298 3299 3300 |
WARN("CONSIDER_COMPLETION", "consider using a completion " . $herecurr); |
1704f47b5 lockdep: Add nova... |
3301 |
|
773647a09 update checkpatch... |
3302 |
} |
33ee3b2e2 kstrto*: converti... |
3303 |
# recommend kstrto* over simple_strto* |
773647a09 update checkpatch... |
3304 |
if ($line =~ /\bsimple_(strto.*?)\s*\(/) { |
000d1cc18 checkpatch.pl: ad... |
3305 3306 3307 |
WARN("CONSIDER_KSTRTO", "consider using kstrto* in preference to simple_$1 " . $herecurr); |
773647a09 update checkpatch... |
3308 |
} |
f3db6639f checkpatch: add a... |
3309 3310 |
# check for __initcall(), use device_initcall() explicitly please if ($line =~ /^.\s*__initcall\s*\(/) { |
000d1cc18 checkpatch.pl: ad... |
3311 3312 3313 |
WARN("USE_DEVICE_INITCALL", "please use device_initcall() instead of __initcall() " . $herecurr); |
f3db6639f checkpatch: add a... |
3314 |
} |
79404849e checkpatch.pl: ex... |
3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 |
# check for various ops structs, ensure they are const. my $struct_ops = qr{acpi_dock_ops| address_space_operations| backlight_ops| block_device_operations| dentry_operations| dev_pm_ops| dma_map_ops| extent_io_ops| file_lock_operations| file_operations| hv_ops| ide_dma_ops| intel_dvo_dev_ops| item_operations| iwl_ops| kgdb_arch| kgdb_io| kset_uevent_ops| lock_manager_operations| microcode_ops| mtrr_ops| neigh_ops| nlmsvc_binding| pci_raw_ops| pipe_buf_operations| platform_hibernation_ops| platform_suspend_ops| proto_ops| rpc_pipe_ops| seq_operations| snd_ac97_build_ops| soc_pcmcia_socket_ops| stacktrace_ops| sysfs_ops| tty_operations| usb_mon_operations| wd_ops}x; |
6903ffb22 checkpatch: struc... |
3353 |
if ($line !~ /\bconst\b/ && |
79404849e checkpatch.pl: ex... |
3354 |
$line =~ /\bstruct\s+($struct_ops)\b/) { |
000d1cc18 checkpatch.pl: ad... |
3355 3356 3357 |
WARN("CONST_STRUCT", "struct $1 should normally be const " . |
6903ffb22 checkpatch: struc... |
3358 |
$herecurr); |
2b6db5cb6 checkpatch: struc... |
3359 |
} |
773647a09 update checkpatch... |
3360 3361 3362 3363 |
# use of NR_CPUS is usually wrong # ignore definitions of NR_CPUS and usage to define arrays as likely right if ($line =~ /\bNR_CPUS\b/ && |
c45dcabd2 update checkpatch... |
3364 3365 |
$line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ && $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ && |
171ae1a49 update checkpatch... |
3366 3367 3368 |
$line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ && $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ && $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/) |
773647a09 update checkpatch... |
3369 |
{ |
000d1cc18 checkpatch.pl: ad... |
3370 3371 3372 |
WARN("NR_CPUS", "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc " . $herecurr); |
773647a09 update checkpatch... |
3373 |
} |
9c9ba34ee update checkpatch... |
3374 3375 3376 3377 3378 |
# check for %L{u,d,i} in strings my $string; while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) { $string = substr($rawline, $-[1], $+[1] - $-[1]); |
2a1bc5d5c checkpatch: %Lx t... |
3379 |
$string =~ s/%%/__/g; |
9c9ba34ee update checkpatch... |
3380 |
if ($string =~ /(?<!%)%L[udi]/) { |
000d1cc18 checkpatch.pl: ad... |
3381 3382 3383 |
WARN("PRINTF_L", "\%Ld/%Lu are not-standard C, use %lld/%llu " . $herecurr); |
9c9ba34ee update checkpatch... |
3384 3385 3386 |
last; } } |
691d77b6b checkpatch: add c... |
3387 3388 3389 3390 |
# whine mightly about in_atomic if ($line =~ /\bin_atomic\s*\(/) { if ($realfile =~ m@^drivers/@) { |
000d1cc18 checkpatch.pl: ad... |
3391 3392 3393 |
ERROR("IN_ATOMIC", "do not use in_atomic in drivers " . $herecurr); |
f4a877367 checkpatch: make ... |
3394 |
} elsif ($realfile !~ m@^kernel/@) { |
000d1cc18 checkpatch.pl: ad... |
3395 3396 3397 |
WARN("IN_ATOMIC", "use of in_atomic() is incorrect outside core kernel code " . $herecurr); |
691d77b6b checkpatch: add c... |
3398 3399 |
} } |
1704f47b5 lockdep: Add nova... |
3400 3401 3402 3403 3404 3405 3406 |
# check for lockdep_set_novalidate_class if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ || $line =~ /__lockdep_no_validate__\s*\)/ ) { if ($realfile !~ m@^kernel/lockdep@ && $realfile !~ m@^include/linux/lockdep@ && $realfile !~ m@^drivers/base/core@) { |
000d1cc18 checkpatch.pl: ad... |
3407 3408 3409 |
ERROR("LOCKDEP", "lockdep_no_validate class is reserved for device->mutex. " . $herecurr); |
1704f47b5 lockdep: Add nova... |
3410 3411 |
} } |
88f8831c0 checkpatch: check... |
3412 3413 3414 |
if ($line =~ /debugfs_create_file.*S_IWUGO/ || $line =~ /DEVICE_ATTR.*S_IWUGO/ ) { |
000d1cc18 checkpatch.pl: ad... |
3415 3416 3417 |
WARN("EXPORTED_WORLD_WRITABLE", "Exporting world writable files is usually an error. Consider more restrictive permissions. " . $herecurr); |
88f8831c0 checkpatch: check... |
3418 |
} |
309c00c73 checkpatch: warn ... |
3419 3420 3421 |
# Check for memset with swapped arguments if ($line =~ /memset.*\,(\ |)(0x|)0(\ |0|)\);/) { |
000d1cc18 checkpatch.pl: ad... |
3422 3423 3424 |
ERROR("MEMSET", "memset size is 3rd argument, not the second. " . $herecurr); |
309c00c73 checkpatch: warn ... |
3425 |
} |
13214adf7 update checkpatch... |
3426 3427 3428 3429 3430 3431 |
} # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines == -1) { exit(0); |
0a920b5b6 add a trivial pat... |
3432 |
} |
8905a67c6 update checkpatch... |
3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 |
# In mailback mode only produce a report in the negative, for # things that appear to be patches. if ($mailback && ($clean == 1 || !$is_patch)) { exit(0); } # This is not a patch, and we are are in 'no-patch' mode so # just keep quiet. if (!$chk_patch && !$is_patch) { exit(0); } if (!$is_patch) { |
000d1cc18 checkpatch.pl: ad... |
3446 3447 3448 |
ERROR("NOT_UNIFIED_DIFF", "Does not appear to be a unified-diff format patch "); |
0a920b5b6 add a trivial pat... |
3449 3450 |
} if ($is_patch && $chk_signoff && $signoff == 0) { |
000d1cc18 checkpatch.pl: ad... |
3451 3452 3453 |
ERROR("MISSING_SIGN_OFF", "Missing Signed-off-by: line(s) "); |
0a920b5b6 add a trivial pat... |
3454 |
} |
8905a67c6 update checkpatch... |
3455 |
print report_dump(); |
13214adf7 update checkpatch... |
3456 3457 |
if ($summary && !($clean == 1 && $quiet == 1)) { print "$filename " if ($summary_file); |
8905a67c6 update checkpatch... |
3458 3459 3460 3461 3462 3463 |
print "total: $cnt_error errors, $cnt_warn warnings, " . (($check)? "$cnt_chk checks, " : "") . "$cnt_lines lines checked "; print " " if ($quiet == 0); |
f0a594c1c update checkpatch... |
3464 |
} |
8905a67c6 update checkpatch... |
3465 |
|
d2c0a2351 checkpatch: sugge... |
3466 3467 3468 3469 3470 3471 3472 3473 3474 |
if ($quiet == 0) { # If there were whitespace errors which cleanpatch can fix # then suggest that. if ($rpt_cleaners) { print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or "; print " scripts/cleanfile "; |
b0781216e scripts/checkpatc... |
3475 |
$rpt_cleaners = 0; |
d2c0a2351 checkpatch: sugge... |
3476 3477 |
} } |
000d1cc18 checkpatch.pl: ad... |
3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 |
if (keys %ignore_type) { print "NOTE: Ignored message types:"; foreach my $ignore (sort keys %ignore_type) { print " $ignore"; } print " "; print " " if ($quiet == 0); } |
0a920b5b6 add a trivial pat... |
3488 |
if ($clean == 1 && $quiet == 0) { |
c2fdda0df update checkpatch... |
3489 3490 |
print "$vname has no obvious style problems and is ready for submission. " |
0a920b5b6 add a trivial pat... |
3491 3492 |
} if ($clean == 0 && $quiet == 0) { |
000d1cc18 checkpatch.pl: ad... |
3493 3494 3495 3496 3497 3498 |
print << "EOM"; $vname has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. EOM |
0a920b5b6 add a trivial pat... |
3499 |
} |
13214adf7 update checkpatch... |
3500 |
|
0a920b5b6 add a trivial pat... |
3501 3502 |
return $clean; } |