From bf37323c855daa113860a53f05da27059204442e Mon Sep 17 00:00:00 2001 From: Franklin S Cooper Jr Date: Wed, 7 Oct 2015 04:52:25 -0500 Subject: [PATCH] Input: edt-ft5x06 - Work around FT5506 firmware bug In the touchscreen controller ISR, reading the tsc starting from register 0x2 causes the tsc to very infrequently update the detected finger movement coordinates. The irq pin toogles at a fast rate to indicate touch events are happening but when reading the coordinates from the tsc the are only updated/change at at rate of ~100 ms. Example: X: 10 , Y: 30 X: 10 , Y: 30 X: 10, Y: 30 .. // After 100 ms X: 300, Y: 300 X: 300, y: 300 .. // After 100 ms X: 1743, Y: 621 X: 1743, Y: 621 For some reason if instead of starting to read at register 0x2 you start reading at register 0x0 this issue isn't seen. This seems like a quirk only seen in the EDT FT5506 so to fix this issue simply adjust the code to start reading from 0x0. Since there is technically nothing wrong with doing this no regressions should be seen with other touchscreen controllers supported by this driver. Signed-off-by: Franklin S Cooper Jr Signed-off-by: Sekhar Nori --- drivers/input/touchscreen/edt-ft5x06.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 2a2075c..8db73b9 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -174,7 +174,7 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id) struct edt_ft5x06_ts_data *tsdata = dev_id; struct device *dev = &tsdata->client->dev; u8 cmd; - u8 rdbuf[59]; + u8 rdbuf[61]; int i, type, x, y, id; int offset, tplen, datalen; int error; @@ -190,8 +190,8 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id) break; case M09: - cmd = 0x02; - offset = 1; + cmd = 0x0; + offset = 3; tplen = 6; datalen = tplen * tsdata->max_support_points + 1 - cmd; break; -- 1.9.1