From a81a6216209c2424a5ca50faa6eef9fec68cb839 Mon Sep 17 00:00:00 2001 From: "Andrew F. Davis" Date: Fri, 20 Nov 2015 18:16:00 -0600 Subject: [PATCH] remoteproc/keystone: ensure the DSPs are in reset in probe The DSPs are expected to be in reset when the driver probes a device. If the DSPs are out of reset in probe, the system may crash when the firmware is being loaded. So, add a check to make sure the DSP resets are asserted, and if not, throw a eye-catchy warning and assert the resets specifically. Signed-off-by: Andrew F. Davis [s-anna@ti.com: replace warning with a WARN] Signed-off-by: Suman Anna --- drivers/remoteproc/keystone_remoteproc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c index fe15b92..7ec8126 100644 --- a/drivers/remoteproc/keystone_remoteproc.c +++ b/drivers/remoteproc/keystone_remoteproc.c @@ -907,6 +907,16 @@ static int keystone_rproc_probe(struct platform_device *pdev) if (rproc_get_alias_id(rproc) < 0) dev_warn(&pdev->dev, "device does not have an alias id\n"); + /* ensure the DSP is in reset before loading firmware */ + ret = reset_control_status(ksproc->reset); + if (ret < 0) { + dev_err(dev, "failed to get reset status, status = %d\n", ret); + goto release_mem; + } else if (ret == 0) { + WARN(1, "device is not in reset\n"); + keystone_rproc_dsp_reset(ksproc); + } + ret = rproc_add(rproc); if (ret) { dev_err(dev, "failed to add register device with remoteproc core, status = %d\n", -- 1.9.1