Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit ed9eb845d7916b2bc863e5b93c82e18be8faf032

Authored by Ingo Molnar 2015-01-08 15:59:22 +0800

Exists in ti-lsk-linux-4.1.y and in 10 other branches

Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/g…

…it/acme/linux into perf/urgent

Pull perf/urgent fixes from Arnaldo Carvalho de Melo:

"
  - 'perf probe' should fall back to find probe point in symbols when failing
    to do so in a debuginfo file (Masami Hiramatsu)

  - Fix 'perf probe' crash in dwarf_getcfi_elf (Namhyung Kim)

  - Fix shell completion with 'perf list' --raw-dump option (Taesoo Kim)

  - Fix 'perf diff' to sort by baseline field by default (Namhyung Kim)
"

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

Showing 4 changed files Inline Diff

tools/perf/builtin-diff.c
tools/perf/builtin-list.c
tools/perf/util/probe-event.c
tools/perf/util/probe-finder.c

tools/perf/builtin-diff.c

Diff comments View file @ ed9eb84

 /*
  * builtin-diff.c
  *
  * Builtin diff command: Analyze two perf.data input files, look up and read
  * DSOs and symbol information, sort them and produce a diff.
  */
 #include "builtin.h"
 #include "util/debug.h"
 #include "util/event.h"
 #include "util/hist.h"
 #include "util/evsel.h"
 #include "util/evlist.h"
 #include "util/session.h"
 #include "util/tool.h"
 #include "util/sort.h"
 #include "util/symbol.h"
 #include "util/util.h"
 #include "util/data.h"
 #include <stdlib.h>
 #include <math.h>
 /* Diff command specific HPP columns. */
 enum {
 	PERF_HPP_DIFF__BASELINE,
 	PERF_HPP_DIFF__PERIOD,
 	PERF_HPP_DIFF__PERIOD_BASELINE,
 	PERF_HPP_DIFF__DELTA,
 	PERF_HPP_DIFF__RATIO,
 	PERF_HPP_DIFF__WEIGHTED_DIFF,
 	PERF_HPP_DIFF__FORMULA,
 	PERF_HPP_DIFF__MAX_INDEX
 };
 struct diff_hpp_fmt {
 	struct perf_hpp_fmt	 fmt;
 	int			 idx;
 	char			*header;
 	int			 header_width;
 };
 struct data__file {
 	struct perf_session	*session;
 	struct perf_data_file	file;
 	int			 idx;
 	struct hists		*hists;
 	struct diff_hpp_fmt	 fmt[PERF_HPP_DIFF__MAX_INDEX];
 };
 static struct data__file *data__files;
 static int data__files_cnt;
 #define data__for_each_file_start(i, d, s)	\
 	for (i = s, d = &data__files[s];	\
 	     i < data__files_cnt;		\
 	     i++, d = &data__files[i])
 #define data__for_each_file(i, d) data__for_each_file_start(i, d, 0)
 #define data__for_each_file_new(i, d) data__for_each_file_start(i, d, 1)
 static bool force;
 static bool show_period;
 static bool show_formula;
 static bool show_baseline_only;
 static unsigned int sort_compute;
 static s64 compute_wdiff_w1;
 static s64 compute_wdiff_w2;
 enum {
 	COMPUTE_DELTA,
 	COMPUTE_RATIO,
 	COMPUTE_WEIGHTED_DIFF,
 	COMPUTE_MAX,
 };
 const char *compute_names[COMPUTE_MAX] = {
 	[COMPUTE_DELTA] = "delta",
 	[COMPUTE_RATIO] = "ratio",
 	[COMPUTE_WEIGHTED_DIFF] = "wdiff",
 };
 static int compute;
 static int compute_2_hpp[COMPUTE_MAX] = {
 	[COMPUTE_DELTA]		= PERF_HPP_DIFF__DELTA,
 	[COMPUTE_RATIO]		= PERF_HPP_DIFF__RATIO,
 	[COMPUTE_WEIGHTED_DIFF]	= PERF_HPP_DIFF__WEIGHTED_DIFF,
 };
 #define MAX_COL_WIDTH 70
 static struct header_column {
 	const char *name;
 	int width;
 } columns[PERF_HPP_DIFF__MAX_INDEX] = {
 	[PERF_HPP_DIFF__BASELINE] = {
 		.name  = "Baseline",
 	},
 	[PERF_HPP_DIFF__PERIOD] = {
 		.name  = "Period",
 		.width = 14,
 	},
 	[PERF_HPP_DIFF__PERIOD_BASELINE] = {
 		.name  = "Base period",
 		.width = 14,
 	},
 	[PERF_HPP_DIFF__DELTA] = {
 		.name  = "Delta",
 		.width = 7,
 	},
 	[PERF_HPP_DIFF__RATIO] = {
 		.name  = "Ratio",
 		.width = 14,
 	},
 	[PERF_HPP_DIFF__WEIGHTED_DIFF] = {
 		.name  = "Weighted diff",
 		.width = 14,
 	},
 	[PERF_HPP_DIFF__FORMULA] = {
 		.name  = "Formula",
 		.width = MAX_COL_WIDTH,
 	}
 };
 static int setup_compute_opt_wdiff(char *opt)
 {
 	char *w1_str = opt;
 	char *w2_str;
 	int ret = -EINVAL;
 	if (!opt)
 		goto out;
 	w2_str = strchr(opt, ',');
 	if (!w2_str)
 		goto out;
 	*w2_str++ = 0x0;
 	if (!*w2_str)
 		goto out;
 	compute_wdiff_w1 = strtol(w1_str, NULL, 10);
 	compute_wdiff_w2 = strtol(w2_str, NULL, 10);
 	if (!compute_wdiff_w1 || !compute_wdiff_w2)
 		goto out;
 	pr_debug("compute wdiff w1(%" PRId64 ") w2(%" PRId64 ")\n",
 		  compute_wdiff_w1, compute_wdiff_w2);
 	ret = 0;
  out:
 	if (ret)
 		pr_err("Failed: wrong weight data, use 'wdiff:w1,w2'\n");
 	return ret;
 }
 static int setup_compute_opt(char *opt)
 {
 	if (compute == COMPUTE_WEIGHTED_DIFF)
 		return setup_compute_opt_wdiff(opt);
 	if (opt) {
 		pr_err("Failed: extra option specified '%s'", opt);
 		return -EINVAL;
 	}
 	return 0;
 }
 static int setup_compute(const struct option *opt, const char *str,
 			 int unset __maybe_unused)
 {
 	int *cp = (int *) opt->value;
 	char *cstr = (char *) str;
 	char buf[50];
 	unsigned i;
 	char *option;
 	if (!str) {
 		*cp = COMPUTE_DELTA;
 		return 0;
 	}
 	option = strchr(str, ':');
 	if (option) {
 		unsigned len = option++ - str;
 		/*
 		 * The str data are not writeable, so we need
 		 * to use another buffer.
 		 */
 		/* No option value is longer. */
 		if (len >= sizeof(buf))
 			return -EINVAL;
 		strncpy(buf, str, len);
 		buf[len] = 0x0;
 		cstr = buf;
 	}
 	for (i = 0; i < COMPUTE_MAX; i++)
 		if (!strcmp(cstr, compute_names[i])) {
 			*cp = i;
 			return setup_compute_opt(option);
 		}
 	pr_err("Failed: '%s' is not computation method "
 	       "(use 'delta','ratio' or 'wdiff')\n", str);
 	return -EINVAL;
 }
 static double period_percent(struct hist_entry *he, u64 period)
 {
 	u64 total = hists__total_period(he->hists);
 	return (period * 100.0) / total;
 }
 static double compute_delta(struct hist_entry *he, struct hist_entry *pair)
 {
 	double old_percent = period_percent(he, he->stat.period);
 	double new_percent = period_percent(pair, pair->stat.period);
 	pair->diff.period_ratio_delta = new_percent - old_percent;
 	pair->diff.computed = true;
 	return pair->diff.period_ratio_delta;
 }
 static double compute_ratio(struct hist_entry *he, struct hist_entry *pair)
 {
 	double old_period = he->stat.period ?: 1;
 	double new_period = pair->stat.period;
 	pair->diff.computed = true;
 	pair->diff.period_ratio = new_period / old_period;
 	return pair->diff.period_ratio;
 }
 static s64 compute_wdiff(struct hist_entry *he, struct hist_entry *pair)
 {
 	u64 old_period = he->stat.period;
 	u64 new_period = pair->stat.period;
 	pair->diff.computed = true;
 	pair->diff.wdiff = new_period * compute_wdiff_w2 -
 			   old_period * compute_wdiff_w1;
 	return pair->diff.wdiff;
 }
 static int formula_delta(struct hist_entry *he, struct hist_entry *pair,
 			 char *buf, size_t size)
 {
 	u64 he_total = he->hists->stats.total_period;
 	u64 pair_total = pair->hists->stats.total_period;
 	if (symbol_conf.filter_relative) {
 		he_total = he->hists->stats.total_non_filtered_period;
 		pair_total = pair->hists->stats.total_non_filtered_period;
 	}
 	return scnprintf(buf, size,
 			 "(%" PRIu64 " * 100 / %" PRIu64 ") - "
 			 "(%" PRIu64 " * 100 / %" PRIu64 ")",
 			 pair->stat.period, pair_total,
 			 he->stat.period, he_total);
 }
 static int formula_ratio(struct hist_entry *he, struct hist_entry *pair,
 			 char *buf, size_t size)
 {
 	double old_period = he->stat.period;
 	double new_period = pair->stat.period;
 	return scnprintf(buf, size, "%.0F / %.0F", new_period, old_period);
 }
 static int formula_wdiff(struct hist_entry *he, struct hist_entry *pair,
 			 char *buf, size_t size)
 {
 	u64 old_period = he->stat.period;
 	u64 new_period = pair->stat.period;
 	return scnprintf(buf, size,
 		  "(%" PRIu64 " * " "%" PRId64 ") - (%" PRIu64 " * " "%" PRId64 ")",
 		  new_period, compute_wdiff_w2, old_period, compute_wdiff_w1);
 }
 static int formula_fprintf(struct hist_entry *he, struct hist_entry *pair,
 			   char *buf, size_t size)
 {
 	switch (compute) {
 	case COMPUTE_DELTA:
 		return formula_delta(he, pair, buf, size);
 	case COMPUTE_RATIO:
 		return formula_ratio(he, pair, buf, size);
 	case COMPUTE_WEIGHTED_DIFF:
 		return formula_wdiff(he, pair, buf, size);
 	default:
 		BUG_ON(1);
 	}
 	return -1;
 }
 static int hists__add_entry(struct hists *hists,
 			    struct addr_location *al, u64 period,
 			    u64 weight, u64 transaction)
 {
 	if (__hists__add_entry(hists, al, NULL, NULL, NULL, period, weight,
 			       transaction, true) != NULL)
 		return 0;
 	return -ENOMEM;
 }
 static int diff__process_sample_event(struct perf_tool *tool __maybe_unused,
 				      union perf_event *event,
 				      struct perf_sample *sample,
 				      struct perf_evsel *evsel,
 				      struct machine *machine)
 {
 	struct addr_location al;
 	struct hists *hists = evsel__hists(evsel);
 	if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) {
 		pr_warning("problem processing %d event, skipping it.\n",
 			   event->header.type);
 		return -1;
 	}
 	if (hists__add_entry(hists, &al, sample->period,
 			     sample->weight, sample->transaction)) {
 		pr_warning("problem incrementing symbol period, skipping event\n");
 		return -1;
 	}
 	/*
 	 * The total_period is updated here before going to the output
 	 * tree since normally only the baseline hists will call
 	 * hists__output_resort() and precompute needs the total
 	 * period in order to sort entries by percentage delta.
 	 */
 	hists->stats.total_period += sample->period;
 	if (!al.filtered)
 		hists->stats.total_non_filtered_period += sample->period;
 	return 0;
 }
 static struct perf_tool tool = {
 	.sample	= diff__process_sample_event,
 	.mmap	= perf_event__process_mmap,
 	.mmap2	= perf_event__process_mmap2,
 	.comm	= perf_event__process_comm,
 	.exit	= perf_event__process_exit,
 	.fork	= perf_event__process_fork,
 	.lost	= perf_event__process_lost,
 	.ordered_events = true,
 	.ordering_requires_timestamps = true,
 };
 static struct perf_evsel *evsel_match(struct perf_evsel *evsel,
 				      struct perf_evlist *evlist)
 {
 	struct perf_evsel *e;
 	evlist__for_each(evlist, e) {
 		if (perf_evsel__match2(evsel, e))
 			return e;
 	}
 	return NULL;
 }
 static void perf_evlist__collapse_resort(struct perf_evlist *evlist)
 {
 	struct perf_evsel *evsel;
 	evlist__for_each(evlist, evsel) {
 		struct hists *hists = evsel__hists(evsel);
 		hists__collapse_resort(hists, NULL);
 	}
 }
 static struct hist_entry*
 get_pair_data(struct hist_entry *he, struct data__file *d)
 {
 	if (hist_entry__has_pairs(he)) {
 		struct hist_entry *pair;
 		list_for_each_entry(pair, &he->pairs.head, pairs.node)
 			if (pair->hists == d->hists)
 				return pair;
 	}
 	return NULL;
 }
 static struct hist_entry*
 get_pair_fmt(struct hist_entry *he, struct diff_hpp_fmt *dfmt)
 {
 	void *ptr = dfmt - dfmt->idx;
 	struct data__file *d = container_of(ptr, struct data__file, fmt);
 	return get_pair_data(he, d);
 }
 static void hists__baseline_only(struct hists *hists)
 {
 	struct rb_root *root;
 	struct rb_node *next;
 	if (sort__need_collapse)
 		root = &hists->entries_collapsed;
 	else
 		root = hists->entries_in;
 	next = rb_first(root);
 	while (next != NULL) {
 		struct hist_entry *he = rb_entry(next, struct hist_entry, rb_node_in);
 		next = rb_next(&he->rb_node_in);
 		if (!hist_entry__next_pair(he)) {
 			rb_erase(&he->rb_node_in, root);
 			hist_entry__free(he);
 		}
 	}
 }
 static void hists__precompute(struct hists *hists)
 {
 	struct rb_root *root;
 	struct rb_node *next;
 	if (sort__need_collapse)
 		root = &hists->entries_collapsed;
 	else
 		root = hists->entries_in;
 	next = rb_first(root);
 	while (next != NULL) {
 		struct hist_entry *he, *pair;
 		he   = rb_entry(next, struct hist_entry, rb_node_in);
 		next = rb_next(&he->rb_node_in);
 		pair = get_pair_data(he, &data__files[sort_compute]);
 		if (!pair)
 			continue;
 		switch (compute) {
 		case COMPUTE_DELTA:
 			compute_delta(he, pair);
 			break;
 		case COMPUTE_RATIO:
 			compute_ratio(he, pair);
 			break;
 		case COMPUTE_WEIGHTED_DIFF:
 			compute_wdiff(he, pair);
 			break;
 		default:
 			BUG_ON(1);
 		}
 	}
 }
 static int64_t cmp_doubles(double l, double r)
 {
 	if (l > r)
 		return -1;
 	else if (l < r)
 		return 1;
 	else
 		return 0;
 }
 static int64_t
 __hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right,
 			int c)
 {
 	switch (c) {
 	case COMPUTE_DELTA:
 	{
 		double l = left->diff.period_ratio_delta;
 		double r = right->diff.period_ratio_delta;
 		return cmp_doubles(l, r);
 	}
 	case COMPUTE_RATIO:
 	{
 		double l = left->diff.period_ratio;
 		double r = right->diff.period_ratio;
 		return cmp_doubles(l, r);
 	}
 	case COMPUTE_WEIGHTED_DIFF:
 	{
 		s64 l = left->diff.wdiff;
 		s64 r = right->diff.wdiff;
 		return r - l;
 	}
 	default:
 		BUG_ON(1);
 	}
 	return 0;
 }
 static int64_t
 hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right,
 			int c)
 {
 	bool pairs_left  = hist_entry__has_pairs(left);
 	bool pairs_right = hist_entry__has_pairs(right);
 	struct hist_entry *p_right, *p_left;
 	if (!pairs_left && !pairs_right)
 		return 0;
 	if (!pairs_left || !pairs_right)
 		return pairs_left ? -1 : 1;
 	p_left  = get_pair_data(left,  &data__files[sort_compute]);
 	p_right = get_pair_data(right, &data__files[sort_compute]);
 	if (!p_left && !p_right)
 		return 0;
 	if (!p_left || !p_right)
 		return p_left ? -1 : 1;
 	/*
 	 * We have 2 entries of same kind, let's
 	 * make the data comparison.
 	 */
 	return __hist_entry__cmp_compute(p_left, p_right, c);
 }
+static int64_t
+hist_entry__cmp_nop(struct hist_entry *left __maybe_unused,
+		    struct hist_entry *right __maybe_unused)
+{
+	return 0;
+}
+static int64_t
+hist_entry__cmp_baseline(struct hist_entry *left, struct hist_entry *right)
+{
+	if (sort_compute)
+		return 0;
+	if (left->stat.period == right->stat.period)
+		return 0;
+	return left->stat.period > right->stat.period ? 1 : -1;
+}
+static int64_t
+hist_entry__cmp_delta(struct hist_entry *left, struct hist_entry *right)
+{
+	return hist_entry__cmp_compute(right, left, COMPUTE_DELTA);
+}
+static int64_t
+hist_entry__cmp_ratio(struct hist_entry *left, struct hist_entry *right)
+{
+	return hist_entry__cmp_compute(right, left, COMPUTE_RATIO);
+}
+static int64_t
+hist_entry__cmp_wdiff(struct hist_entry *left, struct hist_entry *right)
+{
+	return hist_entry__cmp_compute(right, left, COMPUTE_WEIGHTED_DIFF);
+}
 static void insert_hist_entry_by_compute(struct rb_root *root,
 					 struct hist_entry *he,
 					 int c)
 {
 	struct rb_node **p = &root->rb_node;
 	struct rb_node *parent = NULL;
 	struct hist_entry *iter;
 	while (*p != NULL) {
 		parent = *p;
 		iter = rb_entry(parent, struct hist_entry, rb_node);
 		if (hist_entry__cmp_compute(he, iter, c) < 0)
 			p = &(*p)->rb_left;
 		else
 			p = &(*p)->rb_right;
 	}
 	rb_link_node(&he->rb_node, parent, p);
 	rb_insert_color(&he->rb_node, root);
 }
 static void hists__compute_resort(struct hists *hists)
 {
 	struct rb_root *root;
 	struct rb_node *next;
 	if (sort__need_collapse)
 		root = &hists->entries_collapsed;
 	else
 		root = hists->entries_in;
 	hists->entries = RB_ROOT;
 	next = rb_first(root);
 	hists__reset_stats(hists);
 	hists__reset_col_len(hists);
 	while (next != NULL) {
 		struct hist_entry *he;
 		he = rb_entry(next, struct hist_entry, rb_node_in);
 		next = rb_next(&he->rb_node_in);
 		insert_hist_entry_by_compute(&hists->entries, he, compute);
 		hists__inc_stats(hists, he);
 		if (!he->filtered)
 			hists__calc_col_len(hists, he);
 	}
 }
 static void hists__process(struct hists *hists)
 {
 	if (show_baseline_only)
 		hists__baseline_only(hists);
 	if (sort_compute) {
 		hists__precompute(hists);
 		hists__compute_resort(hists);
 	} else {
 		hists__output_resort(hists, NULL);
 	}
 	hists__fprintf(hists, true, 0, 0, 0, stdout);
 }
 static void data__fprintf(void)
 {
 	struct data__file *d;
 	int i;
 	fprintf(stdout, "# Data files:\n");
 	data__for_each_file(i, d)
 		fprintf(stdout, "#  [%d] %s %s\n",
 			d->idx, d->file.path,
 			!d->idx ? "(Baseline)" : "");
 	fprintf(stdout, "#\n");
 }
 static void data_process(void)
 {
 	struct perf_evlist *evlist_base = data__files[0].session->evlist;
 	struct perf_evsel *evsel_base;
 	bool first = true;
 	evlist__for_each(evlist_base, evsel_base) {
 		struct hists *hists_base = evsel__hists(evsel_base);
 		struct data__file *d;
 		int i;
 		data__for_each_file_new(i, d) {
 			struct perf_evlist *evlist = d->session->evlist;
 			struct perf_evsel *evsel;
 			struct hists *hists;
 			evsel = evsel_match(evsel_base, evlist);
 			if (!evsel)
 				continue;
 			hists = evsel__hists(evsel);
 			d->hists = hists;
 			hists__match(hists_base, hists);
 			if (!show_baseline_only)
 				hists__link(hists_base, hists);
 		}
 		fprintf(stdout, "%s# Event '%s'\n#\n", first ? "" : "\n",
 			perf_evsel__name(evsel_base));
 		first = false;
 		if (verbose || data__files_cnt > 2)
 			data__fprintf();
 		hists__process(hists_base);
 	}
 }
 static void data__free(struct data__file *d)
 {
 	int col;
 	for (col = 0; col < PERF_HPP_DIFF__MAX_INDEX; col++) {
 		struct diff_hpp_fmt *fmt = &d->fmt[col];
 		zfree(&fmt->header);
 	}
 }
 static int __cmd_diff(void)
 {
 	struct data__file *d;
 	int ret = -EINVAL, i;
 	data__for_each_file(i, d) {
 		d->session = perf_session__new(&d->file, false, &tool);
 		if (!d->session) {
 			pr_err("Failed to open %s\n", d->file.path);
 			ret = -1;
 			goto out_delete;
 		}
 		ret = perf_session__process_events(d->session, &tool);
 		if (ret) {
 			pr_err("Failed to process %s\n", d->file.path);
 			goto out_delete;
 		}
 		perf_evlist__collapse_resort(d->session->evlist);
 	}
 	data_process();
  out_delete:
 	data__for_each_file(i, d) {
 		if (d->session)
 			perf_session__delete(d->session);
 		data__free(d);
 	}
 	free(data__files);
 	return ret;
 }
 static const char * const diff_usage[] = {
 	"perf diff [<options>] [old_file] [new_file]",
 	NULL,
 };
 static const struct option options[] = {
 	OPT_INCR('v', "verbose", &verbose,
 		    "be more verbose (show symbol address, etc)"),
 	OPT_BOOLEAN('b', "baseline-only", &show_baseline_only,
 		    "Show only items with match in baseline"),
 	OPT_CALLBACK('c', "compute", &compute,
 		     "delta,ratio,wdiff:w1,w2 (default delta)",
 		     "Entries differential computation selection",
 		     setup_compute),
 	OPT_BOOLEAN('p', "period", &show_period,
 		    "Show period values."),
 	OPT_BOOLEAN('F', "formula", &show_formula,
 		    "Show formula."),
 	OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
 		    "dump raw trace in ASCII"),
 	OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
 	OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
 		    "load module symbols - WARNING: use only with -k and LIVE kernel"),
 	OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
 		   "only consider symbols in these dsos"),
 	OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
 		   "only consider symbols in these comms"),
 	OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
 		   "only consider these symbols"),
 	OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
 		   "sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ..."
 		   " Please refer the man page for the complete list."),
 	OPT_STRING('t', "field-separator", &symbol_conf.field_sep, "separator",
 		   "separator for columns, no spaces will be added between "
 		   "columns '.' is reserved."),
 	OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
 		    "Look for files with symbols relative to this directory"),
 	OPT_UINTEGER('o', "order", &sort_compute, "Specify compute sorting."),
 	OPT_CALLBACK(0, "percentage", NULL, "relative|absolute",
 		     "How to display percentage of filtered entries", parse_filter_percentage),
 	OPT_END()
 };
 static double baseline_percent(struct hist_entry *he)
 {
 	u64 total = hists__total_period(he->hists);
 	return 100.0 * he->stat.period / total;
 }
 static int hpp__color_baseline(struct perf_hpp_fmt *fmt,
 			       struct perf_hpp *hpp, struct hist_entry *he)
 {
 	struct diff_hpp_fmt *dfmt =
 		container_of(fmt, struct diff_hpp_fmt, fmt);
 	double percent = baseline_percent(he);
 	char pfmt[20] = " ";
 	if (!he->dummy) {
 		scnprintf(pfmt, 20, "%%%d.2f%%%%", dfmt->header_width - 1);
 		return percent_color_snprintf(hpp->buf, hpp->size,
 					      pfmt, percent);
 	} else
 		return scnprintf(hpp->buf, hpp->size, "%*s",
 				 dfmt->header_width, pfmt);
 }
 static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size)
 {
 	double percent = baseline_percent(he);
 	const char *fmt = symbol_conf.field_sep ? "%.2f" : "%6.2f%%";
 	int ret = 0;
 	if (!he->dummy)
 		ret = scnprintf(buf, size, fmt, percent);
 	return ret;
 }
 static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
 				struct perf_hpp *hpp, struct hist_entry *he,
 				int comparison_method)
 {
 	struct diff_hpp_fmt *dfmt =
 		container_of(fmt, struct diff_hpp_fmt, fmt);
 	struct hist_entry *pair = get_pair_fmt(he, dfmt);
 	double diff;
 	s64 wdiff;
 	char pfmt[20] = " ";
 	if (!pair)
 		goto dummy_print;
 	switch (comparison_method) {
 	case COMPUTE_DELTA:
 		if (pair->diff.computed)
 			diff = pair->diff.period_ratio_delta;
 		else
 			diff = compute_delta(he, pair);
 		if (fabs(diff) < 0.01)
 			goto dummy_print;
 		scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
 		return percent_color_snprintf(hpp->buf, hpp->size,
 					pfmt, diff);
 	case COMPUTE_RATIO:
 		if (he->dummy)
 			goto dummy_print;
 		if (pair->diff.computed)
 			diff = pair->diff.period_ratio;
 		else
 			diff = compute_ratio(he, pair);
 		scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width);
 		return value_color_snprintf(hpp->buf, hpp->size,
 					pfmt, diff);
 	case COMPUTE_WEIGHTED_DIFF:
 		if (he->dummy)
 			goto dummy_print;
 		if (pair->diff.computed)
 			wdiff = pair->diff.wdiff;
 		else
 			wdiff = compute_wdiff(he, pair);
 		scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
 		return color_snprintf(hpp->buf, hpp->size,
 				get_percent_color(wdiff),
 				pfmt, wdiff);
 	default:
 		BUG_ON(1);
 	}
 dummy_print:
 	return scnprintf(hpp->buf, hpp->size, "%*s",
 			dfmt->header_width, pfmt);
 }
 static int hpp__color_delta(struct perf_hpp_fmt *fmt,
 			struct perf_hpp *hpp, struct hist_entry *he)
 {
 	return __hpp__color_compare(fmt, hpp, he, COMPUTE_DELTA);
 }
 static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
 			struct perf_hpp *hpp, struct hist_entry *he)
 {
 	return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
 }
 static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
 			struct perf_hpp *hpp, struct hist_entry *he)
 {
 	return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
 }
 static void
 hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
 {
 	switch (idx) {
 	case PERF_HPP_DIFF__PERIOD_BASELINE:
 		scnprintf(buf, size, "%" PRIu64, he->stat.period);
 		break;
 	default:
 		break;
 	}
 }
 static void
 hpp__entry_pair(struct hist_entry *he, struct hist_entry *pair,
 		int idx, char *buf, size_t size)
 {
 	double diff;
 	double ratio;
 	s64 wdiff;
 	switch (idx) {
 	case PERF_HPP_DIFF__DELTA:
 		if (pair->diff.computed)
 			diff = pair->diff.period_ratio_delta;
 		else
 			diff = compute_delta(he, pair);
 		if (fabs(diff) >= 0.01)
 			scnprintf(buf, size, "%+4.2F%%", diff);
 		break;
 	case PERF_HPP_DIFF__RATIO:
 		/* No point for ratio number if we are dummy.. */
 		if (he->dummy)
 			break;
 		if (pair->diff.computed)
 			ratio = pair->diff.period_ratio;
 		else
 			ratio = compute_ratio(he, pair);
 		if (ratio > 0.0)
 			scnprintf(buf, size, "%14.6F", ratio);
 		break;
 	case PERF_HPP_DIFF__WEIGHTED_DIFF:
 		/* No point for wdiff number if we are dummy.. */
 		if (he->dummy)
 			break;
 		if (pair->diff.computed)
 			wdiff = pair->diff.wdiff;
 		else
 			wdiff = compute_wdiff(he, pair);
 		if (wdiff != 0)
 			scnprintf(buf, size, "%14ld", wdiff);
 		break;
 	case PERF_HPP_DIFF__FORMULA:
 		formula_fprintf(he, pair, buf, size);
 		break;
 	case PERF_HPP_DIFF__PERIOD:
 		scnprintf(buf, size, "%" PRIu64, pair->stat.period);
 		break;
 	default:
 		BUG_ON(1);
 	};
 }
 static void
 __hpp__entry_global(struct hist_entry *he, struct diff_hpp_fmt *dfmt,
 		    char *buf, size_t size)
 {
 	struct hist_entry *pair = get_pair_fmt(he, dfmt);
 	int idx = dfmt->idx;
 	/* baseline is special */
 	if (idx == PERF_HPP_DIFF__BASELINE)
 		hpp__entry_baseline(he, buf, size);
 	else {
 		if (pair)
 			hpp__entry_pair(he, pair, idx, buf, size);
 		else
 			hpp__entry_unpair(he, idx, buf, size);
 	}
 }
 static int hpp__entry_global(struct perf_hpp_fmt *_fmt, struct perf_hpp *hpp,
 			     struct hist_entry *he)
 {
 	struct diff_hpp_fmt *dfmt =
 		container_of(_fmt, struct diff_hpp_fmt, fmt);
 	char buf[MAX_COL_WIDTH] = " ";
 	__hpp__entry_global(he, dfmt, buf, MAX_COL_WIDTH);
 	if (symbol_conf.field_sep)
 		return scnprintf(hpp->buf, hpp->size, "%s", buf);
 	else
 		return scnprintf(hpp->buf, hpp->size, "%*s",
 				 dfmt->header_width, buf);
 }
 static int hpp__header(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
 		       struct perf_evsel *evsel __maybe_unused)
 {
 	struct diff_hpp_fmt *dfmt =
 		container_of(fmt, struct diff_hpp_fmt, fmt);
 	BUG_ON(!dfmt->header);
 	return scnprintf(hpp->buf, hpp->size, dfmt->header);
 }
 static int hpp__width(struct perf_hpp_fmt *fmt,
 		      struct perf_hpp *hpp __maybe_unused,
 		      struct perf_evsel *evsel __maybe_unused)
 {
 	struct diff_hpp_fmt *dfmt =
 		container_of(fmt, struct diff_hpp_fmt, fmt);
 	BUG_ON(dfmt->header_width <= 0);
 	return dfmt->header_width;
 }
 static void init_header(struct data__file *d, struct diff_hpp_fmt *dfmt)
 {
 #define MAX_HEADER_NAME 100
 	char buf_indent[MAX_HEADER_NAME];
 	char buf[MAX_HEADER_NAME];
 	const char *header = NULL;
 	int width = 0;
 	BUG_ON(dfmt->idx >= PERF_HPP_DIFF__MAX_INDEX);
 	header = columns[dfmt->idx].name;
 	width  = columns[dfmt->idx].width;
 	/* Only our defined HPP fmts should appear here. */
 	BUG_ON(!header);
 	if (data__files_cnt > 2)
 		scnprintf(buf, MAX_HEADER_NAME, "%s/%d", header, d->idx);
 #define NAME (data__files_cnt > 2 ? buf : header)
 	dfmt->header_width = width;
 	width = (int) strlen(NAME);
 	if (dfmt->header_width < width)
 		dfmt->header_width = width;
 	scnprintf(buf_indent, MAX_HEADER_NAME, "%*s",
 		  dfmt->header_width, NAME);
 	dfmt->header = strdup(buf_indent);
 #undef MAX_HEADER_NAME
 #undef NAME
 }
 static void data__hpp_register(struct data__file *d, int idx)
 {
 	struct diff_hpp_fmt *dfmt = &d->fmt[idx];
 	struct perf_hpp_fmt *fmt = &dfmt->fmt;
 	dfmt->idx = idx;
 	fmt->header = hpp__header;
 	fmt->width  = hpp__width;
 	fmt->entry  = hpp__entry_global;
+	fmt->cmp    = hist_entry__cmp_nop;
+	fmt->collapse = hist_entry__cmp_nop;
 	/* TODO more colors */
 	switch (idx) {
 	case PERF_HPP_DIFF__BASELINE:
 		fmt->color = hpp__color_baseline;
+		fmt->sort  = hist_entry__cmp_baseline;
 		break;
 	case PERF_HPP_DIFF__DELTA:
 		fmt->color = hpp__color_delta;
+		fmt->sort  = hist_entry__cmp_delta;
 		break;
 	case PERF_HPP_DIFF__RATIO:
 		fmt->color = hpp__color_ratio;
+		fmt->sort  = hist_entry__cmp_ratio;
 		break;
 	case PERF_HPP_DIFF__WEIGHTED_DIFF:
 		fmt->color = hpp__color_wdiff;
+		fmt->sort  = hist_entry__cmp_wdiff;
 		break;
 	default:
+		fmt->sort  = hist_entry__cmp_nop;
 		break;
 	}
 	init_header(d, dfmt);
 	perf_hpp__column_register(fmt);
+	perf_hpp__register_sort_field(fmt);
 }
 static void ui_init(void)
 {
 	struct data__file *d;
 	int i;
 	data__for_each_file(i, d) {
 		/*
 		 * Baseline or compute realted columns:
 		 *
 		 *   PERF_HPP_DIFF__BASELINE
 		 *   PERF_HPP_DIFF__DELTA
 		 *   PERF_HPP_DIFF__RATIO
 		 *   PERF_HPP_DIFF__WEIGHTED_DIFF
 		 */
 		data__hpp_register(d, i ? compute_2_hpp[compute] :
 					  PERF_HPP_DIFF__BASELINE);
 		/*
 		 * And the rest:
 		 *
 		 * PERF_HPP_DIFF__FORMULA
 		 * PERF_HPP_DIFF__PERIOD
 		 * PERF_HPP_DIFF__PERIOD_BASELINE
 		 */
 		if (show_formula && i)
 			data__hpp_register(d, PERF_HPP_DIFF__FORMULA);
 		if (show_period)
 			data__hpp_register(d, i ? PERF_HPP_DIFF__PERIOD :
 						  PERF_HPP_DIFF__PERIOD_BASELINE);
 	}
 }
 static int data_init(int argc, const char **argv)
 {
 	struct data__file *d;
 	static const char *defaults[] = {
 		"perf.data.old",
 		"perf.data",
 	};
 	bool use_default = true;
 	int i;
 	data__files_cnt = 2;
 	if (argc) {
 		if (argc == 1)
 			defaults[1] = argv[0];
 		else {
 			data__files_cnt = argc;
 			use_default = false;
 		}
 	} else if (perf_guest) {
 		defaults[0] = "perf.data.host";
 		defaults[1] = "perf.data.guest";
 	}
 	if (sort_compute >= (unsigned int) data__files_cnt) {
 		pr_err("Order option out of limit.\n");
 		return -EINVAL;
 	}
 	data__files = zalloc(sizeof(*data__files) * data__files_cnt);
 	if (!data__files)
 		return -ENOMEM;
 	data__for_each_file(i, d) {
 		struct perf_data_file *file = &d->file;
 		file->path  = use_default ? defaults[i] : argv[i];
 		file->mode  = PERF_DATA_MODE_READ,
 		file->force = force,
 		d->idx  = i;
 	}
 	return 0;
 }
 int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
 {
 	int ret = hists__init();
 	if (ret < 0)
 		return ret;
 	perf_config(perf_default_config, NULL);
 	argc = parse_options(argc, argv, options, diff_usage, 0);
 	if (symbol__init(NULL) < 0)
 		return -1;
 	if (data_init(argc, argv) < 0)
 		return -1;
 	ui_init();
 	sort__mode = SORT_MODE__DIFF;
 	if (setup_sorting() < 0)
 		usage_with_options(diff_usage, options);
 	setup_pager();
 	sort__setup_elide(NULL);
 	return __cmd_diff();
 }

tools/perf/builtin-list.c

Diff comments View file @ ed9eb84

 /*
  * builtin-list.c
  *
  * Builtin list command: list all event types
  *
  * Copyright (C) 2009, Thomas Gleixner <tglx@linutronix.de>
  * Copyright (C) 2008-2009, Red Hat Inc, Ingo Molnar <mingo@redhat.com>
  * Copyright (C) 2011, Red Hat Inc, Arnaldo Carvalho de Melo <acme@redhat.com>
  */
 #include "builtin.h"
 #include "perf.h"
 #include "util/parse-events.h"
 #include "util/cache.h"
 #include "util/pmu.h"
 #include "util/parse-options.h"
 int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
 {
 	int i;
-	const struct option list_options[] = {
+	bool raw_dump = false;
+	struct option list_options[] = {
+		OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"),
 		OPT_END()
 	};
 	const char * const list_usage[] = {
 		"perf list [hw|sw|cache|tracepoint|pmu|event_glob]",
 		NULL
 	};
+	set_option_flag(list_options, 0, "raw-dump", PARSE_OPT_HIDDEN);
 	argc = parse_options(argc, argv, list_options, list_usage,
 			     PARSE_OPT_STOP_AT_NON_OPTION);
 	setup_pager();
+	if (raw_dump) {
+		print_events(NULL, true);
+		return 0;
+	}
 	if (argc == 0) {
 		print_events(NULL, false);
 		return 0;
 	}
 	for (i = 0; i < argc; ++i) {
 		if (i)
 			putchar('\n');
 		if (strncmp(argv[i], "tracepoint", 10) == 0)
 			print_tracepoint_events(NULL, NULL, false);
 		else if (strcmp(argv[i], "hw") == 0 ||
 			 strcmp(argv[i], "hardware") == 0)
 			print_events_type(PERF_TYPE_HARDWARE);
 		else if (strcmp(argv[i], "sw") == 0 ||
 			 strcmp(argv[i], "software") == 0)
 			print_events_type(PERF_TYPE_SOFTWARE);
 		else if (strcmp(argv[i], "cache") == 0 ||
 			 strcmp(argv[i], "hwcache") == 0)
 			print_hwcache_events(NULL, false);
 		else if (strcmp(argv[i], "pmu") == 0)
 			print_pmu_events(NULL, false);
-		else if (strcmp(argv[i], "--raw-dump") == 0)
-			print_events(NULL, true);
 		else {
 			char *sep = strchr(argv[i], ':'), *s;
 			int sep_idx;
 			if (sep == NULL) {
 				print_events(argv[i], false);
 				continue;
 			}
 			sep_idx = sep - argv[i];
 			s = strdup(argv[i]);
 			if (s == NULL)
 				return -1;
 			s[sep_idx] = '\0';
 			print_tracepoint_events(s, s + sep_idx + 1, false);
 			free(s);
 		}
 	}
 	return 0;

tools/perf/util/probe-event.c

Diff comments View file @ ed9eb84

 /*
  * probe-event.c : perf-probe definition to probe_events format converter
  *
  * Written by Masami Hiramatsu <mhiramat@redhat.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
  *
  */
 #include <sys/utsname.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdarg.h>
 #include <limits.h>
 #include <elf.h>
 #include "util.h"
 #include "event.h"
 #include "strlist.h"
 #include "debug.h"
 #include "cache.h"
 #include "color.h"
 #include "symbol.h"
 #include "thread.h"
 #include <api/fs/debugfs.h>
 #include "trace-event.h"	/* For __maybe_unused */
 #include "probe-event.h"
 #include "probe-finder.h"
 #include "session.h"
 #define MAX_CMDLEN 256
 #define PERFPROBE_GROUP "probe"
 bool probe_event_dry_run;	/* Dry run flag */
 #define semantic_error(msg ...) pr_err("Semantic error :" msg)
 /* If there is no space to write, returns -E2BIG. */
 static int e_snprintf(char *str, size_t size, const char *format, ...)
 	__attribute__((format(printf, 3, 4)));
 static int e_snprintf(char *str, size_t size, const char *format, ...)
 {
 	int ret;
 	va_list ap;
 	va_start(ap, format);
 	ret = vsnprintf(str, size, format, ap);
 	va_end(ap);
 	if (ret >= (int)size)
 		ret = -E2BIG;
 	return ret;
 }
 static char *synthesize_perf_probe_point(struct perf_probe_point *pp);
 static void clear_probe_trace_event(struct probe_trace_event *tev);
 static struct machine *host_machine;
 /* Initialize symbol maps and path of vmlinux/modules */
 static int init_symbol_maps(bool user_only)
 {
 	int ret;
 	symbol_conf.sort_by_name = true;
 	ret = symbol__init(NULL);
 	if (ret < 0) {
 		pr_debug("Failed to init symbol map.\n");
 		goto out;
 	}
 	if (host_machine || user_only)	/* already initialized */
 		return 0;
 	if (symbol_conf.vmlinux_name)
 		pr_debug("Use vmlinux: %s\n", symbol_conf.vmlinux_name);
 	host_machine = machine__new_host();
 	if (!host_machine) {
 		pr_debug("machine__new_host() failed.\n");
 		symbol__exit();
 		ret = -1;
 	}
 out:
 	if (ret < 0)
 		pr_warning("Failed to init vmlinux path.\n");
 	return ret;
 }
 static void exit_symbol_maps(void)
 {
 	if (host_machine) {
 		machine__delete(host_machine);
 		host_machine = NULL;
 	}
 	symbol__exit();
 }
 static struct symbol *__find_kernel_function_by_name(const char *name,
 						     struct map **mapp)
 {
 	return machine__find_kernel_function_by_name(host_machine, name, mapp,
 						     NULL);
 }
 static struct symbol *__find_kernel_function(u64 addr, struct map **mapp)
 {
 	return machine__find_kernel_function(host_machine, addr, mapp, NULL);
 }
 static struct ref_reloc_sym *kernel_get_ref_reloc_sym(void)
 {
 	/* kmap->ref_reloc_sym should be set if host_machine is initialized */
 	struct kmap *kmap;
 	if (map__load(host_machine->vmlinux_maps[MAP__FUNCTION], NULL) < 0)
 		return NULL;
 	kmap = map__kmap(host_machine->vmlinux_maps[MAP__FUNCTION]);
 	return kmap->ref_reloc_sym;
 }
 static u64 kernel_get_symbol_address_by_name(const char *name, bool reloc)
 {
 	struct ref_reloc_sym *reloc_sym;
 	struct symbol *sym;
 	struct map *map;
 	/* ref_reloc_sym is just a label. Need a special fix*/
 	reloc_sym = kernel_get_ref_reloc_sym();
 	if (reloc_sym && strcmp(name, reloc_sym->name) == 0)
 		return (reloc) ? reloc_sym->addr : reloc_sym->unrelocated_addr;
 	else {
 		sym = __find_kernel_function_by_name(name, &map);
 		if (sym)
 			return map->unmap_ip(map, sym->start) -
 				(reloc) ? 0 : map->reloc;
 	}
 	return 0;
 }
 static struct map *kernel_get_module_map(const char *module)
 {
 	struct rb_node *nd;
 	struct map_groups *grp = &host_machine->kmaps;
 	/* A file path -- this is an offline module */
 	if (module && strchr(module, '/'))
 		return machine__new_module(host_machine, 0, module);
 	if (!module)
 		module = "kernel";
 	for (nd = rb_first(&grp->maps[MAP__FUNCTION]); nd; nd = rb_next(nd)) {
 		struct map *pos = rb_entry(nd, struct map, rb_node);
 		if (strncmp(pos->dso->short_name + 1, module,
 			    pos->dso->short_name_len - 2) == 0) {
 			return pos;
 		}
 	}
 	return NULL;
 }
 static struct dso *kernel_get_module_dso(const char *module)
 {
 	struct dso *dso;
 	struct map *map;
 	const char *vmlinux_name;
 	if (module) {
 		list_for_each_entry(dso, &host_machine->kernel_dsos.head,
 				    node) {
 			if (strncmp(dso->short_name + 1, module,
 				    dso->short_name_len - 2) == 0)
 				goto found;
 		}
 		pr_debug("Failed to find module %s.\n", module);
 		return NULL;
 	}
 	map = host_machine->vmlinux_maps[MAP__FUNCTION];
 	dso = map->dso;
 	vmlinux_name = symbol_conf.vmlinux_name;
 	if (vmlinux_name) {
 		if (dso__load_vmlinux(dso, map, vmlinux_name, false, NULL) <= 0)
 			return NULL;
 	} else {
 		if (dso__load_vmlinux_path(dso, map, NULL) <= 0) {
 			pr_debug("Failed to load kernel map.\n");
 			return NULL;
 		}
 	}
 found:
 	return dso;
 }
 const char *kernel_get_module_path(const char *module)
 {
 	struct dso *dso = kernel_get_module_dso(module);
 	return (dso) ? dso->long_name : NULL;
 }
 static int convert_exec_to_group(const char *exec, char **result)
 {
 	char *ptr1, *ptr2, *exec_copy;
 	char buf[64];
 	int ret;
 	exec_copy = strdup(exec);
 	if (!exec_copy)
 		return -ENOMEM;
 	ptr1 = basename(exec_copy);
 	if (!ptr1) {
 		ret = -EINVAL;
 		goto out;
 	}
 	ptr2 = strpbrk(ptr1, "-._");
 	if (ptr2)
 		*ptr2 = '\0';
 	ret = e_snprintf(buf, 64, "%s_%s", PERFPROBE_GROUP, ptr1);
 	if (ret < 0)
 		goto out;
 	*result = strdup(buf);
 	ret = *result ? 0 : -ENOMEM;
 out:
 	free(exec_copy);
 	return ret;
 }
 static void clear_probe_trace_events(struct probe_trace_event *tevs, int ntevs)
 {
 	int i;
 	for (i = 0; i < ntevs; i++)
 		clear_probe_trace_event(tevs + i);
 }
 #ifdef HAVE_DWARF_SUPPORT
 /* Open new debuginfo of given module */
 static struct debuginfo *open_debuginfo(const char *module, bool silent)
 {
 	const char *path = module;
 	struct debuginfo *ret;
 	if (!module || !strchr(module, '/')) {
 		path = kernel_get_module_path(module);
 		if (!path) {
 			if (!silent)
 				pr_err("Failed to find path of %s module.\n",
 				       module ?: "kernel");
 			return NULL;
 		}
 	}
 	ret = debuginfo__new(path);
 	if (!ret && !silent) {
 		pr_warning("The %s file has no debug information.\n", path);
 		if (!module || !strtailcmp(path, ".ko"))
 			pr_warning("Rebuild with CONFIG_DEBUG_INFO=y, ");
 		else
 			pr_warning("Rebuild with -g, ");
 		pr_warning("or install an appropriate debuginfo package.\n");
 	}
 	return ret;
 }
 static int get_text_start_address(const char *exec, unsigned long *address)
 {
 	Elf *elf;
 	GElf_Ehdr ehdr;
 	GElf_Shdr shdr;
 	int fd, ret = -ENOENT;
 	fd = open(exec, O_RDONLY);
 	if (fd < 0)
 		return -errno;
 	elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
 	if (elf == NULL)
 		return -EINVAL;
 	if (gelf_getehdr(elf, &ehdr) == NULL)
 		goto out;
 	if (!elf_section_by_name(elf, &ehdr, &shdr, ".text", NULL))
 		goto out;
 	*address = shdr.sh_addr - shdr.sh_offset;
 	ret = 0;
 out:
 	elf_end(elf);
 	return ret;
 }
 /*
  * Convert trace point to probe point with debuginfo
  */
 static int find_perf_probe_point_from_dwarf(struct probe_trace_point *tp,
 					    struct perf_probe_point *pp,
 					    bool is_kprobe)
 {
 	struct debuginfo *dinfo = NULL;
 	unsigned long stext = 0;
 	u64 addr = tp->address;
 	int ret = -ENOENT;
 	/* convert the address to dwarf address */
 	if (!is_kprobe) {
 		if (!addr) {
 			ret = -EINVAL;
 			goto error;
 		}
 		ret = get_text_start_address(tp->module, &stext);
 		if (ret < 0)
 			goto error;
 		addr += stext;
 	} else {
 		addr = kernel_get_symbol_address_by_name(tp->symbol, false);
 		if (addr == 0)
 			goto error;
 		addr += tp->offset;
 	}
 	pr_debug("try to find information at %" PRIx64 " in %s\n", addr,
 		 tp->module ? : "kernel");
 	dinfo = open_debuginfo(tp->module, verbose == 0);
 	if (dinfo) {
 		ret = debuginfo__find_probe_point(dinfo,
 						 (unsigned long)addr, pp);
 		debuginfo__delete(dinfo);
 	} else
 		ret = -ENOENT;
 	if (ret > 0) {
 		pp->retprobe = tp->retprobe;
 		return 0;
 	}
 error:
 	pr_debug("Failed to find corresponding probes from debuginfo.\n");
 	return ret ? : -ENOENT;
 }
 static int add_exec_to_probe_trace_events(struct probe_trace_event *tevs,
 					  int ntevs, const char *exec)
 {
 	int i, ret = 0;
 	unsigned long stext = 0;
 	if (!exec)
 		return 0;
 	ret = get_text_start_address(exec, &stext);
 	if (ret < 0)
 		return ret;
 	for (i = 0; i < ntevs && ret >= 0; i++) {
 		/* point.address is the addres of point.symbol + point.offset */
 		tevs[i].point.address -= stext;
 		tevs[i].point.module = strdup(exec);
 		if (!tevs[i].point.module) {
 			ret = -ENOMEM;
 			break;
 		}
 		tevs[i].uprobes = true;
 	}
 	return ret;
 }
 static int add_module_to_probe_trace_events(struct probe_trace_event *tevs,
 					    int ntevs, const char *module)
 {
 	int i, ret = 0;
 	char *tmp;
 	if (!module)
 		return 0;
 	tmp = strrchr(module, '/');
 	if (tmp) {
 		/* This is a module path -- get the module name */
 		module = strdup(tmp + 1);
 		if (!module)
 			return -ENOMEM;
 		tmp = strchr(module, '.');
 		if (tmp)
 			*tmp = '\0';
 		tmp = (char *)module;	/* For free() */
 	}
 	for (i = 0; i < ntevs; i++) {
 		tevs[i].point.module = strdup(module);
 		if (!tevs[i].point.module) {
 			ret = -ENOMEM;
 			break;
 		}
 	}
 	free(tmp);
 	return ret;
 }
 /* Post processing the probe events */
 static int post_process_probe_trace_events(struct probe_trace_event *tevs,
 					   int ntevs, const char *module,
 					   bool uprobe)
 {
 	struct ref_reloc_sym *reloc_sym;
 	char *tmp;
 	int i;
 	if (uprobe)
 		return add_exec_to_probe_trace_events(tevs, ntevs, module);
 	/* Note that currently ref_reloc_sym based probe is not for drivers */
 	if (module)
 		return add_module_to_probe_trace_events(tevs, ntevs, module);
 	reloc_sym = kernel_get_ref_reloc_sym();
 	if (!reloc_sym) {
 		pr_warning("Relocated base symbol is not found!\n");
 		return -EINVAL;
 	}
 	for (i = 0; i < ntevs; i++) {
 		if (tevs[i].point.address) {
 			tmp = strdup(reloc_sym->name);
 			if (!tmp)
 				return -ENOMEM;
 			free(tevs[i].point.symbol);
 			tevs[i].point.symbol = tmp;
 			tevs[i].point.offset = tevs[i].point.address -
 					       reloc_sym->unrelocated_addr;
 		}
 	}
 	return 0;
 }
 /* Try to find perf_probe_event with debuginfo */
 static int try_to_find_probe_trace_events(struct perf_probe_event *pev,
 					  struct probe_trace_event **tevs,
 					  int max_tevs, const char *target)
 {
 	bool need_dwarf = perf_probe_event_need_dwarf(pev);
 	struct debuginfo *dinfo;
 	int ntevs, ret = 0;
 	dinfo = open_debuginfo(target, !need_dwarf);
 	if (!dinfo) {
 		if (need_dwarf)
 			return -ENOENT;
 		pr_debug("Could not open debuginfo. Try to use symbols.\n");
 		return 0;
 	}
 	pr_debug("Try to find probe point from debuginfo.\n");
 	/* Searching trace events corresponding to a probe event */
 	ntevs = debuginfo__find_trace_events(dinfo, pev, tevs, max_tevs);
 	debuginfo__delete(dinfo);
 	if (ntevs > 0) {	/* Succeeded to find trace events */
 		pr_debug("Found %d probe_trace_events.\n", ntevs);
 		ret = post_process_probe_trace_events(*tevs, ntevs,
 							target, pev->uprobes);
 		if (ret < 0) {
 			clear_probe_trace_events(*tevs, ntevs);
 			zfree(tevs);
 		}
 		return ret < 0 ? ret : ntevs;
 	}
 	if (ntevs == 0)	{	/* No error but failed to find probe point. */
-		pr_warning("Probe point '%s' not found.\n",
+		pr_warning("Probe point '%s' not found in debuginfo.\n",
 			   synthesize_perf_probe_point(&pev->point));
-		return -ENOENT;
+		if (need_dwarf)
+			return -ENOENT;
+		return 0;
 	}
 	/* Error path : ntevs < 0 */
 	pr_debug("An error occurred in debuginfo analysis (%d).\n", ntevs);
 	if (ntevs == -EBADF) {
 		pr_warning("Warning: No dwarf info found in the vmlinux - "
 			"please rebuild kernel with CONFIG_DEBUG_INFO=y.\n");
 		if (!need_dwarf) {
 			pr_debug("Trying to use symbols.\n");
 			return 0;
 		}
 	}
 	return ntevs;
 }
 /*
  * Find a src file from a DWARF tag path. Prepend optional source path prefix
  * and chop off leading directories that do not exist. Result is passed back as
  * a newly allocated path on success.
  * Return 0 if file was found and readable, -errno otherwise.
  */
 static int get_real_path(const char *raw_path, const char *comp_dir,
 			 char **new_path)
 {
 	const char *prefix = symbol_conf.source_prefix;
 	if (!prefix) {
 		if (raw_path[0] != '/' && comp_dir)
 			/* If not an absolute path, try to use comp_dir */
 			prefix = comp_dir;
 		else {
 			if (access(raw_path, R_OK) == 0) {
 				*new_path = strdup(raw_path);
 				return 0;
 			} else
 				return -errno;
 		}
 	}
 	*new_path = malloc((strlen(prefix) + strlen(raw_path) + 2));
 	if (!*new_path)
 		return -ENOMEM;
 	for (;;) {
 		sprintf(*new_path, "%s/%s", prefix, raw_path);
 		if (access(*new_path, R_OK) == 0)
 			return 0;
 		if (!symbol_conf.source_prefix)
 			/* In case of searching comp_dir, don't retry */
 			return -errno;
 		switch (errno) {
 		case ENAMETOOLONG:
 		case ENOENT:
 		case EROFS:
 		case EFAULT:
 			raw_path = strchr(++raw_path, '/');
 			if (!raw_path) {
 				zfree(new_path);
 				return -ENOENT;
 			}
 			continue;
 		default:
 			zfree(new_path);
 			return -errno;
 		}
 	}
 }
 #define LINEBUF_SIZE 256
 #define NR_ADDITIONAL_LINES 2
 static int __show_one_line(FILE *fp, int l, bool skip, bool show_num)
 {
 	char buf[LINEBUF_SIZE], sbuf[STRERR_BUFSIZE];
 	const char *color = show_num ? "" : PERF_COLOR_BLUE;
 	const char *prefix = NULL;
 	do {
 		if (fgets(buf, LINEBUF_SIZE, fp) == NULL)
 			goto error;
 		if (skip)
 			continue;
 		if (!prefix) {
 			prefix = show_num ? "%7d  " : "         ";
 			color_fprintf(stdout, color, prefix, l);
 		}
 		color_fprintf(stdout, color, "%s", buf);
 	} while (strchr(buf, '\n') == NULL);
 	return 1;
 error:
 	if (ferror(fp)) {
 		pr_warning("File read error: %s\n",
 			   strerror_r(errno, sbuf, sizeof(sbuf)));
 		return -1;
 	}
 	return 0;
 }
 static int _show_one_line(FILE *fp, int l, bool skip, bool show_num)
 {
 	int rv = __show_one_line(fp, l, skip, show_num);
 	if (rv == 0) {
 		pr_warning("Source file is shorter than expected.\n");
 		rv = -1;
 	}
 	return rv;
 }
 #define show_one_line_with_num(f,l)	_show_one_line(f,l,false,true)
 #define show_one_line(f,l)		_show_one_line(f,l,false,false)
 #define skip_one_line(f,l)		_show_one_line(f,l,true,false)
 #define show_one_line_or_eof(f,l)	__show_one_line(f,l,false,false)
 /*
  * Show line-range always requires debuginfo to find source file and
  * line number.
  */
 static int __show_line_range(struct line_range *lr, const char *module)
 {
 	int l = 1;
 	struct int_node *ln;
 	struct debuginfo *dinfo;
 	FILE *fp;
 	int ret;
 	char *tmp;
 	char sbuf[STRERR_BUFSIZE];
 	/* Search a line range */
 	dinfo = open_debuginfo(module, false);
 	if (!dinfo)
 		return -ENOENT;
 	ret = debuginfo__find_line_range(dinfo, lr);
 	debuginfo__delete(dinfo);
 	if (ret == 0 || ret == -ENOENT) {
 		pr_warning("Specified source line is not found.\n");
 		return -ENOENT;
 	} else if (ret < 0) {
 		pr_warning("Debuginfo analysis failed.\n");
 		return ret;
 	}
 	/* Convert source file path */
 	tmp = lr->path;
 	ret = get_real_path(tmp, lr->comp_dir, &lr->path);
 	free(tmp);	/* Free old path */
 	if (ret < 0) {
 		pr_warning("Failed to find source file path.\n");
 		return ret;
 	}
 	setup_pager();
 	if (lr->function)
 		fprintf(stdout, "<%s@%s:%d>\n", lr->function, lr->path,
 			lr->start - lr->offset);
 	else
 		fprintf(stdout, "<%s:%d>\n", lr->path, lr->start);
 	fp = fopen(lr->path, "r");
 	if (fp == NULL) {
 		pr_warning("Failed to open %s: %s\n", lr->path,
 			   strerror_r(errno, sbuf, sizeof(sbuf)));
 		return -errno;
 	}
 	/* Skip to starting line number */
 	while (l < lr->start) {
 		ret = skip_one_line(fp, l++);
 		if (ret < 0)
 			goto end;
 	}
 	intlist__for_each(ln, lr->line_list) {
 		for (; ln->i > l; l++) {
 			ret = show_one_line(fp, l - lr->offset);
 			if (ret < 0)
 				goto end;
 		}
 		ret = show_one_line_with_num(fp, l++ - lr->offset);
 		if (ret < 0)
 			goto end;
 	}
 	if (lr->end == INT_MAX)
 		lr->end = l + NR_ADDITIONAL_LINES;
 	while (l <= lr->end) {
 		ret = show_one_line_or_eof(fp, l++ - lr->offset);
 		if (ret <= 0)
 			break;
 	}
 end:
 	fclose(fp);
 	return ret;
 }
 int show_line_range(struct line_range *lr, const char *module, bool user)
 {
 	int ret;
 	ret = init_symbol_maps(user);
 	if (ret < 0)
 		return ret;
 	ret = __show_line_range(lr, module);
 	exit_symbol_maps();
 	return ret;
 }
 static int show_available_vars_at(struct debuginfo *dinfo,
 				  struct perf_probe_event *pev,
 				  int max_vls, struct strfilter *_filter,
 				  bool externs)
 {
 	char *buf;
 	int ret, i, nvars;
 	struct str_node *node;
 	struct variable_list *vls = NULL, *vl;
 	const char *var;
 	buf = synthesize_perf_probe_point(&pev->point);
 	if (!buf)
 		return -EINVAL;
 	pr_debug("Searching variables at %s\n", buf);
 	ret = debuginfo__find_available_vars_at(dinfo, pev, &vls,
 						max_vls, externs);
 	if (ret <= 0) {
 		if (ret == 0 || ret == -ENOENT) {
 			pr_err("Failed to find the address of %s\n", buf);
 			ret = -ENOENT;
 		} else
 			pr_warning("Debuginfo analysis failed.\n");
 		goto end;
 	}
 	/* Some variables are found */
 	fprintf(stdout, "Available variables at %s\n", buf);
 	for (i = 0; i < ret; i++) {
 		vl = &vls[i];
 		/*
 		 * A probe point might be converted to
 		 * several trace points.
 		 */
 		fprintf(stdout, "\t@<%s+%lu>\n", vl->point.symbol,
 			vl->point.offset);
 		zfree(&vl->point.symbol);
 		nvars = 0;
 		if (vl->vars) {
 			strlist__for_each(node, vl->vars) {
 				var = strchr(node->s, '\t') + 1;
 				if (strfilter__compare(_filter, var)) {
 					fprintf(stdout, "\t\t%s\n", node->s);
 					nvars++;
 				}
 			}
 			strlist__delete(vl->vars);
 		}
 		if (nvars == 0)
 			fprintf(stdout, "\t\t(No matched variables)\n");
 	}
 	free(vls);
 end:
 	free(buf);
 	return ret;
 }
 /* Show available variables on given probe point */
 int show_available_vars(struct perf_probe_event *pevs, int npevs,
 			int max_vls, const char *module,
 			struct strfilter *_filter, bool externs)
 {
 	int i, ret = 0;
 	struct debuginfo *dinfo;
 	ret = init_symbol_maps(pevs->uprobes);
 	if (ret < 0)
 		return ret;
 	dinfo = open_debuginfo(module, false);
 	if (!dinfo) {
 		ret = -ENOENT;
 		goto out;
 	}
 	setup_pager();
 	for (i = 0; i < npevs && ret >= 0; i++)
 		ret = show_available_vars_at(dinfo, &pevs[i], max_vls, _filter,
 					     externs);
 	debuginfo__delete(dinfo);
 out:
 	exit_symbol_maps();
 	return ret;
 }
 #else	/* !HAVE_DWARF_SUPPORT */
 static int
 find_perf_probe_point_from_dwarf(struct probe_trace_point *tp __maybe_unused,
 				 struct perf_probe_point *pp __maybe_unused,
 				 bool is_kprobe __maybe_unused)
 {
 	return -ENOSYS;
 }
 static int try_to_find_probe_trace_events(struct perf_probe_event *pev,
 				struct probe_trace_event **tevs __maybe_unused,
 				int max_tevs __maybe_unused,
 				const char *target __maybe_unused)
 {
 	if (perf_probe_event_need_dwarf(pev)) {
 		pr_warning("Debuginfo-analysis is not supported.\n");
 		return -ENOSYS;
 	}
 	return 0;
 }
 int show_line_range(struct line_range *lr __maybe_unused,
 		    const char *module __maybe_unused,
 		    bool user __maybe_unused)
 {
 	pr_warning("Debuginfo-analysis is not supported.\n");
 	return -ENOSYS;
 }
 int show_available_vars(struct perf_probe_event *pevs __maybe_unused,
 			int npevs __maybe_unused, int max_vls __maybe_unused,
 			const char *module __maybe_unused,
 			struct strfilter *filter __maybe_unused,
 			bool externs __maybe_unused)
 {
 	pr_warning("Debuginfo-analysis is not supported.\n");
 	return -ENOSYS;
 }
 #endif
 void line_range__clear(struct line_range *lr)
 {
 	free(lr->function);
 	free(lr->file);
 	free(lr->path);
 	free(lr->comp_dir);
 	intlist__delete(lr->line_list);
 	memset(lr, 0, sizeof(*lr));
 }
 int line_range__init(struct line_range *lr)
 {
 	memset(lr, 0, sizeof(*lr));
 	lr->line_list = intlist__new(NULL);
 	if (!lr->line_list)
 		return -ENOMEM;
 	else
 		return 0;
 }
 static int parse_line_num(char **ptr, int *val, const char *what)
 {
 	const char *start = *ptr;
 	errno = 0;
 	*val = strtol(*ptr, ptr, 0);
 	if (errno || *ptr == start) {
 		semantic_error("'%s' is not a valid number.\n", what);
 		return -EINVAL;
 	}
 	return 0;
 }
 /*
  * Stuff 'lr' according to the line range described by 'arg'.
  * The line range syntax is described by:
  *
  *         SRC[:SLN[+NUM|-ELN]]
  *         FNC[@SRC][:SLN[+NUM|-ELN]]
  */
 int parse_line_range_desc(const char *arg, struct line_range *lr)
 {
 	char *range, *file, *name = strdup(arg);
 	int err;
 	if (!name)
 		return -ENOMEM;
 	lr->start = 0;
 	lr->end = INT_MAX;
 	range = strchr(name, ':');
 	if (range) {
 		*range++ = '\0';
 		err = parse_line_num(&range, &lr->start, "start line");
 		if (err)
 			goto err;
 		if (*range == '+' || *range == '-') {
 			const char c = *range++;
 			err = parse_line_num(&range, &lr->end, "end line");
 			if (err)
 				goto err;
 			if (c == '+') {
 				lr->end += lr->start;
 				/*
 				 * Adjust the number of lines here.
 				 * If the number of lines == 1, the
 				 * the end of line should be equal to
 				 * the start of line.
 				 */
 				lr->end--;
 			}
 		}
 		pr_debug("Line range is %d to %d\n", lr->start, lr->end);
 		err = -EINVAL;
 		if (lr->start > lr->end) {
 			semantic_error("Start line must be smaller"
 				       " than end line.\n");
 			goto err;
 		}
 		if (*range != '\0') {
 			semantic_error("Tailing with invalid str '%s'.\n", range);
 			goto err;
 		}
 	}
 	file = strchr(name, '@');
 	if (file) {
 		*file = '\0';
 		lr->file = strdup(++file);
 		if (lr->file == NULL) {
 			err = -ENOMEM;
 			goto err;
 		}
 		lr->function = name;
 	} else if (strchr(name, '.'))
 		lr->file = name;
 	else
 		lr->function = name;
 	return 0;
 err:
 	free(name);
 	return err;
 }
 /* Check the name is good for event/group */
 static bool check_event_name(const char *name)
 {
 	if (!isalpha(*name) && *name != '_')
 		return false;
 	while (*++name != '\0') {
 		if (!isalpha(*name) && !isdigit(*name) && *name != '_')
 			return false;
 	}
 	return true;
 }
 /* Parse probepoint definition. */
 static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev)
 {
 	struct perf_probe_point *pp = &pev->point;
 	char *ptr, *tmp;
 	char c, nc = 0;
 	/*
 	 * <Syntax>
 	 * perf probe [EVENT=]SRC[:LN|;PTN]
 	 * perf probe [EVENT=]FUNC[@SRC][+OFFS|%return|:LN|;PAT]
 	 *
 	 * TODO:Group name support
 	 */
 	ptr = strpbrk(arg, ";=@+%");
 	if (ptr && *ptr == '=') {	/* Event name */
 		*ptr = '\0';
 		tmp = ptr + 1;
 		if (strchr(arg, ':')) {
 			semantic_error("Group name is not supported yet.\n");
 			return -ENOTSUP;
 		}
 		if (!check_event_name(arg)) {
 			semantic_error("%s is bad for event name -it must "
 				       "follow C symbol-naming rule.\n", arg);
 			return -EINVAL;
 		}
 		pev->event = strdup(arg);
 		if (pev->event == NULL)
 			return -ENOMEM;
 		pev->group = NULL;
 		arg = tmp;
 	}
 	ptr = strpbrk(arg, ";:+@%");
 	if (ptr) {
 		nc = *ptr;
 		*ptr++ = '\0';
 	}
 	tmp = strdup(arg);
 	if (tmp == NULL)
 		return -ENOMEM;
 	/* Check arg is function or file and copy it */
 	if (strchr(tmp, '.'))	/* File */
 		pp->file = tmp;
 	else			/* Function */
 		pp->function = tmp;
 	/* Parse other options */
 	while (ptr) {
 		arg = ptr;
 		c = nc;
 		if (c == ';') {	/* Lazy pattern must be the last part */
 			pp->lazy_line = strdup(arg);
 			if (pp->lazy_line == NULL)
 				return -ENOMEM;
 			break;
 		}
 		ptr = strpbrk(arg, ";:+@%");
 		if (ptr) {
 			nc = *ptr;
 			*ptr++ = '\0';
 		}
 		switch (c) {
 		case ':':	/* Line number */
 			pp->line = strtoul(arg, &tmp, 0);
 			if (*tmp != '\0') {
 				semantic_error("There is non-digit char"
 					       " in line number.\n");
 				return -EINVAL;
 			}
 			break;
 		case '+':	/* Byte offset from a symbol */
 			pp->offset = strtoul(arg, &tmp, 0);
 			if (*tmp != '\0') {
 				semantic_error("There is non-digit character"
 						" in offset.\n");
 				return -EINVAL;
 			}
 			break;
 		case '@':	/* File name */
 			if (pp->file) {
 				semantic_error("SRC@SRC is not allowed.\n");
 				return -EINVAL;
 			}
 			pp->file = strdup(arg);
 			if (pp->file == NULL)
 				return -ENOMEM;
 			break;
 		case '%':	/* Probe places */
 			if (strcmp(arg, "return") == 0) {
 				pp->retprobe = 1;
 			} else {	/* Others not supported yet */
 				semantic_error("%%%s is not supported.\n", arg);
 				return -ENOTSUP;
 			}
 			break;
 		default:	/* Buggy case */
 			pr_err("This program has a bug at %s:%d.\n",
 				__FILE__, __LINE__);
 			return -ENOTSUP;
 			break;
 		}
 	}
 	/* Exclusion check */
 	if (pp->lazy_line && pp->line) {
 		semantic_error("Lazy pattern can't be used with"
 			       " line number.\n");
 		return -EINVAL;
 	}
 	if (pp->lazy_line && pp->offset) {
 		semantic_error("Lazy pattern can't be used with offset.\n");
 		return -EINVAL;
 	}
 	if (pp->line && pp->offset) {
 		semantic_error("Offset can't be used with line number.\n");
 		return -EINVAL;
 	}
 	if (!pp->line && !pp->lazy_line && pp->file && !pp->function) {
 		semantic_error("File always requires line number or "
 			       "lazy pattern.\n");
 		return -EINVAL;
 	}
 	if (pp->offset && !pp->function) {
 		semantic_error("Offset requires an entry function.\n");
 		return -EINVAL;
 	}
 	if (pp->retprobe && !pp->function) {
 		semantic_error("Return probe requires an entry function.\n");
 		return -EINVAL;
 	}
 	if ((pp->offset || pp->line || pp->lazy_line) && pp->retprobe) {
 		semantic_error("Offset/Line/Lazy pattern can't be used with "
 			       "return probe.\n");
 		return -EINVAL;
 	}
 	pr_debug("symbol:%s file:%s line:%d offset:%lu return:%d lazy:%s\n",
 		 pp->function, pp->file, pp->line, pp->offset, pp->retprobe,
 		 pp->lazy_line);
 	return 0;
 }
 /* Parse perf-probe event argument */
 static int parse_perf_probe_arg(char *str, struct perf_probe_arg *arg)
 {
 	char *tmp, *goodname;
 	struct perf_probe_arg_field **fieldp;
 	pr_debug("parsing arg: %s into ", str);
 	tmp = strchr(str, '=');
 	if (tmp) {
 		arg->name = strndup(str, tmp - str);
 		if (arg->name == NULL)
 			return -ENOMEM;
 		pr_debug("name:%s ", arg->name);
 		str = tmp + 1;
 	}
 	tmp = strchr(str, ':');
 	if (tmp) {	/* Type setting */
 		*tmp = '\0';
 		arg->type = strdup(tmp + 1);
 		if (arg->type == NULL)
 			return -ENOMEM;
 		pr_debug("type:%s ", arg->type);
 	}
 	tmp = strpbrk(str, "-.[");
 	if (!is_c_varname(str) || !tmp) {
 		/* A variable, register, symbol or special value */
 		arg->var = strdup(str);
 		if (arg->var == NULL)
 			return -ENOMEM;
 		pr_debug("%s\n", arg->var);
 		return 0;
 	}
 	/* Structure fields or array element */
 	arg->var = strndup(str, tmp - str);
 	if (arg->var == NULL)
 		return -ENOMEM;
 	goodname = arg->var;
 	pr_debug("%s, ", arg->var);
 	fieldp = &arg->field;
 	do {
 		*fieldp = zalloc(sizeof(struct perf_probe_arg_field));
 		if (*fieldp == NULL)
 			return -ENOMEM;
 		if (*tmp == '[') {	/* Array */
 			str = tmp;
 			(*fieldp)->index = strtol(str + 1, &tmp, 0);
 			(*fieldp)->ref = true;
 			if (*tmp != ']' || tmp == str + 1) {
 				semantic_error("Array index must be a"
 						" number.\n");
 				return -EINVAL;
 			}
 			tmp++;
 			if (*tmp == '\0')
 				tmp = NULL;
 		} else {		/* Structure */
 			if (*tmp == '.') {
 				str = tmp + 1;
 				(*fieldp)->ref = false;
 			} else if (tmp[1] == '>') {
 				str = tmp + 2;
 				(*fieldp)->ref = true;
 			} else {
 				semantic_error("Argument parse error: %s\n",
 					       str);
 				return -EINVAL;
 			}
 			tmp = strpbrk(str, "-.[");
 		}
 		if (tmp) {
 			(*fieldp)->name = strndup(str, tmp - str);
 			if ((*fieldp)->name == NULL)
 				return -ENOMEM;
 			if (*str != '[')
 				goodname = (*fieldp)->name;
 			pr_debug("%s(%d), ", (*fieldp)->name, (*fieldp)->ref);
 			fieldp = &(*fieldp)->next;
 		}
 	} while (tmp);
 	(*fieldp)->name = strdup(str);
 	if ((*fieldp)->name == NULL)
 		return -ENOMEM;
 	if (*str != '[')
 		goodname = (*fieldp)->name;
 	pr_debug("%s(%d)\n", (*fieldp)->name, (*fieldp)->ref);
 	/* If no name is specified, set the last field name (not array index)*/
 	if (!arg->name) {
 		arg->name = strdup(goodname);
 		if (arg->name == NULL)
 			return -ENOMEM;
 	}
 	return 0;
 }
 /* Parse perf-probe event command */
 int parse_perf_probe_command(const char *cmd, struct perf_probe_event *pev)
 {
 	char **argv;
 	int argc, i, ret = 0;
 	argv = argv_split(cmd, &argc);
 	if (!argv) {
 		pr_debug("Failed to split arguments.\n");
 		return -ENOMEM;
 	}
 	if (argc - 1 > MAX_PROBE_ARGS) {
 		semantic_error("Too many probe arguments (%d).\n", argc - 1);
 		ret = -ERANGE;
 		goto out;
 	}
 	/* Parse probe point */
 	ret = parse_perf_probe_point(argv[0], pev);
 	if (ret < 0)
 		goto out;
 	/* Copy arguments and ensure return probe has no C argument */
 	pev->nargs = argc - 1;
 	pev->args = zalloc(sizeof(struct perf_probe_arg) * pev->nargs);
 	if (pev->args == NULL) {
 		ret = -ENOMEM;
 		goto out;
 	}
 	for (i = 0; i < pev->nargs && ret >= 0; i++) {
 		ret = parse_perf_probe_arg(argv[i + 1], &pev->args[i]);
 		if (ret >= 0 &&
 		    is_c_varname(pev->args[i].var) && pev->point.retprobe) {
 			semantic_error("You can't specify local variable for"
 				       " kretprobe.\n");
 			ret = -EINVAL;
 		}
 	}
 out:
 	argv_free(argv);
 	return ret;
 }
 /* Return true if this perf_probe_event requires debuginfo */
 bool perf_probe_event_need_dwarf(struct perf_probe_event *pev)
 {
 	int i;
 	if (pev->point.file || pev->point.line || pev->point.lazy_line)
 		return true;
 	for (i = 0; i < pev->nargs; i++)
 		if (is_c_varname(pev->args[i].var))
 			return true;
 	return false;
 }
 /* Parse probe_events event into struct probe_point */
 static int parse_probe_trace_command(const char *cmd,
 				     struct probe_trace_event *tev)
 {
 	struct probe_trace_point *tp = &tev->point;
 	char pr;
 	char *p;
 	char *argv0_str = NULL, *fmt, *fmt1_str, *fmt2_str, *fmt3_str;
 	int ret, i, argc;
 	char **argv;
 	pr_debug("Parsing probe_events: %s\n", cmd);
 	argv = argv_split(cmd, &argc);
 	if (!argv) {
 		pr_debug("Failed to split arguments.\n");
 		return -ENOMEM;
 	}
 	if (argc < 2) {
 		semantic_error("Too few probe arguments.\n");
 		ret = -ERANGE;
 		goto out;
 	}
 	/* Scan event and group name. */
 	argv0_str = strdup(argv[0]);
 	if (argv0_str == NULL) {
 		ret = -ENOMEM;
 		goto out;
 	}
 	fmt1_str = strtok_r(argv0_str, ":", &fmt);
 	fmt2_str = strtok_r(NULL, "/", &fmt);
 	fmt3_str = strtok_r(NULL, " \t", &fmt);
 	if (fmt1_str == NULL || strlen(fmt1_str) != 1 || fmt2_str == NULL
 	    || fmt3_str == NULL) {
 		semantic_error("Failed to parse event name: %s\n", argv[0]);
 		ret = -EINVAL;
 		goto out;
 	}
 	pr = fmt1_str[0];
 	tev->group = strdup(fmt2_str);
 	tev->event = strdup(fmt3_str);
 	if (tev->group == NULL || tev->event == NULL) {
 		ret = -ENOMEM;
 		goto out;
 	}
 	pr_debug("Group:%s Event:%s probe:%c\n", tev->group, tev->event, pr);
 	tp->retprobe = (pr == 'r');
 	/* Scan module name(if there), function name and offset */
 	p = strchr(argv[1], ':');
 	if (p) {
 		tp->module = strndup(argv[1], p - argv[1]);
 		p++;
 	} else
 		p = argv[1];
 	fmt1_str = strtok_r(p, "+", &fmt);
 	if (fmt1_str[0] == '0')	/* only the address started with 0x */
 		tp->address = strtoul(fmt1_str, NULL, 0);
 	else {
 		/* Only the symbol-based probe has offset */
 		tp->symbol = strdup(fmt1_str);
 		if (tp->symbol == NULL) {
 			ret = -ENOMEM;
 			goto out;
 		}
 		fmt2_str = strtok_r(NULL, "", &fmt);
 		if (fmt2_str == NULL)
 			tp->offset = 0;
 		else
 			tp->offset = strtoul(fmt2_str, NULL, 10);
 	}
 	tev->nargs = argc - 2;
 	tev->args = zalloc(sizeof(struct probe_trace_arg) * tev->nargs);
 	if (tev->args == NULL) {
 		ret = -ENOMEM;
 		goto out;
 	}
 	for (i = 0; i < tev->nargs; i++) {
 		p = strchr(argv[i + 2], '=');
 		if (p)	/* We don't need which register is assigned. */
 			*p++ = '\0';
 		else
 			p = argv[i + 2];
 		tev->args[i].name = strdup(argv[i + 2]);
 		/* TODO: parse regs and offset */
 		tev->args[i].value = strdup(p);
 		if (tev->args[i].name == NULL || tev->args[i].value == NULL) {
 			ret = -ENOMEM;
 			goto out;
 		}
 	}
 	ret = 0;
 out:
 	free(argv0_str);
 	argv_free(argv);
 	return ret;
 }
 /* Compose only probe arg */
 int synthesize_perf_probe_arg(struct perf_probe_arg *pa, char *buf, size_t len)
 {
 	struct perf_probe_arg_field *field = pa->field;
 	int ret;
 	char *tmp = buf;
 	if (pa->name && pa->var)
 		ret = e_snprintf(tmp, len, "%s=%s", pa->name, pa->var);
 	else
 		ret = e_snprintf(tmp, len, "%s", pa->name ? pa->name : pa->var);
 	if (ret <= 0)
 		goto error;
 	tmp += ret;
 	len -= ret;
 	while (field) {
 		if (field->name[0] == '[')
 			ret = e_snprintf(tmp, len, "%s", field->name);
 		else
 			ret = e_snprintf(tmp, len, "%s%s",
 					 field->ref ? "->" : ".", field->name);
 		if (ret <= 0)
 			goto error;
 		tmp += ret;
 		len -= ret;
 		field = field->next;
 	}
 	if (pa->type) {
 		ret = e_snprintf(tmp, len, ":%s", pa->type);
 		if (ret <= 0)
 			goto error;
 		tmp += ret;
 		len -= ret;
 	}
 	return tmp - buf;
 error:
 	pr_debug("Failed to synthesize perf probe argument: %d\n", ret);
 	return ret;
 }
 /* Compose only probe point (not argument) */
 static char *synthesize_perf_probe_point(struct perf_probe_point *pp)
 {
 	char *buf, *tmp;
 	char offs[32] = "", line[32] = "", file[32] = "";
 	int ret, len;
 	buf = zalloc(MAX_CMDLEN);
 	if (buf == NULL) {
 		ret = -ENOMEM;
 		goto error;
 	}
 	if (pp->offset) {
 		ret = e_snprintf(offs, 32, "+%lu", pp->offset);
 		if (ret <= 0)
 			goto error;
 	}
 	if (pp->line) {
 		ret = e_snprintf(line, 32, ":%d", pp->line);
 		if (ret <= 0)
 			goto error;
 	}
 	if (pp->file) {
 		tmp = pp->file;
 		len = strlen(tmp);
 		if (len > 30) {
 			tmp = strchr(pp->file + len - 30, '/');
 			tmp = tmp ? tmp + 1 : pp->file + len - 30;
 		}
 		ret = e_snprintf(file, 32, "@%s", tmp);
 		if (ret <= 0)
 			goto error;
 	}
 	if (pp->function)
 		ret = e_snprintf(buf, MAX_CMDLEN, "%s%s%s%s%s", pp->function,
 				 offs, pp->retprobe ? "%return" : "", line,
 				 file);
 	else
 		ret = e_snprintf(buf, MAX_CMDLEN, "%s%s", file, line);
 	if (ret <= 0)
 		goto error;
 	return buf;
 error:
 	pr_debug("Failed to synthesize perf probe point: %d\n", ret);
 	free(buf);
 	return NULL;
 }
 #if 0
 char *synthesize_perf_probe_command(struct perf_probe_event *pev)
 {
 	char *buf;
 	int i, len, ret;
 	buf = synthesize_perf_probe_point(&pev->point);
 	if (!buf)
 		return NULL;
 	len = strlen(buf);
 	for (i = 0; i < pev->nargs; i++) {
 		ret = e_snprintf(&buf[len], MAX_CMDLEN - len, " %s",
 				 pev->args[i].name);
 		if (ret <= 0) {
 			free(buf);
 			return NULL;
 		}
 		len += ret;
 	}
 	return buf;
 }
 #endif
 static int __synthesize_probe_trace_arg_ref(struct probe_trace_arg_ref *ref,
 					     char **buf, size_t *buflen,
 					     int depth)
 {
 	int ret;
 	if (ref->next) {
 		depth = __synthesize_probe_trace_arg_ref(ref->next, buf,
 							 buflen, depth + 1);
 		if (depth < 0)
 			goto out;
 	}
 	ret = e_snprintf(*buf, *buflen, "%+ld(", ref->offset);
 	if (ret < 0)
 		depth = ret;
 	else {
 		*buf += ret;
 		*buflen -= ret;
 	}
 out:
 	return depth;
 }
 static int synthesize_probe_trace_arg(struct probe_trace_arg *arg,
 				       char *buf, size_t buflen)
 {
 	struct probe_trace_arg_ref *ref = arg->ref;
 	int ret, depth = 0;
 	char *tmp = buf;
 	/* Argument name or separator */
 	if (arg->name)
 		ret = e_snprintf(buf, buflen, " %s=", arg->name);
 	else
 		ret = e_snprintf(buf, buflen, " ");
 	if (ret < 0)
 		return ret;
 	buf += ret;
 	buflen -= ret;
 	/* Special case: @XXX */
 	if (arg->value[0] == '@' && arg->ref)
 			ref = ref->next;
 	/* Dereferencing arguments */
 	if (ref) {
 		depth = __synthesize_probe_trace_arg_ref(ref, &buf,
 							  &buflen, 1);
 		if (depth < 0)
 			return depth;
 	}
 	/* Print argument value */
 	if (arg->value[0] == '@' && arg->ref)
 		ret = e_snprintf(buf, buflen, "%s%+ld", arg->value,
 				 arg->ref->offset);
 	else
 		ret = e_snprintf(buf, buflen, "%s", arg->value);
 	if (ret < 0)
 		return ret;
 	buf += ret;
 	buflen -= ret;
 	/* Closing */
 	while (depth--) {
 		ret = e_snprintf(buf, buflen, ")");
 		if (ret < 0)
 			return ret;
 		buf += ret;
 		buflen -= ret;
 	}
 	/* Print argument type */
 	if (arg->type) {
 		ret = e_snprintf(buf, buflen, ":%s", arg->type);
 		if (ret <= 0)
 			return ret;
 		buf += ret;
 	}
 	return buf - tmp;
 }
 char *synthesize_probe_trace_command(struct probe_trace_event *tev)
 {
 	struct probe_trace_point *tp = &tev->point;
 	char *buf;
 	int i, len, ret;
 	buf = zalloc(MAX_CMDLEN);
 	if (buf == NULL)
 		return NULL;
 	len = e_snprintf(buf, MAX_CMDLEN, "%c:%s/%s ", tp->retprobe ? 'r' : 'p',
 			 tev->group, tev->event);
 	if (len <= 0)
 		goto error;
 	/* Uprobes must have tp->address and tp->module */
 	if (tev->uprobes && (!tp->address || !tp->module))
 		goto error;
 	/* Use the tp->address for uprobes */
 	if (tev->uprobes)
 		ret = e_snprintf(buf + len, MAX_CMDLEN - len, "%s:0x%lx",
 				 tp->module, tp->address);
 	else
 		ret = e_snprintf(buf + len, MAX_CMDLEN - len, "%s%s%s+%lu",
 				 tp->module ?: "", tp->module ? ":" : "",
 				 tp->symbol, tp->offset);
 	if (ret <= 0)
 		goto error;
 	len += ret;
 	for (i = 0; i < tev->nargs; i++) {
 		ret = synthesize_probe_trace_arg(&tev->args[i], buf + len,
 						  MAX_CMDLEN - len);
 		if (ret <= 0)
 			goto error;
 		len += ret;
 	}
 	return buf;
 error:
 	free(buf);
 	return NULL;
 }
 static int find_perf_probe_point_from_map(struct probe_trace_point *tp,
 					  struct perf_probe_point *pp,
 					  bool is_kprobe)
 {
 	struct symbol *sym = NULL;
 	struct map *map;
 	u64 addr;
 	int ret = -ENOENT;
 	if (!is_kprobe) {
 		map = dso__new_map(tp->module);
 		if (!map)
 			goto out;
 		addr = tp->address;
 		sym = map__find_symbol(map, addr, NULL);
 	} else {
 		addr = kernel_get_symbol_address_by_name(tp->symbol, true);
 		if (addr) {
 			addr += tp->offset;
 			sym = __find_kernel_function(addr, &map);
 		}
 	}
 	if (!sym)
 		goto out;
 	pp->retprobe = tp->retprobe;
 	pp->offset = addr - map->unmap_ip(map, sym->start);
 	pp->function = strdup(sym->name);
 	ret = pp->function ? 0 : -ENOMEM;
 out:
 	if (map && !is_kprobe) {
 		dso__delete(map->dso);
 		map__delete(map);
 	}
 	return ret;
 }
 static int convert_to_perf_probe_point(struct probe_trace_point *tp,
 					struct perf_probe_point *pp,
 					bool is_kprobe)
 {
 	char buf[128];
 	int ret;
 	ret = find_perf_probe_point_from_dwarf(tp, pp, is_kprobe);
 	if (!ret)
 		return 0;
 	ret = find_perf_probe_point_from_map(tp, pp, is_kprobe);
 	if (!ret)
 		return 0;
 	pr_debug("Failed to find probe point from both of dwarf and map.\n");
 	if (tp->symbol) {
 		pp->function = strdup(tp->symbol);
 		pp->offset = tp->offset;
 	} else if (!tp->module && !is_kprobe) {
 		ret = e_snprintf(buf, 128, "0x%" PRIx64, (u64)tp->address);
 		if (ret < 0)
 			return ret;
 		pp->function = strdup(buf);
 		pp->offset = 0;
 	}
 	if (pp->function == NULL)
 		return -ENOMEM;
 	pp->retprobe = tp->retprobe;
 	return 0;
 }
 static int convert_to_perf_probe_event(struct probe_trace_event *tev,
 			       struct perf_probe_event *pev, bool is_kprobe)
 {
 	char buf[64] = "";
 	int i, ret;
 	/* Convert event/group name */
 	pev->event = strdup(tev->event);
 	pev->group = strdup(tev->group);
 	if (pev->event == NULL || pev->group == NULL)
 		return -ENOMEM;
 	/* Convert trace_point to probe_point */
 	ret = convert_to_perf_probe_point(&tev->point, &pev->point, is_kprobe);
 	if (ret < 0)
 		return ret;
 	/* Convert trace_arg to probe_arg */
 	pev->nargs = tev->nargs;
 	pev->args = zalloc(sizeof(struct perf_probe_arg) * pev->nargs);
 	if (pev->args == NULL)
 		return -ENOMEM;
 	for (i = 0; i < tev->nargs && ret >= 0; i++) {
 		if (tev->args[i].name)
 			pev->args[i].name = strdup(tev->args[i].name);
 		else {
 			ret = synthesize_probe_trace_arg(&tev->args[i],
 							  buf, 64);
 			pev->args[i].name = strdup(buf);
 		}
 		if (pev->args[i].name == NULL && ret >= 0)
 			ret = -ENOMEM;
 	}
 	if (ret < 0)
 		clear_perf_probe_event(pev);
 	return ret;
 }
 void clear_perf_probe_event(struct perf_probe_event *pev)
 {
 	struct perf_probe_point *pp = &pev->point;
 	struct perf_probe_arg_field *field, *next;
 	int i;
 	free(pev->event);
 	free(pev->group);
 	free(pp->file);
 	free(pp->function);
 	free(pp->lazy_line);
 	for (i = 0; i < pev->nargs; i++) {
 		free(pev->args[i].name);
 		free(pev->args[i].var);
 		free(pev->args[i].type);
 		field = pev->args[i].field;
 		while (field) {
 			next = field->next;
 			zfree(&field->name);
 			free(field);
 			field = next;
 		}
 	}
 	free(pev->args);
 	memset(pev, 0, sizeof(*pev));
 }
 static void clear_probe_trace_event(struct probe_trace_event *tev)
 {
 	struct probe_trace_arg_ref *ref, *next;
 	int i;
 	free(tev->event);
 	free(tev->group);
 	free(tev->point.symbol);
 	free(tev->point.module);
 	for (i = 0; i < tev->nargs; i++) {
 		free(tev->args[i].name);
 		free(tev->args[i].value);
 		free(tev->args[i].type);
 		ref = tev->args[i].ref;
 		while (ref) {
 			next = ref->next;
 			free(ref);
 			ref = next;
 		}
 	}
 	free(tev->args);
 	memset(tev, 0, sizeof(*tev));
 }
 static void print_open_warning(int err, bool is_kprobe)
 {
 	char sbuf[STRERR_BUFSIZE];
 	if (err == -ENOENT) {
 		const char *config;
 		if (!is_kprobe)
 			config = "CONFIG_UPROBE_EVENTS";
 		else
 			config = "CONFIG_KPROBE_EVENTS";
 		pr_warning("%cprobe_events file does not exist"
 			   " - please rebuild kernel with %s.\n",
 			   is_kprobe ? 'k' : 'u', config);
 	} else if (err == -ENOTSUP)
 		pr_warning("Debugfs is not mounted.\n");
 	else
 		pr_warning("Failed to open %cprobe_events: %s\n",
 			   is_kprobe ? 'k' : 'u',
 			   strerror_r(-err, sbuf, sizeof(sbuf)));
 }
 static void print_both_open_warning(int kerr, int uerr)
 {
 	/* Both kprobes and uprobes are disabled, warn it. */
 	if (kerr == -ENOTSUP && uerr == -ENOTSUP)
 		pr_warning("Debugfs is not mounted.\n");
 	else if (kerr == -ENOENT && uerr == -ENOENT)
 		pr_warning("Please rebuild kernel with CONFIG_KPROBE_EVENTS "
 			   "or/and CONFIG_UPROBE_EVENTS.\n");
 	else {
 		char sbuf[STRERR_BUFSIZE];
 		pr_warning("Failed to open kprobe events: %s.\n",
 			   strerror_r(-kerr, sbuf, sizeof(sbuf)));
 		pr_warning("Failed to open uprobe events: %s.\n",
 			   strerror_r(-uerr, sbuf, sizeof(sbuf)));
 	}
 }
 static int open_probe_events(const char *trace_file, bool readwrite)
 {
 	char buf[PATH_MAX];
 	const char *__debugfs;
 	int ret;
 	__debugfs = debugfs_find_mountpoint();
 	if (__debugfs == NULL)
 		return -ENOTSUP;
 	ret = e_snprintf(buf, PATH_MAX, "%s/%s", __debugfs, trace_file);
 	if (ret >= 0) {
 		pr_debug("Opening %s write=%d\n", buf, readwrite);
 		if (readwrite && !probe_event_dry_run)
 			ret = open(buf, O_RDWR, O_APPEND);
 		else
 			ret = open(buf, O_RDONLY, 0);
 		if (ret < 0)
 			ret = -errno;
 	}
 	return ret;
 }
 static int open_kprobe_events(bool readwrite)
 {
 	return open_probe_events("tracing/kprobe_events", readwrite);
 }
 static int open_uprobe_events(bool readwrite)
 {
 	return open_probe_events("tracing/uprobe_events", readwrite);
 }
 /* Get raw string list of current kprobe_events  or uprobe_events */
 static struct strlist *get_probe_trace_command_rawlist(int fd)
 {
 	int ret, idx;
 	FILE *fp;
 	char buf[MAX_CMDLEN];
 	char *p;
 	struct strlist *sl;
 	sl = strlist__new(true, NULL);
 	fp = fdopen(dup(fd), "r");
 	while (!feof(fp)) {
 		p = fgets(buf, MAX_CMDLEN, fp);
 		if (!p)
 			break;
 		idx = strlen(p) - 1;
 		if (p[idx] == '\n')
 			p[idx] = '\0';
 		ret = strlist__add(sl, buf);
 		if (ret < 0) {
 			pr_debug("strlist__add failed (%d)\n", ret);
 			strlist__delete(sl);
 			return NULL;
 		}
 	}
 	fclose(fp);
 	return sl;
 }
 /* Show an event */
 static int show_perf_probe_event(struct perf_probe_event *pev,
 				 const char *module)
 {
 	int i, ret;
 	char buf[128];
 	char *place;
 	/* Synthesize only event probe point */
 	place = synthesize_perf_probe_point(&pev->point);
 	if (!place)
 		return -EINVAL;
 	ret = e_snprintf(buf, 128, "%s:%s", pev->group, pev->event);
 	if (ret < 0)
 		return ret;
 	pr_info("  %-20s (on %s", buf, place);
 	if (module)
 		pr_info(" in %s", module);
 	if (pev->nargs > 0) {
 		pr_info(" with");
 		for (i = 0; i < pev->nargs; i++) {
 			ret = synthesize_perf_probe_arg(&pev->args[i],
 							buf, 128);
 			if (ret < 0)
 				break;
 			pr_info(" %s", buf);
 		}
 	}
 	pr_info(")\n");
 	free(place);
 	return ret;
 }
 static int __show_perf_probe_events(int fd, bool is_kprobe)
 {
 	int ret = 0;
 	struct probe_trace_event tev;
 	struct perf_probe_event pev;
 	struct strlist *rawlist;
 	struct str_node *ent;
 	memset(&tev, 0, sizeof(tev));
 	memset(&pev, 0, sizeof(pev));
 	rawlist = get_probe_trace_command_rawlist(fd);
 	if (!rawlist)
 		return -ENOMEM;
 	strlist__for_each(ent, rawlist) {
 		ret = parse_probe_trace_command(ent->s, &tev);
 		if (ret >= 0) {
 			ret = convert_to_perf_probe_event(&tev, &pev,
 								is_kprobe);
 			if (ret >= 0)
 				ret = show_perf_probe_event(&pev,
 							    tev.point.module);
 		}
 		clear_perf_probe_event(&pev);
 		clear_probe_trace_event(&tev);
 		if (ret < 0)
 			break;
 	}
 	strlist__delete(rawlist);
 	return ret;
 }
 /* List up current perf-probe events */
 int show_perf_probe_events(void)
 {
 	int kp_fd, up_fd, ret;
 	setup_pager();
 	ret = init_symbol_maps(false);
 	if (ret < 0)
 		return ret;
 	kp_fd = open_kprobe_events(false);
 	if (kp_fd >= 0) {
 		ret = __show_perf_probe_events(kp_fd, true);
 		close(kp_fd);
 		if (ret < 0)
 			goto out;
 	}
 	up_fd = open_uprobe_events(false);
 	if (kp_fd < 0 && up_fd < 0) {
 		print_both_open_warning(kp_fd, up_fd);
 		ret = kp_fd;
 		goto out;
 	}
 	if (up_fd >= 0) {
 		ret = __show_perf_probe_events(up_fd, false);
 		close(up_fd);
 	}
 out:
 	exit_symbol_maps();
 	return ret;
 }
 /* Get current perf-probe event names */
 static struct strlist *get_probe_trace_event_names(int fd, bool include_group)
 {
 	char buf[128];
 	struct strlist *sl, *rawlist;
 	struct str_node *ent;
 	struct probe_trace_event tev;
 	int ret = 0;
 	memset(&tev, 0, sizeof(tev));
 	rawlist = get_probe_trace_command_rawlist(fd);
 	if (!rawlist)
 		return NULL;
 	sl = strlist__new(true, NULL);
 	strlist__for_each(ent, rawlist) {
 		ret = parse_probe_trace_command(ent->s, &tev);
 		if (ret < 0)
 			break;
 		if (include_group) {
 			ret = e_snprintf(buf, 128, "%s:%s", tev.group,
 					tev.event);
 			if (ret >= 0)
 				ret = strlist__add(sl, buf);
 		} else
 			ret = strlist__add(sl, tev.event);
 		clear_probe_trace_event(&tev);
 		if (ret < 0)
 			break;
 	}
 	strlist__delete(rawlist);
 	if (ret < 0) {
 		strlist__delete(sl);
 		return NULL;
 	}
 	return sl;
 }
 static int write_probe_trace_event(int fd, struct probe_trace_event *tev)
 {
 	int ret = 0;
 	char *buf = synthesize_probe_trace_command(tev);
 	char sbuf[STRERR_BUFSIZE];
 	if (!buf) {
 		pr_debug("Failed to synthesize probe trace event.\n");
 		return -EINVAL;
 	}
 	pr_debug("Writing event: %s\n", buf);
 	if (!probe_event_dry_run) {
 		ret = write(fd, buf, strlen(buf));
 		if (ret <= 0)
 			pr_warning("Failed to write event: %s\n",
 				   strerror_r(errno, sbuf, sizeof(sbuf)));
 	}
 	free(buf);
 	return ret;
 }
 static int get_new_event_name(char *buf, size_t len, const char *base,
 			      struct strlist *namelist, bool allow_suffix)
 {
 	int i, ret;
 	/* Try no suffix */
 	ret = e_snprintf(buf, len, "%s", base);
 	if (ret < 0) {
 		pr_debug("snprintf() failed: %d\n", ret);
 		return ret;
 	}
 	if (!strlist__has_entry(namelist, buf))
 		return 0;
 	if (!allow_suffix) {
 		pr_warning("Error: event \"%s\" already exists. "
 			   "(Use -f to force duplicates.)\n", base);
 		return -EEXIST;
 	}
 	/* Try to add suffix */
 	for (i = 1; i < MAX_EVENT_INDEX; i++) {
 		ret = e_snprintf(buf, len, "%s_%d", base, i);
 		if (ret < 0) {
 			pr_debug("snprintf() failed: %d\n", ret);
 			return ret;
 		}
 		if (!strlist__has_entry(namelist, buf))
 			break;
 	}
 	if (i == MAX_EVENT_INDEX) {
 		pr_warning("Too many events are on the same function.\n");
 		ret = -ERANGE;
 	}
 	return ret;
 }
 static int __add_probe_trace_events(struct perf_probe_event *pev,
 				     struct probe_trace_event *tevs,
 				     int ntevs, bool allow_suffix)
 {
 	int i, fd, ret;
 	struct probe_trace_event *tev = NULL;
 	char buf[64];
 	const char *event, *group;
 	struct strlist *namelist;
 	if (pev->uprobes)
 		fd = open_uprobe_events(true);
 	else
 		fd = open_kprobe_events(true);
 	if (fd < 0) {
 		print_open_warning(fd, !pev->uprobes);
 		return fd;
 	}
 	/* Get current event names */
 	namelist = get_probe_trace_event_names(fd, false);
 	if (!namelist) {
 		pr_debug("Failed to get current event list.\n");
 		return -EIO;
 	}
 	ret = 0;
 	pr_info("Added new event%s\n", (ntevs > 1) ? "s:" : ":");
 	for (i = 0; i < ntevs; i++) {
 		tev = &tevs[i];
 		if (pev->event)
 			event = pev->event;
 		else
 			if (pev->point.function)
 				event = pev->point.function;
 			else
 				event = tev->point.symbol;
 		if (pev->group)
 			group = pev->group;
 		else
 			group = PERFPROBE_GROUP;
 		/* Get an unused new event name */
 		ret = get_new_event_name(buf, 64, event,
 					 namelist, allow_suffix);
 		if (ret < 0)
 			break;
 		event = buf;
 		tev->event = strdup(event);
 		tev->group = strdup(group);
 		if (tev->event == NULL || tev->group == NULL) {
 			ret = -ENOMEM;
 			break;
 		}
 		ret = write_probe_trace_event(fd, tev);
 		if (ret < 0)
 			break;
 		/* Add added event name to namelist */
 		strlist__add(namelist, event);
 		/* Trick here - save current event/group */
 		event = pev->event;
 		group = pev->group;
 		pev->event = tev->event;
 		pev->group = tev->group;
 		show_perf_probe_event(pev, tev->point.module);
 		/* Trick here - restore current event/group */
 		pev->event = (char *)event;
 		pev->group = (char *)group;
 		/*
 		 * Probes after the first probe which comes from same
 		 * user input are always allowed to add suffix, because
 		 * there might be several addresses corresponding to
 		 * one code line.
 		 */
 		allow_suffix = true;
 	}
 	if (ret >= 0) {
 		/* Show how to use the event. */
 		pr_info("\nYou can now use it in all perf tools, such as:\n\n");
 		pr_info("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group,
 			 tev->event);
 	}
 	strlist__delete(namelist);
 	close(fd);
 	return ret;
 }
 static char *looking_function_name;
 static int num_matched_functions;
 static int probe_function_filter(struct map *map __maybe_unused,
 				      struct symbol *sym)
 {
 	if ((sym->binding == STB_GLOBAL || sym->binding == STB_LOCAL) &&
 	    strcmp(looking_function_name, sym->name) == 0) {
 		num_matched_functions++;
 		return 0;
 	}
 	return 1;
 }
 #define strdup_or_goto(str, label)	\
 	({ char *__p = strdup(str); if (!__p) goto label; __p; })
 /*
  * Find probe function addresses from map.
  * Return an error or the number of found probe_trace_event
  */
 static int find_probe_trace_events_from_map(struct perf_probe_event *pev,
 					    struct probe_trace_event **tevs,
 					    int max_tevs, const char *target)
 {
 	struct map *map = NULL;
 	struct kmap *kmap = NULL;
 	struct ref_reloc_sym *reloc_sym = NULL;
 	struct symbol *sym;
 	struct rb_node *nd;
 	struct probe_trace_event *tev;
 	struct perf_probe_point *pp = &pev->point;
 	struct probe_trace_point *tp;
 	int ret, i;
 	/* Init maps of given executable or kernel */
 	if (pev->uprobes)
 		map = dso__new_map(target);
 	else
 		map = kernel_get_module_map(target);
 	if (!map) {
 		ret = -EINVAL;
 		goto out;
 	}
 	/*
 	 * Load matched symbols: Since the different local symbols may have
 	 * same name but different addresses, this lists all the symbols.
 	 */
 	num_matched_functions = 0;
 	looking_function_name = pp->function;
 	ret = map__load(map, probe_function_filter);
 	if (ret || num_matched_functions == 0) {
 		pr_err("Failed to find symbol %s in %s\n", pp->function,
 			target ? : "kernel");
 		ret = -ENOENT;
 		goto out;
 	} else if (num_matched_functions > max_tevs) {
 		pr_err("Too many functions matched in %s\n",
 			target ? : "kernel");
 		ret = -E2BIG;
 		goto out;
 	}
 	if (!pev->uprobes) {
 		kmap = map__kmap(map);
 		reloc_sym = kmap->ref_reloc_sym;
 		if (!reloc_sym) {
 			pr_warning("Relocated base symbol is not found!\n");
 			ret = -EINVAL;
 			goto out;
 		}
 	}
 	/* Setup result trace-probe-events */
 	*tevs = zalloc(sizeof(*tev) * num_matched_functions);
 	if (!*tevs) {
 		ret = -ENOMEM;
 		goto out;
 	}
 	ret = 0;
 	map__for_each_symbol(map, sym, nd) {
 		tev = (*tevs) + ret;
 		tp = &tev->point;
 		if (ret == num_matched_functions) {
 			pr_warning("Too many symbols are listed. Skip it.\n");
 			break;
 		}
 		ret++;
 		if (pp->offset > sym->end - sym->start) {
 			pr_warning("Offset %ld is bigger than the size of %s\n",
 				   pp->offset, sym->name);
 			ret = -ENOENT;
 			goto err_out;
 		}
 		/* Add one probe point */
 		tp->address = map->unmap_ip(map, sym->start) + pp->offset;
 		if (reloc_sym) {
 			tp->symbol = strdup_or_goto(reloc_sym->name, nomem_out);
 			tp->offset = tp->address - reloc_sym->addr;
 		} else {
 			tp->symbol = strdup_or_goto(sym->name, nomem_out);
 			tp->offset = pp->offset;
 		}
 		tp->retprobe = pp->retprobe;
 		if (target)
 			tev->point.module = strdup_or_goto(target, nomem_out);
 		tev->uprobes = pev->uprobes;
 		tev->nargs = pev->nargs;
 		if (tev->nargs) {
 			tev->args = zalloc(sizeof(struct probe_trace_arg) *
 					   tev->nargs);
 			if (tev->args == NULL)
 				goto nomem_out;
 		}
 		for (i = 0; i < tev->nargs; i++) {
 			if (pev->args[i].name)
 				tev->args[i].name =
 					strdup_or_goto(pev->args[i].name,
 							nomem_out);
 			tev->args[i].value = strdup_or_goto(pev->args[i].var,
 							    nomem_out);
 			if (pev->args[i].type)
 				tev->args[i].type =
 					strdup_or_goto(pev->args[i].type,
 							nomem_out);
 		}
 	}
 out:
 	if (map && pev->uprobes) {
 		/* Only when using uprobe(exec) map needs to be released */
 		dso__delete(map->dso);
 		map__delete(map);
 	}
 	return ret;
 nomem_out:
 	ret = -ENOMEM;
 err_out:
 	clear_probe_trace_events(*tevs, num_matched_functions);
 	zfree(tevs);
 	goto out;
 }
 static int convert_to_probe_trace_events(struct perf_probe_event *pev,
 					  struct probe_trace_event **tevs,
 					  int max_tevs, const char *target)
 {
 	int ret;
 	if (pev->uprobes && !pev->group) {
 		/* Replace group name if not given */
 		ret = convert_exec_to_group(target, &pev->group);
 		if (ret != 0) {
 			pr_warning("Failed to make a group name.\n");
 			return ret;
 		}
 	}
 	/* Convert perf_probe_event with debuginfo */
 	ret = try_to_find_probe_trace_events(pev, tevs, max_tevs, target);
 	if (ret != 0)
 		return ret;	/* Found in debuginfo or got an error */
 	return find_probe_trace_events_from_map(pev, tevs, max_tevs, target);
 }
 struct __event_package {
 	struct perf_probe_event		*pev;
 	struct probe_trace_event	*tevs;
 	int				ntevs;
 };
 int add_perf_probe_events(struct perf_probe_event *pevs, int npevs,
 			  int max_tevs, const char *target, bool force_add)
 {
 	int i, j, ret;
 	struct __event_package *pkgs;
 	ret = 0;
 	pkgs = zalloc(sizeof(struct __event_package) * npevs);
 	if (pkgs == NULL)
 		return -ENOMEM;
 	ret = init_symbol_maps(pevs->uprobes);
 	if (ret < 0) {
 		free(pkgs);
 		return ret;
 	}
 	/* Loop 1: convert all events */
 	for (i = 0; i < npevs; i++) {
 		pkgs[i].pev = &pevs[i];
 		/* Convert with or without debuginfo */
 		ret  = convert_to_probe_trace_events(pkgs[i].pev,
 						     &pkgs[i].tevs,
 						     max_tevs,
 						     target);
 		if (ret < 0)
 			goto end;
 		pkgs[i].ntevs = ret;
 	}
 	/* Loop 2: add all events */
 	for (i = 0; i < npevs; i++) {
 		ret = __add_probe_trace_events(pkgs[i].pev, pkgs[i].tevs,
 						pkgs[i].ntevs, force_add);
 		if (ret < 0)
 			break;
 	}
 end:
 	/* Loop 3: cleanup and free trace events  */
 	for (i = 0; i < npevs; i++) {
 		for (j = 0; j < pkgs[i].ntevs; j++)
 			clear_probe_trace_event(&pkgs[i].tevs[j]);
 		zfree(&pkgs[i].tevs);
 	}
 	free(pkgs);
 	exit_symbol_maps();
 	return ret;
 }
 static int __del_trace_probe_event(int fd, struct str_node *ent)
 {
 	char *p;
 	char buf[128];
 	int ret;
 	/* Convert from perf-probe event to trace-probe event */
 	ret = e_snprintf(buf, 128, "-:%s", ent->s);
 	if (ret < 0)
 		goto error;
 	p = strchr(buf + 2, ':');
 	if (!p) {
 		pr_debug("Internal error: %s should have ':' but not.\n",
 			 ent->s);
 		ret = -ENOTSUP;
 		goto error;
 	}
 	*p = '/';
 	pr_debug("Writing event: %s\n", buf);
 	ret = write(fd, buf, strlen(buf));
 	if (ret < 0) {
 		ret = -errno;
 		goto error;
 	}
 	pr_info("Removed event: %s\n", ent->s);
 	return 0;
 error:
 	pr_warning("Failed to delete event: %s\n",
 		   strerror_r(-ret, buf, sizeof(buf)));
 	return ret;
 }
 static int del_trace_probe_event(int fd, const char *buf,
 						  struct strlist *namelist)
 {
 	struct str_node *ent, *n;
 	int ret = -1;
 	if (strpbrk(buf, "*?")) { /* Glob-exp */
 		strlist__for_each_safe(ent, n, namelist)
 			if (strglobmatch(ent->s, buf)) {
 				ret = __del_trace_probe_event(fd, ent);
 				if (ret < 0)
 					break;
 				strlist__remove(namelist, ent);
 			}
 	} else {
 		ent = strlist__find(namelist, buf);
 		if (ent) {
 			ret = __del_trace_probe_event(fd, ent);
 			if (ret >= 0)
 				strlist__remove(namelist, ent);
 		}
 	}
 	return ret;
 }
 int del_perf_probe_events(struct strlist *dellist)
 {
 	int ret = -1, ufd = -1, kfd = -1;
 	char buf[128];
 	const char *group, *event;
 	char *p, *str;
 	struct str_node *ent;
 	struct strlist *namelist = NULL, *unamelist = NULL;
 	/* Get current event names */
 	kfd = open_kprobe_events(true);
 	if (kfd >= 0)
 		namelist = get_probe_trace_event_names(kfd, true);
 	ufd = open_uprobe_events(true);
 	if (ufd >= 0)
 		unamelist = get_probe_trace_event_names(ufd, true);
 	if (kfd < 0 && ufd < 0) {
 		print_both_open_warning(kfd, ufd);
 		goto error;
 	}
 	if (namelist == NULL && unamelist == NULL)
 		goto error;
 	strlist__for_each(ent, dellist) {
 		str = strdup(ent->s);
 		if (str == NULL) {
 			ret = -ENOMEM;
 			goto error;
 		}
 		pr_debug("Parsing: %s\n", str);
 		p = strchr(str, ':');
 		if (p) {
 			group = str;
 			*p = '\0';
 			event = p + 1;
 		} else {
 			group = "*";
 			event = str;
 		}
 		ret = e_snprintf(buf, 128, "%s:%s", group, event);
 		if (ret < 0) {
 			pr_err("Failed to copy event.");
 			free(str);
 			goto error;
 		}
 		pr_debug("Group: %s, Event: %s\n", group, event);
 		if (namelist)
 			ret = del_trace_probe_event(kfd, buf, namelist);
 		if (unamelist && ret != 0)
 			ret = del_trace_probe_event(ufd, buf, unamelist);
 		if (ret != 0)
 			pr_info("Info: Event \"%s\" does not exist.\n", buf);
 		free(str);
 	}
 error:
 	if (kfd >= 0) {
 		strlist__delete(namelist);
 		close(kfd);
 	}
 	if (ufd >= 0) {
 		strlist__delete(unamelist);
 		close(ufd);
 	}
 	return ret;
 }
 /* TODO: don't use a global variable for filter ... */
 static struct strfilter *available_func_filter;
 /*
  * If a symbol corresponds to a function with global binding and
  * matches filter return 0. For all others return 1.
  */
 static int filter_available_functions(struct map *map __maybe_unused,
 				      struct symbol *sym)
 {
 	if ((sym->binding == STB_GLOBAL || sym->binding == STB_LOCAL) &&
 	    strfilter__compare(available_func_filter, sym->name))
 		return 0;
 	return 1;
 }
 int show_available_funcs(const char *target, struct strfilter *_filter,
 					bool user)
 {
 	struct map *map;
 	int ret;
 	ret = init_symbol_maps(user);
 	if (ret < 0)
 		return ret;
 	/* Get a symbol map */
 	if (user)
 		map = dso__new_map(target);
 	else
 		map = kernel_get_module_map(target);
 	if (!map) {
 		pr_err("Failed to get a map for %s\n", (target) ? : "kernel");
 		return -EINVAL;
 	}
 	/* Load symbols with given filter */
 	available_func_filter = _filter;
 	if (map__load(map, filter_available_functions)) {
 		pr_err("Failed to load symbols in %s\n", (target) ? : "kernel");
 		goto end;
 	}
 	if (!dso__sorted_by_name(map->dso, map->type))
 		dso__sort_by_name(map->dso, map->type);
 	/* Show all (filtered) symbols */
 	setup_pager();
 	dso__fprintf_symbols_by_name(map->dso, map->type, stdout);
 end:
 	if (user) {
 		dso__delete(map->dso);
 		map__delete(map);
 	}
 	exit_symbol_maps();
 	return ret;
 }

tools/perf/util/probe-finder.c

Diff comments View file @ ed9eb84

 /*
  * probe-finder.c : C expression to kprobe event converter
  *
  * Written by Masami Hiramatsu <mhiramat@redhat.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
  *
  */
 #include <sys/utsname.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdarg.h>
 #include <dwarf-regs.h>
 #include <linux/bitops.h>
 #include "event.h"
 #include "dso.h"
 #include "debug.h"
 #include "intlist.h"
 #include "util.h"
 #include "symbol.h"
 #include "probe-finder.h"
 /* Kprobe tracer basic type is up to u64 */
 #define MAX_BASIC_TYPE_BITS	64
 /* Dwarf FL wrappers */
 static char *debuginfo_path;	/* Currently dummy */
 static const Dwfl_Callbacks offline_callbacks = {
 	.find_debuginfo = dwfl_standard_find_debuginfo,
 	.debuginfo_path = &debuginfo_path,
 	.section_address = dwfl_offline_section_address,
 	/* We use this table for core files too.  */
 	.find_elf = dwfl_build_id_find_elf,
 };
 /* Get a Dwarf from offline image */
 static int debuginfo__init_offline_dwarf(struct debuginfo *dbg,
 					 const char *path)
 {
 	int fd;
 	fd = open(path, O_RDONLY);
 	if (fd < 0)
 		return fd;
 	dbg->dwfl = dwfl_begin(&offline_callbacks);
 	if (!dbg->dwfl)
 		goto error;
 	dbg->mod = dwfl_report_offline(dbg->dwfl, "", "", fd);
 	if (!dbg->mod)
 		goto error;
 	dbg->dbg = dwfl_module_getdwarf(dbg->mod, &dbg->bias);
 	if (!dbg->dbg)
 		goto error;
 	return 0;
 error:
 	if (dbg->dwfl)
 		dwfl_end(dbg->dwfl);
 	else
 		close(fd);
 	memset(dbg, 0, sizeof(*dbg));
 	return -ENOENT;
 }
 static struct debuginfo *__debuginfo__new(const char *path)
 {
 	struct debuginfo *dbg = zalloc(sizeof(*dbg));
 	if (!dbg)
 		return NULL;
 	if (debuginfo__init_offline_dwarf(dbg, path) < 0)
 		zfree(&dbg);
 	if (dbg)
 		pr_debug("Open Debuginfo file: %s\n", path);
 	return dbg;
 }
 enum dso_binary_type distro_dwarf_types[] = {
 	DSO_BINARY_TYPE__FEDORA_DEBUGINFO,
 	DSO_BINARY_TYPE__UBUNTU_DEBUGINFO,
 	DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO,
 	DSO_BINARY_TYPE__BUILDID_DEBUGINFO,
 	DSO_BINARY_TYPE__NOT_FOUND,
 };
 struct debuginfo *debuginfo__new(const char *path)
 {
 	enum dso_binary_type *type;
 	char buf[PATH_MAX], nil = '\0';
 	struct dso *dso;
 	struct debuginfo *dinfo = NULL;
 	/* Try to open distro debuginfo files */
 	dso = dso__new(path);
 	if (!dso)
 		goto out;
 	for (type = distro_dwarf_types;
 	     !dinfo && *type != DSO_BINARY_TYPE__NOT_FOUND;
 	     type++) {
 		if (dso__read_binary_type_filename(dso, *type, &nil,
 						   buf, PATH_MAX) < 0)
 			continue;
 		dinfo = __debuginfo__new(buf);
 	}
 	dso__delete(dso);
 out:
 	/* if failed to open all distro debuginfo, open given binary */
 	return dinfo ? : __debuginfo__new(path);
 }
 void debuginfo__delete(struct debuginfo *dbg)
 {
 	if (dbg) {
 		if (dbg->dwfl)
 			dwfl_end(dbg->dwfl);
 		free(dbg);
 	}
 }
 /*
  * Probe finder related functions
  */
 static struct probe_trace_arg_ref *alloc_trace_arg_ref(long offs)
 {
 	struct probe_trace_arg_ref *ref;
 	ref = zalloc(sizeof(struct probe_trace_arg_ref));
 	if (ref != NULL)
 		ref->offset = offs;
 	return ref;
 }
 /*
  * Convert a location into trace_arg.
  * If tvar == NULL, this just checks variable can be converted.
  * If fentry == true and vr_die is a parameter, do huristic search
  * for the location fuzzed by function entry mcount.
  */
 static int convert_variable_location(Dwarf_Die *vr_die, Dwarf_Addr addr,
 				     Dwarf_Op *fb_ops, Dwarf_Die *sp_die,
 				     struct probe_trace_arg *tvar)
 {
 	Dwarf_Attribute attr;
 	Dwarf_Addr tmp = 0;
 	Dwarf_Op *op;
 	size_t nops;
 	unsigned int regn;
 	Dwarf_Word offs = 0;
 	bool ref = false;
 	const char *regs;
 	int ret;
 	if (dwarf_attr(vr_die, DW_AT_external, &attr) != NULL)
 		goto static_var;
 	/* TODO: handle more than 1 exprs */
 	if (dwarf_attr(vr_die, DW_AT_location, &attr) == NULL)
 		return -EINVAL;	/* Broken DIE ? */
 	if (dwarf_getlocation_addr(&attr, addr, &op, &nops, 1) <= 0) {
 		ret = dwarf_entrypc(sp_die, &tmp);
 		if (ret || addr != tmp ||
 		    dwarf_tag(vr_die) != DW_TAG_formal_parameter ||
 		    dwarf_highpc(sp_die, &tmp))
 			return -ENOENT;
 		/*
 		 * This is fuzzed by fentry mcount. We try to find the
 		 * parameter location at the earliest address.
 		 */
 		for (addr += 1; addr <= tmp; addr++) {
 			if (dwarf_getlocation_addr(&attr, addr, &op,
 						   &nops, 1) > 0)
 				goto found;
 		}
 		return -ENOENT;
 	}
 found:
 	if (nops == 0)
 		/* TODO: Support const_value */
 		return -ENOENT;
 	if (op->atom == DW_OP_addr) {
 static_var:
 		if (!tvar)
 			return 0;
 		/* Static variables on memory (not stack), make @varname */
 		ret = strlen(dwarf_diename(vr_die));
 		tvar->value = zalloc(ret + 2);
 		if (tvar->value == NULL)
 			return -ENOMEM;
 		snprintf(tvar->value, ret + 2, "@%s", dwarf_diename(vr_die));
 		tvar->ref = alloc_trace_arg_ref((long)offs);
 		if (tvar->ref == NULL)
 			return -ENOMEM;
 		return 0;
 	}
 	/* If this is based on frame buffer, set the offset */
 	if (op->atom == DW_OP_fbreg) {
 		if (fb_ops == NULL)
 			return -ENOTSUP;
 		ref = true;
 		offs = op->number;
 		op = &fb_ops[0];
 	}
 	if (op->atom >= DW_OP_breg0 && op->atom <= DW_OP_breg31) {
 		regn = op->atom - DW_OP_breg0;
 		offs += op->number;
 		ref = true;
 	} else if (op->atom >= DW_OP_reg0 && op->atom <= DW_OP_reg31) {
 		regn = op->atom - DW_OP_reg0;
 	} else if (op->atom == DW_OP_bregx) {
 		regn = op->number;
 		offs += op->number2;
 		ref = true;
 	} else if (op->atom == DW_OP_regx) {
 		regn = op->number;
 	} else {
 		pr_debug("DW_OP %x is not supported.\n", op->atom);
 		return -ENOTSUP;
 	}
 	if (!tvar)
 		return 0;
 	regs = get_arch_regstr(regn);
 	if (!regs) {
 		/* This should be a bug in DWARF or this tool */
 		pr_warning("Mapping for the register number %u "
 			   "missing on this architecture.\n", regn);
 		return -ERANGE;
 	}
 	tvar->value = strdup(regs);
 	if (tvar->value == NULL)
 		return -ENOMEM;
 	if (ref) {
 		tvar->ref = alloc_trace_arg_ref((long)offs);
 		if (tvar->ref == NULL)
 			return -ENOMEM;
 	}
 	return 0;
 }
 #define BYTES_TO_BITS(nb)	((nb) * BITS_PER_LONG / sizeof(long))
 static int convert_variable_type(Dwarf_Die *vr_die,
 				 struct probe_trace_arg *tvar,
 				 const char *cast)
 {
 	struct probe_trace_arg_ref **ref_ptr = &tvar->ref;
 	Dwarf_Die type;
 	char buf[16];
 	char sbuf[STRERR_BUFSIZE];
 	int bsize, boffs, total;
 	int ret;
 	/* TODO: check all types */
 	if (cast && strcmp(cast, "string") != 0) {
 		/* Non string type is OK */
 		tvar->type = strdup(cast);
 		return (tvar->type == NULL) ? -ENOMEM : 0;
 	}
 	bsize = dwarf_bitsize(vr_die);
 	if (bsize > 0) {
 		/* This is a bitfield */
 		boffs = dwarf_bitoffset(vr_die);
 		total = dwarf_bytesize(vr_die);
 		if (boffs < 0 || total < 0)
 			return -ENOENT;
 		ret = snprintf(buf, 16, "b%d@%d/%zd", bsize, boffs,
 				BYTES_TO_BITS(total));
 		goto formatted;
 	}
 	if (die_get_real_type(vr_die, &type) == NULL) {
 		pr_warning("Failed to get a type information of %s.\n",
 			   dwarf_diename(vr_die));
 		return -ENOENT;
 	}
 	pr_debug("%s type is %s.\n",
 		 dwarf_diename(vr_die), dwarf_diename(&type));
 	if (cast && strcmp(cast, "string") == 0) {	/* String type */
 		ret = dwarf_tag(&type);
 		if (ret != DW_TAG_pointer_type &&
 		    ret != DW_TAG_array_type) {
 			pr_warning("Failed to cast into string: "
 				   "%s(%s) is not a pointer nor array.\n",
 				   dwarf_diename(vr_die), dwarf_diename(&type));
 			return -EINVAL;
 		}
 		if (die_get_real_type(&type, &type) == NULL) {
 			pr_warning("Failed to get a type"
 				   " information.\n");
 			return -ENOENT;
 		}
 		if (ret == DW_TAG_pointer_type) {
 			while (*ref_ptr)
 				ref_ptr = &(*ref_ptr)->next;
 			/* Add new reference with offset +0 */
 			*ref_ptr = zalloc(sizeof(struct probe_trace_arg_ref));
 			if (*ref_ptr == NULL) {
 				pr_warning("Out of memory error\n");
 				return -ENOMEM;
 			}
 		}
 		if (!die_compare_name(&type, "char") &&
 		    !die_compare_name(&type, "unsigned char")) {
 			pr_warning("Failed to cast into string: "
 				   "%s is not (unsigned) char *.\n",
 				   dwarf_diename(vr_die));
 			return -EINVAL;
 		}
 		tvar->type = strdup(cast);
 		return (tvar->type == NULL) ? -ENOMEM : 0;
 	}
 	ret = dwarf_bytesize(&type);
 	if (ret <= 0)
 		/* No size ... try to use default type */
 		return 0;
 	ret = BYTES_TO_BITS(ret);
 	/* Check the bitwidth */
 	if (ret > MAX_BASIC_TYPE_BITS) {
 		pr_info("%s exceeds max-bitwidth. Cut down to %d bits.\n",
 			dwarf_diename(&type), MAX_BASIC_TYPE_BITS);
 		ret = MAX_BASIC_TYPE_BITS;
 	}
 	ret = snprintf(buf, 16, "%c%d",
 		       die_is_signed_type(&type) ? 's' : 'u', ret);
 formatted:
 	if (ret < 0 || ret >= 16) {
 		if (ret >= 16)
 			ret = -E2BIG;
 		pr_warning("Failed to convert variable type: %s\n",
 			   strerror_r(-ret, sbuf, sizeof(sbuf)));
 		return ret;
 	}
 	tvar->type = strdup(buf);
 	if (tvar->type == NULL)
 		return -ENOMEM;
 	return 0;
 }
 static int convert_variable_fields(Dwarf_Die *vr_die, const char *varname,
 				    struct perf_probe_arg_field *field,
 				    struct probe_trace_arg_ref **ref_ptr,
 				    Dwarf_Die *die_mem)
 {
 	struct probe_trace_arg_ref *ref = *ref_ptr;
 	Dwarf_Die type;
 	Dwarf_Word offs;
 	int ret, tag;
 	pr_debug("converting %s in %s\n", field->name, varname);
 	if (die_get_real_type(vr_die, &type) == NULL) {
 		pr_warning("Failed to get the type of %s.\n", varname);
 		return -ENOENT;
 	}
 	pr_debug2("Var real type: (%x)\n", (unsigned)dwarf_dieoffset(&type));
 	tag = dwarf_tag(&type);
 	if (field->name[0] == '[' &&
 	    (tag == DW_TAG_array_type || tag == DW_TAG_pointer_type)) {
 		if (field->next)
 			/* Save original type for next field */
 			memcpy(die_mem, &type, sizeof(*die_mem));
 		/* Get the type of this array */
 		if (die_get_real_type(&type, &type) == NULL) {
 			pr_warning("Failed to get the type of %s.\n", varname);
 			return -ENOENT;
 		}
 		pr_debug2("Array real type: (%x)\n",
 			 (unsigned)dwarf_dieoffset(&type));
 		if (tag == DW_TAG_pointer_type) {
 			ref = zalloc(sizeof(struct probe_trace_arg_ref));
 			if (ref == NULL)
 				return -ENOMEM;
 			if (*ref_ptr)
 				(*ref_ptr)->next = ref;
 			else
 				*ref_ptr = ref;
 		}
 		ref->offset += dwarf_bytesize(&type) * field->index;
 		if (!field->next)
 			/* Save vr_die for converting types */
 			memcpy(die_mem, vr_die, sizeof(*die_mem));
 		goto next;
 	} else if (tag == DW_TAG_pointer_type) {
 		/* Check the pointer and dereference */
 		if (!field->ref) {
 			pr_err("Semantic error: %s must be referred by '->'\n",
 			       field->name);
 			return -EINVAL;
 		}
 		/* Get the type pointed by this pointer */
 		if (die_get_real_type(&type, &type) == NULL) {
 			pr_warning("Failed to get the type of %s.\n", varname);
 			return -ENOENT;
 		}
 		/* Verify it is a data structure  */
 		tag = dwarf_tag(&type);
 		if (tag != DW_TAG_structure_type && tag != DW_TAG_union_type) {
 			pr_warning("%s is not a data structure nor an union.\n",
 				   varname);
 			return -EINVAL;
 		}
 		ref = zalloc(sizeof(struct probe_trace_arg_ref));
 		if (ref == NULL)
 			return -ENOMEM;
 		if (*ref_ptr)
 			(*ref_ptr)->next = ref;
 		else
 			*ref_ptr = ref;
 	} else {
 		/* Verify it is a data structure  */
 		if (tag != DW_TAG_structure_type && tag != DW_TAG_union_type) {
 			pr_warning("%s is not a data structure nor an union.\n",
 				   varname);
 			return -EINVAL;
 		}
 		if (field->name[0] == '[') {
 			pr_err("Semantic error: %s is not a pointor"
 			       " nor array.\n", varname);
 			return -EINVAL;
 		}
 		if (field->ref) {
 			pr_err("Semantic error: %s must be referred by '.'\n",
 			       field->name);
 			return -EINVAL;
 		}
 		if (!ref) {
 			pr_warning("Structure on a register is not "
 				   "supported yet.\n");
 			return -ENOTSUP;
 		}
 	}
 	if (die_find_member(&type, field->name, die_mem) == NULL) {
 		pr_warning("%s(type:%s) has no member %s.\n", varname,
 			   dwarf_diename(&type), field->name);
 		return -EINVAL;
 	}
 	/* Get the offset of the field */
 	if (tag == DW_TAG_union_type) {
 		offs = 0;
 	} else {
 		ret = die_get_data_member_location(die_mem, &offs);
 		if (ret < 0) {
 			pr_warning("Failed to get the offset of %s.\n",
 				   field->name);
 			return ret;
 		}
 	}
 	ref->offset += (long)offs;
 next:
 	/* Converting next field */
 	if (field->next)
 		return convert_variable_fields(die_mem, field->name,
 					field->next, &ref, die_mem);
 	else
 		return 0;
 }
 /* Show a variables in kprobe event format */
 static int convert_variable(Dwarf_Die *vr_die, struct probe_finder *pf)
 {
 	Dwarf_Die die_mem;
 	int ret;
 	pr_debug("Converting variable %s into trace event.\n",
 		 dwarf_diename(vr_die));
 	ret = convert_variable_location(vr_die, pf->addr, pf->fb_ops,
 					&pf->sp_die, pf->tvar);
 	if (ret == -ENOENT || ret == -EINVAL)
 		pr_err("Failed to find the location of %s at this address.\n"
 		       " Perhaps, it has been optimized out.\n", pf->pvar->var);
 	else if (ret == -ENOTSUP)
 		pr_err("Sorry, we don't support this variable location yet.\n");
 	else if (ret == 0 && pf->pvar->field) {
 		ret = convert_variable_fields(vr_die, pf->pvar->var,
 					      pf->pvar->field, &pf->tvar->ref,
 					      &die_mem);
 		vr_die = &die_mem;
 	}
 	if (ret == 0)
 		ret = convert_variable_type(vr_die, pf->tvar, pf->pvar->type);
 	/* *expr will be cached in libdw. Don't free it. */
 	return ret;
 }
 /* Find a variable in a scope DIE */
 static int find_variable(Dwarf_Die *sc_die, struct probe_finder *pf)
 {
 	Dwarf_Die vr_die;
 	char buf[32], *ptr;
 	int ret = 0;
 	if (!is_c_varname(pf->pvar->var)) {
 		/* Copy raw parameters */
 		pf->tvar->value = strdup(pf->pvar->var);
 		if (pf->tvar->value == NULL)
 			return -ENOMEM;
 		if (pf->pvar->type) {
 			pf->tvar->type = strdup(pf->pvar->type);
 			if (pf->tvar->type == NULL)
 				return -ENOMEM;
 		}
 		if (pf->pvar->name) {
 			pf->tvar->name = strdup(pf->pvar->name);
 			if (pf->tvar->name == NULL)
 				return -ENOMEM;
 		} else
 			pf->tvar->name = NULL;
 		return 0;
 	}
 	if (pf->pvar->name)
 		pf->tvar->name = strdup(pf->pvar->name);
 	else {
 		ret = synthesize_perf_probe_arg(pf->pvar, buf, 32);
 		if (ret < 0)
 			return ret;
 		ptr = strchr(buf, ':');	/* Change type separator to _ */
 		if (ptr)
 			*ptr = '_';
 		pf->tvar->name = strdup(buf);
 	}
 	if (pf->tvar->name == NULL)
 		return -ENOMEM;
 	pr_debug("Searching '%s' variable in context.\n", pf->pvar->var);
 	/* Search child die for local variables and parameters. */
 	if (!die_find_variable_at(sc_die, pf->pvar->var, pf->addr, &vr_die)) {
 		/* Search again in global variables */
 		if (!die_find_variable_at(&pf->cu_die, pf->pvar->var, 0, &vr_die))
 			pr_warning("Failed to find '%s' in this function.\n",
 				   pf->pvar->var);
 			ret = -ENOENT;
 	}
 	if (ret >= 0)
 		ret = convert_variable(&vr_die, pf);
 	return ret;
 }
 /* Convert subprogram DIE to trace point */
 static int convert_to_trace_point(Dwarf_Die *sp_die, Dwfl_Module *mod,
 				  Dwarf_Addr paddr, bool retprobe,
 				  struct probe_trace_point *tp)
 {
 	Dwarf_Addr eaddr, highaddr;
 	GElf_Sym sym;
 	const char *symbol;
 	/* Verify the address is correct */
 	if (dwarf_entrypc(sp_die, &eaddr) != 0) {
 		pr_warning("Failed to get entry address of %s\n",
 			   dwarf_diename(sp_die));
 		return -ENOENT;
 	}
 	if (dwarf_highpc(sp_die, &highaddr) != 0) {
 		pr_warning("Failed to get end address of %s\n",
 			   dwarf_diename(sp_die));
 		return -ENOENT;
 	}
 	if (paddr > highaddr) {
 		pr_warning("Offset specified is greater than size of %s\n",
 			   dwarf_diename(sp_die));
 		return -EINVAL;
 	}
 	symbol = dwarf_diename(sp_die);
 	if (!symbol) {
 		/* Try to get the symbol name from symtab */
 		symbol = dwfl_module_addrsym(mod, paddr, &sym, NULL);
 		if (!symbol) {
 			pr_warning("Failed to find symbol at 0x%lx\n",
 				   (unsigned long)paddr);
 			return -ENOENT;
 		}
 		eaddr = sym.st_value;
 	}
 	tp->offset = (unsigned long)(paddr - eaddr);
 	tp->address = (unsigned long)paddr;
 	tp->symbol = strdup(symbol);
 	if (!tp->symbol)
 		return -ENOMEM;
 	/* Return probe must be on the head of a subprogram */
 	if (retprobe) {
 		if (eaddr != paddr) {
 			pr_warning("Return probe must be on the head of"
 				   " a real function.\n");
 			return -EINVAL;
 		}
 		tp->retprobe = true;
 	}
 	return 0;
 }
 /* Call probe_finder callback with scope DIE */
 static int call_probe_finder(Dwarf_Die *sc_die, struct probe_finder *pf)
 {
 	Dwarf_Attribute fb_attr;
 	size_t nops;
 	int ret;
 	if (!sc_die) {
 		pr_err("Caller must pass a scope DIE. Program error.\n");
 		return -EINVAL;
 	}
 	/* If not a real subprogram, find a real one */
 	if (!die_is_func_def(sc_die)) {
 		if (!die_find_realfunc(&pf->cu_die, pf->addr, &pf->sp_die)) {
 			pr_warning("Failed to find probe point in any "
 				   "functions.\n");
 			return -ENOENT;
 		}
 	} else
 		memcpy(&pf->sp_die, sc_die, sizeof(Dwarf_Die));
 	/* Get the frame base attribute/ops from subprogram */
 	dwarf_attr(&pf->sp_die, DW_AT_frame_base, &fb_attr);
 	ret = dwarf_getlocation_addr(&fb_attr, pf->addr, &pf->fb_ops, &nops, 1);
 	if (ret <= 0 || nops == 0) {
 		pf->fb_ops = NULL;
 #if _ELFUTILS_PREREQ(0, 142)
 	} else if (nops == 1 && pf->fb_ops[0].atom == DW_OP_call_frame_cfa &&
 		   pf->cfi != NULL) {
 		Dwarf_Frame *frame;
 		if (dwarf_cfi_addrframe(pf->cfi, pf->addr, &frame) != 0 ||
 		    dwarf_frame_cfa(frame, &pf->fb_ops, &nops) != 0) {
 			pr_warning("Failed to get call frame on 0x%jx\n",
 				   (uintmax_t)pf->addr);
 			return -ENOENT;
 		}
 #endif
 	}
 	/* Call finder's callback handler */
 	ret = pf->callback(sc_die, pf);
 	/* *pf->fb_ops will be cached in libdw. Don't free it. */
 	pf->fb_ops = NULL;
 	return ret;
 }
 struct find_scope_param {
 	const char *function;
 	const char *file;
 	int line;
 	int diff;
 	Dwarf_Die *die_mem;
 	bool found;
 };
 static int find_best_scope_cb(Dwarf_Die *fn_die, void *data)
 {
 	struct find_scope_param *fsp = data;
 	const char *file;
 	int lno;
 	/* Skip if declared file name does not match */
 	if (fsp->file) {
 		file = dwarf_decl_file(fn_die);
 		if (!file || strcmp(fsp->file, file) != 0)
 			return 0;
 	}
 	/* If the function name is given, that's what user expects */
 	if (fsp->function) {
 		if (die_compare_name(fn_die, fsp->function)) {
 			memcpy(fsp->die_mem, fn_die, sizeof(Dwarf_Die));
 			fsp->found = true;
 			return 1;
 		}
 	} else {
 		/* With the line number, find the nearest declared DIE */
 		dwarf_decl_line(fn_die, &lno);
 		if (lno < fsp->line && fsp->diff > fsp->line - lno) {
 			/* Keep a candidate and continue */
 			fsp->diff = fsp->line - lno;
 			memcpy(fsp->die_mem, fn_die, sizeof(Dwarf_Die));
 			fsp->found = true;
 		}
 	}
 	return 0;
 }
 /* Find an appropriate scope fits to given conditions */
 static Dwarf_Die *find_best_scope(struct probe_finder *pf, Dwarf_Die *die_mem)
 {
 	struct find_scope_param fsp = {
 		.function = pf->pev->point.function,
 		.file = pf->fname,
 		.line = pf->lno,
 		.diff = INT_MAX,
 		.die_mem = die_mem,
 		.found = false,
 	};
 	cu_walk_functions_at(&pf->cu_die, pf->addr, find_best_scope_cb, &fsp);
 	return fsp.found ? die_mem : NULL;
 }
 static int probe_point_line_walker(const char *fname, int lineno,
 				   Dwarf_Addr addr, void *data)
 {
 	struct probe_finder *pf = data;
 	Dwarf_Die *sc_die, die_mem;
 	int ret;
 	if (lineno != pf->lno || strtailcmp(fname, pf->fname) != 0)
 		return 0;
 	pf->addr = addr;
 	sc_die = find_best_scope(pf, &die_mem);
 	if (!sc_die) {
 		pr_warning("Failed to find scope of probe point.\n");
 		return -ENOENT;
 	}
 	ret = call_probe_finder(sc_die, pf);
 	/* Continue if no error, because the line will be in inline function */
 	return ret < 0 ? ret : 0;
 }
 /* Find probe point from its line number */
 static int find_probe_point_by_line(struct probe_finder *pf)
 {
 	return die_walk_lines(&pf->cu_die, probe_point_line_walker, pf);
 }
 /* Find lines which match lazy pattern */
 static int find_lazy_match_lines(struct intlist *list,
 				 const char *fname, const char *pat)
 {
 	FILE *fp;
 	char *line = NULL;
 	size_t line_len;
 	ssize_t len;
 	int count = 0, linenum = 1;
 	char sbuf[STRERR_BUFSIZE];
 	fp = fopen(fname, "r");
 	if (!fp) {
 		pr_warning("Failed to open %s: %s\n", fname,
 			   strerror_r(errno, sbuf, sizeof(sbuf)));
 		return -errno;
 	}
 	while ((len = getline(&line, &line_len, fp)) > 0) {
 		if (line[len - 1] == '\n')
 			line[len - 1] = '\0';
 		if (strlazymatch(line, pat)) {
 			intlist__add(list, linenum);
 			count++;
 		}
 		linenum++;
 	}
 	if (ferror(fp))
 		count = -errno;
 	free(line);
 	fclose(fp);
 	if (count == 0)
 		pr_debug("No matched lines found in %s.\n", fname);
 	return count;
 }
 static int probe_point_lazy_walker(const char *fname, int lineno,
 				   Dwarf_Addr addr, void *data)
 {
 	struct probe_finder *pf = data;
 	Dwarf_Die *sc_die, die_mem;
 	int ret;
 	if (!intlist__has_entry(pf->lcache, lineno) ||
 	    strtailcmp(fname, pf->fname) != 0)
 		return 0;
 	pr_debug("Probe line found: line:%d addr:0x%llx\n",
 		 lineno, (unsigned long long)addr);
 	pf->addr = addr;
 	pf->lno = lineno;
 	sc_die = find_best_scope(pf, &die_mem);
 	if (!sc_die) {
 		pr_warning("Failed to find scope of probe point.\n");
 		return -ENOENT;
 	}
 	ret = call_probe_finder(sc_die, pf);
 	/*
 	 * Continue if no error, because the lazy pattern will match
 	 * to other lines
 	 */
 	return ret < 0 ? ret : 0;
 }
 /* Find probe points from lazy pattern  */
 static int find_probe_point_lazy(Dwarf_Die *sp_die, struct probe_finder *pf)
 {
 	int ret = 0;
 	if (intlist__empty(pf->lcache)) {
 		/* Matching lazy line pattern */
 		ret = find_lazy_match_lines(pf->lcache, pf->fname,
 					    pf->pev->point.lazy_line);
 		if (ret <= 0)
 			return ret;
 	}
 	return die_walk_lines(sp_die, probe_point_lazy_walker, pf);
 }
 static int probe_point_inline_cb(Dwarf_Die *in_die, void *data)
 {
 	struct probe_finder *pf = data;
 	struct perf_probe_point *pp = &pf->pev->point;
 	Dwarf_Addr addr;
 	int ret;
 	if (pp->lazy_line)
 		ret = find_probe_point_lazy(in_die, pf);
 	else {
 		/* Get probe address */
 		if (dwarf_entrypc(in_die, &addr) != 0) {
 			pr_warning("Failed to get entry address of %s.\n",
 				   dwarf_diename(in_die));
 			return -ENOENT;
 		}
 		pf->addr = addr;
 		pf->addr += pp->offset;
 		pr_debug("found inline addr: 0x%jx\n",
 			 (uintmax_t)pf->addr);
 		ret = call_probe_finder(in_die, pf);
 	}
 	return ret;
 }
 /* Callback parameter with return value for libdw */
 struct dwarf_callback_param {
 	void *data;
 	int retval;
 };
 /* Search function from function name */
 static int probe_point_search_cb(Dwarf_Die *sp_die, void *data)
 {
 	struct dwarf_callback_param *param = data;
 	struct probe_finder *pf = param->data;
 	struct perf_probe_point *pp = &pf->pev->point;
 	/* Check tag and diename */
 	if (!die_is_func_def(sp_die) ||
 	    !die_compare_name(sp_die, pp->function))
 		return DWARF_CB_OK;
 	/* Check declared file */
 	if (pp->file && strtailcmp(pp->file, dwarf_decl_file(sp_die)))
 		return DWARF_CB_OK;
 	pf->fname = dwarf_decl_file(sp_die);
 	if (pp->line) { /* Function relative line */
 		dwarf_decl_line(sp_die, &pf->lno);
 		pf->lno += pp->line;
 		param->retval = find_probe_point_by_line(pf);
 	} else if (!dwarf_func_inline(sp_die)) {
 		/* Real function */
 		if (pp->lazy_line)
 			param->retval = find_probe_point_lazy(sp_die, pf);
 		else {
 			if (dwarf_entrypc(sp_die, &pf->addr) != 0) {
 				pr_warning("Failed to get entry address of "
 					   "%s.\n", dwarf_diename(sp_die));
 				param->retval = -ENOENT;
 				return DWARF_CB_ABORT;
 			}
 			pf->addr += pp->offset;
 			/* TODO: Check the address in this function */
 			param->retval = call_probe_finder(sp_die, pf);
 		}
 	} else
 		/* Inlined function: search instances */
 		param->retval = die_walk_instances(sp_die,
 					probe_point_inline_cb, (void *)pf);
 	return DWARF_CB_ABORT; /* Exit; no same symbol in this CU. */
 }
 static int find_probe_point_by_func(struct probe_finder *pf)
 {
 	struct dwarf_callback_param _param = {.data = (void *)pf,
 					      .retval = 0};
 	dwarf_getfuncs(&pf->cu_die, probe_point_search_cb, &_param, 0);
 	return _param.retval;
 }
 struct pubname_callback_param {
 	char *function;
 	char *file;
 	Dwarf_Die *cu_die;
 	Dwarf_Die *sp_die;
 	int found;
 };
 static int pubname_search_cb(Dwarf *dbg, Dwarf_Global *gl, void *data)
 {
 	struct pubname_callback_param *param = data;
 	if (dwarf_offdie(dbg, gl->die_offset, param->sp_die)) {
 		if (dwarf_tag(param->sp_die) != DW_TAG_subprogram)
 			return DWARF_CB_OK;
 		if (die_compare_name(param->sp_die, param->function)) {
 			if (!dwarf_offdie(dbg, gl->cu_offset, param->cu_die))
 				return DWARF_CB_OK;
 			if (param->file &&
 			    strtailcmp(param->file, dwarf_decl_file(param->sp_die)))
 				return DWARF_CB_OK;
 			param->found = 1;
 			return DWARF_CB_ABORT;
 		}
 	}
 	return DWARF_CB_OK;
 }
 /* Find probe points from debuginfo */
 static int debuginfo__find_probes(struct debuginfo *dbg,
 				  struct probe_finder *pf)
 {
 	struct perf_probe_point *pp = &pf->pev->point;
 	Dwarf_Off off, noff;
 	size_t cuhl;
 	Dwarf_Die *diep;
 	int ret = 0;
 #if _ELFUTILS_PREREQ(0, 142)
+	Elf *elf;
+	GElf_Ehdr ehdr;
+	GElf_Shdr shdr;
 	/* Get the call frame information from this dwarf */
-	pf->cfi = dwarf_getcfi_elf(dwarf_getelf(dbg->dbg));
+	elf = dwarf_getelf(dbg->dbg);
+	if (elf == NULL)
+		return -EINVAL;
+	if (gelf_getehdr(elf, &ehdr) == NULL)
+		return -EINVAL;
+	if (elf_section_by_name(elf, &ehdr, &shdr, ".eh_frame", NULL) &&
+	    shdr.sh_type == SHT_PROGBITS) {
+		pf->cfi = dwarf_getcfi_elf(elf);
+	} else {
+		pf->cfi = dwarf_getcfi(dbg->dbg);
+	}
 #endif
 	off = 0;
 	pf->lcache = intlist__new(NULL);
 	if (!pf->lcache)
 		return -ENOMEM;
 	/* Fastpath: lookup by function name from .debug_pubnames section */
 	if (pp->function) {
 		struct pubname_callback_param pubname_param = {
 			.function = pp->function,
 			.file	  = pp->file,
 			.cu_die	  = &pf->cu_die,
 			.sp_die	  = &pf->sp_die,
 			.found	  = 0,
 		};
 		struct dwarf_callback_param probe_param = {
 			.data = pf,
 		};
 		dwarf_getpubnames(dbg->dbg, pubname_search_cb,
 				  &pubname_param, 0);
 		if (pubname_param.found) {
 			ret = probe_point_search_cb(&pf->sp_die, &probe_param);
 			if (ret)
 				goto found;
 		}
 	}
 	/* Loop on CUs (Compilation Unit) */
 	while (!dwarf_nextcu(dbg->dbg, off, &noff, &cuhl, NULL, NULL, NULL)) {
 		/* Get the DIE(Debugging Information Entry) of this CU */
 		diep = dwarf_offdie(dbg->dbg, off + cuhl, &pf->cu_die);
 		if (!diep)
 			continue;
 		/* Check if target file is included. */
 		if (pp->file)
 			pf->fname = cu_find_realpath(&pf->cu_die, pp->file);
 		else
 			pf->fname = NULL;
 		if (!pp->file || pf->fname) {
 			if (pp->function)
 				ret = find_probe_point_by_func(pf);
 			else if (pp->lazy_line)
 				ret = find_probe_point_lazy(NULL, pf);
 			else {
 				pf->lno = pp->line;
 				ret = find_probe_point_by_line(pf);
 			}
 			if (ret < 0)
 				break;
 		}
 		off = noff;
 	}
 found:
 	intlist__delete(pf->lcache);
 	pf->lcache = NULL;
 	return ret;
 }
 struct local_vars_finder {
 	struct probe_finder *pf;
 	struct perf_probe_arg *args;
 	int max_args;
 	int nargs;
 	int ret;
 };
 /* Collect available variables in this scope */
 static int copy_variables_cb(Dwarf_Die *die_mem, void *data)
 {
 	struct local_vars_finder *vf = data;
 	struct probe_finder *pf = vf->pf;
 	int tag;
 	tag = dwarf_tag(die_mem);
 	if (tag == DW_TAG_formal_parameter ||
 	    tag == DW_TAG_variable) {
 		if (convert_variable_location(die_mem, vf->pf->addr,
 					      vf->pf->fb_ops, &pf->sp_die,
 					      NULL) == 0) {
 			vf->args[vf->nargs].var = (char *)dwarf_diename(die_mem);
 			if (vf->args[vf->nargs].var == NULL) {
 				vf->ret = -ENOMEM;
 				return DIE_FIND_CB_END;
 			}
 			pr_debug(" %s", vf->args[vf->nargs].var);
 			vf->nargs++;
 		}
 	}
 	if (dwarf_haspc(die_mem, vf->pf->addr))
 		return DIE_FIND_CB_CONTINUE;
 	else
 		return DIE_FIND_CB_SIBLING;
 }
 static int expand_probe_args(Dwarf_Die *sc_die, struct probe_finder *pf,
 			     struct perf_probe_arg *args)
 {
 	Dwarf_Die die_mem;
 	int i;
 	int n = 0;
 	struct local_vars_finder vf = {.pf = pf, .args = args,
 				.max_args = MAX_PROBE_ARGS, .ret = 0};
 	for (i = 0; i < pf->pev->nargs; i++) {
 		/* var never be NULL */
 		if (strcmp(pf->pev->args[i].var, "$vars") == 0) {
 			pr_debug("Expanding $vars into:");
 			vf.nargs = n;
 			/* Special local variables */
 			die_find_child(sc_die, copy_variables_cb, (void *)&vf,
 				       &die_mem);
 			pr_debug(" (%d)\n", vf.nargs - n);
 			if (vf.ret < 0)
 				return vf.ret;
 			n = vf.nargs;
 		} else {
 			/* Copy normal argument */
 			args[n] = pf->pev->args[i];
 			n++;
 		}
 	}
 	return n;
 }
 /* Add a found probe point into trace event list */
 static int add_probe_trace_event(Dwarf_Die *sc_die, struct probe_finder *pf)
 {
 	struct trace_event_finder *tf =
 			container_of(pf, struct trace_event_finder, pf);
 	struct probe_trace_event *tev;
 	struct perf_probe_arg *args;
 	int ret, i;
 	/* Check number of tevs */
 	if (tf->ntevs == tf->max_tevs) {
 		pr_warning("Too many( > %d) probe point found.\n",
 			   tf->max_tevs);
 		return -ERANGE;
 	}
 	tev = &tf->tevs[tf->ntevs++];
 	/* Trace point should be converted from subprogram DIE */
 	ret = convert_to_trace_point(&pf->sp_die, tf->mod, pf->addr,
 				     pf->pev->point.retprobe, &tev->point);
 	if (ret < 0)
 		return ret;
 	pr_debug("Probe point found: %s+%lu\n", tev->point.symbol,
 		 tev->point.offset);
 	/* Expand special probe argument if exist */
 	args = zalloc(sizeof(struct perf_probe_arg) * MAX_PROBE_ARGS);
 	if (args == NULL)
 		return -ENOMEM;
 	ret = expand_probe_args(sc_die, pf, args);
 	if (ret < 0)
 		goto end;
 	tev->nargs = ret;
 	tev->args = zalloc(sizeof(struct probe_trace_arg) * tev->nargs);
 	if (tev->args == NULL) {
 		ret = -ENOMEM;
 		goto end;
 	}
 	/* Find each argument */
 	for (i = 0; i < tev->nargs; i++) {
 		pf->pvar = &args[i];
 		pf->tvar = &tev->args[i];
 		/* Variable should be found from scope DIE */
 		ret = find_variable(sc_die, pf);
 		if (ret != 0)
 			break;
 	}
 end:
 	free(args);
 	return ret;
 }
 /* Find probe_trace_events specified by perf_probe_event from debuginfo */
 int debuginfo__find_trace_events(struct debuginfo *dbg,
 				 struct perf_probe_event *pev,
 				 struct probe_trace_event **tevs, int max_tevs)
 {
 	struct trace_event_finder tf = {
 			.pf = {.pev = pev, .callback = add_probe_trace_event},
 			.mod = dbg->mod, .max_tevs = max_tevs};
 	int ret;
 	/* Allocate result tevs array */
 	*tevs = zalloc(sizeof(struct probe_trace_event) * max_tevs);
 	if (*tevs == NULL)
 		return -ENOMEM;
 	tf.tevs = *tevs;
 	tf.ntevs = 0;
 	ret = debuginfo__find_probes(dbg, &tf.pf);
 	if (ret < 0) {
 		zfree(tevs);
 		return ret;
 	}
 	return (ret < 0) ? ret : tf.ntevs;
 }
 #define MAX_VAR_LEN 64
 /* Collect available variables in this scope */
 static int collect_variables_cb(Dwarf_Die *die_mem, void *data)
 {
 	struct available_var_finder *af = data;
 	struct variable_list *vl;
 	char buf[MAX_VAR_LEN];
 	int tag, ret;
 	vl = &af->vls[af->nvls - 1];
 	tag = dwarf_tag(die_mem);
 	if (tag == DW_TAG_formal_parameter ||
 	    tag == DW_TAG_variable) {
 		ret = convert_variable_location(die_mem, af->pf.addr,
 						af->pf.fb_ops, &af->pf.sp_die,
 						NULL);
 		if (ret == 0) {
 			ret = die_get_varname(die_mem, buf, MAX_VAR_LEN);
 			pr_debug2("Add new var: %s\n", buf);
 			if (ret > 0)
 				strlist__add(vl->vars, buf);
 		}
 	}
 	if (af->child && dwarf_haspc(die_mem, af->pf.addr))
 		return DIE_FIND_CB_CONTINUE;
 	else
 		return DIE_FIND_CB_SIBLING;
 }
 /* Add a found vars into available variables list */
 static int add_available_vars(Dwarf_Die *sc_die, struct probe_finder *pf)
 {
 	struct available_var_finder *af =
 			container_of(pf, struct available_var_finder, pf);
 	struct variable_list *vl;
 	Dwarf_Die die_mem;
 	int ret;
 	/* Check number of tevs */
 	if (af->nvls == af->max_vls) {
 		pr_warning("Too many( > %d) probe point found.\n", af->max_vls);
 		return -ERANGE;
 	}
 	vl = &af->vls[af->nvls++];
 	/* Trace point should be converted from subprogram DIE */
 	ret = convert_to_trace_point(&pf->sp_die, af->mod, pf->addr,
 				     pf->pev->point.retprobe, &vl->point);
 	if (ret < 0)
 		return ret;
 	pr_debug("Probe point found: %s+%lu\n", vl->point.symbol,
 		 vl->point.offset);
 	/* Find local variables */
 	vl->vars = strlist__new(true, NULL);
 	if (vl->vars == NULL)
 		return -ENOMEM;
 	af->child = true;
 	die_find_child(sc_die, collect_variables_cb, (void *)af, &die_mem);
 	/* Find external variables */
 	if (!af->externs)
 		goto out;
 	/* Don't need to search child DIE for externs. */
 	af->child = false;
 	die_find_child(&pf->cu_die, collect_variables_cb, (void *)af, &die_mem);
 out:
 	if (strlist__empty(vl->vars)) {
 		strlist__delete(vl->vars);
 		vl->vars = NULL;
 	}
 	return ret;
 }
 /*
  * Find available variables at given probe point
  * Return the number of found probe points. Return 0 if there is no
  * matched probe point. Return <0 if an error occurs.
  */
 int debuginfo__find_available_vars_at(struct debuginfo *dbg,
 				      struct perf_probe_event *pev,
 				      struct variable_list **vls,
 				      int max_vls, bool externs)
 {
 	struct available_var_finder af = {
 			.pf = {.pev = pev, .callback = add_available_vars},
 			.mod = dbg->mod,
 			.max_vls = max_vls, .externs = externs};
 	int ret;
 	/* Allocate result vls array */
 	*vls = zalloc(sizeof(struct variable_list) * max_vls);
 	if (*vls == NULL)
 		return -ENOMEM;
 	af.vls = *vls;
 	af.nvls = 0;
 	ret = debuginfo__find_probes(dbg, &af.pf);
 	if (ret < 0) {
 		/* Free vlist for error */
 		while (af.nvls--) {
 			zfree(&af.vls[af.nvls].point.symbol);
 			strlist__delete(af.vls[af.nvls].vars);
 		}
 		zfree(vls);
 		return ret;
 	}
 	return (ret < 0) ? ret : af.nvls;
 }
 /* Reverse search */
 int debuginfo__find_probe_point(struct debuginfo *dbg, unsigned long addr,
 				struct perf_probe_point *ppt)
 {
 	Dwarf_Die cudie, spdie, indie;
 	Dwarf_Addr _addr = 0, baseaddr = 0;
 	const char *fname = NULL, *func = NULL, *basefunc = NULL, *tmp;
 	int baseline = 0, lineno = 0, ret = 0;
 	/* Adjust address with bias */
 	addr += dbg->bias;
 	/* Find cu die */
 	if (!dwarf_addrdie(dbg->dbg, (Dwarf_Addr)addr - dbg->bias, &cudie)) {
 		pr_warning("Failed to find debug information for address %lx\n",
 			   addr);
 		ret = -EINVAL;
 		goto end;
 	}
 	/* Find a corresponding line (filename and lineno) */
 	cu_find_lineinfo(&cudie, addr, &fname, &lineno);
 	/* Don't care whether it failed or not */
 	/* Find a corresponding function (name, baseline and baseaddr) */
 	if (die_find_realfunc(&cudie, (Dwarf_Addr)addr, &spdie)) {
 		/* Get function entry information */
 		func = basefunc = dwarf_diename(&spdie);
 		if (!func ||
 		    dwarf_entrypc(&spdie, &baseaddr) != 0 ||
 		    dwarf_decl_line(&spdie, &baseline) != 0) {
 			lineno = 0;
 			goto post;
 		}
 		fname = dwarf_decl_file(&spdie);
 		if (addr == (unsigned long)baseaddr) {
 			/* Function entry - Relative line number is 0 */
 			lineno = baseline;
 			goto post;
 		}
 		/* Track down the inline functions step by step */
 		while (die_find_top_inlinefunc(&spdie, (Dwarf_Addr)addr,
 						&indie)) {
 			/* There is an inline function */
 			if (dwarf_entrypc(&indie, &_addr) == 0 &&
 			    _addr == addr) {
 				/*
 				 * addr is at an inline function entry.
 				 * In this case, lineno should be the call-site
 				 * line number. (overwrite lineinfo)
 				 */
 				lineno = die_get_call_lineno(&indie);
 				fname = die_get_call_file(&indie);
 				break;
 			} else {
 				/*
 				 * addr is in an inline function body.
 				 * Since lineno points one of the lines
 				 * of the inline function, baseline should
 				 * be the entry line of the inline function.
 				 */
 				tmp = dwarf_diename(&indie);
 				if (!tmp ||
 				    dwarf_decl_line(&indie, &baseline) != 0)
 					break;
 				func = tmp;
 				spdie = indie;
 			}
 		}
 		/* Verify the lineno and baseline are in a same file */
 		tmp = dwarf_decl_file(&spdie);
 		if (!tmp || strcmp(tmp, fname) != 0)
 			lineno = 0;
 	}
 post:
 	/* Make a relative line number or an offset */
 	if (lineno)
 		ppt->line = lineno - baseline;
 	else if (basefunc) {
 		ppt->offset = addr - (unsigned long)baseaddr;
 		func = basefunc;
 	}
 	/* Duplicate strings */
 	if (func) {
 		ppt->function = strdup(func);
 		if (ppt->function == NULL) {
 			ret = -ENOMEM;
 			goto end;
 		}
 	}
 	if (fname) {
 		ppt->file = strdup(fname);
 		if (ppt->file == NULL) {
 			zfree(&ppt->function);
 			ret = -ENOMEM;
 			goto end;
 		}
 	}
 end:
 	if (ret == 0 && (fname || func))
 		ret = 1;	/* Found a point */
 	return ret;
 }
 /* Add a line and store the src path */
 static int line_range_add_line(const char *src, unsigned int lineno,
 			       struct line_range *lr)
 {
 	/* Copy source path */
 	if (!lr->path) {
 		lr->path = strdup(src);
 		if (lr->path == NULL)
 			return -ENOMEM;
 	}
 	return intlist__add(lr->line_list, lineno);
 }
 static int line_range_walk_cb(const char *fname, int lineno,
 			      Dwarf_Addr addr __maybe_unused,
 			      void *data)
 {
 	struct line_finder *lf = data;
 	int err;
 	if ((strtailcmp(fname, lf->fname) != 0) ||
 	    (lf->lno_s > lineno || lf->lno_e < lineno))
 		return 0;
 	err = line_range_add_line(fname, lineno, lf->lr);
 	if (err < 0 && err != -EEXIST)
 		return err;
 	return 0;
 }
 /* Find line range from its line number */
 static int find_line_range_by_line(Dwarf_Die *sp_die, struct line_finder *lf)
 {
 	int ret;
 	ret = die_walk_lines(sp_die ?: &lf->cu_die, line_range_walk_cb, lf);
 	/* Update status */
 	if (ret >= 0)
 		if (!intlist__empty(lf->lr->line_list))
 			ret = lf->found = 1;
 		else
 			ret = 0;	/* Lines are not found */
 	else {
 		zfree(&lf->lr->path);
 	}
 	return ret;
 }
 static int line_range_inline_cb(Dwarf_Die *in_die, void *data)
 {
 	int ret = find_line_range_by_line(in_die, data);
 	/*
 	 * We have to check all instances of inlined function, because
 	 * some execution paths can be optimized out depends on the
 	 * function argument of instances. However, if an error occurs,
 	 * it should be handled by the caller.
 	 */
 	return ret < 0 ? ret : 0;
 }
 /* Search function definition from function name */
 static int line_range_search_cb(Dwarf_Die *sp_die, void *data)
 {
 	struct dwarf_callback_param *param = data;
 	struct line_finder *lf = param->data;
 	struct line_range *lr = lf->lr;
 	/* Check declared file */
 	if (lr->file && strtailcmp(lr->file, dwarf_decl_file(sp_die)))
 		return DWARF_CB_OK;
 	if (die_is_func_def(sp_die) &&
 	    die_compare_name(sp_die, lr->function)) {
 		lf->fname = dwarf_decl_file(sp_die);
 		dwarf_decl_line(sp_die, &lr->offset);
 		pr_debug("fname: %s, lineno:%d\n", lf->fname, lr->offset);
 		lf->lno_s = lr->offset + lr->start;
 		if (lf->lno_s < 0)	/* Overflow */
 			lf->lno_s = INT_MAX;
 		lf->lno_e = lr->offset + lr->end;
 		if (lf->lno_e < 0)	/* Overflow */
 			lf->lno_e = INT_MAX;
 		pr_debug("New line range: %d to %d\n", lf->lno_s, lf->lno_e);
 		lr->start = lf->lno_s;
 		lr->end = lf->lno_e;
 		if (dwarf_func_inline(sp_die))
 			param->retval = die_walk_instances(sp_die,
 						line_range_inline_cb, lf);
 		else
 			param->retval = find_line_range_by_line(sp_die, lf);
 		return DWARF_CB_ABORT;
 	}
 	return DWARF_CB_OK;
 }
 static int find_line_range_by_func(struct line_finder *lf)
 {
 	struct dwarf_callback_param param = {.data = (void *)lf, .retval = 0};
 	dwarf_getfuncs(&lf->cu_die, line_range_search_cb, &param, 0);
 	return param.retval;
 }
 int debuginfo__find_line_range(struct debuginfo *dbg, struct line_range *lr)
 {
 	struct line_finder lf = {.lr = lr, .found = 0};
 	int ret = 0;
 	Dwarf_Off off = 0, noff;
 	size_t cuhl;
 	Dwarf_Die *diep;
 	const char *comp_dir;
 	/* Fastpath: lookup by function name from .debug_pubnames section */
 	if (lr->function) {
 		struct pubname_callback_param pubname_param = {
 			.function = lr->function, .file = lr->file,
 			.cu_die = &lf.cu_die, .sp_die = &lf.sp_die, .found = 0};
 		struct dwarf_callback_param line_range_param = {
 			.data = (void *)&lf, .retval = 0};
 		dwarf_getpubnames(dbg->dbg, pubname_search_cb,
 				  &pubname_param, 0);
 		if (pubname_param.found) {
 			line_range_search_cb(&lf.sp_die, &line_range_param);
 			if (lf.found)
 				goto found;
 		}
 	}
 	/* Loop on CUs (Compilation Unit) */
 	while (!lf.found && ret >= 0) {
 		if (dwarf_nextcu(dbg->dbg, off, &noff, &cuhl,
 				 NULL, NULL, NULL) != 0)
 			break;
 		/* Get the DIE(Debugging Information Entry) of this CU */
 		diep = dwarf_offdie(dbg->dbg, off + cuhl, &lf.cu_die);
 		if (!diep)
 			continue;
 		/* Check if target file is included. */
 		if (lr->file)
 			lf.fname = cu_find_realpath(&lf.cu_die, lr->file);
 		else
 			lf.fname = 0;
 		if (!lr->file || lf.fname) {
 			if (lr->function)
 				ret = find_line_range_by_func(&lf);
 			else {
 				lf.lno_s = lr->start;
 				lf.lno_e = lr->end;
 				ret = find_line_range_by_line(NULL, &lf);
 			}
 		}
 		off = noff;
 	}
 found:
 	/* Store comp_dir */
 	if (lf.found) {
 		comp_dir = cu_get_comp_dir(&lf.cu_die);
 		if (comp_dir) {
 			lr->comp_dir = strdup(comp_dir);
 			if (!lr->comp_dir)
 				ret = -ENOMEM;
 		}
 	}
 	pr_debug("path: %s\n", lr->path);
 	return (ret < 0) ? ret : lf.found;
 }