Eric Lee / smarc-ti-linux-kernel

09 Mar, 2012

1 commit

  • 2f16669d3   TTY: remove re-assignments to tty_driver members ... Browse Code »

    All num, magic and owner are set by alloc_tty_driver. No need to
    re-set them on each allocation site.

    pti driver sets something different to what it passes to
    alloc_tty_driver. It is not a bug, since we don't use the lines
    parameter in any way. Anyway this is fixed, and now we do the right
    thing.

    Signed-off-by: Jiri Slaby
    Acked-by: Tilman Schmidt
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

03 Feb, 2012

1 commit

27 May, 2011

1 commit

  • b7c2f0362   Merge branch 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6 ... Browse Code »

    * 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6:
    gfs2: Drop __TIME__ usage
    isdn/diva: Drop __TIME__ usage
    atm: Drop __TIME__ usage
    dlm: Drop __TIME__ usage
    wan/pc300: Drop __TIME__ usage
    parport: Drop __TIME__ usage
    hdlcdrv: Drop __TIME__ usage
    baycom: Drop __TIME__ usage
    pmcraid: Drop __DATE__ usage
    edac: Drop __DATE__ usage
    rio: Drop __DATE__ usage
    scsi/wd33c93: Drop __TIME__ usage
    scsi/in2000: Drop __TIME__ usage
    aacraid: Drop __TIME__ usage
    media/cx231xx: Drop __TIME__ usage
    media/radio-maxiradio: Drop __TIME__ usage
    nozomi: Drop __TIME__ usage
    cyclades: Drop __TIME__ usage

    Linus Torvalds
     

26 Apr, 2011

3 commits

  • 7fdc28931   Char: nozomi, remove useless tty_sem ... Browse Code »

    tty_sem used to protect tty open count. This was removed in 33dd474a
    but the lock remained in place.

    So remove it completely as it protects nothing now.

    Also this solves Mac's problem with inatomic operation called from
    atomic context (ppp):
    BUG: scheduling while atomic: firefox-bin/1992/0x10000800
    Modules linked in: ...
    Pid: 1992, comm: firefox-bin Not tainted 2.6.38 #1
    Call Trace:
    ...
    [] ? mutex_lock+0xe/0x21
    [] ? ntty_write+0x5d/0x192 [nozomi]
    [] ? __mod_timer.clone.30+0xbe/0xcc
    [] ? check_preempt_curr+0x60/0x6d
    [] ? __nf_ct_refresh_acct+0x75/0xbe
    [] ? ppp_async_push+0xa9/0x3bd [ppp_async]
    [] ? ppp_async_send+0x34/0x40 [ppp_async]
    [] ? ppp_push+0x6c/0x4f9 [ppp_generic]
    ...

    Signed-off-by: Jiri Slaby
    Reported-by: Mac
    Tested-by: Gerald Pfeifer
    Reviewed-by: Jack Stone
    Cc: Alan Cox
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • 6d742f655   Char: nozomi, remove port.count checks ... Browse Code »

    Before 33dd474a, these were some kind of protection against race with
    HUP. They were protected with port->tty_sem at the same time.

    By that commit, the counting was switched to tty_port's one, but the
    locking remained the old one. So the count was not protected by
    any lock anymore.

    The driver should not test whether it raced with HUP or not anyways.
    With the new refcounted tty model, it just should proceed as nothing
    happened because all needed info is still there. In respect to this,
    let's drop the useless and unprotected tests (tty_port->count is
    protected by tty_port->lock).

    Signed-off-by: Jiri Slaby
    Tested-by: Gerald Pfeifer
    Cc: Alan Cox
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     
  • c29bd8d89   Char: nozomi, use GFP_KERNEL for kfifo allocation ... Browse Code »

    The allocation was moved to probe function in 9842c38e9176. And we can
    sleep there. So allocate the 4*8192 bytes as GFP_KERNEL to mitigate
    the allocation failure.

    Signed-off-by: Jiri Slaby
    Tested-by: Gerald Pfeifer
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

19 Apr, 2011

1 commit

  • 2cae8de7b   nozomi: Drop __TIME__ usage ... Browse Code »

    The kernel already prints its build timestamp during boot, no need to
    repeat it in random drivers and produce different object files each
    time.

    Acked-by: Greg Kroah-Hartman
    Signed-off-by: Michal Marek

    Michal Marek
     

31 Mar, 2011

1 commit

26 Feb, 2011

1 commit

  • 2c590f3ca   nozomi: don't use flush_scheduled_work() ... Browse Code »

    flush_scheduled_work() in tty_exit() doesn't seem to target any
    specific work. If it was to flush work items used in tty generic
    layer, they're already flushed properly during tty release.

    flush_scheduled_work() is going away. Remove the seemingly redundant
    usage.

    Signed-off-by: Tejun Heo
    Cc: Jiri Slaby
    Cc: Alan Cox
    Signed-off-by: Greg Kroah-Hartman

    Tejun Heo
     

23 Feb, 2011

1 commit