14 Jan, 2014

1 commit


08 Jan, 2014

1 commit


04 Jan, 2014

1 commit

  • Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be
    used when each argument is an array within a structure that contains at
    least two bytes of data beyond the array.

    The structures involved are:
    ieee80211_hdr defined in include/linux/ieee80211.h and
    rtl_mac defined in drivers/net/wireless/rtlwifi/wifi.h

    This was done using Coccinelle (http://coccinelle.lip6.fr/).

    Signed-off-by: Julia Lawall
    Acked-by: Larry Finger
    Signed-off-by: John W. Linville

    Julia Lawall
     

06 Dec, 2013

1 commit


12 Nov, 2013

1 commit

  • All of the rtlwifi drivers have an error in the routine that tests if
    the data is "special". If it is, the subsequant transmission will be
    at the lowest rate to enhance reliability. The 16-bit quantity is
    big-endian, but was being extracted in native CPU mode. One of the
    effects of this bug is to inhibit association under some conditions
    as the TX rate is too high.

    Based on suggestions by Joe Perches, the entire routine is rewritten.

    One of the local headers contained duplicates of some of the ETH_P_XXX
    definitions. These are deleted.

    Signed-off-by: Larry Finger
    Cc: Mark Cave-Ayland
    Cc: Stable [2.6.38+]
    Signed-off-by: John W. Linville

    Mark Cave-Ayland
     

04 Oct, 2013

1 commit


04 Sep, 2013

1 commit

  • Use the new bool function ether_addr_equal to add
    some clarity and reduce the likelihood for misuse
    of compare_ether_addr for sorting.

    Done via cocci script: (and a little typing)

    $ cat compare_ether_addr.cocci
    @@
    expression a,b;
    @@
    - !compare_ether_addr(a, b)
    + ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - compare_ether_addr(a, b)
    + !ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - !ether_addr_equal(a, b) == 0
    + ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - !ether_addr_equal(a, b) != 0
    + !ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - ether_addr_equal(a, b) == 0
    + !ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - ether_addr_equal(a, b) != 0
    + ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - !!ether_addr_equal(a, b)
    + ether_addr_equal(a, b)

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

19 Jul, 2013

1 commit

  • The present build configuration for the rtlwifi family of drivers will
    fail under two known conditions:

    (1) If rtlwifi is selected without selecting any of the dependent drivers,
    there are errors in the build.
    (2) If the PCI drivers are built into the kernel and the USB drivers are modules,
    or vice versa, there are missing globals.

    The first condition is fixed by never building rtlwifi unless at least one
    of the device drivers is selected. The second failure is fixed by splitting
    the PCI and USB codes out of rtlwifi, and creating their own mini drivers.
    If the drivers that use them are modules, they will also be modules.

    Although a number of files are touched by this patch, only Makefile and Kconfig
    have undergone significant changes. The only modifications to the other files
    were to export entry points needed by the new rtl_pci and rtl_usb units, or to
    rename two variables that had names that were likely to cause namespace collisions.

    Reported-by: Fengguang Wu [Condition 1]
    Reported-by: Ben Hutchings [Condition 2]
    Signed-off-by: Larry Finger
    Cc: Ben Hutchings
    Cc: Fengguang Wu
    Signed-off-by: John W. Linville

    Larry Finger
     

10 Jul, 2013

1 commit

  • Pull networking updates from David Miller:
    "This is a re-do of the net-next pull request for the current merge
    window. The only difference from the one I made the other day is that
    this has Eliezer's interface renames and the timeout handling changes
    made based upon your feedback, as well as a few bug fixes that have
    trickeled in.

    Highlights:

    1) Low latency device polling, eliminating the cost of interrupt
    handling and context switches. Allows direct polling of a network
    device from socket operations, such as recvmsg() and poll().

    Currently ixgbe, mlx4, and bnx2x support this feature.

    Full high level description, performance numbers, and design in
    commit 0a4db187a999 ("Merge branch 'll_poll'")

    From Eliezer Tamir.

    2) With the routing cache removed, ip_check_mc_rcu() gets exercised
    more than ever before in the case where we have lots of multicast
    addresses. Use a hash table instead of a simple linked list, from
    Eric Dumazet.

    3) Add driver for Atheros CQA98xx 802.11ac wireless devices, from
    Bartosz Markowski, Janusz Dziedzic, Kalle Valo, Marek Kwaczynski,
    Marek Puzyniak, Michal Kazior, and Sujith Manoharan.

    4) Support reporting the TUN device persist flag to userspace, from
    Pavel Emelyanov.

    5) Allow controlling network device VF link state using netlink, from
    Rony Efraim.

    6) Support GRE tunneling in openvswitch, from Pravin B Shelar.

    7) Adjust SOCK_MIN_RCVBUF and SOCK_MIN_SNDBUF for modern times, from
    Daniel Borkmann and Eric Dumazet.

    8) Allow controlling of TCP quickack behavior on a per-route basis,
    from Cong Wang.

    9) Several bug fixes and improvements to vxlan from Stephen
    Hemminger, Pravin B Shelar, and Mike Rapoport. In particular,
    support receiving on multiple UDP ports.

    10) Major cleanups, particular in the area of debugging and cookie
    lifetime handline, to the SCTP protocol code. From Daniel
    Borkmann.

    11) Allow packets to cross network namespaces when traversing tunnel
    devices. From Nicolas Dichtel.

    12) Allow monitoring netlink traffic via AF_PACKET sockets, in a
    manner akin to how we monitor real network traffic via ptype_all.
    From Daniel Borkmann.

    13) Several bug fixes and improvements for the new alx device driver,
    from Johannes Berg.

    14) Fix scalability issues in the netem packet scheduler's time queue,
    by using an rbtree. From Eric Dumazet.

    15) Several bug fixes in TCP loss recovery handling, from Yuchung
    Cheng.

    16) Add support for GSO segmentation of MPLS packets, from Simon
    Horman.

    17) Make network notifiers have a real data type for the opaque
    pointer that's passed into them. Use this to properly handle
    network device flag changes in arp_netdev_event(). From Jiri
    Pirko and Timo Teräs.

    18) Convert several drivers over to module_pci_driver(), from Peter
    Huewe.

    19) tcp_fixup_rcvbuf() can loop 500 times over loopback, just use a
    O(1) calculation instead. From Eric Dumazet.

    20) Support setting of explicit tunnel peer addresses in ipv6, just
    like ipv4. From Nicolas Dichtel.

    21) Protect x86 BPF JIT against spraying attacks, from Eric Dumazet.

    22) Prevent a single high rate flow from overruning an individual cpu
    during RX packet processing via selective flow shedding. From
    Willem de Bruijn.

    23) Don't use spinlocks in TCP md5 signing fast paths, from Eric
    Dumazet.

    24) Don't just drop GSO packets which are above the TBF scheduler's
    burst limit, chop them up so they are in-bounds instead. Also
    from Eric Dumazet.

    25) VLAN offloads are missed when configured on top of a bridge, fix
    from Vlad Yasevich.

    26) Support IPV6 in ping sockets. From Lorenzo Colitti.

    27) Receive flow steering targets should be updated at poll() time
    too, from David Majnemer.

    28) Fix several corner case regressions in PMTU/redirect handling due
    to the routing cache removal, from Timo Teräs.

    29) We have to be mindful of ipv4 mapped ipv6 sockets in
    upd_v6_push_pending_frames(). From Hannes Frederic Sowa.

    30) Fix L2TP sequence number handling bugs, from James Chapman."

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1214 commits)
    drivers/net: caif: fix wrong rtnl_is_locked() usage
    drivers/net: enic: release rtnl_lock on error-path
    vhost-net: fix use-after-free in vhost_net_flush
    net: mv643xx_eth: do not use port number as platform device id
    net: sctp: confirm route during forward progress
    virtio_net: fix race in RX VQ processing
    virtio: support unlocked queue poll
    net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit
    Documentation: Fix references to defunct linux-net@vger.kernel.org
    net/fs: change busy poll time accounting
    net: rename low latency sockets functions to busy poll
    bridge: fix some kernel warning in multicast timer
    sfc: Fix memory leak when discarding scattered packets
    sit: fix tunnel update via netlink
    dt:net:stmmac: Add dt specific phy reset callback support.
    dt:net:stmmac: Add support to dwmac version 3.610 and 3.710
    dt:net:stmmac: Allocate platform data only if its NULL.
    net:stmmac: fix memleak in the open method
    ipv6: rt6_check_neigh should successfully verify neigh if no NUD information are available
    net: ipv6: fix wrong ping_v6_sendmsg return value
    ...

    Linus Torvalds
     

04 Jul, 2013

1 commit

  • For the workqueue creation interfaces that do not expect format strings,
    make sure they cannot accidently be parsed that way. Additionally, clean
    up calls made with a single parameter that would be handled as a format
    string. Many callers are passing potentially dynamic string content, so
    use "%s" in those cases to avoid any potential accidents.

    Signed-off-by: Kees Cook
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kees Cook
     

03 Jun, 2013

1 commit


11 Apr, 2013

1 commit


02 Apr, 2013

3 commits

  • …red by adding rtl81988ee

    This patch combines the remaining changes in the rtlwifi family to handle
    the addition of rtl8188ee. A number of these changes eliminate some CamelCase
    variable names, and other shorten common variable names so that long lines
    in the new driver could be shortened.

    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Cc: jcheung@suse.com
    Cc: machen@suse.com
    Cc: mmarek@suse.cz
    Cc: zhiyuan_yang@realsil.com.cn
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

    Larry Finger
     
  • In commit a5ffbe0, some of the calls to rtl_lps_leave() were switched
    to be called from a work queue to avoid a scheduling while atomic bug.
    This patch converts the remaining calls to use the work queue. In
    addition, the call to rtl_lps_enter() is also switched to the work
    queue. None of these newly converted calls had triggered the bug (yet),
    but this change make all of them fit a single pattern.

    Signed-off-by: Larry Finger
    Cc: jcheung@suse.com
    Cc: machen@suse.com
    Cc: mmarek@suse.cz
    Cc: zhiyuan_yang@realsil.com.cn
    Cc: page_he@realsil.com.cn
    Signed-off-by: John W. Linville

    Larry Finger
     
  • These changes add the new variables for P2P and modify the various struct
    definitions for other new features.

    This patch updates files base.{c,h} for the changes in the newest vendor
    driver.

    This patch updates files ps.{c,h} for the changes in the newest vendor
    driver.

    This patch updates files debug.{c,h}, efuse.c, pci.{c,h}, and wifi.h for
    the changes in the newest vendor driver.

    This patch updates files core.c, ps.c, rc.c, and wifi.h for
    the changes in the newest vendor driver.

    Signed-off-by: Larry Finger
    Cc: jcheung@suse.com
    Cc: machen@suse.com
    Cc: mmarek@suse.cz
    Cc: zhiyuan_yang@realsil.com.cn
    Cc: page_he@realsil.com.cn
    Signed-off-by: John W. Linville

    Larry Finger
     

26 Mar, 2013

1 commit


16 Feb, 2013

1 commit


15 Feb, 2013

1 commit

  • For VHT, many more bandwidth changes are possible. As a first
    step, stop toggling the IEEE80211_HT_CAP_SUP_WIDTH_20_40 flag
    in the HT capabilities and instead introduce a bandwidth field
    indicating the currently usable bandwidth to transmit to the
    station. Of course, make all drivers use it.

    To achieve this, make ieee80211_ht_cap_ie_to_sta_ht_cap() get
    the station as an argument, rather than the new capabilities,
    so it can set up the new bandwidth field.

    If the station is a VHT station and VHT bandwidth is in use,
    also set the bandwidth accordingly.

    Doing this allows us to get rid of the supports_40mhz flag as
    the HT capabilities now reflect the true capability instead of
    the current setting.

    While at it, also fix ieee80211_ht_cap_ie_to_sta_ht_cap() to not
    ignore HT cap overrides when MCS TX isn't supported (not that it
    really happens...)

    Signed-off-by: Johannes Berg

    Johannes Berg
     

05 Feb, 2013

1 commit

  • Kernel commits 41affd5 and 6539306 changed the locking in rtl_lps_leave()
    from a spinlock to a mutex by doing the calls indirectly from a work queue
    to reduce the time that interrupts were disabled. This change was fine for
    most systems; however a scheduling while atomic bug was reported in
    https://bugzilla.redhat.com/show_bug.cgi?id=903881. The backtrace indicates
    that routine rtl_is_special(), which calls rtl_lps_leave() in three places
    was entered in atomic context. These direct calls are replaced by putting a
    request on the appropriate work queue.

    Signed-off-by: Larry Finger
    Reported-and-tested-by: Nathaniel Doherty
    Cc: Nathaniel Doherty
    Cc: Stanislaw Gruszka
    Cc: Stable
    Signed-off-by: John W. Linville

    Larry Finger
     

15 Nov, 2012

1 commit


31 Jul, 2012

1 commit

  • Remove the control.sta pointer from ieee80211_tx_info to free up
    sufficient space in the TX skb control buffer for the upcoming
    Transmit Power Control (TPC).
    Instead, the pointer is now on the stack in a new control struct
    that is passed as a function parameter to the drivers' tx method.

    Signed-off-by: Thomas Huehn
    Signed-off-by: Alina Friedrichsen
    Signed-off-by: Felix Fietkau
    [reworded commit message]
    Signed-off-by: Johannes Berg

    Thomas Huehn
     

21 Jul, 2012

1 commit


13 Jul, 2012

1 commit


07 Jun, 2012

1 commit

  • Adding casts of objects to the same type is unnecessary
    and confusing for a human reader.

    For example, this cast:

    int y;
    int *p = (int *)&y;

    I used the coccinelle script below to find and remove these
    unnecessary casts. I manually removed the conversions this
    script produces of casts with __force, __iomem and __user.

    @@
    type T;
    T *p;
    @@

    - (T *)p
    + p

    Neatened the mwifiex_deauthenticate_infra function which
    was doing odd things with array pointers and not using
    is_zero_ether_addr.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

11 May, 2012

1 commit

  • Use the new bool function ether_addr_equal to add
    some clarity and reduce the likelihood for misuse
    of compare_ether_addr for sorting.

    Done via cocci script:

    $ cat compare_ether_addr.cocci
    @@
    expression a,b;
    @@
    - !compare_ether_addr(a, b)
    + ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - compare_ether_addr(a, b)
    + !ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - !ether_addr_equal(a, b) == 0
    + ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - !ether_addr_equal(a, b) != 0
    + !ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - ether_addr_equal(a, b) == 0
    + !ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - ether_addr_equal(a, b) != 0
    + ether_addr_equal(a, b)

    @@
    expression a,b;
    @@
    - !!ether_addr_equal(a, b)
    + ether_addr_equal(a, b)

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

10 Apr, 2012

1 commit

  • When the rate-control indexing is incorrectly set up, mac80211 issues
    a warning and returns NULL from the call to ieee80211_get_tx_rate().
    When this happens, avoid a NULL pointer dereference.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

23 Feb, 2012

1 commit


31 Jan, 2012

2 commits

  • This patch addresses a kernel bugzilla report and two recent mail threads.

    The kernel bugzilla report is https://bugzilla.kernel.org/show_bug.cgi?id=42632,
    which reports a udev timeout on boot.

    The first mail thread, which was on LKML (http://lkml.indiana.edu/hypermail/
    linux/kernel/1112.3/00965.html) was for a WARNING that occurs after a
    suspend/resume cycle for rtl8192cu.

    The scond mail thread (http://marc.info/?l=linux-wireless&m=132655490826766&w=2)
    concerned changes in udev that break drivers that delay while firmware is loaded
    on modprobe.

    This patch converts all rtlwifi-based drivers to use the asynchronous firmware
    loading mechanism. Drivers rtl8192ce, rtl8192cu and rtl8192de share a common
    callback routine. Driver rtl8192se needs different handling of the firmware,
    thus it has its own code.

    Signed-off-by: Larry Finger
    Cc: Stable
    Signed-off-by: John W. Linville

    Larry Finger
     
  • Although the rtlwifi family of devices contains 11 copies of the pr_fmt
    macro, the macro is not defined for all routines that need it. By moving
    the macro to wifi.h, a single copy is available for all routines.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

28 Jan, 2012

1 commit

  • Due to firmware limitations, we may not be able to
    support beacon filtering on all virtual interfaces.
    To allow this in mac80211, introduce per-interface
    driver capability flags that the driver sets when
    an interface is added.

    Signed-off-by: Johannes Berg
    Acked-by: Luciano Coelho
    Signed-off-by: John W. Linville

    Johannes Berg
     

25 Jan, 2012

2 commits

  • Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     
  • Consolidate printks to avoid possible message interleaving
    and reduce the object size.

    Remove unnecessary RT_TRACE parentheses.

    Miscellaneous typo and grammar fixes.
    Add missing newlines to formats.
    Remove duplicate KERN_DEBUG prefixes.
    Coalesce formats.
    Align arguments.

    $ size drivers/net/wireless/rtlwifi/built-in.o*
    text data bss dec hex filename
    594841 55333 129680 779854 be64e drivers/net/wireless/rtlwifi/built-in.o.new
    607022 55333 138720 801075 c3933 drivers/net/wireless/rtlwifi/built-in.o.old

    Signed-off-by: Joe Perches
    Acked-by: Larry Finger
    Signed-off-by: John W. Linville

    Joe Perches
     

04 Jan, 2012

1 commit


20 Dec, 2011

2 commits

  • DaveM said:
    Please, this kind of stuff rots forever and not using bool properly
    drives me crazy.

    Joe Perches gave me the spatch script:

    @@
    bool b;
    @@
    -b = 0
    +b = false
    @@
    bool b;
    @@
    -b = 1
    +b = true

    I merely installed coccinelle, read the documentation and took credit.

    Signed-off-by: Rusty Russell
    Signed-off-by: David S. Miller

    Rusty Russell
     
  • When I tested commit 6539306, I did not notice that loading an out-of-tree
    module turns off lockdep testing in kernel 3.2. For that reason, I missed
    the kernel WARNING shown below:

    The solution fixes the warning by partially reverting commit 6539306.

    [ 84.168146] ------------[ cut here ]------------
    [ 84.168155] WARNING: at kernel/mutex.c:198 mutex_lock_nested+0x309/0x310()
    [ 84.168158] Hardware name: HP Pavilion dv2700 Notebook PC
    [ 84.168161] Modules linked in: nfs lockd auth_rpcgss nfs_acl sunrpc af_packet cpufreq_conservative cpufreq_userspace cpufreq_powersave powernow_k8 mperf e
    xt3 jbd ide_cd_mod cdrom snd_hda_codec_conexant arc4 rtl8192ce ide_pci_generic rtl8192c_common rtlwifi snd_hda_intel mac80211 snd_hda_codec snd_pcm snd_timer
    amd74xx ide_core cfg80211 k8temp snd joydev soundcore hwmon battery forcedeth i2c_nforce2 sg rfkill ac serio_raw snd_page_alloc button video i2c_core ipv6 a
    utofs4 ext4 mbcache jbd2 crc16 sd_mod ahci ohci_hcd libahci libata scsi_mod ehci_hcd usbcore usb_common fan processor thermal
    [ 84.168231] Pid: 1218, comm: kworker/u:2 Not tainted 3.2.0-rc5-wl+ #155
    [ 84.168234] Call Trace:
    [ 84.168240] [] warn_slowpath_common+0x7a/0xb0
    [ 84.168245] [] warn_slowpath_null+0x15/0x20
    [ 84.168249] [] mutex_lock_nested+0x309/0x310
    [ 84.168269] [] ? rtl_ips_nic_on+0x49/0xb0 [rtlwifi]
    [ 84.168277] [] rtl_ips_nic_on+0x49/0xb0 [rtlwifi]
    [ 84.168284] [] rtl_pci_tx+0x1b5/0x560 [rtlwifi]
    [ 84.168291] [] rtl_op_tx+0x9a/0xa0 [rtlwifi]
    [ 84.168359] [] __ieee80211_tx+0x181/0x2b0 [mac80211]
    [ 84.168375] [] ieee80211_tx+0xf6/0x120 [mac80211]
    [ 84.168391] [] ? ieee80211_tx+0x39/0x120 [mac80211]
    [ 84.168408] [] ieee80211_xmit+0xdb/0x100 [mac80211]
    [ 84.168425] [] ? ieee80211_skb_resize.isra.26+0xb0/0xb0 [mac80211]
    [ 84.168441] [] ieee80211_tx_skb_tid+0x5a/0x70 [mac80211]
    [ 84.168458] [] ieee80211_send_auth+0x152/0x1b0 [mac80211]
    [ 84.168474] [] ieee80211_work_work+0x1049/0x1860 [mac80211]
    [ 84.168489] [] ? free_work+0x20/0x20 [mac80211]
    [ 84.168504] [] ? free_work+0x20/0x20 [mac80211]
    [ 84.168510] [] process_one_work+0x17c/0x530
    [ 84.168514] [] ? process_one_work+0x112/0x530
    [ 84.168519] [] worker_thread+0x164/0x350
    [ 84.168524] [] ? trace_hardirqs_on+0xd/0x10
    [ 84.168528] [] ? manage_workers.isra.28+0x220/0x220
    [ 84.168533] [] kthread+0x87/0x90
    [ 84.168539] [] kernel_thread_helper+0x4/0x10
    [ 84.168543] [] ? retint_restore_args+0xe/0xe
    [ 84.168547] [] ? __init_kthread_worker+0x70/0x70
    [ 84.168552] [] ? gs_change+0xb/0xb
    [ 84.168554] ---[ end trace f25a4fdc768c028f ]---

    Signed-off-by: Larry Finger
    Cc: Stanislaw Gruska
    Cc: Chaoming Li
    Signed-off-by: John W. Linville

    Larry Finger
     

14 Dec, 2011

1 commit

  • With previous patch "rtlwifi: use work for lps" we can now use mutex for
    protecting ps mode changing critical sections. This fixes running system
    with interrupts disabled for long time.

    Merge ips_lock and lps_lock as they seems to protect the same data
    structures (accessed in rtl_ps_set_rf_state() function).

    Reported-by: Philipp Dreimann
    Tested-by: Larry Finger
    Cc: Mike McCormack
    Cc: Chaoming Li
    Signed-off-by: Stanislaw Gruszka
    Signed-off-by: Larry Finger
    Tested-by: Tim Gardner
    Signed-off-by: John W. Linville

    Stanislaw Gruszka
     

23 Nov, 2011

1 commit


22 Nov, 2011

1 commit

  • Driver rtlwifi fails on a big-endian host.

    These changes have been tested on a Mac PowerBook G4, which has
    a PPC processor.

    Although this patch touches some of the code that will affect endian
    issues on PCI hardware through drivers rtl8192ce, rtl8192se, and
    rtl8192de, these have not been tested due to lack of suitable hardware.

    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Larry Finger
     

01 Nov, 2011

1 commit


15 Oct, 2011

1 commit

  • This patch incorporate the differences between the 06/20/2011 and
    08/16/2011 Realtek releases of the rtlwifi driver.

    The changes include:

    1. Handling of IEEE80211_HW_CONNECTION_MONITOR.
    2. Fix typo to get proper response to nullfunc frames.

    Signed-off-by: Chaoming Li
    Signed-off-by: Larry Finger
    Signed-off-by: John W. Linville

    Chaoming Li