Commit 099c2f21d8cf0724b85abb2c589d6276953781b7

Authored by Phil Carmody
Committed by Greg Kroah-Hartman
1 parent 66ecb92be9

Driver core: driver_attribute parameters can often be const*

Many struct driver_attribute descriptors are purely read-only
structures, and there's no need to change them. Therefore make
the promise not to, which will let those descriptors be put in
a ro section.

Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Showing 4 changed files with 8 additions and 8 deletions Side-by-side Diff

Documentation/driver-model/driver.txt
... ... @@ -226,6 +226,6 @@
226 226 This can then be used to add and remove the attribute from the
227 227 driver's directory using:
228 228  
229   -int driver_create_file(struct device_driver *, struct driver_attribute *);
230   -void driver_remove_file(struct device_driver *, struct driver_attribute *);
  229 +int driver_create_file(struct device_driver *, const struct driver_attribute *);
  230 +void driver_remove_file(struct device_driver *, const struct driver_attribute *);
Documentation/filesystems/sysfs.txt
... ... @@ -358,6 +358,6 @@
358 358  
359 359 Creation/Removal:
360 360  
361   -int driver_create_file(struct device_driver *, struct driver_attribute *);
362   -void driver_remove_file(struct device_driver *, struct driver_attribute *);
  361 +int driver_create_file(struct device_driver *, const struct driver_attribute *);
  362 +void driver_remove_file(struct device_driver *, const struct driver_attribute *);
drivers/base/driver.c
... ... @@ -98,7 +98,7 @@
98 98 * @attr: driver attribute descriptor.
99 99 */
100 100 int driver_create_file(struct device_driver *drv,
101   - struct driver_attribute *attr)
  101 + const struct driver_attribute *attr)
102 102 {
103 103 int error;
104 104 if (drv)
... ... @@ -115,7 +115,7 @@
115 115 * @attr: driver attribute descriptor.
116 116 */
117 117 void driver_remove_file(struct device_driver *drv,
118   - struct driver_attribute *attr)
  118 + const struct driver_attribute *attr)
119 119 {
120 120 if (drv)
121 121 sysfs_remove_file(&drv->p->kobj, &attr->attr);
include/linux/device.h
... ... @@ -166,9 +166,9 @@
166 166 __ATTR(_name, _mode, _show, _store)
167 167  
168 168 extern int __must_check driver_create_file(struct device_driver *driver,
169   - struct driver_attribute *attr);
  169 + const struct driver_attribute *attr);
170 170 extern void driver_remove_file(struct device_driver *driver,
171   - struct driver_attribute *attr);
  171 + const struct driver_attribute *attr);
172 172  
173 173 extern int __must_check driver_add_kobj(struct device_driver *drv,
174 174 struct kobject *kobj,