Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 0a0aee203c202e946a1e7dee3d40714dbab951a4

Authored by Andy Shevchenko
Committed by Vinod Koul
1 parent da0a908ed9
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

tegra20-apb-dma: remove useless use of lock 

Accordingly to dma_cookie_status() description locking is not required.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Showing 1 changed file with 3 additions and 5 deletions Side-by-side Diff

drivers/dma/tegra20-apb-dma.c
Diff comments   View file @ 0a0aee2
... ... @@ -767,13 +767,11 @@
767 767 unsigned long flags;
768 768 unsigned int residual;
769 769  
770   - spin_lock_irqsave(&tdc->lock, flags);
771   -
772 770 ret = dma_cookie_status(dc, cookie, txstate);
773   - if (ret == DMA_SUCCESS) {
774   - spin_unlock_irqrestore(&tdc->lock, flags);
  771 + if (ret == DMA_SUCCESS)
775 772 return ret;
776   - }
  773 +
  774 + spin_lock_irqsave(&tdc->lock, flags);
777 775  
778 776 /* Check on wait_ack desc status */
779 777 list_for_each_entry(dma_desc, &tdc->free_dma_desc, node) {