Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 0c6516ea46191e0385a9f8489c672ebfbc10d490

Authored by Jingoo Han
Committed by Linus Torvalds
1 parent 0fae82378a
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug() 

Fix the checkpatch warning as below:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 4 additions and 6 deletions Side-by-side Diff

drivers/rtc/rtc-rs5c372.c
Diff comments   View file @ 0c6516e
... ... @@ -311,8 +311,7 @@
311 311 buf &= ~RS5C_CTRL1_AALE;
312 312  
313 313 if (i2c_smbus_write_byte_data(client, addr, buf) < 0) {
314   - printk(KERN_WARNING "%s: can't update alarm\n",
315   - rs5c->rtc->name);
  314 + dev_warn(dev, "can't update alarm\n");
316 315 status = -EIO;
317 316 } else
318 317 rs5c->regs[RS5C_REG_CTRL1] = buf;
... ... @@ -381,7 +380,7 @@
381 380 addr = RS5C_ADDR(RS5C_REG_CTRL1);
382 381 buf[0] = rs5c->regs[RS5C_REG_CTRL1] & ~RS5C_CTRL1_AALE;
383 382 if (i2c_smbus_write_byte_data(client, addr, buf[0]) < 0) {
384   - pr_debug("%s: can't disable alarm\n", rs5c->rtc->name);
  383 + dev_dbg(dev, "can't disable alarm\n");
385 384 return -EIO;
386 385 }
387 386 rs5c->regs[RS5C_REG_CTRL1] = buf[0];
... ... @@ -395,7 +394,7 @@
395 394 for (i = 0; i < sizeof(buf); i++) {
396 395 addr = RS5C_ADDR(RS5C_REG_ALARM_A_MIN + i);
397 396 if (i2c_smbus_write_byte_data(client, addr, buf[i]) < 0) {
398   - pr_debug("%s: can't set alarm time\n", rs5c->rtc->name);
  397 + dev_dbg(dev, "can't set alarm time\n");
399 398 return -EIO;
400 399 }
401 400 }
... ... @@ -405,8 +404,7 @@
405 404 addr = RS5C_ADDR(RS5C_REG_CTRL1);
406 405 buf[0] = rs5c->regs[RS5C_REG_CTRL1] | RS5C_CTRL1_AALE;
407 406 if (i2c_smbus_write_byte_data(client, addr, buf[0]) < 0)
408   - printk(KERN_WARNING "%s: can't enable alarm\n",
409   - rs5c->rtc->name);
  407 + dev_warn(dev, "can't enable alarm\n");
410 408 rs5c->regs[RS5C_REG_CTRL1] = buf[0];
411 409 }
412 410