Commit 0ca30b1b6aaab682ce762809f93bb78d6650de89

Authored by Peter Senna Tschudin
Committed by Florian Tobias Schandinat
1 parent caf0a5c9e1

drivers/video/bw2.c: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

... ... @@ -319,8 +319,10 @@
319 319  
320 320 info->screen_base = of_ioremap(&op->resource[0], 0,
321 321 info->fix.smem_len, "bw2 ram");
322   - if (!info->screen_base)
  322 + if (!info->screen_base) {
  323 + err = -ENOMEM;
323 324 goto out_unmap_regs;
  325 + }
324 326  
325 327 bw2_blank(FB_BLANK_UNBLANK, info);
326 328