Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 0da9a0c2638c8476b4a5021841912f249e3187dc

Authored by Tommi Rantala
Committed by David S. Miller
1 parent 80d11788fb
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

sctp: fix /proc/net/sctp/ memory leak 

Commit 13d782f ("sctp: Make the proc files per network namespace.")
changed the /proc/net/sctp/ struct file_operations opener functions to
use single_open_net() and seq_open_net().

Avoid leaking memory by using single_release_net() and seq_release_net()
as the release functions.

Discovered with Trinity (the syscall fuzzer).

Signed-off-by: Tommi Rantala <tt.rantala@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 4 additions and 4 deletions Side-by-side Diff

... ... @@ -102,7 +102,7 @@
102 102 .open = sctp_snmp_seq_open,
103 103 .read = seq_read,
104 104 .llseek = seq_lseek,
105   - .release = single_release,
  105 + .release = single_release_net,
106 106 };
107 107  
108 108 /* Set up the proc fs entry for 'snmp' object. */
... ... @@ -251,7 +251,7 @@
251 251 .open = sctp_eps_seq_open,
252 252 .read = seq_read,
253 253 .llseek = seq_lseek,
254   - .release = seq_release,
  254 + .release = seq_release_net,
255 255 };
256 256  
257 257 /* Set up the proc fs entry for 'eps' object. */
... ... @@ -372,7 +372,7 @@
372 372 .open = sctp_assocs_seq_open,
373 373 .read = seq_read,
374 374 .llseek = seq_lseek,
375   - .release = seq_release,
  375 + .release = seq_release_net,
376 376 };
377 377  
378 378 /* Set up the proc fs entry for 'assocs' object. */
... ... @@ -517,7 +517,7 @@
517 517 .open = sctp_remaddr_seq_open,
518 518 .read = seq_read,
519 519 .llseek = seq_lseek,
520   - .release = seq_release,
  520 + .release = seq_release_net,
521 521 };
522 522  
523 523 int __net_init sctp_remaddr_proc_init(struct net *net)