Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 1107ca104f0331627f6446bfefa2d4b0e673db18

Authored by Mathias Nyman
Committed by Linus Walleij
1 parent de0ccf7881
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

gpiolib-acpi: Fix error checks in interrupt requesting 

Print error message if requesting an interrupt fails.
Use int instead of unsigned for interrupts in case of error values

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Showing 1 changed file with 7 additions and 2 deletions Side-by-side Diff

drivers/gpio/gpiolib-acpi.c
Diff comments   View file @ 1107ca1
... ... @@ -83,7 +83,8 @@
83 83 struct acpi_resource *res;
84 84 acpi_handle handle, ev_handle;
85 85 acpi_status status;
86   - unsigned int pin, irq;
  86 + unsigned int pin;
  87 + int irq, ret;
87 88 char ev_name[5];
88 89  
89 90 if (!chip->dev || !chip->to_irq)
90 91  
... ... @@ -126,11 +127,15 @@
126 127 continue;
127 128  
128 129 /* Assume BIOS sets the triggering, so no flags */
129   - devm_request_threaded_irq(chip->dev, irq, NULL,
  130 + ret = devm_request_threaded_irq(chip->dev, irq, NULL,
130 131 acpi_gpio_irq_handler,
131 132 0,
132 133 "GPIO-signaled-ACPI-event",
133 134 ev_handle);
  135 + if (ret)
  136 + dev_err(chip->dev,
  137 + "Failed to request IRQ %d ACPI event handler\n",
  138 + irq);
134 139 }
135 140 }
136 141 EXPORT_SYMBOL(acpi_gpiochip_request_interrupts);