Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 15e6392feec311f1e409d77e1ccfe51c1d940365

Authored by Namhyung Kim
Committed by Arnaldo Carvalho de Melo
1 parent 29c9862f1b
Exists in master and in 6 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

perf stat: Introduce get_ratio_color() helper 

The get_ratio_color() returns appropriate color string based on @ratio.
It helps reducing code duplication.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1325000151-4463-2-git-send-email-namhyung@gmail.com
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Showing 1 changed file with 35 additions and 56 deletions Side-by-side Diff

tools/perf/builtin-stat.c
Diff comments   View file @ 15e6392
... ... @@ -578,6 +578,33 @@
578 578 avg / avg_stats(&walltime_nsecs_stats));
579 579 }
580 580  
  581 +/* used for get_ratio_color() */
  582 +enum grc_type {
  583 + GRC_STALLED_CYCLES_FE,
  584 + GRC_STALLED_CYCLES_BE,
  585 + GRC_CACHE_MISSES,
  586 + GRC_MAX_NR
  587 +};
  588 +
  589 +static const char *get_ratio_color(enum grc_type type, double ratio)
  590 +{
  591 + static const double grc_table[GRC_MAX_NR][3] = {
  592 + [GRC_STALLED_CYCLES_FE] = { 50.0, 30.0, 10.0 },
  593 + [GRC_STALLED_CYCLES_BE] = { 75.0, 50.0, 20.0 },
  594 + [GRC_CACHE_MISSES] = { 20.0, 10.0, 5.0 },
  595 + };
  596 + const char *color = PERF_COLOR_NORMAL;
  597 +
  598 + if (ratio > grc_table[type][0])
  599 + color = PERF_COLOR_RED;
  600 + else if (ratio > grc_table[type][1])
  601 + color = PERF_COLOR_MAGENTA;
  602 + else if (ratio > grc_table[type][2])
  603 + color = PERF_COLOR_YELLOW;
  604 +
  605 + return color;
  606 +}
  607 +
581 608 static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __used, double avg)
582 609 {
583 610 double total, ratio = 0.0;
... ... @@ -588,13 +615,7 @@
588 615 if (total)
589 616 ratio = avg / total * 100.0;
590 617  
591   - color = PERF_COLOR_NORMAL;
592   - if (ratio > 50.0)
593   - color = PERF_COLOR_RED;
594   - else if (ratio > 30.0)
595   - color = PERF_COLOR_MAGENTA;
596   - else if (ratio > 10.0)
597   - color = PERF_COLOR_YELLOW;
  618 + color = get_ratio_color(GRC_STALLED_CYCLES_FE, ratio);
598 619  
599 620 fprintf(output, " # ");
600 621 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -611,13 +632,7 @@
611 632 if (total)
612 633 ratio = avg / total * 100.0;
613 634  
614   - color = PERF_COLOR_NORMAL;
615   - if (ratio > 75.0)
616   - color = PERF_COLOR_RED;
617   - else if (ratio > 50.0)
618   - color = PERF_COLOR_MAGENTA;
619   - else if (ratio > 20.0)
620   - color = PERF_COLOR_YELLOW;
  635 + color = get_ratio_color(GRC_STALLED_CYCLES_BE, ratio);
621 636  
622 637 fprintf(output, " # ");
623 638 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -634,13 +649,7 @@
634 649 if (total)
635 650 ratio = avg / total * 100.0;
636 651  
637   - color = PERF_COLOR_NORMAL;
638   - if (ratio > 20.0)
639   - color = PERF_COLOR_RED;
640   - else if (ratio > 10.0)
641   - color = PERF_COLOR_MAGENTA;
642   - else if (ratio > 5.0)
643   - color = PERF_COLOR_YELLOW;
  652 + color = get_ratio_color(GRC_CACHE_MISSES, ratio);
644 653  
645 654 fprintf(output, " # ");
646 655 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -657,13 +666,7 @@
657 666 if (total)
658 667 ratio = avg / total * 100.0;
659 668  
660   - color = PERF_COLOR_NORMAL;
661   - if (ratio > 20.0)
662   - color = PERF_COLOR_RED;
663   - else if (ratio > 10.0)
664   - color = PERF_COLOR_MAGENTA;
665   - else if (ratio > 5.0)
666   - color = PERF_COLOR_YELLOW;
  669 + color = get_ratio_color(GRC_CACHE_MISSES, ratio);
667 670  
668 671 fprintf(output, " # ");
669 672 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -680,13 +683,7 @@
680 683 if (total)
681 684 ratio = avg / total * 100.0;
682 685  
683   - color = PERF_COLOR_NORMAL;
684   - if (ratio > 20.0)
685   - color = PERF_COLOR_RED;
686   - else if (ratio > 10.0)
687   - color = PERF_COLOR_MAGENTA;
688   - else if (ratio > 5.0)
689   - color = PERF_COLOR_YELLOW;
  686 + color = get_ratio_color(GRC_CACHE_MISSES, ratio);
690 687  
691 688 fprintf(output, " # ");
692 689 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -703,13 +700,7 @@
703 700 if (total)
704 701 ratio = avg / total * 100.0;
705 702  
706   - color = PERF_COLOR_NORMAL;
707   - if (ratio > 20.0)
708   - color = PERF_COLOR_RED;
709   - else if (ratio > 10.0)
710   - color = PERF_COLOR_MAGENTA;
711   - else if (ratio > 5.0)
712   - color = PERF_COLOR_YELLOW;
  703 + color = get_ratio_color(GRC_CACHE_MISSES, ratio);
713 704  
714 705 fprintf(output, " # ");
715 706 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -726,13 +717,7 @@
726 717 if (total)
727 718 ratio = avg / total * 100.0;
728 719  
729   - color = PERF_COLOR_NORMAL;
730   - if (ratio > 20.0)
731   - color = PERF_COLOR_RED;
732   - else if (ratio > 10.0)
733   - color = PERF_COLOR_MAGENTA;
734   - else if (ratio > 5.0)
735   - color = PERF_COLOR_YELLOW;
  720 + color = get_ratio_color(GRC_CACHE_MISSES, ratio);
736 721  
737 722 fprintf(output, " # ");
738 723 color_fprintf(output, color, "%6.2f%%", ratio);
... ... @@ -749,13 +734,7 @@
749 734 if (total)
750 735 ratio = avg / total * 100.0;
751 736  
752   - color = PERF_COLOR_NORMAL;
753   - if (ratio > 20.0)
754   - color = PERF_COLOR_RED;
755   - else if (ratio > 10.0)
756   - color = PERF_COLOR_MAGENTA;
757   - else if (ratio > 5.0)
758   - color = PERF_COLOR_YELLOW;
  737 + color = get_ratio_color(GRC_CACHE_MISSES, ratio);
759 738  
760 739 fprintf(output, " # ");
761 740 color_fprintf(output, color, "%6.2f%%", ratio);