Commit 187f1882b5b0748b3c4c22274663fdb372ac0452

Authored by Paul Gortmaker
1 parent 50af5ead3b

BUG: headers with BUG/BUG_ON etc. need linux/bug.h

If a header file is making use of BUG, BUG_ON, BUILD_BUG_ON, or any
other BUG variant in a static inline (i.e. not in a #define) then
that header really should be including <linux/bug.h> and not just
expecting it to be implicitly present.

We can make this change risk-free, since if the files using these
headers didn't have exposure to linux/bug.h already, they would have
been causing compile failures/warnings.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Showing 64 changed files with 69 additions and 3 deletions Side-by-side Diff

arch/avr32/include/asm/io.h
1 1 #ifndef __ASM_AVR32_IO_H
2 2 #define __ASM_AVR32_IO_H
3 3  
  4 +#include <linux/bug.h>
4 5 #include <linux/kernel.h>
5 6 #include <linux/string.h>
6 7 #include <linux/types.h>
arch/m68k/include/asm/system.h
... ... @@ -3,6 +3,7 @@
3 3  
4 4 #include <linux/linkage.h>
5 5 #include <linux/kernel.h>
  6 +#include <linux/bug.h>
6 7 #include <linux/irqflags.h>
7 8 #include <asm/segment.h>
8 9 #include <asm/entry.h>
arch/sparc/include/asm/vga.h
... ... @@ -7,6 +7,7 @@
7 7 #ifndef _LINUX_ASM_VGA_H_
8 8 #define _LINUX_ASM_VGA_H_
9 9  
  10 +#include <linux/bug.h>
10 11 #include <asm/types.h>
11 12  
12 13 #define VT_BUF_HAVE_RW
arch/x86/include/asm/paravirt.h
... ... @@ -10,6 +10,7 @@
10 10 #include <asm/paravirt_types.h>
11 11  
12 12 #ifndef __ASSEMBLY__
  13 +#include <linux/bug.h>
13 14 #include <linux/types.h>
14 15 #include <linux/cpumask.h>
15 16  
include/asm-generic/dma-mapping-common.h
... ... @@ -2,6 +2,7 @@
2 2 #define _ASM_GENERIC_DMA_MAPPING_H
3 3  
4 4 #include <linux/kmemcheck.h>
  5 +#include <linux/bug.h>
5 6 #include <linux/scatterlist.h>
6 7 #include <linux/dma-debug.h>
7 8 #include <linux/dma-attrs.h>
include/asm-generic/pgtable.h
... ... @@ -5,6 +5,7 @@
5 5 #ifdef CONFIG_MMU
6 6  
7 7 #include <linux/mm_types.h>
  8 +#include <linux/bug.h>
8 9  
9 10 #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS
10 11 extern int ptep_set_access_flags(struct vm_area_struct *vma,
include/asm-generic/tlbflush.h
... ... @@ -9,6 +9,8 @@
9 9 #error need to implement an architecture specific asm/tlbflush.h
10 10 #endif
11 11  
  12 +#include <linux/bug.h>
  13 +
12 14 static inline void flush_tlb_mm(struct mm_struct *mm)
13 15 {
14 16 BUG();
include/drm/ttm/ttm_memory.h
... ... @@ -30,6 +30,7 @@
30 30  
31 31 #include <linux/workqueue.h>
32 32 #include <linux/spinlock.h>
  33 +#include <linux/bug.h>
33 34 #include <linux/wait.h>
34 35 #include <linux/errno.h>
35 36 #include <linux/kobject.h>
include/linux/atmdev.h
... ... @@ -217,6 +217,7 @@
217 217 #include <linux/wait.h> /* wait_queue_head_t */
218 218 #include <linux/time.h> /* struct timeval */
219 219 #include <linux/net.h>
  220 +#include <linux/bug.h>
220 221 #include <linux/skbuff.h> /* struct sk_buff */
221 222 #include <linux/uio.h>
222 223 #include <net/sock.h>
... ... @@ -23,6 +23,7 @@
23 23 #include <linux/highmem.h>
24 24 #include <linux/mempool.h>
25 25 #include <linux/ioprio.h>
  26 +#include <linux/bug.h>
26 27  
27 28 #ifdef CONFIG_BLOCK
28 29  
include/linux/bit_spinlock.h
... ... @@ -4,6 +4,7 @@
4 4 #include <linux/kernel.h>
5 5 #include <linux/preempt.h>
6 6 #include <linux/atomic.h>
  7 +#include <linux/bug.h>
7 8  
8 9 /*
9 10 * bit-based spin_lock()
include/linux/ceph/decode.h
1 1 #ifndef __CEPH_DECODE_H
2 2 #define __CEPH_DECODE_H
3 3  
4   -#include <asm/unaligned.h>
  4 +#include <linux/bug.h>
5 5 #include <linux/time.h>
  6 +#include <asm/unaligned.h>
6 7  
7 8 #include "types.h"
8 9  
include/linux/ceph/libceph.h
... ... @@ -7,6 +7,7 @@
7 7 #include <linux/backing-dev.h>
8 8 #include <linux/completion.h>
9 9 #include <linux/exportfs.h>
  10 +#include <linux/bug.h>
10 11 #include <linux/fs.h>
11 12 #include <linux/mempool.h>
12 13 #include <linux/pagemap.h>
include/linux/ceph/mdsmap.h
1 1 #ifndef _FS_CEPH_MDSMAP_H
2 2 #define _FS_CEPH_MDSMAP_H
3 3  
  4 +#include <linux/bug.h>
4 5 #include "types.h"
5 6  
6 7 /*
include/linux/cpumask.h
... ... @@ -9,6 +9,7 @@
9 9 #include <linux/kernel.h>
10 10 #include <linux/threads.h>
11 11 #include <linux/bitmap.h>
  12 +#include <linux/bug.h>
12 13  
13 14 typedef struct cpumask { DECLARE_BITMAP(bits, NR_CPUS); } cpumask_t;
14 15  
include/linux/crypto.h
... ... @@ -20,6 +20,7 @@
20 20 #include <linux/atomic.h>
21 21 #include <linux/kernel.h>
22 22 #include <linux/list.h>
  23 +#include <linux/bug.h>
23 24 #include <linux/slab.h>
24 25 #include <linux/string.h>
25 26 #include <linux/uaccess.h>
include/linux/debug_locks.h
... ... @@ -3,6 +3,7 @@
3 3  
4 4 #include <linux/kernel.h>
5 5 #include <linux/atomic.h>
  6 +#include <linux/bug.h>
6 7 #include <asm/system.h>
7 8  
8 9 struct task_struct;
include/linux/dmaengine.h
... ... @@ -23,6 +23,7 @@
23 23  
24 24 #include <linux/device.h>
25 25 #include <linux/uio.h>
  26 +#include <linux/bug.h>
26 27 #include <linux/scatterlist.h>
27 28 #include <linux/bitmap.h>
28 29 #include <asm/page.h>
include/linux/elfcore.h
... ... @@ -6,6 +6,7 @@
6 6 #include <linux/time.h>
7 7 #ifdef __KERNEL__
8 8 #include <linux/user.h>
  9 +#include <linux/bug.h>
9 10 #endif
10 11 #include <linux/ptrace.h>
11 12 #include <linux/elf.h>
include/linux/ext3_fs.h
... ... @@ -18,6 +18,7 @@
18 18  
19 19 #include <linux/types.h>
20 20 #include <linux/magic.h>
  21 +#include <linux/bug.h>
21 22  
22 23 /*
23 24 * The second extended filesystem constants/structures
... ... @@ -389,6 +389,7 @@
389 389 #include <linux/prio_tree.h>
390 390 #include <linux/init.h>
391 391 #include <linux/pid.h>
  392 +#include <linux/bug.h>
392 393 #include <linux/mutex.h>
393 394 #include <linux/capability.h>
394 395 #include <linux/semaphore.h>
include/linux/fsnotify.h
... ... @@ -14,6 +14,7 @@
14 14 #include <linux/fsnotify_backend.h>
15 15 #include <linux/audit.h>
16 16 #include <linux/slab.h>
  17 +#include <linux/bug.h>
17 18  
18 19 /*
19 20 * fsnotify_d_instantiate - instantiate a dentry for inode
include/linux/gpio.h
... ... @@ -34,6 +34,7 @@
34 34 #include <linux/kernel.h>
35 35 #include <linux/types.h>
36 36 #include <linux/errno.h>
  37 +#include <linux/bug.h>
37 38  
38 39 struct device;
39 40 struct gpio_chip;
include/linux/highmem.h
... ... @@ -3,6 +3,7 @@
3 3  
4 4 #include <linux/fs.h>
5 5 #include <linux/kernel.h>
  6 +#include <linux/bug.h>
6 7 #include <linux/mm.h>
7 8 #include <linux/uaccess.h>
8 9 #include <linux/hardirq.h>
... ... @@ -24,6 +24,7 @@
24 24 #define I2O_MAX_DRIVERS 8
25 25  
26 26 #include <linux/pci.h>
  27 +#include <linux/bug.h>
27 28 #include <linux/dma-mapping.h>
28 29 #include <linux/string.h>
29 30 #include <linux/slab.h>
include/linux/if_vlan.h
... ... @@ -17,6 +17,7 @@
17 17 #include <linux/netdevice.h>
18 18 #include <linux/etherdevice.h>
19 19 #include <linux/rtnetlink.h>
  20 +#include <linux/bug.h>
20 21  
21 22 #define VLAN_HLEN 4 /* The additional bytes (on top of the Ethernet header)
22 23 * that VLAN requires.
include/linux/io-mapping.h
... ... @@ -20,6 +20,7 @@
20 20  
21 21 #include <linux/types.h>
22 22 #include <linux/slab.h>
  23 +#include <linux/bug.h>
23 24 #include <asm/io.h>
24 25 #include <asm/page.h>
25 26  
include/linux/kprobes.h
... ... @@ -33,6 +33,7 @@
33 33 #include <linux/list.h>
34 34 #include <linux/notifier.h>
35 35 #include <linux/smp.h>
  36 +#include <linux/bug.h>
36 37 #include <linux/percpu.h>
37 38 #include <linux/spinlock.h>
38 39 #include <linux/rcupdate.h>
include/linux/kvm_host.h
... ... @@ -13,6 +13,7 @@
13 13 #include <linux/spinlock.h>
14 14 #include <linux/signal.h>
15 15 #include <linux/sched.h>
  16 +#include <linux/bug.h>
16 17 #include <linux/mm.h>
17 18 #include <linux/mmu_notifier.h>
18 19 #include <linux/preempt.h>
include/linux/memory_hotplug.h
... ... @@ -4,6 +4,7 @@
4 4 #include <linux/mmzone.h>
5 5 #include <linux/spinlock.h>
6 6 #include <linux/notifier.h>
  7 +#include <linux/bug.h>
7 8  
8 9 struct page;
9 10 struct zone;
... ... @@ -6,6 +6,7 @@
6 6 #ifdef __KERNEL__
7 7  
8 8 #include <linux/gfp.h>
  9 +#include <linux/bug.h>
9 10 #include <linux/list.h>
10 11 #include <linux/mmzone.h>
11 12 #include <linux/rbtree.h>
include/linux/mtd/cfi.h
... ... @@ -22,6 +22,7 @@
22 22  
23 23 #include <linux/delay.h>
24 24 #include <linux/types.h>
  25 +#include <linux/bug.h>
25 26 #include <linux/interrupt.h>
26 27 #include <linux/mtd/flashchip.h>
27 28 #include <linux/mtd/map.h>
include/linux/netdevice.h
... ... @@ -33,6 +33,7 @@
33 33 #ifdef __KERNEL__
34 34 #include <linux/pm_qos.h>
35 35 #include <linux/timer.h>
  36 +#include <linux/bug.h>
36 37 #include <linux/delay.h>
37 38 #include <linux/atomic.h>
38 39 #include <asm/cache.h>
include/linux/nilfs2_fs.h
... ... @@ -41,6 +41,7 @@
41 41 #include <linux/types.h>
42 42 #include <linux/ioctl.h>
43 43 #include <linux/magic.h>
  44 +#include <linux/bug.h>
44 45  
45 46  
46 47 #define NILFS_INODE_BMAP_SIZE 7
include/linux/page-flags.h
... ... @@ -6,6 +6,7 @@
6 6 #define PAGE_FLAGS_H
7 7  
8 8 #include <linux/types.h>
  9 +#include <linux/bug.h>
9 10 #ifndef __GENERATING_BOUNDS_H
10 11 #include <linux/mm_types.h>
11 12 #include <generated/bounds.h>
include/linux/pid_namespace.h
... ... @@ -2,6 +2,7 @@
2 2 #define _LINUX_PID_NS_H
3 3  
4 4 #include <linux/sched.h>
  5 +#include <linux/bug.h>
5 6 #include <linux/mm.h>
6 7 #include <linux/threads.h>
7 8 #include <linux/nsproxy.h>
include/linux/posix_acl.h
... ... @@ -8,6 +8,7 @@
8 8 #ifndef __LINUX_POSIX_ACL_H
9 9 #define __LINUX_POSIX_ACL_H
10 10  
  11 +#include <linux/bug.h>
11 12 #include <linux/slab.h>
12 13 #include <linux/rcupdate.h>
13 14  
include/linux/ptrace.h
... ... @@ -113,6 +113,7 @@
113 113 #include <linux/compiler.h> /* For unlikely. */
114 114 #include <linux/sched.h> /* For struct task_struct. */
115 115 #include <linux/err.h> /* for IS_ERR_VALUE */
  116 +#include <linux/bug.h> /* For BUG_ON. */
116 117  
117 118  
118 119 extern long arch_ptrace(struct task_struct *child, long request,
include/linux/radix-tree.h
... ... @@ -22,6 +22,7 @@
22 22  
23 23 #include <linux/preempt.h>
24 24 #include <linux/types.h>
  25 +#include <linux/bug.h>
25 26 #include <linux/kernel.h>
26 27 #include <linux/rcupdate.h>
27 28  
include/linux/rcupdate.h
... ... @@ -42,6 +42,7 @@
42 42 #include <linux/lockdep.h>
43 43 #include <linux/completion.h>
44 44 #include <linux/debugobjects.h>
  45 +#include <linux/bug.h>
45 46 #include <linux/compiler.h>
46 47  
47 48 #ifdef CONFIG_RCU_TORTURE_TEST
include/linux/regset.h
... ... @@ -15,6 +15,7 @@
15 15  
16 16 #include <linux/compiler.h>
17 17 #include <linux/types.h>
  18 +#include <linux/bug.h>
18 19 #include <linux/uaccess.h>
19 20 struct task_struct;
20 21 struct user_regset;
include/linux/reiserfs_fs.h
... ... @@ -18,6 +18,7 @@
18 18 #include <linux/slab.h>
19 19 #include <linux/interrupt.h>
20 20 #include <linux/sched.h>
  21 +#include <linux/bug.h>
21 22 #include <linux/workqueue.h>
22 23 #include <asm/unaligned.h>
23 24 #include <linux/bitops.h>
include/linux/relay.h
... ... @@ -15,6 +15,7 @@
15 15 #include <linux/timer.h>
16 16 #include <linux/wait.h>
17 17 #include <linux/list.h>
  18 +#include <linux/bug.h>
18 19 #include <linux/fs.h>
19 20 #include <linux/poll.h>
20 21 #include <linux/kref.h>
include/linux/scatterlist.h
1 1 #ifndef _LINUX_SCATTERLIST_H
2 2 #define _LINUX_SCATTERLIST_H
3 3  
  4 +#include <linux/string.h>
  5 +#include <linux/bug.h>
  6 +#include <linux/mm.h>
  7 +
4 8 #include <asm/types.h>
5 9 #include <asm/scatterlist.h>
6   -#include <linux/mm.h>
7   -#include <linux/string.h>
8 10 #include <asm/io.h>
9 11  
10 12 struct sg_table {
include/linux/seq_file.h
... ... @@ -3,6 +3,7 @@
3 3  
4 4 #include <linux/types.h>
5 5 #include <linux/string.h>
  6 +#include <linux/bug.h>
6 7 #include <linux/mutex.h>
7 8 #include <linux/cpumask.h>
8 9 #include <linux/nodemask.h>
include/linux/skbuff.h
... ... @@ -18,6 +18,7 @@
18 18 #include <linux/kmemcheck.h>
19 19 #include <linux/compiler.h>
20 20 #include <linux/time.h>
  21 +#include <linux/bug.h>
21 22 #include <linux/cache.h>
22 23  
23 24 #include <linux/atomic.h>
include/linux/slub_def.h
... ... @@ -8,6 +8,7 @@
8 8 */
9 9 #include <linux/types.h>
10 10 #include <linux/gfp.h>
  11 +#include <linux/bug.h>
11 12 #include <linux/workqueue.h>
12 13 #include <linux/kobject.h>
13 14  
include/linux/ssb/ssb_driver_gige.h
... ... @@ -2,6 +2,7 @@
2 2 #define LINUX_SSB_DRIVER_GIGE_H_
3 3  
4 4 #include <linux/ssb/ssb.h>
  5 +#include <linux/bug.h>
5 6 #include <linux/pci.h>
6 7 #include <linux/spinlock.h>
7 8  
include/linux/swapops.h
... ... @@ -2,6 +2,7 @@
2 2 #define _LINUX_SWAPOPS_H
3 3  
4 4 #include <linux/radix-tree.h>
  5 +#include <linux/bug.h>
5 6  
6 7 /*
7 8 * swapcache pages are stored in the swapper_space radix tree. We want to
include/linux/syscalls.h
... ... @@ -68,6 +68,7 @@
68 68 #include <linux/aio_abi.h>
69 69 #include <linux/capability.h>
70 70 #include <linux/list.h>
  71 +#include <linux/bug.h>
71 72 #include <linux/sem.h>
72 73 #include <asm/siginfo.h>
73 74 #include <asm/signal.h>
include/linux/transport_class.h
... ... @@ -10,6 +10,7 @@
10 10 #define _TRANSPORT_CLASS_H_
11 11  
12 12 #include <linux/device.h>
  13 +#include <linux/bug.h>
13 14 #include <linux/attribute_container.h>
14 15  
15 16 struct transport_container;
include/linux/virtio_config.h
... ... @@ -53,6 +53,7 @@
53 53  
54 54 #ifdef __KERNEL__
55 55 #include <linux/err.h>
  56 +#include <linux/bug.h>
56 57 #include <linux/virtio.h>
57 58  
58 59 /**
include/net/cfg80211.h
... ... @@ -13,6 +13,7 @@
13 13 #include <linux/netdevice.h>
14 14 #include <linux/debugfs.h>
15 15 #include <linux/list.h>
  16 +#include <linux/bug.h>
16 17 #include <linux/netlink.h>
17 18 #include <linux/skbuff.h>
18 19 #include <linux/nl80211.h>
... ... @@ -12,6 +12,7 @@
12 12 #include <linux/netdevice.h>
13 13 #include <linux/rtnetlink.h>
14 14 #include <linux/rcupdate.h>
  15 +#include <linux/bug.h>
15 16 #include <linux/jiffies.h>
16 17 #include <net/neighbour.h>
17 18 #include <asm/processor.h>
... ... @@ -16,6 +16,7 @@
16 16 #include <linux/atomic.h> /* for struct atomic_t */
17 17 #include <linux/compiler.h>
18 18 #include <linux/timer.h>
  19 +#include <linux/bug.h>
19 20  
20 21 #include <net/checksum.h>
21 22 #include <linux/netfilter.h> /* for union nf_inet_addr */
include/net/mac80211.h
... ... @@ -13,6 +13,7 @@
13 13 #ifndef MAC80211_H
14 14 #define MAC80211_H
15 15  
  16 +#include <linux/bug.h>
16 17 #include <linux/kernel.h>
17 18 #include <linux/if_ether.h>
18 19 #include <linux/skbuff.h>
include/net/netns/generic.h
... ... @@ -5,6 +5,7 @@
5 5 #ifndef __NET_GENERIC_H__
6 6 #define __NET_GENERIC_H__
7 7  
  8 +#include <linux/bug.h>
8 9 #include <linux/rcupdate.h>
9 10  
10 11 /*
... ... @@ -2,6 +2,7 @@
2 2 #define __NET_SCHED_RED_H
3 3  
4 4 #include <linux/types.h>
  5 +#include <linux/bug.h>
5 6 #include <net/pkt_sched.h>
6 7 #include <net/inet_ecn.h>
7 8 #include <net/dsfield.h>
... ... @@ -22,6 +22,7 @@
22 22  
23 23 #include <linux/list.h>
24 24 #include <linux/tcp.h>
  25 +#include <linux/bug.h>
25 26 #include <linux/slab.h>
26 27 #include <linux/cache.h>
27 28 #include <linux/percpu.h>
include/net/timewait_sock.h
... ... @@ -12,6 +12,7 @@
12 12 #define _TIMEWAIT_SOCK_H
13 13  
14 14 #include <linux/slab.h>
  15 +#include <linux/bug.h>
15 16 #include <net/sock.h>
16 17  
17 18 struct timewait_sock_ops {
... ... @@ -23,6 +23,7 @@
23 23 #define _UDP_H
24 24  
25 25 #include <linux/list.h>
  26 +#include <linux/bug.h>
26 27 #include <net/inet_sock.h>
27 28 #include <net/sock.h>
28 29 #include <net/snmp.h>
include/net/wpan-phy.h
... ... @@ -23,6 +23,7 @@
23 23  
24 24 #include <linux/netdevice.h>
25 25 #include <linux/mutex.h>
  26 +#include <linux/bug.h>
26 27  
27 28 struct wpan_phy {
28 29 struct mutex pib_lock;
include/scsi/osd_ore.h
... ... @@ -26,6 +26,7 @@
26 26 #include <scsi/osd_attributes.h>
27 27 #include <scsi/osd_sec.h>
28 28 #include <linux/pnfs_osd_xdr.h>
  29 +#include <linux/bug.h>
29 30  
30 31 struct ore_comp {
31 32 struct osd_obj_id obj;
include/scsi/scsi_transport.h
... ... @@ -22,6 +22,7 @@
22 22  
23 23 #include <linux/transport_class.h>
24 24 #include <linux/blkdev.h>
  25 +#include <linux/bug.h>
25 26 #include <scsi/scsi_host.h>
26 27 #include <scsi/scsi_device.h>
27 28