Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 1c1bc9223387dacc48eb2b61b0baabe7e9cf47f6

Authored by Prashanth Nageshappa
Committed by Arnaldo Carvalho de Melo
1 parent cfbd70c17c
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

perf probe: Ensure offset provided is not greater than function length without DWARF info too 

The 'perf probe' command allows kprobe to be inserted at any offset from
a function start, which results in adding kprobes to unintended
location.  (example: perf probe do_fork+10000 is allowed even though
size of do_fork is ~904).

My previous patch https://lkml.org/lkml/2012/2/24/42 addressed the case
where DWARF info was available for the kernel. This patch fixes the
case where perf probe is used on a kernel without debuginfo available.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/4F4C544D.1010909@linux.vnet.ibm.com
Signed-off-by: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Showing 1 changed file with 6 additions and 0 deletions Side-by-side Diff

tools/perf/util/probe-event.c
Diff comments   View file @ 1c1bc92
... ... @@ -1867,6 +1867,12 @@
1867 1867 tev->point.symbol);
1868 1868 ret = -ENOENT;
1869 1869 goto error;
  1870 + } else if (tev->point.offset > sym->end - sym->start) {
  1871 + pr_warning("Offset specified is greater than size of %s\n",
  1872 + tev->point.symbol);
  1873 + ret = -ENOENT;
  1874 + goto error;
  1875 +
1870 1876 }
1871 1877  
1872 1878 return 1;