Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 2008713c7174e5c0f207bac684c6df0939047009

Authored by H. Peter Anvin
Committed by Linus Torvalds
1 parent 6bb1e3819c
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

Makefile: Documentation for external tool should be correct 

If one includes documentation for an external tool, it should be
correct.  This is not:

1. Overriding the input to rngd should typically be neither
   necessary nor desired.  This is especially so since newer
   versions of rngd support a number of different *types* of sources.
2. The default kernel-exported device is called /dev/hwrng not
   /dev/hwrandom nor /dev/hw_random (both of which were used in the
   past; however, kernel and udev seem to have converged on
   /dev/hwrng.)

Overall it is better if the documentation for rngd is kept with rngd
rather than in a kernel Makefile.

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 2 additions and 4 deletions Side-by-side Diff

... ... @@ -174,10 +174,8 @@
174 174 @echo "###"
175 175 @echo "### If this takes a long time, you might wish to run rngd in the"
176 176 @echo "### background to keep the supply of entropy topped up. It"
177   - @echo "### needs to be run as root, and should use a hardware random"
178   - @echo "### number generator if one is available, eg:"
179   - @echo "###"
180   - @echo "### rngd -r /dev/hwrandom"
  177 + @echo "### needs to be run as root, and uses a hardware random"
  178 + @echo "### number generator if one is available."
181 179 @echo "###"
182 180 openssl req -new -nodes -utf8 $(sign_key_with_hash) -days 36500 -batch \
183 181 -x509 -config x509.genkey \