Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 2062cc20d0a8e370163efccbee555347e17100c0

Authored by Dan Carpenter
Committed by David S. Miller
1 parent 65d2897c0f
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

bridge: make buffer larger in br_setlink() 

We pass IFLA_BRPORT_MAX to nla_parse_nested() so we need
IFLA_BRPORT_MAX + 1 elements.  Also Smatch complains that we read past
the end of the array when in br_set_port_flag() when it's called with
IFLA_BRPORT_FAST_LEAVE.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

net/bridge/br_netlink.c
Diff comments   View file @ 2062cc2
... ... @@ -239,7 +239,7 @@
239 239 struct ifinfomsg *ifm;
240 240 struct nlattr *protinfo;
241 241 struct net_bridge_port *p;
242   - struct nlattr *tb[IFLA_BRPORT_MAX];
  242 + struct nlattr *tb[IFLA_BRPORT_MAX + 1];
243 243 int err;
244 244  
245 245 ifm = nlmsg_data(nlh);