Commit 2069d483b39a603a5f3428a19d3b4ac89aa97f48
1 parent
85c50a5899
Exists in
smarc-l5.0.0_1.0.0-ga
and in
5 other branches
ALSA: vmaster: Fix slave change notification
When a value of a vmaster slave control is changed, the ctl change notification is sometimes ignored. This happens when the master control overrides, e.g. when the corresponding master control is muted. The reason is that slave_put() returns the value of the actual slave put callback, and it doesn't reflect the virtual slave value change. This patch fixes the function just to return 1 whenever a slave value is changed. Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Showing 1 changed file with 4 additions and 1 deletions Side-by-side Diff
sound/core/vmaster.c
| ... | ... | @@ -213,7 +213,10 @@ |
| 213 | 213 | } |
| 214 | 214 | if (!changed) |
| 215 | 215 | return 0; |
| 216 | - return slave_put_val(slave, ucontrol); | |
| 216 | + err = slave_put_val(slave, ucontrol); | |
| 217 | + if (err < 0) | |
| 218 | + return err; | |
| 219 | + return 1; | |
| 217 | 220 | } |
| 218 | 221 | |
| 219 | 222 | static int slave_tlv_cmd(struct snd_kcontrol *kcontrol, |