Commit 24b8ff7c27d9e975540656e377de44a2a181a01f

Authored by Cesar Eduardo Barros
Committed by Linus Torvalds
1 parent 40531542e2

mm: remove inline from scan_swap_map()

scan_swap_map() is a large function (224 lines), with several loops and a
complex control flow involving several gotos.

Given all that, it is a bit silly that it is marked as inline.  The
compiler agrees with me: on a x86-64 compile, it did not inline the
function.

Remove the "inline" and let the compiler decide instead.

Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

... ... @@ -212,8 +212,8 @@
212 212 #define SWAPFILE_CLUSTER 256
213 213 #define LATENCY_LIMIT 256
214 214  
215   -static inline unsigned long scan_swap_map(struct swap_info_struct *si,
216   - unsigned char usage)
  215 +static unsigned long scan_swap_map(struct swap_info_struct *si,
  216 + unsigned char usage)
217 217 {
218 218 unsigned long offset;
219 219 unsigned long scan_base;