mfd: Set tps6586x bits if new value is different from the old one

It does not make sense to write new value only when all the bit_mask bits are zero. We need to write new value if the bit mask fields of new value is not equal to old value. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

mfd: Set tps6586x bits if new value is different from the old one
It does not make sense to write new value only when all the bit_mask bits are zero. We need to write new value if the bit mask fields of new value is not equal to old value. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Axel Lin · Samuel Ortiz
1 parent af65e6cef4
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
drivers/mfd/tps6586x.c
@@ -197,7 +197,7 @@
 	if (ret)
 		goto out;
  
-	if ((reg_val & bit_mask) == 0) {
+	if ((reg_val & bit_mask) != bit_mask) {
 		reg_val |= bit_mask;
 		ret = __tps6586x_write(to_i2c_client(dev), reg, reg_val);
 	}
...	...	@@ -197,7 +197,7 @@
197	197	if (ret)
198	198	goto out;
199	199
200		- if ((reg_val & bit_mask) == 0) {
	200	+ if ((reg_val & bit_mask) != bit_mask) {
201	201	reg_val \|= bit_mask;
202	202	ret = __tps6586x_write(to_i2c_client(dev), reg, reg_val);
203	203	}