hpfs_setattr error case avoids unlock_kernel

This fixed a case that 'sparse' spotted where hpfs_setattr has an error return that didn't go through it's path that unlocks. This is against git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git version 6313e3c21743cc88bb5bd8aa72948ee1e83937b6. Build tested only, I don't have an hpfs file system to test. Dave Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

hpfs_setattr error case avoids unlock_kernel
This fixed a case that 'sparse' spotted where hpfs_setattr has an error return that didn't go through it's path that unlocks. This is against git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git version 6313e3c21743cc88bb5bd8aa72948ee1e83937b6. Build tested only, I don't have an hpfs file system to test. Dave Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Dr. David Alan Gilbert · Al Viro
1 parent e0bb6bda43
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
fs/hpfs/inode.c
@@ -281,7 +281,7 @@
 	    attr->ia_size != i_size_read(inode)) {
 		error = vmtruncate(inode, attr->ia_size);
 		if (error)
-			return error;
+			goto out_unlock;
 	}
  
 	setattr_copy(inode, attr);
...	...	@@ -281,7 +281,7 @@
281	281	attr->ia_size != i_size_read(inode)) {
282	282	error = vmtruncate(inode, attr->ia_size);
283	283	if (error)
284		- return error;
	284	+ goto out_unlock;
285	285	}
286	286
287	287	setattr_copy(inode, attr);