Commit 298decfbc44e9a4cb7862ae1b7dfc4e1ba3551b9

Authored by Marti Raudsepp
Committed by Dave Jones
1 parent c2f4a2c6e0

[CPUFREQ] powernow-k8: On load failure, remind the user to enable support in BIOS setup

On Wed, 2010-01-20 at 16:56 +0100, Thomas Renninger wrote:
> But most often this happens if people upgrade their CPU and do not
> update their BIOS.
> Or the vendor does not recognise the new CPU even if the BIOS got
> updated.

Maybe some of those people just didn't realize it was disabled in BIOS?
If you tell users that it's a firmware bug then they'll probably just
give up.

> The itself message might be an enhancment, IMO it's not worth a patch.

Why do you think so? I spent an hour on hunting down the BIOS upgrade,
only to find that it didn't improve anything. It was a day later that I
realized that it might be a BIOS option; and the option was literally
the _last_ option in the whole BIOS setup. :)

This message would have saved the day.

> But do not revert the FW_BUG part!

Sure, you have a point here.

How about this patch?

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

arch/x86/kernel/cpu/cpufreq/powernow-k8.c
... ... @@ -806,6 +806,8 @@
806 806 * www.amd.com
807 807 */
808 808 printk(KERN_ERR FW_BUG PFX "No PSB or ACPI _PSS objects\n");
  809 + printk(KERN_ERR PFX "Make sure that your BIOS is up to date"
  810 + " and Cool'N'Quiet support is enabled in BIOS setup\n");
809 811 return -ENODEV;
810 812 }
811 813