Commit 2c2c8c1c211c75d0cc9d7642a569ceac1aecd96d
1 parent
d4faf636d6
Exists in
master
and in
7 other branches
NTFS: Improve comments on file attribute flags in fs/ntfs/layout.h.
Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
Showing 2 changed files with 13 additions and 13 deletions Side-by-side Diff
fs/ntfs/ChangeLog
| ... | ... | @@ -37,6 +37,7 @@ |
| 37 | 37 | - Limit name length in fs/ntfs/unistr.c::ntfs_nlstoucs() to maximum |
| 38 | 38 | allowed by NTFS, i.e. 255 Unicode characters, not including the |
| 39 | 39 | terminating NULL (which is not stored on disk). |
| 40 | + - Improve comments on file attribute flags in fs/ntfs/layout.h. | |
| 40 | 41 | |
| 41 | 42 | 2.1.26 - Minor bug fixes and updates. |
| 42 | 43 |
fs/ntfs/layout.h
| ... | ... | @@ -801,13 +801,16 @@ |
| 801 | 801 | typedef ATTR_RECORD ATTR_REC; |
| 802 | 802 | |
| 803 | 803 | /* |
| 804 | - * File attribute flags (32-bit). | |
| 804 | + * File attribute flags (32-bit) appearing in the file_attributes fields of the | |
| 805 | + * STANDARD_INFORMATION attribute of MFT_RECORDs and the FILENAME_ATTR | |
| 806 | + * attributes of MFT_RECORDs and directory index entries. | |
| 807 | + * | |
| 808 | + * All of the below flags appear in the directory index entries but only some | |
| 809 | + * appear in the STANDARD_INFORMATION attribute whilst only some others appear | |
| 810 | + * in the FILENAME_ATTR attribute of MFT_RECORDs. Unless otherwise stated the | |
| 811 | + * flags appear in all of the above. | |
| 805 | 812 | */ |
| 806 | 813 | enum { |
| 807 | - /* | |
| 808 | - * The following flags are only present in the STANDARD_INFORMATION | |
| 809 | - * attribute (in the field file_attributes). | |
| 810 | - */ | |
| 811 | 814 | FILE_ATTR_READONLY = const_cpu_to_le32(0x00000001), |
| 812 | 815 | FILE_ATTR_HIDDEN = const_cpu_to_le32(0x00000002), |
| 813 | 816 | FILE_ATTR_SYSTEM = const_cpu_to_le32(0x00000004), |
| 814 | 817 | |
| ... | ... | @@ -839,18 +842,14 @@ |
| 839 | 842 | F_A_COMPRESSED, and F_A_ENCRYPTED and preserves the rest. This mask |
| 840 | 843 | is used to to obtain all flags that are valid for setting. */ |
| 841 | 844 | /* |
| 842 | - * The following flag is only present in the FILE_NAME attribute (in | |
| 843 | - * the field file_attributes). | |
| 845 | + * The flag FILE_ATTR_DUP_FILENAME_INDEX_PRESENT is present in all | |
| 846 | + * FILENAME_ATTR attributes but not in the STANDARD_INFORMATION | |
| 847 | + * attribute of an mft record. | |
| 844 | 848 | */ |
| 845 | 849 | FILE_ATTR_DUP_FILE_NAME_INDEX_PRESENT = const_cpu_to_le32(0x10000000), |
| 846 | 850 | /* Note, this is a copy of the corresponding bit from the mft record, |
| 847 | 851 | telling us whether this is a directory or not, i.e. whether it has |
| 848 | 852 | an index root attribute or not. */ |
| 849 | - /* | |
| 850 | - * The following flag is present both in the STANDARD_INFORMATION | |
| 851 | - * attribute and in the FILE_NAME attribute (in the field | |
| 852 | - * file_attributes). | |
| 853 | - */ | |
| 854 | 853 | FILE_ATTR_DUP_VIEW_INDEX_PRESENT = const_cpu_to_le32(0x20000000), |
| 855 | 854 | /* Note, this is a copy of the corresponding bit from the mft record, |
| 856 | 855 | telling us whether this file has a view index present (eg. object id |
| ... | ... | @@ -891,7 +890,7 @@ |
| 891 | 890 | Windows this is only updated when |
| 892 | 891 | accessed if some time delta has |
| 893 | 892 | passed since the last update. Also, |
| 894 | - last access times updates can be | |
| 893 | + last access time updates can be | |
| 895 | 894 | disabled altogether for speed. */ |
| 896 | 895 | /* 32*/ FILE_ATTR_FLAGS file_attributes; /* Flags describing the file. */ |
| 897 | 896 | /* 36*/ union { |