Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 2ed9926e16094ad143b96b09c64cba8bcba05ee1

Authored by Patrick McHardy
Committed by David S. Miller
1 parent d2dcba612b
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

[NET]: Return more appropriate error from eth_validate_addr(). 

Paul Bolle wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9923 would have been much easier to
> track down if eth_validate_addr() would somehow complain aloud if an address
> is invalid. Shouldn't it make at least some noise?

I guess it should return -EADDRNOTAVAIL similar to eth_mac_addr()
when validation fails.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -301,7 +301,7 @@
301 301 static int eth_validate_addr(struct net_device *dev)
302 302 {
303 303 if (!is_valid_ether_addr(dev->dev_addr))
304   - return -EINVAL;
  304 + return -EADDRNOTAVAIL;
305 305  
306 306 return 0;
307 307 }