Commit 30dfe2c05037fbc021121c037872c09956938c2f

Authored by David S. Miller
1 parent 57e1ab6ead

atm: fore200e: Fix build warning.

GCC (rightfully) complains that:

drivers/atm/fore200e.c:614:5: warning: operation on 'cmdq->head' may be undefined

This is due to the FORE200E_NEXT_ENTRY macro, which essentially
evaluates to:

	i = ++i % m

Make it what's explicitly intended here which is:

	i = (i + 1) % m

and the warning goes away.

Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/atm/fore200e.c
... ... @@ -92,7 +92,7 @@
92 92  
93 93 #define FORE200E_INDEX(virt_addr, type, index) (&((type *)(virt_addr))[ index ])
94 94  
95   -#define FORE200E_NEXT_ENTRY(index, modulo) (index = ++(index) % (modulo))
  95 +#define FORE200E_NEXT_ENTRY(index, modulo) (index = ((index) + 1) % (modulo))
96 96  
97 97 #if 1
98 98 #define ASSERT(expr) if (!(expr)) { \