Commit 320718ee074acce5ffced6506cb51af1388942aa
Committed by
Rusty Russell
1 parent
b7a413015d
Exists in
master
and in
7 other branches
hvc_console: Fix race between hvc_close and hvc_remove
I don't claim to understand the tty layer, but it seems like hvc_open and hvc_close should be balanced in their kref reference counting. Right now we get a kref every call to hvc_open: if (hp->count++ > 0) { tty_kref_get(tty); <----- here spin_unlock_irqrestore(&hp->lock, flags); hvc_kick(); return 0; } /* else count == 0 */ tty->driver_data = hp; hp->tty = tty_kref_get(tty); <------ or here if hp->count was 0 But hvc_close has: tty_kref_get(tty); if (--hp->count == 0) { ... /* Put the ref obtained in hvc_open() */ tty_kref_put(tty); ... } tty_kref_put(tty); Since the outside kref get/put balance we only do a single kref_put when count reaches 0. The patch below changes things to call tty_kref_put once for every hvc_close call, and with that my machine boots fine. Signed-off-by: Anton Blanchard <anton@samba.org> Acked-by: Amit Shah <amit.shah@redhat.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff
drivers/char/hvc_console.c
... | ... | @@ -368,15 +368,11 @@ |
368 | 368 | hp = tty->driver_data; |
369 | 369 | |
370 | 370 | spin_lock_irqsave(&hp->lock, flags); |
371 | - tty_kref_get(tty); | |
372 | 371 | |
373 | 372 | if (--hp->count == 0) { |
374 | 373 | /* We are done with the tty pointer now. */ |
375 | 374 | hp->tty = NULL; |
376 | 375 | spin_unlock_irqrestore(&hp->lock, flags); |
377 | - | |
378 | - /* Put the ref obtained in hvc_open() */ | |
379 | - tty_kref_put(tty); | |
380 | 376 | |
381 | 377 | if (hp->ops->notifier_del) |
382 | 378 | hp->ops->notifier_del(hp, hp->data); |