Commit 33777f34b5cc16a9fb2cd480e7db84c8de631fde
Committed by
Dmitry Torokhov
1 parent
9354f26338
Exists in
smarc-imx_3.14.28_1.0.0_ga
and in
1 other branch
Input: fix PWM-related undefined reference errors
This patch adds a PWM dependency to configure the INPUT_MAX8997_HAPTIC and INPUT_PWM_BEEPER. Without this patch, build system can lead to build failure. This was observed during randconfig testing, in which INPUT_MAX8997_HAPTIC or INPUT_PWM_BEEPER was enabled w/o PWM being enabled, leading to the following errors: init/built-in.o drivers/built-in.o: In function `max8997_haptic_disable': :(.text+0x1073a0): undefined reference to `pwm_disable' drivers/built-in.o: In function `max8997_haptic_remove': :(.text+0x1073fc): undefined reference to `pwm_free' drivers/built-in.o: In function `max8997_haptic_play_effect_work': :(.text+0x1074f0): undefined reference to `pwm_config' :(.text+0x1075b0): undefined reference to `pwm_enable' drivers/built-in.o: In function `max8997_haptic_probe': :(.text+0x1076f8): undefined reference to `pwm_request' :(.text+0x1077e8): undefined reference to `pwm_free' drivers/built-in.o: In function `pwm_beeper_resume': :(.text+0x1081a4): undefined reference to `pwm_config' make: *** [vmlinux] Error 1 Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff
drivers/input/misc/Kconfig
... | ... | @@ -156,7 +156,7 @@ |
156 | 156 | |
157 | 157 | config INPUT_MAX8997_HAPTIC |
158 | 158 | tristate "MAXIM MAX8997 haptic controller support" |
159 | - depends on HAVE_PWM && MFD_MAX8997 | |
159 | + depends on PWM && HAVE_PWM && MFD_MAX8997 | |
160 | 160 | select INPUT_FF_MEMLESS |
161 | 161 | help |
162 | 162 | This option enables device driver support for the haptic controller |
... | ... | @@ -461,7 +461,7 @@ |
461 | 461 | |
462 | 462 | config INPUT_PWM_BEEPER |
463 | 463 | tristate "PWM beeper support" |
464 | - depends on HAVE_PWM || PWM | |
464 | + depends on PWM && HAVE_PWM | |
465 | 465 | help |
466 | 466 | Say Y here to get support for PWM based beeper devices. |
467 | 467 |