leds: support new LP8501 device - another LP55xx common

LP8501 can drive up to 9 channels like LP5523. LEDs can be controlled directly via the I2C and programmable engines are supported. LP55xx common driver LP8501 is one of LP55xx family device, so LP55xx common code are used. Chip specific data is defined in the structure, 'lp55xx_device_config'. Differences between LP8501 and LP5523 Different register layout for LED output control and others. LP8501 specific feature for separate output power selection. LP8501 doesn't support external clock detection. Different programming engine data. LP8501 specific feature - output power selection Output channels are selected by power selection - Vout or Vdd. Separate power for VDD1-6 and VDD7-9 are available. It is configurable in the platform data. To support this feature, LP55xx DT structure and header are changed. Device tree binding is updated as well. LED pattern data Example pattern data is updated in the driver documentation. Signed-off-by: Milo Kim <milo.kim@ti.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>

leds: support new LP8501 device - another LP55xx common
LP8501 can drive up to 9 channels like LP5523. LEDs can be controlled directly via the I2C and programmable engines are supported. LP55xx common driver LP8501 is one of LP55xx family device, so LP55xx common code are used. Chip specific data is defined in the structure, 'lp55xx_device_config'. Differences between LP8501 and LP5523 Different register layout for LED output control and others. LP8501 specific feature for separate output power selection. LP8501 doesn't support external clock detection. Different programming engine data. LP8501 specific feature - output power selection Output channels are selected by power selection - Vout or Vdd. Separate power for VDD1-6 and VDD7-9 are available. It is configurable in the platform data. To support this feature, LP55xx DT structure and header are changed. Device tree binding is updated as well. LED pattern data Example pattern data is updated in the driver documentation. Signed-off-by: Milo Kim <milo.kim@ti.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>
Kim, Milo · Bryan Wu
1 parent 81d2287809
Showing 7 changed files with 537 additions and 7 deletions Side-by-side Diff
Documentation/devicetree/bindings/leds/leds-lp55xx.txt
Documentation/leds/leds-lp55xx.txt
drivers/leds/Kconfig
drivers/leds/Makefile
drivers/leds/leds-lp55xx-common.c
drivers/leds/leds-lp8501.c
include/linux/platform_data/leds-lp55xx.h
 Binding for TI/National Semiconductor LP55xx Led Drivers
  
 Required properties:
-- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562"
+- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562" or "ti,lp8501"
 - reg: I2C slave address
 - clock-mode: Input clock mode, (0: automode, 1: internal, 2: external)
  
@@ -11,6 +11,11 @@
  
 Optional properties:
 - label: Used for naming LEDs
+- pwr-sel: LP8501 specific property. Power selection for output channels.
+         0: D1~9 are connected to VDD
+         1: D1~6 with VDD, D7~9 with VOUT
+         2: D1~6 with VOUT, D7~9 with VDD
+         3: D1~9 are connected to VOUT
  
 Alternatively, each child can have specific channel name
 - chan-name: Name of each channel name
@@ -143,6 +148,71 @@
 		chan-name = "W";
 		led-cur = /bits/ 8 <0x20>;
 		max-cur = /bits/ 8 <0x60>;
+	};
+};
+
+example 4) LP8501
+9 channels are defined. The 'pwr-sel' is LP8501 specific property.
+Others are same as LP5523.
+
+lp8501@32 {
+	compatible = "ti,lp8501";
+	reg = <0x32>;
+	clock-mode = /bits/ 8 <2>;
+	pwr-sel = /bits/ 8 <3>;	/* D1~9 connected to VOUT */
+
+	chan0 {
+		chan-name = "d1";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan1 {
+		chan-name = "d2";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan2 {
+		chan-name = "d3";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan3 {
+		chan-name = "d4";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan4 {
+		chan-name = "d5";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan5 {
+		chan-name = "d6";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan6 {
+		chan-name = "d7";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan7 {
+		chan-name = "d8";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
+	};
+
+	chan8 {
+		chan-name = "d9";
+		led-cur = /bits/ 8 <0x14>;
+		max-cur = /bits/ 8 <0x20>;
 	};
 };
-LP5521/LP5523/LP55231 Common Driver
-===================================
+LP5521/LP5523/LP55231/LP5562/LP8501 Common Driver
+=================================================
  
 Authors: Milo(Woogyom) Kim <milo.kim@ti.com>
  
 Description
 -----------
-LP5521, LP5523/55231 and LP5562 have common features as below.
+LP5521, LP5523/55231, LP5562 and LP8501 have common features as below.
  
   Register access via the I2C
   Device initialization/deinitialization
@@ -108,6 +108,30 @@
 As soon as 'loading' is set to 0, registered callback is called.
 Inside the callback, the selected engine is loaded and memory is updated.
 To run programmed pattern, 'run_engine' attribute should be enabled.
+
+The pattern sqeuence of LP8501 is same as LP5523.
+However pattern data is specific.
+Ex 1) Engine 1 is used
+echo 1 > /sys/bus/i2c/devices/xxxx/select_engine
+echo 1 > /sys/class/firmware/lp8501/loading
+echo "9d0140ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data
+echo 0 > /sys/class/firmware/lp8501/loading
+echo 1 > /sys/bus/i2c/devices/xxxx/run_engine
+
+Ex 2) Engine 2 and 3 are used at the same time
+echo 2 > /sys/bus/i2c/devices/xxxx/select_engine
+sleep 1
+echo 1 > /sys/class/firmware/lp8501/loading
+echo "9d0140ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data
+echo 0 > /sys/class/firmware/lp8501/loading
+sleep 1
+echo 3 > /sys/bus/i2c/devices/xxxx/select_engine
+sleep 1
+echo 1 > /sys/class/firmware/lp8501/loading
+echo "9d0340ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data
+echo 0 > /sys/class/firmware/lp8501/loading
+sleep 1
+echo 1 > /sys/class/leds/d1/device/run_engine
  
 ( 'run_engine' and 'firmware_cb' )
 The sequence of running the program data is common.
@@ -194,11 +194,11 @@
 	  module will be called leds-lp3944.
  
 config LEDS_LP55XX_COMMON
-	tristate "Common Driver for TI/National LP5521, LP5523/55231 and LP5562"
-	depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562
+	tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
+	depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501
 	select FW_LOADER
 	help
-	  This option supports common operations for LP5521 and LP5523/55231
+	  This option supports common operations for LP5521/5523/55231/5562/8501
 	  devices.
  
 config LEDS_LP5521
@@ -231,6 +231,18 @@
 	  It is 4 channels chip with programmable engines.
 	  Driver provides direct control via LED class and interface for
 	  programming the engines.
+
+config LEDS_LP8501
+	tristate "LED Support for TI LP8501 LED driver chip"
+	depends on LEDS_CLASS && I2C
+	select LEDS_LP55XX_COMMON
+	help
+	  If you say yes here you get support for TI LP8501 LED driver.
+	  It is 9 channel chip with programmable engines.
+	  Driver provides direct control via LED class and interface for
+	  programming the engines.
+	  It is similar as LP5523, but output power selection is available.
+	  And register layout and engine program schemes are different.
  
 config LEDS_LP8788
 	tristate "LED support for the TI LP8788 PMIC"
@@ -27,6 +27,7 @@
 obj-$(CONFIG_LEDS_LP5521)		+= leds-lp5521.o
 obj-$(CONFIG_LEDS_LP5523)		+= leds-lp5523.o
 obj-$(CONFIG_LEDS_LP5562)		+= leds-lp5562.o
+obj-$(CONFIG_LEDS_LP8501)		+= leds-lp8501.o
 obj-$(CONFIG_LEDS_LP8788)		+= leds-lp8788.o
 obj-$(CONFIG_LEDS_TCA6507)		+= leds-tca6507.o
 obj-$(CONFIG_LEDS_CLEVO_MAIL)		+= leds-clevo-mail.o
@@ -593,6 +593,9 @@
 	of_property_read_string(np, "label", &pdata->label);
 	of_property_read_u8(np, "clock-mode", &pdata->clock_mode);
  
+	/* LP8501 specific */
+	of_property_read_u8(np, "pwr-sel", (u8 *)&pdata->pwr_sel);
+
 	dev->platform_data = pdata;
  
 	return 0;
+/*
+ * TI LP8501 9 channel LED Driver
+ *
+ * Copyright (C) 2013 Texas Instruments
+ *
+ * Author: Milo(Woogyom) Kim <milo.kim@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * version 2 as published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/delay.h>
+#include <linux/firmware.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/leds.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/platform_data/leds-lp55xx.h>
+#include <linux/slab.h>
+
+#include "leds-lp55xx-common.h"
+
+#define LP8501_PROGRAM_LENGTH		32
+#define LP8501_MAX_LEDS			9
+
+/* Registers */
+#define LP8501_REG_ENABLE		0x00
+#define LP8501_ENABLE			BIT(6)
+#define LP8501_EXEC_M			0x3F
+#define LP8501_EXEC_ENG1_M		0x30
+#define LP8501_EXEC_ENG2_M		0x0C
+#define LP8501_EXEC_ENG3_M		0x03
+#define LP8501_RUN_ENG1			0x20
+#define LP8501_RUN_ENG2			0x08
+#define LP8501_RUN_ENG3			0x02
+
+#define LP8501_REG_OP_MODE		0x01
+#define LP8501_MODE_ENG1_M		0x30
+#define LP8501_MODE_ENG2_M		0x0C
+#define LP8501_MODE_ENG3_M		0x03
+#define LP8501_LOAD_ENG1		0x10
+#define LP8501_LOAD_ENG2		0x04
+#define LP8501_LOAD_ENG3		0x01
+
+#define LP8501_REG_PWR_CONFIG		0x05
+#define LP8501_PWR_CONFIG_M		0x03
+
+#define LP8501_REG_LED_PWM_BASE		0x16
+
+#define LP8501_REG_LED_CURRENT_BASE	0x26
+
+#define LP8501_REG_CONFIG		0x36
+#define LP8501_PWM_PSAVE		BIT(7)
+#define LP8501_AUTO_INC			BIT(6)
+#define LP8501_PWR_SAVE			BIT(5)
+#define LP8501_CP_AUTO			0x18
+#define LP8501_INT_CLK			BIT(0)
+#define LP8501_DEFAULT_CFG	\
+	(LP8501_PWM_PSAVE | LP8501_AUTO_INC | LP8501_PWR_SAVE | LP8501_CP_AUTO)
+
+#define LP8501_REG_RESET		0x3D
+#define LP8501_RESET			0xFF
+
+#define LP8501_REG_PROG_PAGE_SEL	0x4F
+#define LP8501_PAGE_ENG1		0
+#define LP8501_PAGE_ENG2		1
+#define LP8501_PAGE_ENG3		2
+
+#define LP8501_REG_PROG_MEM		0x50
+
+#define LP8501_ENG1_IS_LOADING(mode)	\
+	((mode & LP8501_MODE_ENG1_M) == LP8501_LOAD_ENG1)
+#define LP8501_ENG2_IS_LOADING(mode)	\
+	((mode & LP8501_MODE_ENG2_M) == LP8501_LOAD_ENG2)
+#define LP8501_ENG3_IS_LOADING(mode)	\
+	((mode & LP8501_MODE_ENG3_M) == LP8501_LOAD_ENG3)
+
+static inline void lp8501_wait_opmode_done(void)
+{
+	usleep_range(1000, 2000);
+}
+
+static void lp8501_set_led_current(struct lp55xx_led *led, u8 led_current)
+{
+	led->led_current = led_current;
+	lp55xx_write(led->chip, LP8501_REG_LED_CURRENT_BASE + led->chan_nr,
+		led_current);
+}
+
+static int lp8501_post_init_device(struct lp55xx_chip *chip)
+{
+	int ret;
+	u8 val = LP8501_DEFAULT_CFG;
+
+	ret = lp55xx_write(chip, LP8501_REG_ENABLE, LP8501_ENABLE);
+	if (ret)
+		return ret;
+
+	/* Chip startup time is 500 us, 1 - 2 ms gives some margin */
+	usleep_range(1000, 2000);
+
+	if (chip->pdata->clock_mode != LP55XX_CLOCK_EXT)
+		val |= LP8501_INT_CLK;
+
+	ret = lp55xx_write(chip, LP8501_REG_CONFIG, val);
+	if (ret)
+		return ret;
+
+	/* Power selection for each output */
+	return lp55xx_update_bits(chip, LP8501_REG_PWR_CONFIG,
+				LP8501_PWR_CONFIG_M, chip->pdata->pwr_sel);
+}
+
+static void lp8501_load_engine(struct lp55xx_chip *chip)
+{
+	enum lp55xx_engine_index idx = chip->engine_idx;
+	u8 mask[] = {
+		[LP55XX_ENGINE_1] = LP8501_MODE_ENG1_M,
+		[LP55XX_ENGINE_2] = LP8501_MODE_ENG2_M,
+		[LP55XX_ENGINE_3] = LP8501_MODE_ENG3_M,
+	};
+
+	u8 val[] = {
+		[LP55XX_ENGINE_1] = LP8501_LOAD_ENG1,
+		[LP55XX_ENGINE_2] = LP8501_LOAD_ENG2,
+		[LP55XX_ENGINE_3] = LP8501_LOAD_ENG3,
+	};
+
+	u8 page_sel[] = {
+		[LP55XX_ENGINE_1] = LP8501_PAGE_ENG1,
+		[LP55XX_ENGINE_2] = LP8501_PAGE_ENG2,
+		[LP55XX_ENGINE_3] = LP8501_PAGE_ENG3,
+	};
+
+	lp55xx_update_bits(chip, LP8501_REG_OP_MODE, mask[idx], val[idx]);
+
+	lp8501_wait_opmode_done();
+
+	lp55xx_write(chip, LP8501_REG_PROG_PAGE_SEL, page_sel[idx]);
+}
+
+static void lp8501_stop_engine(struct lp55xx_chip *chip)
+{
+	lp55xx_write(chip, LP8501_REG_OP_MODE, 0);
+	lp8501_wait_opmode_done();
+}
+
+static void lp8501_turn_off_channels(struct lp55xx_chip *chip)
+{
+	int i;
+
+	for (i = 0; i < LP8501_MAX_LEDS; i++)
+		lp55xx_write(chip, LP8501_REG_LED_PWM_BASE + i, 0);
+}
+
+static void lp8501_run_engine(struct lp55xx_chip *chip, bool start)
+{
+	int ret;
+	u8 mode;
+	u8 exec;
+
+	/* stop engine */
+	if (!start) {
+		lp8501_stop_engine(chip);
+		lp8501_turn_off_channels(chip);
+		return;
+	}
+
+	/*
+	 * To run the engine,
+	 * operation mode and enable register should updated at the same time
+	 */
+
+	ret = lp55xx_read(chip, LP8501_REG_OP_MODE, &mode);
+	if (ret)
+		return;
+
+	ret = lp55xx_read(chip, LP8501_REG_ENABLE, &exec);
+	if (ret)
+		return;
+
+	/* change operation mode to RUN only when each engine is loading */
+	if (LP8501_ENG1_IS_LOADING(mode)) {
+		mode = (mode & ~LP8501_MODE_ENG1_M) | LP8501_RUN_ENG1;
+		exec = (exec & ~LP8501_EXEC_ENG1_M) | LP8501_RUN_ENG1;
+	}
+
+	if (LP8501_ENG2_IS_LOADING(mode)) {
+		mode = (mode & ~LP8501_MODE_ENG2_M) | LP8501_RUN_ENG2;
+		exec = (exec & ~LP8501_EXEC_ENG2_M) | LP8501_RUN_ENG2;
+	}
+
+	if (LP8501_ENG3_IS_LOADING(mode)) {
+		mode = (mode & ~LP8501_MODE_ENG3_M) | LP8501_RUN_ENG3;
+		exec = (exec & ~LP8501_EXEC_ENG3_M) | LP8501_RUN_ENG3;
+	}
+
+	lp55xx_write(chip, LP8501_REG_OP_MODE, mode);
+	lp8501_wait_opmode_done();
+
+	lp55xx_update_bits(chip, LP8501_REG_ENABLE, LP8501_EXEC_M, exec);
+}
+
+static int lp8501_update_program_memory(struct lp55xx_chip *chip,
+					const u8 *data, size_t size)
+{
+	u8 pattern[LP8501_PROGRAM_LENGTH] = {0};
+	unsigned cmd;
+	char c[3];
+	int update_size;
+	int nrchars;
+	int offset = 0;
+	int ret;
+	int i;
+
+	/* clear program memory before updating */
+	for (i = 0; i < LP8501_PROGRAM_LENGTH; i++)
+		lp55xx_write(chip, LP8501_REG_PROG_MEM + i, 0);
+
+	i = 0;
+	while ((offset < size - 1) && (i < LP8501_PROGRAM_LENGTH)) {
+		/* separate sscanfs because length is working only for %s */
+		ret = sscanf(data + offset, "%2s%n ", c, &nrchars);
+		if (ret != 1)
+			goto err;
+
+		ret = sscanf(c, "%2x", &cmd);
+		if (ret != 1)
+			goto err;
+
+		pattern[i] = (u8)cmd;
+		offset += nrchars;
+		i++;
+	}
+
+	/* Each instruction is 16bit long. Check that length is even */
+	if (i % 2)
+		goto err;
+
+	update_size = i;
+	for (i = 0; i < update_size; i++)
+		lp55xx_write(chip, LP8501_REG_PROG_MEM + i, pattern[i]);
+
+	return 0;
+
+err:
+	dev_err(&chip->cl->dev, "wrong pattern format\n");
+	return -EINVAL;
+}
+
+static void lp8501_firmware_loaded(struct lp55xx_chip *chip)
+{
+	const struct firmware *fw = chip->fw;
+
+	if (fw->size > LP8501_PROGRAM_LENGTH) {
+		dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
+			fw->size);
+		return;
+	}
+
+	/*
+	 * Program momery sequence
+	 *  1) set engine mode to "LOAD"
+	 *  2) write firmware data into program memory
+	 */
+
+	lp8501_load_engine(chip);
+	lp8501_update_program_memory(chip, fw->data, fw->size);
+}
+
+static void lp8501_led_brightness_work(struct work_struct *work)
+{
+	struct lp55xx_led *led = container_of(work, struct lp55xx_led,
+					      brightness_work);
+	struct lp55xx_chip *chip = led->chip;
+
+	mutex_lock(&chip->lock);
+	lp55xx_write(chip, LP8501_REG_LED_PWM_BASE + led->chan_nr,
+		     led->brightness);
+	mutex_unlock(&chip->lock);
+}
+
+/* Chip specific configurations */
+static struct lp55xx_device_config lp8501_cfg = {
+	.reset = {
+		.addr = LP8501_REG_RESET,
+		.val  = LP8501_RESET,
+	},
+	.enable = {
+		.addr = LP8501_REG_ENABLE,
+		.val  = LP8501_ENABLE,
+	},
+	.max_channel  = LP8501_MAX_LEDS,
+	.post_init_device   = lp8501_post_init_device,
+	.brightness_work_fn = lp8501_led_brightness_work,
+	.set_led_current    = lp8501_set_led_current,
+	.firmware_cb        = lp8501_firmware_loaded,
+	.run_engine         = lp8501_run_engine,
+};
+
+static int lp8501_probe(struct i2c_client *client,
+			const struct i2c_device_id *id)
+{
+	int ret;
+	struct lp55xx_chip *chip;
+	struct lp55xx_led *led;
+	struct lp55xx_platform_data *pdata;
+	struct device_node *np = client->dev.of_node;
+
+	if (!client->dev.platform_data) {
+		if (np) {
+			ret = lp55xx_of_populate_pdata(&client->dev, np);
+			if (ret < 0)
+				return ret;
+		} else {
+			dev_err(&client->dev, "no platform data\n");
+			return -EINVAL;
+		}
+	}
+	pdata = client->dev.platform_data;
+
+	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+	if (!chip)
+		return -ENOMEM;
+
+	led = devm_kzalloc(&client->dev,
+			sizeof(*led) * pdata->num_channels, GFP_KERNEL);
+	if (!led)
+		return -ENOMEM;
+
+	chip->cl = client;
+	chip->pdata = pdata;
+	chip->cfg = &lp8501_cfg;
+
+	mutex_init(&chip->lock);
+
+	i2c_set_clientdata(client, led);
+
+	ret = lp55xx_init_device(chip);
+	if (ret)
+		goto err_init;
+
+	dev_info(&client->dev, "%s Programmable led chip found\n", id->name);
+
+	ret = lp55xx_register_leds(led, chip);
+	if (ret)
+		goto err_register_leds;
+
+	ret = lp55xx_register_sysfs(chip);
+	if (ret) {
+		dev_err(&client->dev, "registering sysfs failed\n");
+		goto err_register_sysfs;
+	}
+
+	return 0;
+
+err_register_sysfs:
+	lp55xx_unregister_leds(led, chip);
+err_register_leds:
+	lp55xx_deinit_device(chip);
+err_init:
+	return ret;
+}
+
+static int lp8501_remove(struct i2c_client *client)
+{
+	struct lp55xx_led *led = i2c_get_clientdata(client);
+	struct lp55xx_chip *chip = led->chip;
+
+	lp8501_stop_engine(chip);
+	lp55xx_unregister_sysfs(chip);
+	lp55xx_unregister_leds(led, chip);
+	lp55xx_deinit_device(chip);
+
+	return 0;
+}
+
+static const struct i2c_device_id lp8501_id[] = {
+	{ "lp8501",  0 },
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, lp8501_id);
+
+#ifdef CONFIG_OF
+static const struct of_device_id of_lp8501_leds_match[] = {
+	{ .compatible = "ti,lp8501", },
+	{},
+};
+
+MODULE_DEVICE_TABLE(of, of_lp8501_leds_match);
+#endif
+
+static struct i2c_driver lp8501_driver = {
+	.driver = {
+		.name	= "lp8501",
+		.of_match_table = of_match_ptr(of_lp8501_leds_match),
+	},
+	.probe		= lp8501_probe,
+	.remove		= lp8501_remove,
+	.id_table	= lp8501_id,
+};
+
+module_i2c_driver(lp8501_driver);
+
+MODULE_DESCRIPTION("Texas Instruments LP8501 LED drvier");
+MODULE_AUTHOR("Milo Kim");
+MODULE_LICENSE("GPL");
@@ -36,6 +36,13 @@
 	u8 size_b;
 };
  
+enum lp8501_pwr_sel {
+	LP8501_ALL_VDD,		/* D1~9 are connected to VDD */
+	LP8501_6VDD_3VOUT,	/* D1~6 with VDD, D7~9 with VOUT */
+	LP8501_3VDD_6VOUT,	/* D1~6 with VOUT, D7~9 with VDD */
+	LP8501_ALL_VOUT,	/* D1~9 are connected to VOUT */
+};
+
 /*
  * struct lp55xx_platform_data
  * @led_config        : Configurable led class device
@@ -67,6 +74,9 @@
 	/* Predefined pattern data */
 	struct lp55xx_predef_pattern *patterns;
 	unsigned int num_patterns;
+
+	/* LP8501 specific */
+	enum lp8501_pwr_sel pwr_sel;
 };
  
 #endif /* _LEDS_LP55XX_H */
1	1	Binding for TI/National Semiconductor LP55xx Led Drivers
2	2
3	3	Required properties:
4		-- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562"
	4	+- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562" or "ti,lp8501"
5	5	- reg: I2C slave address
6	6	- clock-mode: Input clock mode, (0: automode, 1: internal, 2: external)
7	7
...	...	@@ -11,6 +11,11 @@
11	11
12	12	Optional properties:
13	13	- label: Used for naming LEDs
	14	+- pwr-sel: LP8501 specific property. Power selection for output channels.
	15	+ 0: D1~9 are connected to VDD
	16	+ 1: D1~6 with VDD, D7~9 with VOUT
	17	+ 2: D1~6 with VOUT, D7~9 with VDD
	18	+ 3: D1~9 are connected to VOUT
14	19
15	20	Alternatively, each child can have specific channel name
16	21	- chan-name: Name of each channel name
...	...	@@ -143,6 +148,71 @@
143	148	chan-name = "W";
144	149	led-cur = /bits/ 8 <0x20>;
145	150	max-cur = /bits/ 8 <0x60>;
	151	+ };
	152	+};
	153	+
	154	+example 4) LP8501
	155	+9 channels are defined. The 'pwr-sel' is LP8501 specific property.
	156	+Others are same as LP5523.
	157	+
	158	+lp8501@32 {
	159	+ compatible = "ti,lp8501";
	160	+ reg = <0x32>;
	161	+ clock-mode = /bits/ 8 <2>;
	162	+ pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */
	163	+
	164	+ chan0 {
	165	+ chan-name = "d1";
	166	+ led-cur = /bits/ 8 <0x14>;
	167	+ max-cur = /bits/ 8 <0x20>;
	168	+ };
	169	+
	170	+ chan1 {
	171	+ chan-name = "d2";
	172	+ led-cur = /bits/ 8 <0x14>;
	173	+ max-cur = /bits/ 8 <0x20>;
	174	+ };
	175	+
	176	+ chan2 {
	177	+ chan-name = "d3";
	178	+ led-cur = /bits/ 8 <0x14>;
	179	+ max-cur = /bits/ 8 <0x20>;
	180	+ };
	181	+
	182	+ chan3 {
	183	+ chan-name = "d4";
	184	+ led-cur = /bits/ 8 <0x14>;
	185	+ max-cur = /bits/ 8 <0x20>;
	186	+ };
	187	+
	188	+ chan4 {
	189	+ chan-name = "d5";
	190	+ led-cur = /bits/ 8 <0x14>;
	191	+ max-cur = /bits/ 8 <0x20>;
	192	+ };
	193	+
	194	+ chan5 {
	195	+ chan-name = "d6";
	196	+ led-cur = /bits/ 8 <0x14>;
	197	+ max-cur = /bits/ 8 <0x20>;
	198	+ };
	199	+
	200	+ chan6 {
	201	+ chan-name = "d7";
	202	+ led-cur = /bits/ 8 <0x14>;
	203	+ max-cur = /bits/ 8 <0x20>;
	204	+ };
	205	+
	206	+ chan7 {
	207	+ chan-name = "d8";
	208	+ led-cur = /bits/ 8 <0x14>;
	209	+ max-cur = /bits/ 8 <0x20>;
	210	+ };
	211	+
	212	+ chan8 {
	213	+ chan-name = "d9";
	214	+ led-cur = /bits/ 8 <0x14>;
	215	+ max-cur = /bits/ 8 <0x20>;
146	216	};
147	217	};
1		-LP5521/LP5523/LP55231 Common Driver
2		-===================================
	1	+LP5521/LP5523/LP55231/LP5562/LP8501 Common Driver
	2	+=================================================
3	3
4	4	Authors: Milo(Woogyom) Kim <milo.kim@ti.com>
5	5
6	6	Description
7	7	-----------
8		-LP5521, LP5523/55231 and LP5562 have common features as below.
	8	+LP5521, LP5523/55231, LP5562 and LP8501 have common features as below.
9	9
10	10	Register access via the I2C
11	11	Device initialization/deinitialization
...	...	@@ -108,6 +108,30 @@
108	108	As soon as 'loading' is set to 0, registered callback is called.
109	109	Inside the callback, the selected engine is loaded and memory is updated.
110	110	To run programmed pattern, 'run_engine' attribute should be enabled.
	111	+
	112	+The pattern sqeuence of LP8501 is same as LP5523.
	113	+However pattern data is specific.
	114	+Ex 1) Engine 1 is used
	115	+echo 1 > /sys/bus/i2c/devices/xxxx/select_engine
	116	+echo 1 > /sys/class/firmware/lp8501/loading
	117	+echo "9d0140ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data
	118	+echo 0 > /sys/class/firmware/lp8501/loading
	119	+echo 1 > /sys/bus/i2c/devices/xxxx/run_engine
	120	+
	121	+Ex 2) Engine 2 and 3 are used at the same time
	122	+echo 2 > /sys/bus/i2c/devices/xxxx/select_engine
	123	+sleep 1
	124	+echo 1 > /sys/class/firmware/lp8501/loading
	125	+echo "9d0140ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data
	126	+echo 0 > /sys/class/firmware/lp8501/loading
	127	+sleep 1
	128	+echo 3 > /sys/bus/i2c/devices/xxxx/select_engine
	129	+sleep 1
	130	+echo 1 > /sys/class/firmware/lp8501/loading
	131	+echo "9d0340ff7e0040007e00a001c000" > /sys/class/firmware/lp8501/data
	132	+echo 0 > /sys/class/firmware/lp8501/loading
	133	+sleep 1
	134	+echo 1 > /sys/class/leds/d1/device/run_engine
111	135
112	136	( 'run_engine' and 'firmware_cb' )
113	137	The sequence of running the program data is common.
...	...	@@ -194,11 +194,11 @@
194	194	module will be called leds-lp3944.
195	195
196	196	config LEDS_LP55XX_COMMON
197		- tristate "Common Driver for TI/National LP5521, LP5523/55231 and LP5562"
198		- depends on LEDS_LP5521 \|\| LEDS_LP5523 \|\| LEDS_LP5562
	197	+ tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
	198	+ depends on LEDS_LP5521 \|\| LEDS_LP5523 \|\| LEDS_LP5562 \|\| LEDS_LP8501
199	199	select FW_LOADER
200	200	help
201		- This option supports common operations for LP5521 and LP5523/55231
	201	+ This option supports common operations for LP5521/5523/55231/5562/8501
202	202	devices.
203	203
204	204	config LEDS_LP5521
...	...	@@ -231,6 +231,18 @@
231	231	It is 4 channels chip with programmable engines.
232	232	Driver provides direct control via LED class and interface for
233	233	programming the engines.
	234	+
	235	+config LEDS_LP8501
	236	+ tristate "LED Support for TI LP8501 LED driver chip"
	237	+ depends on LEDS_CLASS && I2C
	238	+ select LEDS_LP55XX_COMMON
	239	+ help
	240	+ If you say yes here you get support for TI LP8501 LED driver.
	241	+ It is 9 channel chip with programmable engines.
	242	+ Driver provides direct control via LED class and interface for
	243	+ programming the engines.
	244	+ It is similar as LP5523, but output power selection is available.
	245	+ And register layout and engine program schemes are different.
234	246
235	247	config LEDS_LP8788
236	248	tristate "LED support for the TI LP8788 PMIC"
...	...	@@ -27,6 +27,7 @@
27	27	obj-$(CONFIG_LEDS_LP5521) += leds-lp5521.o
28	28	obj-$(CONFIG_LEDS_LP5523) += leds-lp5523.o
29	29	obj-$(CONFIG_LEDS_LP5562) += leds-lp5562.o
	30	+obj-$(CONFIG_LEDS_LP8501) += leds-lp8501.o
30	31	obj-$(CONFIG_LEDS_LP8788) += leds-lp8788.o
31	32	obj-$(CONFIG_LEDS_TCA6507) += leds-tca6507.o
32	33	obj-$(CONFIG_LEDS_CLEVO_MAIL) += leds-clevo-mail.o
...	...	@@ -593,6 +593,9 @@
593	593	of_property_read_string(np, "label", &pdata->label);
594	594	of_property_read_u8(np, "clock-mode", &pdata->clock_mode);
595	595
	596	+ /* LP8501 specific */
	597	+ of_property_read_u8(np, "pwr-sel", (u8 *)&pdata->pwr_sel);
	598	+
596	599	dev->platform_data = pdata;
597	600
598	601	return 0;
	1	+/*
	2	+ * TI LP8501 9 channel LED Driver
	3	+ *
	4	+ * Copyright (C) 2013 Texas Instruments
	5	+ *
	6	+ * Author: Milo(Woogyom) Kim <milo.kim@ti.com>
	7	+ *
	8	+ * This program is free software; you can redistribute it and/or
	9	+ * modify it under the terms of the GNU General Public License
	10	+ * version 2 as published by the Free Software Foundation.
	11	+ *
	12	+ */
	13	+
	14	+#include <linux/delay.h>
	15	+#include <linux/firmware.h>
	16	+#include <linux/i2c.h>
	17	+#include <linux/init.h>
	18	+#include <linux/leds.h>
	19	+#include <linux/module.h>
	20	+#include <linux/mutex.h>
	21	+#include <linux/platform_data/leds-lp55xx.h>
	22	+#include <linux/slab.h>
	23	+
	24	+#include "leds-lp55xx-common.h"
	25	+
	26	+#define LP8501_PROGRAM_LENGTH 32
	27	+#define LP8501_MAX_LEDS 9
	28	+
	29	+/* Registers */
	30	+#define LP8501_REG_ENABLE 0x00
	31	+#define LP8501_ENABLE BIT(6)
	32	+#define LP8501_EXEC_M 0x3F
	33	+#define LP8501_EXEC_ENG1_M 0x30
	34	+#define LP8501_EXEC_ENG2_M 0x0C
	35	+#define LP8501_EXEC_ENG3_M 0x03
	36	+#define LP8501_RUN_ENG1 0x20
	37	+#define LP8501_RUN_ENG2 0x08
	38	+#define LP8501_RUN_ENG3 0x02
	39	+
	40	+#define LP8501_REG_OP_MODE 0x01
	41	+#define LP8501_MODE_ENG1_M 0x30
	42	+#define LP8501_MODE_ENG2_M 0x0C
	43	+#define LP8501_MODE_ENG3_M 0x03
	44	+#define LP8501_LOAD_ENG1 0x10
	45	+#define LP8501_LOAD_ENG2 0x04
	46	+#define LP8501_LOAD_ENG3 0x01
	47	+
	48	+#define LP8501_REG_PWR_CONFIG 0x05
	49	+#define LP8501_PWR_CONFIG_M 0x03
	50	+
	51	+#define LP8501_REG_LED_PWM_BASE 0x16
	52	+
	53	+#define LP8501_REG_LED_CURRENT_BASE 0x26
	54	+
	55	+#define LP8501_REG_CONFIG 0x36
	56	+#define LP8501_PWM_PSAVE BIT(7)
	57	+#define LP8501_AUTO_INC BIT(6)
	58	+#define LP8501_PWR_SAVE BIT(5)
	59	+#define LP8501_CP_AUTO 0x18
	60	+#define LP8501_INT_CLK BIT(0)
	61	+#define LP8501_DEFAULT_CFG \
	62	+ (LP8501_PWM_PSAVE \| LP8501_AUTO_INC \| LP8501_PWR_SAVE \| LP8501_CP_AUTO)
	63	+
	64	+#define LP8501_REG_RESET 0x3D
	65	+#define LP8501_RESET 0xFF
	66	+
	67	+#define LP8501_REG_PROG_PAGE_SEL 0x4F
	68	+#define LP8501_PAGE_ENG1 0
	69	+#define LP8501_PAGE_ENG2 1
	70	+#define LP8501_PAGE_ENG3 2
	71	+
	72	+#define LP8501_REG_PROG_MEM 0x50
	73	+
	74	+#define LP8501_ENG1_IS_LOADING(mode) \
	75	+ ((mode & LP8501_MODE_ENG1_M) == LP8501_LOAD_ENG1)
	76	+#define LP8501_ENG2_IS_LOADING(mode) \
	77	+ ((mode & LP8501_MODE_ENG2_M) == LP8501_LOAD_ENG2)
	78	+#define LP8501_ENG3_IS_LOADING(mode) \
	79	+ ((mode & LP8501_MODE_ENG3_M) == LP8501_LOAD_ENG3)
	80	+
	81	+static inline void lp8501_wait_opmode_done(void)
	82	+{
	83	+ usleep_range(1000, 2000);
	84	+}
	85	+
	86	+static void lp8501_set_led_current(struct lp55xx_led *led, u8 led_current)
	87	+{
	88	+ led->led_current = led_current;
	89	+ lp55xx_write(led->chip, LP8501_REG_LED_CURRENT_BASE + led->chan_nr,
	90	+ led_current);
	91	+}
	92	+
	93	+static int lp8501_post_init_device(struct lp55xx_chip *chip)
	94	+{
	95	+ int ret;
	96	+ u8 val = LP8501_DEFAULT_CFG;
	97	+
	98	+ ret = lp55xx_write(chip, LP8501_REG_ENABLE, LP8501_ENABLE);
	99	+ if (ret)
	100	+ return ret;
	101	+
	102	+ /* Chip startup time is 500 us, 1 - 2 ms gives some margin */
	103	+ usleep_range(1000, 2000);
	104	+
	105	+ if (chip->pdata->clock_mode != LP55XX_CLOCK_EXT)
	106	+ val \|= LP8501_INT_CLK;
	107	+
	108	+ ret = lp55xx_write(chip, LP8501_REG_CONFIG, val);
	109	+ if (ret)
	110	+ return ret;
	111	+
	112	+ /* Power selection for each output */
	113	+ return lp55xx_update_bits(chip, LP8501_REG_PWR_CONFIG,
	114	+ LP8501_PWR_CONFIG_M, chip->pdata->pwr_sel);
	115	+}
	116	+
	117	+static void lp8501_load_engine(struct lp55xx_chip *chip)
	118	+{
	119	+ enum lp55xx_engine_index idx = chip->engine_idx;
	120	+ u8 mask[] = {
	121	+ [LP55XX_ENGINE_1] = LP8501_MODE_ENG1_M,
	122	+ [LP55XX_ENGINE_2] = LP8501_MODE_ENG2_M,
	123	+ [LP55XX_ENGINE_3] = LP8501_MODE_ENG3_M,
	124	+ };
	125	+
	126	+ u8 val[] = {
	127	+ [LP55XX_ENGINE_1] = LP8501_LOAD_ENG1,
	128	+ [LP55XX_ENGINE_2] = LP8501_LOAD_ENG2,
	129	+ [LP55XX_ENGINE_3] = LP8501_LOAD_ENG3,
	130	+ };
	131	+
	132	+ u8 page_sel[] = {
	133	+ [LP55XX_ENGINE_1] = LP8501_PAGE_ENG1,
	134	+ [LP55XX_ENGINE_2] = LP8501_PAGE_ENG2,
	135	+ [LP55XX_ENGINE_3] = LP8501_PAGE_ENG3,
	136	+ };
	137	+
	138	+ lp55xx_update_bits(chip, LP8501_REG_OP_MODE, mask[idx], val[idx]);
	139	+
	140	+ lp8501_wait_opmode_done();
	141	+
	142	+ lp55xx_write(chip, LP8501_REG_PROG_PAGE_SEL, page_sel[idx]);
	143	+}
	144	+
	145	+static void lp8501_stop_engine(struct lp55xx_chip *chip)
	146	+{
	147	+ lp55xx_write(chip, LP8501_REG_OP_MODE, 0);
	148	+ lp8501_wait_opmode_done();
	149	+}
	150	+
	151	+static void lp8501_turn_off_channels(struct lp55xx_chip *chip)
	152	+{
	153	+ int i;
	154	+
	155	+ for (i = 0; i < LP8501_MAX_LEDS; i++)
	156	+ lp55xx_write(chip, LP8501_REG_LED_PWM_BASE + i, 0);
	157	+}
	158	+
	159	+static void lp8501_run_engine(struct lp55xx_chip *chip, bool start)
	160	+{
	161	+ int ret;
	162	+ u8 mode;
	163	+ u8 exec;
	164	+
	165	+ /* stop engine */
	166	+ if (!start) {
	167	+ lp8501_stop_engine(chip);
	168	+ lp8501_turn_off_channels(chip);
	169	+ return;
	170	+ }
	171	+
	172	+ /*
	173	+ * To run the engine,
	174	+ * operation mode and enable register should updated at the same time
	175	+ */
	176	+
	177	+ ret = lp55xx_read(chip, LP8501_REG_OP_MODE, &mode);
	178	+ if (ret)
	179	+ return;
	180	+
	181	+ ret = lp55xx_read(chip, LP8501_REG_ENABLE, &exec);
	182	+ if (ret)
	183	+ return;
	184	+
	185	+ /* change operation mode to RUN only when each engine is loading */
	186	+ if (LP8501_ENG1_IS_LOADING(mode)) {
	187	+ mode = (mode & ~LP8501_MODE_ENG1_M) \| LP8501_RUN_ENG1;
	188	+ exec = (exec & ~LP8501_EXEC_ENG1_M) \| LP8501_RUN_ENG1;
	189	+ }
	190	+
	191	+ if (LP8501_ENG2_IS_LOADING(mode)) {
	192	+ mode = (mode & ~LP8501_MODE_ENG2_M) \| LP8501_RUN_ENG2;
	193	+ exec = (exec & ~LP8501_EXEC_ENG2_M) \| LP8501_RUN_ENG2;
	194	+ }
	195	+
	196	+ if (LP8501_ENG3_IS_LOADING(mode)) {
	197	+ mode = (mode & ~LP8501_MODE_ENG3_M) \| LP8501_RUN_ENG3;
	198	+ exec = (exec & ~LP8501_EXEC_ENG3_M) \| LP8501_RUN_ENG3;
	199	+ }
	200	+
	201	+ lp55xx_write(chip, LP8501_REG_OP_MODE, mode);
	202	+ lp8501_wait_opmode_done();
	203	+
	204	+ lp55xx_update_bits(chip, LP8501_REG_ENABLE, LP8501_EXEC_M, exec);
	205	+}
	206	+
	207	+static int lp8501_update_program_memory(struct lp55xx_chip *chip,
	208	+ const u8 *data, size_t size)
	209	+{
	210	+ u8 pattern[LP8501_PROGRAM_LENGTH] = {0};
	211	+ unsigned cmd;
	212	+ char c[3];
	213	+ int update_size;
	214	+ int nrchars;
	215	+ int offset = 0;
	216	+ int ret;
	217	+ int i;
	218	+
	219	+ /* clear program memory before updating */
	220	+ for (i = 0; i < LP8501_PROGRAM_LENGTH; i++)
	221	+ lp55xx_write(chip, LP8501_REG_PROG_MEM + i, 0);
	222	+
	223	+ i = 0;
	224	+ while ((offset < size - 1) && (i < LP8501_PROGRAM_LENGTH)) {
	225	+ /* separate sscanfs because length is working only for %s */
	226	+ ret = sscanf(data + offset, "%2s%n ", c, &nrchars);
	227	+ if (ret != 1)
	228	+ goto err;
	229	+
	230	+ ret = sscanf(c, "%2x", &cmd);
	231	+ if (ret != 1)
	232	+ goto err;
	233	+
	234	+ pattern[i] = (u8)cmd;
	235	+ offset += nrchars;
	236	+ i++;
	237	+ }
	238	+
	239	+ /* Each instruction is 16bit long. Check that length is even */
	240	+ if (i % 2)
	241	+ goto err;
	242	+
	243	+ update_size = i;
	244	+ for (i = 0; i < update_size; i++)
	245	+ lp55xx_write(chip, LP8501_REG_PROG_MEM + i, pattern[i]);
	246	+
	247	+ return 0;
	248	+
	249	+err:
	250	+ dev_err(&chip->cl->dev, "wrong pattern format\n");
	251	+ return -EINVAL;
	252	+}
	253	+
	254	+static void lp8501_firmware_loaded(struct lp55xx_chip *chip)
	255	+{
	256	+ const struct firmware *fw = chip->fw;
	257	+
	258	+ if (fw->size > LP8501_PROGRAM_LENGTH) {
	259	+ dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
	260	+ fw->size);
	261	+ return;
	262	+ }
	263	+
	264	+ /*
	265	+ * Program momery sequence
	266	+ * 1) set engine mode to "LOAD"
	267	+ * 2) write firmware data into program memory
	268	+ */
	269	+
	270	+ lp8501_load_engine(chip);
	271	+ lp8501_update_program_memory(chip, fw->data, fw->size);
	272	+}
	273	+
	274	+static void lp8501_led_brightness_work(struct work_struct *work)
	275	+{
	276	+ struct lp55xx_led *led = container_of(work, struct lp55xx_led,
	277	+ brightness_work);
	278	+ struct lp55xx_chip *chip = led->chip;
	279	+
	280	+ mutex_lock(&chip->lock);
	281	+ lp55xx_write(chip, LP8501_REG_LED_PWM_BASE + led->chan_nr,
	282	+ led->brightness);
	283	+ mutex_unlock(&chip->lock);
	284	+}
	285	+
	286	+/* Chip specific configurations */
	287	+static struct lp55xx_device_config lp8501_cfg = {
	288	+ .reset = {
	289	+ .addr = LP8501_REG_RESET,
	290	+ .val = LP8501_RESET,
	291	+ },
	292	+ .enable = {
	293	+ .addr = LP8501_REG_ENABLE,
	294	+ .val = LP8501_ENABLE,
	295	+ },
	296	+ .max_channel = LP8501_MAX_LEDS,
	297	+ .post_init_device = lp8501_post_init_device,
	298	+ .brightness_work_fn = lp8501_led_brightness_work,
	299	+ .set_led_current = lp8501_set_led_current,
	300	+ .firmware_cb = lp8501_firmware_loaded,
	301	+ .run_engine = lp8501_run_engine,
	302	+};
	303	+
	304	+static int lp8501_probe(struct i2c_client *client,
	305	+ const struct i2c_device_id *id)
	306	+{
	307	+ int ret;
	308	+ struct lp55xx_chip *chip;
	309	+ struct lp55xx_led *led;
	310	+ struct lp55xx_platform_data *pdata;
	311	+ struct device_node *np = client->dev.of_node;
	312	+
	313	+ if (!client->dev.platform_data) {
	314	+ if (np) {
	315	+ ret = lp55xx_of_populate_pdata(&client->dev, np);
	316	+ if (ret < 0)
	317	+ return ret;
	318	+ } else {
	319	+ dev_err(&client->dev, "no platform data\n");
	320	+ return -EINVAL;
	321	+ }
	322	+ }
	323	+ pdata = client->dev.platform_data;
	324	+
	325	+ chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
	326	+ if (!chip)
	327	+ return -ENOMEM;
	328	+
	329	+ led = devm_kzalloc(&client->dev,
	330	+ sizeof(led) pdata->num_channels, GFP_KERNEL);
	331	+ if (!led)
	332	+ return -ENOMEM;
	333	+
	334	+ chip->cl = client;
	335	+ chip->pdata = pdata;
	336	+ chip->cfg = &lp8501_cfg;
	337	+
	338	+ mutex_init(&chip->lock);
	339	+
	340	+ i2c_set_clientdata(client, led);
	341	+
	342	+ ret = lp55xx_init_device(chip);
	343	+ if (ret)
	344	+ goto err_init;
	345	+
	346	+ dev_info(&client->dev, "%s Programmable led chip found\n", id->name);
	347	+
	348	+ ret = lp55xx_register_leds(led, chip);
	349	+ if (ret)
	350	+ goto err_register_leds;
	351	+
	352	+ ret = lp55xx_register_sysfs(chip);
	353	+ if (ret) {
	354	+ dev_err(&client->dev, "registering sysfs failed\n");
	355	+ goto err_register_sysfs;
	356	+ }
	357	+
	358	+ return 0;
	359	+
	360	+err_register_sysfs:
	361	+ lp55xx_unregister_leds(led, chip);
	362	+err_register_leds:
	363	+ lp55xx_deinit_device(chip);
	364	+err_init:
	365	+ return ret;
	366	+}
	367	+
	368	+static int lp8501_remove(struct i2c_client *client)
	369	+{
	370	+ struct lp55xx_led *led = i2c_get_clientdata(client);
	371	+ struct lp55xx_chip *chip = led->chip;
	372	+
	373	+ lp8501_stop_engine(chip);
	374	+ lp55xx_unregister_sysfs(chip);
	375	+ lp55xx_unregister_leds(led, chip);
	376	+ lp55xx_deinit_device(chip);
	377	+
	378	+ return 0;
	379	+}
	380	+
	381	+static const struct i2c_device_id lp8501_id[] = {
	382	+ { "lp8501", 0 },
	383	+ { }
	384	+};
	385	+MODULE_DEVICE_TABLE(i2c, lp8501_id);
	386	+
	387	+#ifdef CONFIG_OF
	388	+static const struct of_device_id of_lp8501_leds_match[] = {
	389	+ { .compatible = "ti,lp8501", },
	390	+ {},
	391	+};
	392	+
	393	+MODULE_DEVICE_TABLE(of, of_lp8501_leds_match);
	394	+#endif
	395	+
	396	+static struct i2c_driver lp8501_driver = {
	397	+ .driver = {
	398	+ .name = "lp8501",
	399	+ .of_match_table = of_match_ptr(of_lp8501_leds_match),
	400	+ },
	401	+ .probe = lp8501_probe,
	402	+ .remove = lp8501_remove,
	403	+ .id_table = lp8501_id,
	404	+};
	405	+
	406	+module_i2c_driver(lp8501_driver);
	407	+
	408	+MODULE_DESCRIPTION("Texas Instruments LP8501 LED drvier");
	409	+MODULE_AUTHOR("Milo Kim");
	410	+MODULE_LICENSE("GPL");
...	...	@@ -36,6 +36,13 @@
36	36	u8 size_b;
37	37	};
38	38
	39	+enum lp8501_pwr_sel {
	40	+ LP8501_ALL_VDD, /* D1~9 are connected to VDD */
	41	+ LP8501_6VDD_3VOUT, /* D1~6 with VDD, D7~9 with VOUT */
	42	+ LP8501_3VDD_6VOUT, /* D1~6 with VOUT, D7~9 with VDD */
	43	+ LP8501_ALL_VOUT, /* D1~9 are connected to VOUT */
	44	+};
	45	+
39	46	/*
40	47	* struct lp55xx_platform_data
41	48	* @led_config : Configurable led class device
...	...	@@ -67,6 +74,9 @@
67	74	/* Predefined pattern data */
68	75	struct lp55xx_predef_pattern *patterns;
69	76	unsigned int num_patterns;
	77	+
	78	+ /* LP8501 specific */
	79	+ enum lp8501_pwr_sel pwr_sel;
70	80	};
71	81
72	82	#endif /* _LEDS_LP55XX_H */