Commit 342709efc7a4ba91eac6d2d2d931ec316a587dfa

Authored by Pavel Emelyanov
Committed by David S. Miller
1 parent a37ae4086e

[NET]: Remove in-code externs for some functions from net/core/dev.c

Inconsistent prototype and real type for functions may have worse
consequences, than those for variables, so move them into a header.

Since they are used privately in net/core, make this file reside in
the same place.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 3 changed files with 12 additions and 4 deletions Side-by-side Diff

... ... @@ -120,6 +120,8 @@
120 120 #include <linux/ctype.h>
121 121 #include <linux/if_arp.h>
122 122  
  123 +#include "net-sysfs.h"
  124 +
123 125 /*
124 126 * The list of packet types we will receive (as opposed to discard)
125 127 * and the routines to invoke.
... ... @@ -248,10 +250,6 @@
248 250 */
249 251  
250 252 DEFINE_PER_CPU(struct softnet_data, softnet_data);
251   -
252   -extern int netdev_kobject_init(void);
253   -extern int netdev_register_kobject(struct net_device *);
254   -extern void netdev_unregister_kobject(struct net_device *);
255 253  
256 254 #ifdef CONFIG_DEBUG_LOCK_ALLOC
257 255 /*
net/core/net-sysfs.c
... ... @@ -18,6 +18,8 @@
18 18 #include <linux/wireless.h>
19 19 #include <net/iw_handler.h>
20 20  
  21 +#include "net-sysfs.h"
  22 +
21 23 #ifdef CONFIG_SYSFS
22 24 static const char fmt_hex[] = "%#x\n";
23 25 static const char fmt_long_hex[] = "%#lx\n";
net/core/net-sysfs.h
  1 +#ifndef __NET_SYSFS_H__
  2 +#define __NET_SYSFS_H__
  3 +
  4 +int netdev_kobject_init(void);
  5 +int netdev_register_kobject(struct net_device *);
  6 +void netdev_unregister_kobject(struct net_device *);
  7 +
  8 +#endif