Commit 3ce5efad47b62c57a4f5c54248347085a750ce0e

Authored by Mathias Krause
Committed by David S. Miller
1 parent c77a4b9cff

netrom: fix info leak via msg_name in nr_recvmsg()

In case msg_name is set the sockaddr info gets filled out, as
requested, but the code fails to initialize the padding bytes of
struct sockaddr_ax25 inserted by the compiler for alignment. Also
the sax25_ndigis member does not get assigned, leaking four more
bytes.

Both issues lead to the fact that the code will leak uninitialized
kernel stack bytes in net/socket.c.

Fix both issues by initializing the memory with memset(0).

Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

net/netrom/af_netrom.c
... ... @@ -1173,6 +1173,7 @@
1173 1173 }
1174 1174  
1175 1175 if (sax != NULL) {
  1176 + memset(sax, 0, sizeof(sax));
1176 1177 sax->sax25_family = AF_NETROM;
1177 1178 skb_copy_from_linear_data_offset(skb, 7, sax->sax25_call.ax25_call,
1178 1179 AX25_ADDR_LEN);