Commit 41b5c2e77a0221cf07ac127afa122add67ac5418
Committed by
Lachlan McIlroy
1 parent
4249023a5d
Exists in
master
and in
7 other branches
[XFS] xfs_unmountfs should return void
xfs_unmounts can't and shouldn't return errors so declare it as returning void. SGI-PV: 981498 SGI-Modid: xfs-linux-melb:xfs-kern:31833a Signed-off-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Showing 2 changed files with 6 additions and 8 deletions Side-by-side Diff
fs/xfs/xfs_mount.c
... | ... | @@ -1229,16 +1229,15 @@ |
1229 | 1229 | } |
1230 | 1230 | |
1231 | 1231 | /* |
1232 | - * xfs_unmountfs | |
1233 | - * | |
1234 | 1232 | * This flushes out the inodes,dquots and the superblock, unmounts the |
1235 | 1233 | * log and makes sure that incore structures are freed. |
1236 | 1234 | */ |
1237 | -int | |
1238 | -xfs_unmountfs(xfs_mount_t *mp) | |
1235 | +void | |
1236 | +xfs_unmountfs( | |
1237 | + struct xfs_mount *mp) | |
1239 | 1238 | { |
1240 | - __uint64_t resblks; | |
1241 | - int error = 0; | |
1239 | + __uint64_t resblks; | |
1240 | + int error; | |
1242 | 1241 | |
1243 | 1242 | IRELE(mp->m_rootip); |
1244 | 1243 | |
... | ... | @@ -1311,7 +1310,6 @@ |
1311 | 1310 | xfs_errortag_clearall(mp, 0); |
1312 | 1311 | #endif |
1313 | 1312 | xfs_mount_free(mp); |
1314 | - return 0; | |
1315 | 1313 | } |
1316 | 1314 | |
1317 | 1315 | STATIC void |
fs/xfs/xfs_mount.h
... | ... | @@ -513,7 +513,7 @@ |
513 | 513 | extern int xfs_mountfs(xfs_mount_t *mp); |
514 | 514 | extern void xfs_mountfs_check_barriers(xfs_mount_t *mp); |
515 | 515 | |
516 | -extern int xfs_unmountfs(xfs_mount_t *); | |
516 | +extern void xfs_unmountfs(xfs_mount_t *); | |
517 | 517 | extern int xfs_unmountfs_writesb(xfs_mount_t *); |
518 | 518 | extern int xfs_unmount_flush(xfs_mount_t *, int); |
519 | 519 | extern int xfs_mod_incore_sb(xfs_mount_t *, xfs_sb_field_t, int64_t, int); |