Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 42416cc81f4990ad8d425b41a0fc8cd985eb5fa5

Authored by Mark Brown
Committed by Greg Kroah-Hartman
1 parent 1f9230713a
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

usb: misc: Fix swapped properties in usb3503 DT parsing 

The intn and connect GPIO properties are swapped in the code which will
cause failures at runtime if these are connected, fix the code.

There are currently no in-tree users of this device to check or update.

Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/usb/misc/usb3503.c
Diff comments   View file @ 42416cc
... ... @@ -215,10 +215,10 @@
215 215 }
216 216 }
217 217  
218   - hub->gpio_intn = of_get_named_gpio(np, "connect-gpios", 0);
  218 + hub->gpio_intn = of_get_named_gpio(np, "intn-gpios", 0);
219 219 if (hub->gpio_intn == -EPROBE_DEFER)
220 220 return -EPROBE_DEFER;
221   - hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0);
  221 + hub->gpio_connect = of_get_named_gpio(np, "connect-gpios", 0);
222 222 if (hub->gpio_connect == -EPROBE_DEFER)
223 223 return -EPROBE_DEFER;
224 224 hub->gpio_reset = of_get_named_gpio(np, "reset-gpios", 0);