Commit 49ad9599d42da4787d5b3a19263440e0fcd4d1fc
1 parent
3b5b35d022
Exists in
master
and in
7 other branches
Revert "net: release skb->dst in sock_queue_rcv_skb()"
This reverts commit 70355602879229c6f8bd694ec9c0814222bc4936. As pointed out by Mark McLoughlin IP_PKTINFO cmsg data is one post-queueing user, so this optimization is not valid right now. Signed-off-by: David S. Miller <davem@davemloft.net>
Showing 1 changed file with 1 additions and 5 deletions Side-by-side Diff
net/core/sock.c
| ... | ... | @@ -289,11 +289,7 @@ |
| 289 | 289 | |
| 290 | 290 | skb->dev = NULL; |
| 291 | 291 | skb_set_owner_r(skb, sk); |
| 292 | - /* | |
| 293 | - * release dst right now while its hot | |
| 294 | - */ | |
| 295 | - dst_release(skb->dst); | |
| 296 | - skb->dst = NULL; | |
| 292 | + | |
| 297 | 293 | /* Cache the SKB length before we tack it onto the receive |
| 298 | 294 | * queue. Once it is added it no longer belongs to us and |
| 299 | 295 | * may be freed by other threads of control pulling packets |