Commit 4a5fa3590f09999f6db41bc386bce40848fa9f63

Authored by James Bottomley
Committed by James Bottomley
1 parent d9b41e0b54

[PARISC] slub: fix panic with DISCONTIGMEM

Slub makes assumptions about page_to_nid() which are violated by
DISCONTIGMEM and !NUMA.  This violation results in a panic because
page_to_nid() can be non-zero for pages in the discontiguous ranges and
this leads to a null return by get_node().  The assertion by the
maintainer is that DISCONTIGMEM should only be allowed when NUMA is also
defined.  However, at least six architectures: alpha, ia64, m32r, m68k,
mips, parisc violate this.  The panic is a regression against slab, so
just mark slub broken in the problem configuration to prevent users
reporting these panics.

Cc: stable@kernel.org
Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

... ... @@ -1226,6 +1226,7 @@
1226 1226 per cpu and per node queues.
1227 1227  
1228 1228 config SLUB
  1229 + depends on BROKEN || NUMA || !DISCONTIGMEM
1229 1230 bool "SLUB (Unqueued Allocator)"
1230 1231 help
1231 1232 SLUB is a slab allocator that minimizes cache line usage