Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 4ab69a2b3b84415085d261bcf848b7a95c010c9d

Authored by Adrian Knoth
Committed by Takashi Iwai
1 parent 7c4a95b5ec
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

ALSA: hdspm - prevent reading unitialized stack memory 

Original patch by Dan Rosenberg <drosenberg@vsecurity.com> under commit
e68d3b316ab7b02a074edc4f770e6a746390cb7d. I'm copying his text here:

The SNDRV_HDSPM_IOCTL_GET_CONFIG_INFO ioctl in hdspm.c allow unprivileged
users to read uninitialized kernel stack memory, because several fields
of the hdspm_config struct declared on the stack are not altered
or zeroed before being copied back to the user.  This patch takes care
of it.

Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

sound/pci/rme9652/hdspm.c
Diff comments   View file @ 4ab69a2
... ... @@ -6081,6 +6081,7 @@
6081 6081  
6082 6082 case SNDRV_HDSPM_IOCTL_GET_CONFIG:
6083 6083  
  6084 + memset(&info, 0, sizeof(info));
6084 6085 spin_lock_irq(&hdspm->lock);
6085 6086 info.pref_sync_ref = hdspm_pref_sync_ref(hdspm);
6086 6087 info.wordclock_sync_check = hdspm_wc_sync_check(hdspm);