Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 547b4e718115eea74087e28d7fa70aec619200db

Authored by Stephen Hemminger
Committed by David S. Miller
1 parent cfa82e020b
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

bridge: set priority of STP packets 

Spanning Tree Protocol packets should have always been marked as
control packets, this causes them to get queued in the high prirority
FIFO. As Radia Perlman mentioned in her LCA talk, STP dies if bridge
gets overloaded and can't communicate. This is a long-standing bug back
to the first versions of Linux bridge.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

net/bridge/br_stp_bpdu.c
Diff comments   View file @ 547b4e7
... ... @@ -16,6 +16,7 @@
16 16 #include <linux/etherdevice.h>
17 17 #include <linux/llc.h>
18 18 #include <linux/slab.h>
  19 +#include <linux/pkt_sched.h>
19 20 #include <net/net_namespace.h>
20 21 #include <net/llc.h>
21 22 #include <net/llc_pdu.h>
... ... @@ -40,6 +41,7 @@
40 41  
41 42 skb->dev = p->dev;
42 43 skb->protocol = htons(ETH_P_802_2);
  44 + skb->priority = TC_PRIO_CONTROL;
43 45  
44 46 skb_reserve(skb, LLC_RESERVE);
45 47 memcpy(__skb_put(skb, length), data, length);