Commit 5762482f5496cb1dd86acd2aace3ea25d1404e1f
1 parent
b7c09ad401
Exists in
smarc-imx_3.14.28_1.0.0_ga
and in
1 other branch
vfs: move get_fs_root_and_pwd() to single caller
Let's not pollute the include files with inline functions that are only used in a single place. Especially not if we decide we might want to change the semantics of said function to make it more efficient.. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Showing 2 changed files with 11 additions and 11 deletions Side-by-side Diff
fs/dcache.c
| ... | ... | @@ -3015,6 +3015,17 @@ |
| 3015 | 3015 | return ERR_PTR(-ENAMETOOLONG); |
| 3016 | 3016 | } |
| 3017 | 3017 | |
| 3018 | +static inline void get_fs_root_and_pwd(struct fs_struct *fs, struct path *root, | |
| 3019 | + struct path *pwd) | |
| 3020 | +{ | |
| 3021 | + spin_lock(&fs->lock); | |
| 3022 | + *root = fs->root; | |
| 3023 | + path_get(root); | |
| 3024 | + *pwd = fs->pwd; | |
| 3025 | + path_get(pwd); | |
| 3026 | + spin_unlock(&fs->lock); | |
| 3027 | +} | |
| 3028 | + | |
| 3018 | 3029 | /* |
| 3019 | 3030 | * NOTE! The user-level library version returns a |
| 3020 | 3031 | * character pointer. The kernel system call just |
include/linux/fs_struct.h
| ... | ... | @@ -39,17 +39,6 @@ |
| 39 | 39 | spin_unlock(&fs->lock); |
| 40 | 40 | } |
| 41 | 41 | |
| 42 | -static inline void get_fs_root_and_pwd(struct fs_struct *fs, struct path *root, | |
| 43 | - struct path *pwd) | |
| 44 | -{ | |
| 45 | - spin_lock(&fs->lock); | |
| 46 | - *root = fs->root; | |
| 47 | - path_get(root); | |
| 48 | - *pwd = fs->pwd; | |
| 49 | - path_get(pwd); | |
| 50 | - spin_unlock(&fs->lock); | |
| 51 | -} | |
| 52 | - | |
| 53 | 42 | extern bool current_chrooted(void); |
| 54 | 43 | |
| 55 | 44 | #endif /* _LINUX_FS_STRUCT_H */ |