Commit 632b89e82bf1c04c251924b49adc689f7b346321

Authored by Dave Chinner
Committed by Ben Myers
1 parent a629362105

xfs: fix static and extern sparse warnings

The kbuild test robot indicated that there were some new sparse
warnings in fs/xfs/xfs_dquot_buf.c. Actually, there were a lot more
that is wasn't warning about, so fix them all up.

Reported-by: kbuild test robot
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

Showing 12 changed files with 18 additions and 8 deletions Side-by-side Diff

fs/xfs/xfs_alloc_btree.c
... ... @@ -17,6 +17,7 @@
17 17 */
18 18 #include "xfs.h"
19 19 #include "xfs_fs.h"
  20 +#include "xfs_shared.h"
20 21 #include "xfs_format.h"
21 22 #include "xfs_log_format.h"
22 23 #include "xfs_trans_resv.h"
fs/xfs/xfs_attr_leaf.c
... ... @@ -18,6 +18,7 @@
18 18 */
19 19 #include "xfs.h"
20 20 #include "xfs_fs.h"
  21 +#include "xfs_shared.h"
21 22 #include "xfs_format.h"
22 23 #include "xfs_log_format.h"
23 24 #include "xfs_trans_resv.h"
fs/xfs/xfs_attr_remote.c
... ... @@ -18,6 +18,7 @@
18 18 */
19 19 #include "xfs.h"
20 20 #include "xfs_fs.h"
  21 +#include "xfs_shared.h"
21 22 #include "xfs_format.h"
22 23 #include "xfs_log_format.h"
23 24 #include "xfs_trans_resv.h"
... ... @@ -17,6 +17,7 @@
17 17 */
18 18 #include "xfs.h"
19 19 #include "xfs_log_format.h"
  20 +#include "xfs_bit.h"
20 21  
21 22 /*
22 23 * XFS bit manipulation routines, used in non-realtime code.
fs/xfs/xfs_bmap_btree.c
... ... @@ -17,6 +17,7 @@
17 17 */
18 18 #include "xfs.h"
19 19 #include "xfs_fs.h"
  20 +#include "xfs_shared.h"
20 21 #include "xfs_format.h"
21 22 #include "xfs_log_format.h"
22 23 #include "xfs_trans_resv.h"
fs/xfs/xfs_buf_item.c
... ... @@ -809,7 +809,7 @@
809 809 * Mark bytes first through last inclusive as dirty in the buf
810 810 * item's bitmap.
811 811 */
812   -void
  812 +static void
813 813 xfs_buf_item_log_segment(
814 814 struct xfs_buf_log_item *bip,
815 815 uint first,
fs/xfs/xfs_da_format.c
... ... @@ -18,6 +18,7 @@
18 18 */
19 19 #include "xfs.h"
20 20 #include "xfs_fs.h"
  21 +#include "xfs_shared.h"
21 22 #include "xfs_format.h"
22 23 #include "xfs_log_format.h"
23 24 #include "xfs_trans_resv.h"
... ... @@ -706,7 +707,7 @@
706 707 hdr3->nused = cpu_to_be32(from->nused);
707 708 }
708 709  
709   -const struct xfs_dir_ops xfs_dir2_ops = {
  710 +static const struct xfs_dir_ops xfs_dir2_ops = {
710 711 .sf_entsize = xfs_dir2_sf_entsize,
711 712 .sf_nextentry = xfs_dir2_sf_nextentry,
712 713 .sf_get_ftype = xfs_dir2_sfe_get_ftype,
... ... @@ -756,7 +757,7 @@
756 757 .db_to_fdindex = xfs_dir2_db_to_fdindex,
757 758 };
758 759  
759   -const struct xfs_dir_ops xfs_dir2_ftype_ops = {
  760 +static const struct xfs_dir_ops xfs_dir2_ftype_ops = {
760 761 .sf_entsize = xfs_dir3_sf_entsize,
761 762 .sf_nextentry = xfs_dir3_sf_nextentry,
762 763 .sf_get_ftype = xfs_dir3_sfe_get_ftype,
... ... @@ -806,7 +807,7 @@
806 807 .db_to_fdindex = xfs_dir2_db_to_fdindex,
807 808 };
808 809  
809   -const struct xfs_dir_ops xfs_dir3_ops = {
  810 +static const struct xfs_dir_ops xfs_dir3_ops = {
810 811 .sf_entsize = xfs_dir3_sf_entsize,
811 812 .sf_nextentry = xfs_dir3_sf_nextentry,
812 813 .sf_get_ftype = xfs_dir3_sfe_get_ftype,
813 814  
... ... @@ -856,14 +857,14 @@
856 857 .db_to_fdindex = xfs_dir3_db_to_fdindex,
857 858 };
858 859  
859   -const struct xfs_dir_ops xfs_dir2_nondir_ops = {
  860 +static const struct xfs_dir_ops xfs_dir2_nondir_ops = {
860 861 .node_hdr_size = sizeof(struct xfs_da_node_hdr),
861 862 .node_hdr_to_disk = xfs_da2_node_hdr_to_disk,
862 863 .node_hdr_from_disk = xfs_da2_node_hdr_from_disk,
863 864 .node_tree_p = xfs_da2_node_tree_p,
864 865 };
865 866  
866   -const struct xfs_dir_ops xfs_dir3_nondir_ops = {
  867 +static const struct xfs_dir_ops xfs_dir3_nondir_ops = {
867 868 .node_hdr_size = sizeof(struct xfs_da3_node_hdr),
868 869 .node_hdr_to_disk = xfs_da3_node_hdr_to_disk,
869 870 .node_hdr_from_disk = xfs_da3_node_hdr_from_disk,
fs/xfs/xfs_dquot_buf.c
... ... @@ -18,6 +18,7 @@
18 18 */
19 19 #include "xfs.h"
20 20 #include "xfs_fs.h"
  21 +#include "xfs_shared.h"
21 22 #include "xfs_format.h"
22 23 #include "xfs_log_format.h"
23 24 #include "xfs_trans_resv.h"
... ... @@ -267,7 +268,7 @@
267 268 * the buffer after the update is done. This ensures that the dquot in the
268 269 * buffer always has an up-to-date CRC value.
269 270 */
270   -void
  271 +static void
271 272 xfs_dquot_buf_write_verify(
272 273 struct xfs_buf *bp)
273 274 {
fs/xfs/xfs_ialloc_btree.c
... ... @@ -17,6 +17,7 @@
17 17 */
18 18 #include "xfs.h"
19 19 #include "xfs_fs.h"
  20 +#include "xfs_shared.h"
20 21 #include "xfs_format.h"
21 22 #include "xfs_log_format.h"
22 23 #include "xfs_trans_resv.h"
fs/xfs/xfs_rtbitmap.c
... ... @@ -37,6 +37,7 @@
37 37 #include "xfs_buf.h"
38 38 #include "xfs_icache.h"
39 39 #include "xfs_dinode.h"
  40 +#include "xfs_rtalloc.h"
40 41  
41 42  
42 43 /*
... ... @@ -17,6 +17,7 @@
17 17 */
18 18 #include "xfs.h"
19 19 #include "xfs_fs.h"
  20 +#include "xfs_shared.h"
20 21 #include "xfs_format.h"
21 22 #include "xfs_log_format.h"
22 23 #include "xfs_trans_resv.h"
... ... @@ -1155,7 +1155,7 @@
1155 1155 * Note: xfs_log_quiesce() stops background log work - the callers must ensure
1156 1156 * it is started again when appropriate.
1157 1157 */
1158   -void
  1158 +static void
1159 1159 xfs_quiesce_attr(
1160 1160 struct xfs_mount *mp)
1161 1161 {