Commit 65afa5e603d507014580ead016ec887b49e1afa6

Authored by Frederic Weisbecker
Committed by Ingo Molnar
1 parent eae849ca03

tracing/function-return-tracer: free the return stack on free_task()

Impact: avoid losing some traces when a task is freed

do_exit() is not the last function called when a task finishes.
There are still some functions which are to be called such as
ree_task().  So we delay the freeing of the return stack to the
last moment.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

Showing 2 changed files with 1 additions and 2 deletions Side-by-side Diff

... ... @@ -47,7 +47,6 @@
47 47 #include <linux/task_io_accounting_ops.h>
48 48 #include <linux/tracehook.h>
49 49 #include <trace/sched.h>
50   -#include <linux/ftrace.h>
51 50  
52 51 #include <asm/uaccess.h>
53 52 #include <asm/unistd.h>
... ... @@ -1128,7 +1127,6 @@
1128 1127 preempt_disable();
1129 1128 /* causes final put_task_struct in finish_task_switch(). */
1130 1129 tsk->state = TASK_DEAD;
1131   - ftrace_retfunc_exit_task(tsk);
1132 1130 schedule();
1133 1131 BUG();
1134 1132 /* Avoid "noreturn function does return". */
... ... @@ -140,6 +140,7 @@
140 140 prop_local_destroy_single(&tsk->dirties);
141 141 free_thread_info(tsk->stack);
142 142 rt_mutex_debug_task_free(tsk);
  143 + ftrace_retfunc_exit_task(tsk);
143 144 free_task_struct(tsk);
144 145 }
145 146 EXPORT_SYMBOL(free_task);