Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 68e58a294fb26f692697179e3f3ecf88dd8cb97c

Authored by Mike Snitzer
Committed by Alasdair G Kergon
1 parent d93dc5c447
Exists in master and in 6 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

dm: flakey fix corrupt_bio_byte error path 

If no arguments were provided to the corrupt_bio_byte feature an error
should be returned immediately.

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

drivers/md/dm-flakey.c
Diff comments   View file @ 68e58a2
... ... @@ -81,8 +81,10 @@
81 81 * corrupt_bio_byte <Nth_byte> <direction> <value> <bio_flags>
82 82 */
83 83 if (!strcasecmp(arg_name, "corrupt_bio_byte")) {
84   - if (!argc)
  84 + if (!argc) {
85 85 ti->error = "Feature corrupt_bio_byte requires parameters";
  86 + return -EINVAL;
  87 + }
86 88  
87 89 r = dm_read_arg(_args + 1, as, &fc->corrupt_bio_byte, &ti->error);
88 90 if (r)