USB-BKL: Remove lock_kernel in usbfs update_sb()

The code this is attempting to lock against does not use the BKL, so it's not needed. Most likely this code is still broken/racy (Al Viro also thinks so), but removing the BKL should not make it worse than before. Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

USB-BKL: Remove lock_kernel in usbfs update_sb()
The code this is attempting to lock against does not use the BKL, so it's not needed. Most likely this code is still broken/racy (Al Viro also thinks so), but removing the BKL should not make it worse than before. Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andi Kleen · Greg Kroah-Hartman
1 parent 16f76a7654
Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff
drivers/usb/core/inode.c
@@ -265,12 +265,8 @@
 		return -EINVAL;
 	}
  
-	lock_kernel();
-
 	if (usbfs_mount && usbfs_mount->mnt_sb)
 		update_sb(usbfs_mount->mnt_sb);
-
-	unlock_kernel();
  
 	return 0;
 }
...	...	@@ -265,12 +265,8 @@
265	265	return -EINVAL;
266	266	}
267	267
268		- lock_kernel();
269		-
270	268	if (usbfs_mount && usbfs_mount->mnt_sb)
271	269	update_sb(usbfs_mount->mnt_sb);
272		-
273		- unlock_kernel();
274	270
275	271	return 0;
276	272	}