Commit 709e1b5cd9e1915ad4f6c470ebf6b55d4a911d8c
Committed by
David S. Miller
1 parent
aaca735f4f
Exists in
smarc-l5.0.0_1.0.0-ga
and in
5 other branches
bridge: message age needs to increase, not decrease.
commit bridge: send proper message_age in config BPDU added this gem: bpdu.message_age = (jiffies - root->designated_age) p->designated_age = jiffies + bpdu->message_age; Notice how bpdu->message_age is negated when reassigned to bpdu.message_age. This causes message age to decrease breaking the STP protocol. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> Signed-off-by: David S. Miller <davem@davemloft.net>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
net/bridge/br_stp.c
... | ... | @@ -186,7 +186,7 @@ |
186 | 186 | p->designated_cost = bpdu->root_path_cost; |
187 | 187 | p->designated_bridge = bpdu->bridge_id; |
188 | 188 | p->designated_port = bpdu->port_id; |
189 | - p->designated_age = jiffies + bpdu->message_age; | |
189 | + p->designated_age = jiffies - bpdu->message_age; | |
190 | 190 | |
191 | 191 | mod_timer(&p->message_age_timer, jiffies |
192 | 192 | + (p->br->max_age - bpdu->message_age)); |