Commit 70fa9f2eadea7ca35bdcd89b20d555934593b40c
1 parent
bbe281fad6
Exists in
master
and in
7 other branches
HID: no more reinitializtion is needed in post_reset
No more reinitialization is needed in the post reset hook, remove the FIXME comment. While at it, clean up whitespaces in the immediate surrounding. Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Showing 1 changed file with 3 additions and 4 deletions Side-by-side Diff
drivers/hid/usbhid/hid-core.c
... | ... | @@ -1234,12 +1234,11 @@ |
1234 | 1234 | struct hid_device *hid = usb_get_intfdata(intf); |
1235 | 1235 | struct usbhid_device *usbhid = hid->driver_data; |
1236 | 1236 | int status; |
1237 | - | |
1237 | + | |
1238 | 1238 | spin_lock_irq(&usbhid->lock); |
1239 | 1239 | clear_bit(HID_RESET_PENDING, &usbhid->iofl); |
1240 | 1240 | spin_unlock_irq(&usbhid->lock); |
1241 | 1241 | hid_set_idle(dev, intf->cur_altsetting->desc.bInterfaceNumber, 0, 0); |
1242 | - /* FIXME: Any more reinitialization needed? */ | |
1243 | 1242 | status = hid_start_in(hid); |
1244 | 1243 | if (status < 0) |
1245 | 1244 | hid_io_error(hid); |
1246 | 1245 | |
... | ... | @@ -1251,14 +1250,14 @@ |
1251 | 1250 | int usbhid_get_power(struct hid_device *hid) |
1252 | 1251 | { |
1253 | 1252 | struct usbhid_device *usbhid = hid->driver_data; |
1254 | - | |
1253 | + | |
1255 | 1254 | return usb_autopm_get_interface(usbhid->intf); |
1256 | 1255 | } |
1257 | 1256 | |
1258 | 1257 | void usbhid_put_power(struct hid_device *hid) |
1259 | 1258 | { |
1260 | 1259 | struct usbhid_device *usbhid = hid->driver_data; |
1261 | - | |
1260 | + | |
1262 | 1261 | usb_autopm_put_interface(usbhid->intf); |
1263 | 1262 | } |
1264 | 1263 |