Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 72651cac884b1e285fa8e8314b10e9f1b8458802

Authored by Jan Kara
Committed by Al Viro
1 parent 39e3c9553f
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

fs: Fix imbalance in freeze protection in mark_files_ro() 

File descriptors (even those for writing) do not hold freeze protection.
Thus mark_files_ro() must call __mnt_drop_write() to only drop protection
against remount read-only. Calling mnt_drop_write_file() as we do now
results in:

[ BUG: bad unlock balance detected! ]
3.7.0-rc6-00028-g88e75b6 #101 Not tainted
-------------------------------------
kworker/1:2/79 is trying to release lock (sb_writers) at:
[<ffffffff811b33b4>] mnt_drop_write+0x24/0x30
but there are no more locks to release!

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -458,8 +458,8 @@
458 458 spin_unlock(&f->f_lock);
459 459 if (file_check_writeable(f) != 0)
460 460 continue;
  461 + __mnt_drop_write(f->f_path.mnt);
461 462 file_release_write(f);
462   - mnt_drop_write_file(f);
463 463 } while_file_list_for_each_entry;
464 464 lg_global_unlock(&files_lglock);
465 465 }