Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 737f644c279b65b46ca9fe9ad149c713ca8b2663

Authored by Lars-Peter Clausen
Committed by Dmitry Torokhov
1 parent 139097a0a7
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

Input: navpoint - pass correct pointer to free_irq() 

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/input/mouse/navpoint.c
Diff comments   View file @ 737f644
... ... @@ -287,7 +287,7 @@
287 287 return 0;
288 288  
289 289 err_free_irq:
290   - free_irq(ssp->irq, &pdev->dev);
  290 + free_irq(ssp->irq, navpoint);
291 291 err_free_mem:
292 292 input_free_device(input);
293 293 kfree(navpoint);