Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 7799652557d966e49512479f4d3b9079bbc01fff

Authored by Evgeniy Polyakov
Committed by David S. Miller
1 parent a5a97263a9
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

[NETFILTER]: Fix NULL pointer dereference in nf_nat_move_storage() 

Reported by Chuck Ebbert as:

	https://bugzilla.redhat.com/show_bug.cgi?id=259501#c14

This routine is called each time hash should be replaced, nf_conn has
extension list which contains pointers to connection tracking users
(like nat, which is right now the only such user), so when replace takes
place it should copy own extensions. Loop above checks for own
extension, but tries to move higer-layer one, which can lead to above
oops.

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

net/netfilter/nf_conntrack_extend.c
Diff comments   View file @ 7799652
... ... @@ -109,7 +109,7 @@
109 109 rcu_read_lock();
110 110 t = rcu_dereference(nf_ct_ext_types[i]);
111 111 if (t && t->move)
112   - t->move(ct, ct->ext + ct->ext->offset[id]);
  112 + t->move(ct, ct->ext + ct->ext->offset[i]);
113 113 rcu_read_unlock();
114 114 }
115 115 kfree(ct->ext);