Commit 7833b08e18241a1c35c09ef38be840cbf6c58acf
1 parent
ed04d98169
Exists in
smarc-imx_3.14.28_1.0.0_ga
and in
1 other branch
dm table: print error on preresume failure
If preresume fails it is worth logging an error given that a device is
left suspended due to the failure.
This change was motivated by local preresume error logging that was
added to the cache target ("preresume failed"). Elevating this
target-agnostic context for the where the target-specific error occurred
relative to the DM core's callouts makes sense.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Joe Thornber <ejt@redhat.com>
Showing 1 changed file with 4 additions and 1 deletions Side-by-side Diff
drivers/md/dm-table.c
| ... | ... | @@ -1562,8 +1562,11 @@ |
| 1562 | 1562 | continue; |
| 1563 | 1563 | |
| 1564 | 1564 | r = ti->type->preresume(ti); |
| 1565 | - if (r) | |
| 1565 | + if (r) { | |
| 1566 | + DMERR("%s: %s: preresume failed, error = %d", | |
| 1567 | + dm_device_name(t->md), ti->type->name, r); | |
| 1566 | 1568 | return r; |
| 1569 | + } | |
| 1567 | 1570 | } |
| 1568 | 1571 | |
| 1569 | 1572 | for (i = 0; i < t->num_targets; i++) { |