Commit 789336360e0a2aeb9750c16ab704a02cbe035e9e

Authored by Tom Parkin
Committed by David S. Miller
1 parent e3c9851278

l2tp: fix oops in l2tp_eth_create() error path

When creating an L2TPv3 Ethernet session, if register_netdev() should fail for
any reason (for example, automatic naming for "l2tpeth%d" interfaces hits the
32k-interface limit), the netdev is freed in the error path.  However, the
l2tp_eth_sess structure's dev pointer is left uncleared, and this results in
l2tp_eth_delete() then attempting to unregister the same netdev later in the
session teardown.  This results in an oops.

To avoid this, clear the session dev pointer in the error path.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

... ... @@ -291,6 +291,7 @@
291 291  
292 292 out_del_dev:
293 293 free_netdev(dev);
  294 + spriv->dev = NULL;
294 295 out_del_session:
295 296 l2tp_session_delete(session);
296 297 out: