Commit 79549c6dfda0603dba9a70a53467ce62d9335c33

Authored by Oleg Nesterov
Committed by Linus Torvalds
1 parent 923e9a1399

cred: copy_process() should clear child->replacement_session_keyring

keyctl_session_to_parent(task) sets ->replacement_session_keyring,
it should be processed and cleared by key_replace_session_keyring().

However, this task can fork before it notices TIF_NOTIFY_RESUME and
the new child gets the bogus ->replacement_session_keyring copied by
dup_task_struct(). This is obviously wrong and, if nothing else, this
leads to put_cred(already_freed_cred).

change copy_creds() to clear this member. If copy_process() fails
before this point the wrong ->replacement_session_keyring doesn't
matter, exit_creds() won't be called.

Cc: <stable@vger.kernel.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

... ... @@ -386,6 +386,8 @@
386 386 struct cred *new;
387 387 int ret;
388 388  
  389 + p->replacement_session_keyring = NULL;
  390 +
389 391 if (
390 392 #ifdef CONFIG_KEYS
391 393 !p->cred->thread_keyring &&